----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/466/ -----------------------------------------------------------
(Updated Sept. 15, 2011, 2:57 p.m.) Review request for Viewer and Seth ProductEngine. Changes ------- * Fix: Don't enable the "Verify" button if use just moves cursor in the API key input field. * Fixed a copy&paste error in unit tests. * Fixed a typo: LLBingTranslarionHandler * Fixed a Windows compilation error. * Added Doxygen comments to lltranslate.h. Summary ------- Replaced deprecated Google Translate v1 API with Google Translate v2 and Bing Translate APIs. Changes after https://codereview.secondlife.com/r/464/: * New translation preferences floater layout that supports API key verification. * Unit tests. This addresses bug STORM-1577. http://jira.secondlife.com/browse/STORM-1577 Diffs (updated) ----- indra/newview/CMakeLists.txt 8da01486a36a indra/newview/app_settings/settings.xml 8da01486a36a indra/newview/llfloaterpreference.h 8da01486a36a indra/newview/llfloaterpreference.cpp 8da01486a36a indra/newview/llfloatertranslationsettings.h PRE-CREATION indra/newview/llfloatertranslationsettings.cpp PRE-CREATION indra/newview/lltranslate.h 8da01486a36a indra/newview/lltranslate.cpp 8da01486a36a indra/newview/llviewerfloaterreg.cpp 8da01486a36a indra/newview/llviewermessage.cpp 8da01486a36a indra/newview/skins/default/xui/en/floater_translation_settings.xml PRE-CREATION indra/newview/skins/default/xui/en/panel_preferences_chat.xml 8da01486a36a indra/newview/skins/default/xui/en/strings.xml 8da01486a36a indra/newview/tests/lltranslate_test.cpp PRE-CREATION Diff: http://codereview.secondlife.com/r/466/diff Testing ------- Thanks, Vadim
_______________________________________________ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
