> On Aug. 26, 2011, 6:05 a.m., Vadim ProductEngine wrote: > > indra/newview/llviewermessage.cpp, lines 6556-6559 > > <http://codereview.secondlife.com/r/449/diff/2/?file=6988#file6988line6556> > > > > It's a hack to update the Block List panel from here. > > The panel should be an observer of the mute list, or something like > > that, i.e. update itself automatically. > > Jonathan Yap wrote: > This exact same call is used in 6 other places in the code. It forces > the sidebar open and highlights the newly Blocked item as feedback to the > user that their Block click has had some effect, so I think having this call > is correct.
Ah, right. You see -- more comments won't hurt! :-) - Vadim ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/449/#review993 ----------------------------------------------------------- On Aug. 23, 2011, 1:41 p.m., Jonathan Yap wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://codereview.secondlife.com/r/449/ > ----------------------------------------------------------- > > (Updated Aug. 23, 2011, 1:41 p.m.) > > > Review request for Viewer. > > > Summary > ------- > > Add a block button to popups from llDialog calls. Clicking on the Block > button adds the object to the block list. The type of block is Object. > Changing the object's name does not defeat this block as the block entry is > stored as a UUID. > > Note: The object's name in the block list does not change if the object is > renamed, though the block does work. This may need to be addressed in a > separate SVC jira once this change is incorporated into viewer-development. > > > This addresses bug STORM-1567. > http://jira.secondlife.com/browse/STORM-1567 > > > Diffs > ----- > > doc/contributions.txt 4ebbd04efd93 > indra/newview/lltoastnotifypanel.cpp 4ebbd04efd93 > indra/newview/llviewermessage.cpp 4ebbd04efd93 > indra/newview/skins/default/xui/en/notifications.xml 4ebbd04efd93 > > Diff: http://codereview.secondlife.com/r/449/diff > > > Testing > ------- > > Tested per Test Plan jira entry. > > > Thanks, > > Jonathan > >
_______________________________________________ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
