ppkarwasz commented on PR #175:
URL:
https://github.com/apache/logging-log4j-tools/pull/175#issuecomment-2866920863
@alan0428a, thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specif
ppkarwasz merged PR #175:
URL: https://github.com/apache/logging-log4j-tools/pull/175
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsu
alan0428a commented on PR #175:
URL:
https://github.com/apache/logging-log4j-tools/pull/175#issuecomment-2866761348
@ppkarwasz
Thanks! I've signed all commits.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
U
ppkarwasz commented on PR #175:
URL:
https://github.com/apache/logging-log4j-tools/pull/175#issuecomment-2859577016
@alan0428a,
Thanks, this is ready to merge!
In all our repos we **require** signed Git commit, which means that I can
not merge until **all** commits are signed.
alan0428a commented on PR #175:
URL:
https://github.com/apache/logging-log4j-tools/pull/175#issuecomment-2858591434
@ppkarwasz
Oh, that's true. Thanks for checking. Updated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
ppkarwasz commented on PR #175:
URL:
https://github.com/apache/logging-log4j-tools/pull/175#issuecomment-2854452265
Apparently there is still one required change: the workflows in
`.github/workflows` must be migrated from `@rel/11.3.0` to `@rel/12.1.0`.
--
This is an automated message fr
alan0428a commented on PR #175:
URL:
https://github.com/apache/logging-log4j-tools/pull/175#issuecomment-2854211268
@ppkarwasz fixed. Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
ppkarwasz commented on PR #175:
URL:
https://github.com/apache/logging-log4j-tools/pull/175#issuecomment-2833202635
@alan0428a,
The new Error Prone from `logging-parent` version `12.1.0` is complaining
about a return statement:
```
Warning:
/home/runner/work/logging-log4j
alan0428a commented on code in PR #175:
URL:
https://github.com/apache/logging-log4j-tools/pull/175#discussion_r2061094525
##
log4j-tools-parent/pom.xml:
##
@@ -46,6 +46,11 @@
5.12.0
2.1.2
2.10.0
+2.0.0
+
1.1.2
+4.8.6
+1.0.0
+7.0.0
Review Com
alan0428a commented on code in PR #175:
URL:
https://github.com/apache/logging-log4j-tools/pull/175#discussion_r2061095805
##
pom.xml:
##
@@ -31,7 +31,7 @@
org.apache.logging
logging-parent
-11.0.0
+12.1.0-SNAPSHOT
Review Comment:
Updated the version t
vy commented on code in PR #175:
URL:
https://github.com/apache/logging-log4j-tools/pull/175#discussion_r2041192370
##
log4j-tools-parent/pom.xml:
##
@@ -46,6 +46,11 @@
5.12.0
2.1.2
2.10.0
+2.0.0
+
1.1.2
+4.8.6
+1.0.0
+7.0.0
Review Comment:
vy commented on code in PR #175:
URL:
https://github.com/apache/logging-log4j-tools/pull/175#discussion_r2041191985
##
pom.xml:
##
@@ -31,7 +31,7 @@
org.apache.logging
logging-parent
-11.0.0
+12.1.0-SNAPSHOT
Review Comment:
@ppkarwasz, thanks for your
ppkarwasz commented on PR #175:
URL:
https://github.com/apache/logging-log4j-tools/pull/175#issuecomment-2727445173
@alan0428a,
> ```
>
/Users/alanyu/Repos/logging-log4j-tools/log4j-docgen/src/main/java/org/apache/logging/log4j/docgen/processor/DescriptorGenerator.java:[618,71]
[
alan0428a commented on code in PR #175:
URL:
https://github.com/apache/logging-log4j-tools/pull/175#discussion_r1997458133
##
log4j-tools-parent/pom.xml:
##
@@ -140,6 +146,43 @@
${xmlunit.version}
+
+
+org.osgi
+org.osgi.annotation
alan0428a commented on PR #175:
URL:
https://github.com/apache/logging-log4j-tools/pull/175#issuecomment-2727115008
@ppkarwasz
I can see it failed to build `log4j-docgen`, because there is a warning in
`DescriptorGenerator`. And the compile settting is `failOnWarning=true` for
that pac
ppkarwasz commented on code in PR #175:
URL:
https://github.com/apache/logging-log4j-tools/pull/175#discussion_r1996628015
##
log4j-tools-parent/pom.xml:
##
@@ -140,6 +146,43 @@
${xmlunit.version}
+
+
+org.osgi
+org.osgi.annotation
alan0428a opened a new pull request, #175:
URL: https://github.com/apache/logging-log4j-tools/pull/175
[A clear and concise description of what the pull request is for along with
a reference to the associated issue IDs, if they exist.]
## Checklist
* `./mvnw verify` succeeds (i
17 matches
Mail list logo
