vy commented on code in PR #175:
URL:
https://github.com/apache/logging-log4j-tools/pull/175#discussion_r2041192370
##########
log4j-tools-parent/pom.xml:
##########
@@ -46,6 +46,11 @@
<junit.version>5.12.0</junit.version>
<modello.version>2.1.2</modello.version>
<xmlunit.version>2.10.0</xmlunit.version>
+ <osgi.annotation.bundle.version>2.0.0</osgi.annotation.bundle.version>
+
<osgi.annotation.versioning.version>1.1.2</osgi.annotation.versioning.version>
+ <spotbugs-annotations.version>4.8.6</spotbugs-annotations.version>
+ <jspecify.version>1.0.0</jspecify.version>
+ <bnd.annotation.version>7.0.0</bnd.annotation.version>
Review Comment:
1. I think some of these versions are out-of-date. Could you update them,
please?
2. Properties are alphanumerically ordered. Could you adhere to that, please?
##########
log4j-tools-parent/pom.xml:
##########
@@ -140,6 +145,37 @@
<version>${xmlunit.version}</version>
</dependency>
+ <!-- OSGi and annotation dependencies -->
+ <dependency>
+ <groupId>org.osgi</groupId>
+ <artifactId>org.osgi.annotation.bundle</artifactId>
+ <version>${osgi.annotation.bundle.version}</version>
+ </dependency>
+
+ <dependency>
+ <groupId>org.osgi</groupId>
+ <artifactId>org.osgi.annotation.versioning</artifactId>
+ <version>${osgi.annotation.versioning.version}</version>
+ </dependency>
+
+ <dependency>
+ <groupId>com.github.spotbugs</groupId>
+ <artifactId>spotbugs-annotations</artifactId>
+ <version>${spotbugs-annotations.version}</version>
+ </dependency>
+
+ <dependency>
+ <groupId>org.jspecify</groupId>
+ <artifactId>jspecify</artifactId>
+ <version>${jspecify.version}</version>
+ </dependency>
+
+ <dependency>
+ <groupId>biz.aQute.bnd</groupId>
+ <artifactId>biz.aQute.bnd.annotation</artifactId>
+ <version>${bnd.annotation.version}</version>
+ </dependency>
Review Comment:
Dependencies are ordered by `artifactId`. Could you adhere to that, please?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@logging.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
