ppkarwasz commented on PR #175:
URL: 
https://github.com/apache/logging-log4j-tools/pull/175#issuecomment-2727445173

   @alan0428a,
   
   > ```
   > 
/Users/alanyu/Repos/logging-log4j-tools/log4j-docgen/src/main/java/org/apache/logging/log4j/docgen/processor/DescriptorGenerator.java:[618,71]
 [VoidUsed] Using a Void-typed variable is potentially confusing, and can be 
replaced with a literal `null`.
   >     (see https://errorprone.info/bugpattern/VoidUsed)
   >   Did you mean 'return super.visitExecutable(element, null);'?
   > ```
   
   The usage of `Void` in that code is due the visitor API that has a type 
parameter we don't use.
   Currently I pass to `super` the parameters that the method receives, but we 
can replace it with `null`.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@logging.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to