ppkarwasz commented on code in PR #175:
URL:
https://github.com/apache/logging-log4j-tools/pull/175#discussion_r1996628015
##########
log4j-tools-parent/pom.xml:
##########
@@ -140,6 +146,43 @@
<version>${xmlunit.version}</version>
</dependency>
+ <!-- OSGi and annotation dependencies -->
+ <dependency>
+ <groupId>org.osgi</groupId>
+ <artifactId>org.osgi.annotation.bundle</artifactId>
+ <version>${osgi.annotation.bundle.version}</version>
+ </dependency>
+
+ <dependency>
+ <groupId>org.osgi</groupId>
+ <artifactId>osgi.annotation</artifactId>
+ <version>${osgi.annotation.version}</version>
+ </dependency>
Review Comment:
This artifact has the same content as `org.osgi.annotation.bundle` and
`org.osgi.annotation.versioning` and can be removed in favor of those.
##########
pom.xml:
##########
@@ -31,7 +31,7 @@
<parent>
<groupId>org.apache.logging</groupId>
<artifactId>logging-parent</artifactId>
- <version>11.0.0</version>
+ <version>12.1.0-SNAPSHOT</version>
Review Comment:
On the CI this will cause a chicken-and-egg problem:
- Version `12.1.0-SNAPSHOT` is available only in the snapshot repository.
- The appropriate `<repository>` element is defined in `logging-parent` (or
more strictly in the parent POM of `logging-parent`.
The PR is OK, but it can not be merged until we release `12.1.0`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@logging.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
