Re: [PR] Scoped context (logging-log4j2)

2024-03-27 Thread via GitHub
rgoers commented on PR #2419: URL: https://github.com/apache/logging-log4j2/pull/2419#issuecomment-2024398297 @rocketraman I did look into that and what you are asking for just can't be implemented in a reasonable way without significant mods to the API and will likely impact performance. T

Re: [PR] Scoped context (logging-log4j2)

2024-03-27 Thread via GitHub
rocketraman commented on PR #2419: URL: https://github.com/apache/logging-log4j2/pull/2419#issuecomment-2024335371 > All events in a ResourceLogger use ParameterizedMapMessage. When logging it behaves like a ParameterizedMessage in that formatMessage only returns the message directly being

Re: [PR] Bump org.scala-lang:scala3-library_3 from 3.4.0 to 3.4.1 [logging-log4j-scala]

2024-03-27 Thread via GitHub
github-actions[bot] merged PR #50: URL: https://github.com/apache/logging-log4j-scala/pull/50 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notificati

[PR] Bump org.scala-lang:scala3-library_3 from 3.4.0 to 3.4.1 [logging-log4j-scala]

2024-03-27 Thread via GitHub
dependabot[bot] opened a new pull request, #50: URL: https://github.com/apache/logging-log4j-scala/pull/50 Bumps [org.scala-lang:scala3-library_3](https://github.com/scala/scala3) from 3.4.0 to 3.4.1. Release notes Sourced from https://github.com/scala/scala3/releases";>org.scala-l

[PR] Bump com.fasterxml.woodstox:woodstox-core from 6.5.1 to 6.6.2 [logging-log4j-samples]

2024-03-27 Thread via GitHub
dependabot[bot] opened a new pull request, #121: URL: https://github.com/apache/logging-log4j-samples/pull/121 Bumps [com.fasterxml.woodstox:woodstox-core](https://github.com/FasterXML/woodstox) from 6.5.1 to 6.6.2. Commits https://github.com/FasterXML/woodstox/commit/3bed2621

Re: [PR] Bump com.fasterxml.woodstox:woodstox-core from 6.5.1 to 6.6.1 [logging-log4j-samples]

2024-03-27 Thread via GitHub
dependabot[bot] commented on PR #118: URL: https://github.com/apache/logging-log4j-samples/pull/118#issuecomment-2024192976 Superseded by #121. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

Re: [PR] Bump com.fasterxml.woodstox:woodstox-core from 6.5.1 to 6.6.1 [logging-log4j-samples]

2024-03-27 Thread via GitHub
dependabot[bot] closed pull request #118: Bump com.fasterxml.woodstox:woodstox-core from 6.5.1 to 6.6.1 URL: https://github.com/apache/logging-log4j-samples/pull/118 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] Nullable and modernization part 6 (logging-log4net)

2024-03-27 Thread via GitHub
erikmav commented on PR #132: URL: https://github.com/apache/logging-log4net/pull/132#issuecomment-2024058588 For #124 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To u

[PR] Nullable and modernization part 6 (logging-log4net)

2024-03-27 Thread via GitHub
erikmav opened a new pull request, #132: URL: https://github.com/apache/logging-log4net/pull/132 Adjusted nullability on some classes after applying the 3.0 binary to two existing projects that have nullable enabled. -- This is an automated message from the Apache Git Service. To resp

[PR] Scoped context (logging-log4j2)

2024-03-27 Thread via GitHub
rgoers opened a new pull request, #2419: URL: https://github.com/apache/logging-log4j2/pull/2419 This adds support for a ScopedContext and a ResourceLogger as requested in https://github.com/apache/logging-log4j-kotlin/issues/71 and similar to https://github.com/apache/logging-log4j2/discus

Re: [PR] 2214 - Add support for ScopedContext (logging-log4j2)

2024-03-27 Thread via GitHub
rgoers closed pull request #2385: 2214 - Add support for ScopedContext URL: https://github.com/apache/logging-log4j2/pull/2385 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. T

Re: [PR] Part 5 of nullable and modernization (logging-log4net)

2024-03-27 Thread via GitHub
FreeAndNil merged PR #131: URL: https://github.com/apache/logging-log4net/pull/131 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubsc

Re: [PR] Part 5 of nullable and modernization (logging-log4net)

2024-03-27 Thread via GitHub
erikmav commented on code in PR #131: URL: https://github.com/apache/logging-log4net/pull/131#discussion_r1541720526 ## src/log4net/Core/LogImpl.cs: ## @@ -326,7 +329,7 @@ public virtual void DebugFormat(string format, object arg0, object arg1, object /// methods instead.

Re: [PR] Part 5 of nullable and modernization (logging-log4net)

2024-03-27 Thread via GitHub
FreeAndNil commented on code in PR #131: URL: https://github.com/apache/logging-log4net/pull/131#discussion_r1541538986 ## src/log4net/ILog.cs: ## @@ -216,7 +216,7 @@ public interface ILog : ILoggerWrapper /// /// /// -void DebugFormat(IFormatProvider provi

Re: [PR] Part 5 of nullable and modernization (logging-log4net)

2024-03-27 Thread via GitHub
FreeAndNil commented on code in PR #131: URL: https://github.com/apache/logging-log4net/pull/131#discussion_r1541533057 ## src/log4net/Appender/BufferingAppenderSkeleton.cs: ## @@ -437,7 +437,7 @@ protected override void Append(LoggingEvent loggingEvent) loggingEvent.Fi

Re: [PR] Part 5 of nullable and modernization (logging-log4net)

2024-03-27 Thread via GitHub
erikmav commented on code in PR #131: URL: https://github.com/apache/logging-log4net/pull/131#discussion_r1541475884 ## src/log4net/ILog.cs: ## @@ -216,7 +216,7 @@ public interface ILog : ILoggerWrapper /// /// /// -void DebugFormat(IFormatProvider provider

Re: [PR] Part 5 of nullable and modernization (logging-log4net)

2024-03-27 Thread via GitHub
erikmav commented on code in PR #131: URL: https://github.com/apache/logging-log4net/pull/131#discussion_r1541420446 ## src/log4net/Appender/BufferingAppenderSkeleton.cs: ## @@ -437,7 +437,7 @@ protected override void Append(LoggingEvent loggingEvent) loggingEvent.Fix =

Re: [I] Remove `log4j-kubernetes` module (logging-log4j2)

2024-03-27 Thread via GitHub
ppkarwasz commented on issue #2218: URL: https://github.com/apache/logging-log4j2/issues/2218#issuecomment-2023146978 An improved `kubernetes-log4j` module is available since Kubernetes Client version 6.11.0 (cf. [announcement](https://github.com/fabric8io/kubernetes-client/releases/tag/v6

Re: [I] Log4j incompatible with recent kubernetes-client (logging-log4j2)

2024-03-27 Thread via GitHub
ppkarwasz commented on issue #2151: URL: https://github.com/apache/logging-log4j2/issues/2151#issuecomment-2023138028 I am closing this, since a new `kubernetes-log4j` lookup is available since version 6.11.0 of Kubernetes Client (cf. [announcement](https://github.com/fabric8io/kubernetes-

Re: [I] Log4j incompatible with recent kubernetes-client (logging-log4j2)

2024-03-27 Thread via GitHub
ppkarwasz closed issue #2151: Log4j incompatible with recent kubernetes-client URL: https://github.com/apache/logging-log4j2/issues/2151 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific c

Re: [PR] Remove `log4j-kubernetes` in version 3.x (logging-log4j2)

2024-03-27 Thread via GitHub
ppkarwasz commented on PR #2408: URL: https://github.com/apache/logging-log4j2/pull/2408#issuecomment-2023127985 Closes #2218 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [I] Remove `log4j-kubernetes` module (logging-log4j2)

2024-03-27 Thread via GitHub
ppkarwasz closed issue #2218: Remove `log4j-kubernetes` module URL: https://github.com/apache/logging-log4j2/issues/2218 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsu

Re: [PR] Remove `log4j-kubernetes` in version 2.x (logging-log4j2)

2024-03-27 Thread via GitHub
ppkarwasz commented on PR #2412: URL: https://github.com/apache/logging-log4j2/pull/2412#issuecomment-2023126966 Closes #2218. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment

Re: [PR] Remove `log4j-kubernetes` in version 3.x (logging-log4j2)

2024-03-27 Thread via GitHub
ppkarwasz merged PR #2408: URL: https://github.com/apache/logging-log4j2/pull/2408 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubsc

Re: [PR] Remove `log4j-kubernetes` in version 2.x (logging-log4j2)

2024-03-27 Thread via GitHub
ppkarwasz merged PR #2412: URL: https://github.com/apache/logging-log4j2/pull/2412 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubsc

Re: [PR] Replace `PropertiesUtil` with `PropertyEnvironment` (logging-log4j2)

2024-03-27 Thread via GitHub
ppkarwasz commented on code in PR #2396: URL: https://github.com/apache/logging-log4j2/pull/2396#discussion_r1541312483 ## log4j-core/src/main/java/org/apache/logging/log4j/core/LoggerContext.java: ## @@ -201,11 +204,14 @@ public static void checkMessageFactory(final ExtendedLo

Re: [PR] Bump org.elasticsearch.client:elasticsearch-rest-high-level-client from 7.17.18 to 7.17.19 (logging-log4j2)

2024-03-27 Thread via GitHub
github-actions[bot] merged PR #2418: URL: https://github.com/apache/logging-log4j2/pull/2418 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notificatio

Re: [PR] Move `Recycler` to `log4j-kit` (logging-log4j2)

2024-03-27 Thread via GitHub
ppkarwasz commented on code in PR #2400: URL: https://github.com/apache/logging-log4j2/pull/2400#discussion_r1540850963 ## log4j-api/src/main/java/org/apache/logging/log4j/spi/MessageFactory2Adapter.java: ## @@ -0,0 +1,157 @@ +/* + * Licensed to the Apache Software Foundation (A

Re: [PR] Replace `PropertiesUtil` with `PropertyEnvironment` (logging-log4j2)

2024-03-27 Thread via GitHub
ppkarwasz commented on code in PR #2396: URL: https://github.com/apache/logging-log4j2/pull/2396#discussion_r1540662283 ## log4j-jctools/src/main/java/org/apache/logging/log4j/jctools/JCToolsRecyclerFactoryProvider.java: ## @@ -52,7 +51,7 @@ public String getName() { @Overr

Re: [PR] Replace `PropertiesUtil` with `PropertyEnvironment` (logging-log4j2)

2024-03-27 Thread via GitHub
ppkarwasz commented on code in PR #2396: URL: https://github.com/apache/logging-log4j2/pull/2396#discussion_r1540657373 ## log4j-api-test/src/main/java/org/apache/logging/log4j/test/junit/Tags.java: ## @@ -14,25 +14,20 @@ * See the License for the specific language governing p

[I] Run environment-independent tests in full parallel mode (logging-log4j2)

2024-03-27 Thread via GitHub
ppkarwasz opened a new issue, #2417: URL: https://github.com/apache/logging-log4j2/issues/2417 An increasing amount of tests, especially in Log4j Core 3.x does not depend on the environment with two exceptions: - they might read values from `PropertiesUtil`, - they might write logs

Re: [PR] Replace `PropertiesUtil` with `PropertyEnvironment` (logging-log4j2)

2024-03-27 Thread via GitHub
ppkarwasz commented on code in PR #2396: URL: https://github.com/apache/logging-log4j2/pull/2396#discussion_r1540640622 ## log4j-api-test/src/main/java/org/apache/logging/log4j/test/junit/Tags.java: ## @@ -14,25 +14,20 @@ * See the License for the specific language governing p

Re: [I] `Log4j2PluginsCacheFileTransformer` deletes cache if only one is available [logging-log4j-transform]

2024-03-27 Thread via GitHub
ppkarwasz closed issue #87: `Log4j2PluginsCacheFileTransformer` deletes cache if only one is available URL: https://github.com/apache/logging-log4j-transform/issues/87 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the U

Re: [PR] Part 5 of nullable and modernization (logging-log4net)

2024-03-27 Thread via GitHub
FreeAndNil commented on code in PR #131: URL: https://github.com/apache/logging-log4net/pull/131#discussion_r1540190416 ## src/log4net.Tests/Util/SystemInfoTest.cs: ## @@ -55,9 +55,9 @@ public void TestAssemblyLocationInfoDoesNotThrowNotSupportedExceptionForDynamicA priv

Re: [PR] Finalize `log4j-transform-maven-shade-plugin-extensions` transfer [logging-log4j-transform]

2024-03-27 Thread via GitHub
ppkarwasz commented on PR #42: URL: https://github.com/apache/logging-log4j-transform/pull/42#issuecomment-2022150075 Sorry, I didn't notice the bug fix. Closes #87. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

Re: [I] Enable building log4net with docker container (logging-log4net)

2024-03-27 Thread via GitHub
FreeAndNil closed issue #127: Enable building log4net with docker container URL: https://github.com/apache/logging-log4net/issues/127 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comm