On 5/22/19 12:57 PM, Heiner Kallweit wrote:
> Add support for interface mode PHY_INTERFACE_MODE_USXGMII.
>
> Signed-off-by: Heiner Kallweit
If you update Documentation/devicetree/bindings/net/ethernet.txt, then
this is:
Reviewed-by: Florian Fainelli
--
Florian
a
separate commits and just have the DTS changes come last? With that:
Reviewed-by: Florian Fainelli
--
Florian
On 5/22/19 1:18 PM, Heiner Kallweit wrote:
> On 22.05.2019 22:07, Florian Fainelli wrote:
>> On 5/22/19 12:58 PM, Heiner Kallweit wrote:
>>> So far we didn't support mode USXGMII, and in order to not break the
>>> two Freescale boards mode XGMII was accepted for t
follow-up
> patch where this function will be guarded against the existence of a
> phydev->attached_dev.
>
> Signed-off-by: Vladimir Oltean
Reviewed-by: Florian Fainelli
--
Florian
reated in case there is no attached_dev.
>
> - No netif_carrier_off is done if there is no attached_dev.
>
> Signed-off-by: Ioana Ciornei
> Signed-off-by: Vladimir Oltean
Reviewed-by: Florian Fainelli
--
Florian
On 5/22/2019 6:20 PM, Ioana Ciornei wrote:
> Export a phy_standalone device attribute that is meant to give the
> indication that this PHY lacks an attached_dev and its corresponding
> sysfs link.
>
> Signed-off-by: Ioana Ciornei
I would rather have that attribute be conditionally visible/cre
es not exist.
>
> Signed-off-by: Ioana Ciornei
Reviewed-by: Florian Fainelli
--
Florian
_validate);
Those exports should probably be _GPL to follow the PHYLINK exports but
other than that:
Reviewed-by: Florian Fainelli
--
Florian
On 5/22/2019 6:20 PM, Ioana Ciornei wrote:
> This completely removes the usage of PHYLIB from DSA, namely for the
> aforementioned switch ports which used to drive a software PHY manually
> using genphy operations.
>
> For these ports, the newly introduced phylink_create_raw API must be
> used,
On 5/22/2019 6:20 PM, Ioana Ciornei wrote:
> This adds a new entry point to PHYLINK that does not require a
> net_device structure.
>
> The main intended use are DSA ports that do not have net devices
> registered for them (mainly because doing so would be redundant - see
> Documentation/networ
else.
>
> As explained below:
>
> commit aab9c4067d2389d0adfc9c53806437df7b0fe3d5
> Author: Florian Fainelli
> Date: Thu May 10 13:17:36 2018 -0700
>
> net: dsa: Plug in PHYLINK support
>
> Drivers that utilize fixed links for user-facing ports (e.g: bcm_sf2)
> will need to implem
On 5/22/2019 7:25 PM, Florian Fainelli wrote:
>
>
> On 5/22/2019 6:20 PM, Ioana Ciornei wrote:
>> This adds a new entry point to PHYLINK that does not require a
>> net_device structure.
>>
>> The main intended use are DSA ports that do not have net devic
On 5/23/2019 5:10 AM, Ioana Ciornei wrote:
>
>> Subject: Re: [RFC PATCH net-next 5/9] net: phylink: Add phylink_create_raw
>>
>>
>>
>> On 5/22/2019 7:25 PM, Florian Fainelli wrote:
>>>
>>>
>>> On 5/22/2019 6:20 PM, Ioana Ciornei wrot
On 5/23/19 2:56 AM, Maxime Ripard wrote:
> The networking PHYs have a number of available device tree properties that
> can be used in their device tree node. Add a YAML schemas for those.
>
> Signed-off-by: Maxime Ripard
> ---
> Documentation/devicetree/bindings/net/ethernet-phy.yaml | 148
On 5/23/19 11:07 AM, Heiner Kallweit wrote:
> Add new interface mode USXGMII to binding documentation.
>
> Signed-off-by: Heiner Kallweit
Reviewed-by: Florian Fainelli
--
Florian
I mode is set.
>
> v2:
> - add warning if XGMII mode is set
>
> Signed-off-by: Heiner Kallweit
Reviewed-by: Florian Fainelli
--
Florian
On 5/23/19 1:32 PM, Vladimir Oltean wrote:
> On 5/23/19 5:32 PM, Florian Fainelli wrote:
>>
>> On 5/23/2019 5:10 AM, Ioana Ciornei wrote:
>>>
>>>> Subject: Re: [RFC PATCH net-next 5/9] net: phylink: Add
>>>> phylink_create_raw
>>>>
On 5/24/2019 3:35 AM, Max Uvarov wrote:
> PHY_INTERFACE_MODE_RGMII_RXID is less then TXID
> so code to set tx delay is never called.
>
> Signed-off-by: Max Uvarov
Could you provide an appropriate Fixes: tag for this as well as fix the
subject to be:
net: phy: dp83867: Set up RGMII TX delay
On 5/23/2019 2:45 AM, Jiri Pirko wrote:
> From: Jiri Pirko
>
> When user is flashing device using devlink, he currenly does not see any
> information about what is going on, percentages, etc.
> Drivers, for example mlxsw and mlx5, have notion about the progress
> and what is happening. This pa
SGMII) {
> + /* For support SPEED_10 in SGMII mode
> + * DP83867_10M_SGMII_RATE_ADAPT bit
> + * has to be cleared by software. That
> + * does not affect SPEED_100 and
> + * SPEED_1000.
Likewise, s/support/supporting/ wi
On 5/26/2019 11:16 PM, Max Uvarov wrote:
> PHY_INTERFACE_MODE_RGMII_RXID is less then TXID
> so code to set tx delay is never called.
> Fixes: 2a10154abcb75 ("net: phy: dp83867: Add TI dp83867 phy")
>
> Signed-off-by: Max Uvarov
> Cc: Florian Fainelli
R
On 5/26/2019 11:16 PM, Max Uvarov wrote:
> Phy state machine calls _config_init just after
> reset.
>
> Signed-off-by: Max Uvarov
Reviewed-by: Florian Fainelli
--
Florian
timer is set to 2us (bits 6 and 5
> + * are 01). That us not enough to finalize autoneg on some
Likewise, same typo was carried over here. With that fixed and Heiner's
suggestions addressed:
Reviewed-by: Florian Fainelli
--
Florian
On 5/27/2019 11:28 AM, Heiner Kallweit wrote:
> We face the issue that link change interrupt and link status may be
> reported by different layers. As a result the link change interrupt
> may occur before the link status changes.
> Export phy_queue_state_machine to allow PHY drivers to specify a
On 5/27/2019 11:28 AM, Heiner Kallweit wrote:
> The phylib interrupt handler handles link change events only currently.
> However PHY drivers may want to use other interrupt sources too,
> e.g. to report temperature monitoring events. Therefore add a callback
> to struct phy_driver allowing PHY
disconnects the phy_device from the
> net_device and also works when the net_device is lacking.
>
> Signed-off-by: Ioana Ciornei
> Signed-off-by: Vladimir Oltean
The PHYLINK and DSA portions look good to me, and this is a lot nicer
than the notifier, thanks for coming up with that scheme:
Reviewed-by: Florian Fainelli
--
Florian
is decision and replace all
> uses of netdev_err&co with phylink_err.
>
> Signed-off-by: Ioana Ciornei
> Signed-off-by: Vladimir Oltean
Reviewed-by: Florian Fainelli
--
Florian
gned-off-by: Ioana Ciornei
> Signed-off-by: Vladimir Oltean
Reviewed-by: Florian Fainelli
--
Florian
alled with a NULL net_device.
>
> Signed-off-by: Ioana Ciornei
If you update Documentation/ABI/testing/sysfs-class-net-phydev, this is:
Reviewed-by: Florian Fainelli
I will take care of removing sysfs-bus-mdio which duplicates that
information.
--
Florian
.
>
> Signed-off-by: Ioana Ciornei
> Signed-off-by: Vladimir Oltean
Should not this patch be re-ordered to be after patch #8? Other than that:
Reviewed-by: Florian Fainelli
--
Florian
by the CPU-port-handling code in a further
> patch.
>
> Signed-off-by: Ioana Ciornei
> Suggested-by: Vladimir Oltean
Reviewed-by: Florian Fainelli
--
Florian
On 5/28/19 3:00 AM, Max Uvarov wrote:
> Phy state machine calls _config_init just after
> reset.
>
> Signed-off-by: Max Uvarov
Reviewed-by: Florian Fainelli
--
Florian
>
> Signed-off-by: Max Uvarov
> Cc: Florian Fainelli
Reviewed-by: Florian Fainelli
--
Florian
On 5/28/19 9:43 AM, Heiner Kallweit wrote:
> MAC on the GBit versions supports 1000/Full only, however the PHY
> partially claims to support 1000/Half. So let's explicitly remove
> this mode.
>
> Signed-off-by: Heiner Kallweit
Don't you want a Fixes: tag for that?
> ---
> drivers/net/ethernet/
t; Suggested-by: Andrew Lunn
> Reviewed-by: Andrew Lunn
Reviewed-by: Florian Fainelli
--
Florian
On 5/27/19 12:36 PM, Heiner Kallweit wrote:
> On 27.05.2019 21:25, Florian Fainelli wrote:
>>
>>
>> On 5/27/2019 11:28 AM, Heiner Kallweit wrote:
>>> The phylib interrupt handler handles link change events only currently.
>>> However PHY drivers may want to u
ing the setup
> part of the RX VID on the CPU port after all the other front-panel ports
> have been added to the VID.
>
> Signed-off-by: Ioana Ciornei
> Signed-off-by: Vladimir Oltean
> Fixes: f9bbe4477c30 ("net: dsa: Optional VLAN-based port separation for
> switches without tagging")
Reviewed-by: Florian Fainelli
--
Florian
out of the VLAN tags on 5.2 kernels.
>
> Fixes: f9bbe4477c30 ("net: dsa: Optional VLAN-based port separation for
> switches without tagging")
> Signed-off-by: Vladimir Oltean
Reviewed-by: Florian Fainelli
This looks a lot nicer actually, and kudos for documenting the format.
--
Florian
On 5/28/2019 5:21 AM, Ido Schimmel wrote:
> From: Ido Schimmel
>
> Users have several ways to debug the kernel and understand why a packet
> was dropped. For example, using "drop monitor" and "perf". Both
> utilities trace kfree_skb(), which is the function called when a packet
> is freed as p
On 5/31/19 12:15 PM, Robert Hancock wrote:
> This adds a driver for the PHY device implemented in the Xilinx PCS/PMA
> Core logic. Aside from being a generic gigabit PHY, it includes an
> important register setting to disable the PHY isolation bit, which is
> required for the PHY to operate in 1000
+Heiner, Andrew,
On 6/3/2019 4:12 PM, Robert Hancock wrote:
> This adds a driver for the PHY device implemented in the Xilinx PCS/PMA
> Core logic. This is mostly a generic gigabit PHY, except that the
> features are explicitly set because the PHY wrongly indicates it has no
> extended status regi
On 6/4/2019 12:58 PM, Vladimir Oltean wrote:
> Hi,
>
> I've been wondering what is the correct approach to cut the Ethernet
> link when the user requests it to be administratively down (aka ip link
> set dev eth0 down).
> Most of the Ethernet drivers simply call phy_stop or the phylink
> equiva
;
> Signed-off-by: Vladimir Oltean
Reviewed-by: Florian Fainelli
--
Florian
On 6/4/2019 1:42 PM, Vladimir Oltean wrote:
> On Tue, 4 Jun 2019 at 23:07, Andrew Lunn wrote:
>>
>> On Tue, Jun 04, 2019 at 10:58:41PM +0300, Vladimir Oltean wrote:
>>> Hi,
>>>
>>> I've been wondering what is the correct approach to cut the Ethernet link
>>> when the user requests it to be admi
On 6/4/2019 2:29 PM, Vladimir Oltean wrote:
> On Wed, 5 Jun 2019 at 00:12, Andrew Lunn wrote:
>>
>>> But now the second question: between a phy_connect and a phy_start,
>>> shouldn't the PHY be suspended too? Experimentally it looks like it
>>> still isn't.
>>
>> This is not always clear cut. D
On 6/4/2019 2:36 PM, Russell King - ARM Linux admin wrote:
> Normally the PHY receives traffic, and passes it to the MAC which
> just ignores the signals it receives from the PHY, so no processing
> beyond the PHY receiving the traffic happens.
>
> Ultimately, whether you want the PHY to stay link
On 6/4/2019 4:46 PM, Vladimir Oltean wrote:
> On Wed, 5 Jun 2019 at 02:24, Russell King - ARM Linux admin
> wrote:
>>
>> On Wed, Jun 05, 2019 at 02:03:19AM +0300, Vladimir Oltean wrote:
>>> On Wed, 5 Jun 2019 at 01:59, Russell King - ARM Linux admin
>>> wrote:
On Wed, Jun 05, 2019 at
On 6/5/2019 1:45 AM, Russell King - ARM Linux admin wrote:
> On Tue, Jun 04, 2019 at 07:25:46PM -0700, Florian Fainelli wrote:
>> On 6/4/2019 2:36 PM, Russell King - ARM Linux admin wrote:
>>> Normally the PHY receives traffic, and passes it to the MAC which
>>>
On 6/6/2019 1:57 PM, Robert Hancock wrote:
> On 2019-06-06 12:09 p.m., Russell King - ARM Linux admin wrote:
>>> @@ -1466,6 +1467,11 @@ static void sfp_sm_mod_remove(struct sfp *sfp)
>>> static void sfp_sm_event(struct sfp *sfp, unsigned int event)
>>> {
>>> mutex_lock(&sfp->sm_mutex);
>>>
On 6/8/2019 6:03 AM, Vladimir Oltean wrote:
> This is a cosmetic patch that replaces the link speed numbers used in
> the driver with the corresponding ethtool macros.
>
> Signed-off-by: Vladimir Oltean
> Suggested-by: Andrew Lunn
Reviewed-by: Florian Fainelli
--
Florian
On 6/8/2019 6:03 AM, Vladimir Oltean wrote:
> Since the driver is now using PHYLINK exclusively, it makes sense to
> remove all references to it and replace them with PHYLINK.
>
> Signed-off-by: Vladimir Oltean
Reviewed-by: Florian Fainelli
--
Florian
On 6/8/2019 6:03 AM, Vladimir Oltean wrote:
> This will be used to stop egress traffic in .phylink_mac_link_up.
>
> Signed-off-by: Vladimir Oltean
Reviewed-by: Florian Fainelli
--
Florian
hibit
> TX at the MAC level, while leaving RX essentially enabled.
>
> Also stop from trying to put the link down in .phylink_mac_config, which
> is incorrect.
>
> Signed-off-by: Vladimir Oltean
Reviewed-by: Florian Fainelli
--
Florian
that low power mode, but like you, only
have a limited subset to work with.
>
> Signed-off-by: Vladimir Oltean
Reviewed-by: Florian Fainelli
--
Florian
On 6/10/2019 6:56 AM, Ido Schimmel wrote:
> On Mon, Jun 10, 2019 at 03:35:38PM +0200, Andrew Lunn wrote:
>> On Mon, Jun 10, 2019 at 11:40:43AM +0300, Ido Schimmel wrote:
>>> From: Amit Cohen
>>> +declare -A speed_values
>>> +
>>> +speed_values=( [10baseT/Half]=0x001
>>> + [10baseT
On 6/10/19 10:37 AM, Heiner Kallweit wrote:
> This RFC patch is a follow-up to discussion [0]. In cases like missing
> PHY firmware we may want to keep the PHY from being brought up, but
> still allow MDIO access. Setting state PERM_FAIL in the probe or
> config_init callback allows to achieve this
On 6/10/19 11:51 AM, Andrew Lunn wrote:
>> - a PHY driver that requires a firmware should either be loaded prior to
>> Linux taking over the PHY, or should be loaded by the PHY driver itself
>
> Hi Florian
>
> Both the Marvell10g and Aquantia PHY need the firmware in their FLASH.
> It is a slow o
On 6/10/19 2:27 PM, Andrew Lunn wrote:
>> Maybe the broader question is how do you, Heiner and Russell imagine a
>> genuine case where the PHY does not have a firmware provided/loaded
>> before Linux does take over (say, BoM cost savings dictate no flash can
>> be used
>
> I've not seen either of
On 7/17/19 6:42 PM, Benjamin Poirier wrote:
> As pointed out by Firo Yang, a netdev tx timeout may trigger just before an
> ethtool set_channels operation is started. be_tx_timeout(), which dumps
> some queue structures, is not written to run concurrently with
> be_update_queues(), which frees/allo
On 7/16/19 11:29 PM, Wei Yongjun wrote:
> Add the missing unlock before return from function sk_buff()
> in the error handling case.
>
> Fixes: f3097be21bf1 ("net: dsa: sja1105: Add a state machine for RX
> timestamping")
> Signed-off-by: Wei Yongjun
Reviewed-by: Florian Fainelli
--
Florian
On 7/24/2019 9:25 PM, René van Dorst wrote:
> Adding support for port 5.
>
> Port 5 can muxed/interface to:
> - internal 5th GMAC of the switch; can be used as 2nd CPU port or as
> extra port with an external phy for a 6th ethernet port.
> - internal PHY of port 0 or 4; Used in most applicati
On 1/12/21 11:54 AM, Marek Behún wrote:
> From: Pavana Sharma
>
> Add 5gbase-r PHY interface mode.
>
> Signed-off-by: Pavana Sharma
> Reviewed-by: Andrew Lunn
> Acked-by: Rob Herring
> Signed-off-by: Marek Behún
Reviewed-by: Florian Fainelli
--
Florian
On 1/12/21 11:54 AM, Marek Behún wrote:
> From: Pavana Sharma
>
> Add 5GBASE-R phy interface mode
>
> Signed-off-by: Pavana Sharma
> Reviewed-by: Andrew Lunn
> Signed-off-by: Marek Behún
Reviewed-by: Florian Fainelli
--
Florian
On 1/13/21 4:45 AM, Gilles DOFFE wrote:
> A logical 'or' was performed until now.
> So if vlan 1 is the current pvid and vlan 20 is set as the new one,
> vlan 21 is the new pvid.
> This commit fixes this by setting the right mask to set the new pvid.
>
> Signed-off-by: Gilles DOFFE
Looks about r
On 1/13/21 4:45 AM, Gilles DOFFE wrote:
> If 802.1q VLAN tag is removed from egress traffic, ingress
> traffic should by logic be tagged.
Which logic do you refer to? Software or hardware? What an user
configures with the "bridge vlan add ..." commands is the egress
tagging, but this also affects
On 1/13/21 4:45 AM, Gilles DOFFE wrote:
> If a VLAN is removed, the tagging policy should not be changed as
> still active VLANs could be impacted.
>
> Signed-off-by: Gilles DOFFE
It sounds like you need to consolidate the patches dealing with
tagging/untagged of a VLAN/port into a single patch,
On 1/13/21 3:36 PM, Andrew Lunn wrote:
> On Wed, Jan 13, 2021 at 05:41:39PM +0200, Vladimir Oltean wrote:
>> From: Vladimir Oltean
>>
>> Even though we should really share the implementation with the ocelot
>> switchdev driver, that one needs a little bit of rework first, since its
>> struct ocelo
On 1/13/21 4:45 AM, Gilles DOFFE wrote:
> Move tag/untag action at the end of the function to avoid
> tagging or untagging traffic if only vlan 0 is handled.
>
> Signed-off-by: Gilles DOFFE
> ---
> drivers/net/dsa/microchip/ksz8795.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
On 1/11/21 6:50 PM, DENG Qingfang wrote:
> Hi Marek,
>
> On Mon, Jan 11, 2021 at 11:46 PM Marek Behún wrote:
>>
>> what modes does the LED support? Does it support blinking on rx/tx?
>> What about link status?
Just to be crystal clear here, if you configure the LEDs to be in GPIO
mode, you can d
On 1/13/21 6:59 AM, George McCollister wrote:
> Add a driver with initial support for the Arrow SpeedChips XRS7000
> series of gigabit Ethernet switch chips which are typically used in
> critical networking applications.
>
> The switches have up to three RGMII ports and one RMII port.
> Management
On 1/14/21 10:35 AM, George McCollister wrote:
>> Nothing frees up the successfully allocated p->mib_data[] in case of
>> errors so you would be leaking here.
>
> In case of an error probe will end up returning an error and the
> memory will be free'd since it was allocated with a devm_ function,
rnel test robot
> Fixes: b7a9e0da2d1c ("net: switchdev: remove vid_begin -> vid_end range from
> VLAN objects")
> Signed-off-by: Vladimir Oltean
Reviewed-by: Florian Fainelli
--
Florian
t; Signed-off-by: Pavana Sharma
> Reviewed-by: Andrew Lunn
> Reviewed-by: Vladimir Oltean
> Signed-off-by: Marek Behún
Reviewed-by: Florian Fainelli
--
Florian
d one RMII port.
> Management to the switches can be performed over i2c or mdio.
>
> Support for advanced features such as PTP and
> HSR/PRP (IEC 62439-3 Clause 5 & 4) is not included in this patch and
> may be added at a later date.
>
> Signed-off-by: George McCollister
Reviewed-by: Florian Fainelli
--
Florian
entered promiscuous mode
> [ 60.334905] br0: port 1(sw0p2) entered blocking state
> [ 60.340142] br0: port 1(sw0p2) entered forwarding state
> Warning: dsa_core: skipping configuration of VLAN. # This was the pvid
> $ bridge vlan add dev sw0p2 vid 100
> Warning: dsa_core: skipping configuration of VLAN.
>
> Signed-off-by: Vladimir Oltean
Reviewed-by: Florian Fainelli
--
Florian
ling the fid from VTU op [3:0]
> and [11:8].
>
> Signed-off-by: Rasmus Villemoes
Reviewed-by: Florian Fainelli
--
Florian
N filtering.
>
> When the VTU entry is initially created, those bits are all zero, and
> we should make sure to keep them that way when the entry is updated.
>
> Fixes: 92307069a96c (net: dsa: mv88e6xxx: Avoid VTU corruption on 6097)
> Signed-off-by: Rasmus Villemoes
Reviewed-by: Florian Fainelli
--
Florian
On 1/18/2021 8:58 AM, Badel, Laurent wrote:
> Add new flag PHY_RST_AFTER_PROBE for LAN8710/20/40. This flag is intended
> for phy_probe() to assert hardware reset after probing the PHY.
>
> Signed-off-by: Laurent Badel
> ---
> drivers/net/phy/smsc.c | 4 ++--
> include/linux/phy.h| 1 +
>
appropriate type of TCAM
> rule.
>
> Signed-off-by: Vladimir Oltean
Reviewed-by: Florian Fainelli
--
Florian
gned-off-by: Vladimir Oltean
Reviewed-by: Florian Fainelli
--
Florian
igned long
> cookie from tc, as well as a boolean that is supposed to namespace the
> filters added by tc with the ones that aren't.
>
> Signed-off-by: Vladimir Oltean
Reviewed-by: Florian Fainelli
--
Florian
On 1/18/2021 7:06 AM, Geert Uytterhoeven wrote:
> Export mdiobb_read() and mdiobb_write(), so Ethernet controller drivers
> can call them from their MDIO read/write wrappers.
>
> Signed-off-by: Geert Uytterhoeven
Reviewed-by: Florian Fainelli
--
Florian
e
> device is suspended, causing undefined behavior, which may crash the
> system.
>
> Fix this by wrapping the PHY bitbang accessors in the sh_eth driver by
> wrappers that take care of Runtime PM, to resume the device when needed.
>
> Reported-by: Wolfram Sang
> Suggested-by: Andrew Lunn
> Signed-off-by: Geert Uytterhoeven
Reviewed-by: Florian Fainelli
--
Florian
gned-off-by: Vladimir Oltean
Reviewed-by: Florian Fainelli
--
Florian
on
> and it has "dev->num_vlans" elements.
>
> Fixes: a2482d2ce349 ("net: dsa: b53: Plug in VLAN support")
> Signed-off-by: Dan Carpenter
Acked-by: Florian Fainelli
--
Florian
; cannot be > 4094 because it is checked earlier.
>
> Fixes: 98cd1552ea27 ("net: dsa: Mock-up driver")
> Signed-off-by: Dan Carpenter
Acked-by: Florian Fainelli
--
Florian
mation from the
> Extraction Frame Header.
>
> Signed-off-by: Vladimir Oltean
Reviewed-by: Florian Fainelli
--
Florian
On 1/19/2021 3:07 PM, Vladimir Oltean wrote:
> From: Vladimir Oltean
>
> This looks a bit nicer than the open-coded "(x + 3) % 4" idiom.
>
> Signed-off-by: Vladimir Oltean
Reviewed-by: Florian Fainelli
--
Florian
d of
> TOTOAL_PORT_NUM")
> Signed-off-by: Marek Vasut
> Cc: Andrew Lunn
> Cc: Florian Fainelli
> Cc: Michael Grzeschik
> Cc: Jakub Kicinski
Reviewed-by: Florian Fainelli
--
Florian
n the
> original 100uS for the switch itself to come out of reset. Simply
> msleep() for 100 mS which fits the constraint with a bit of extra
> space.
This is nitpicking but the unit symbol for seconds is 's', not 'S' which
is for Siemens.
With that fixed:
Reviewed-by: Florian Fainelli
--
Florian
orrect, but not the Fixes tag, it should be:
Fixes: 31bc72d97656 ("net: systemport: fetch and use clock resources")
Acked-by: Florian Fainelli
--
Florian
On 1/19/2021 7:34 PM, Wei Wang wrote:
> This patch adds a new sysfs attribute to the network device class.
> Said attribute provides a per-device control to enable/disable the
> threaded mode for all the napi instances of the given network device.
> User sets it to 1 or 0 to enable or disable th
for 100 ms which fits the constraint with a bit of extra
>>> space.
>>>
>>> Fixes: 5b797980908a ("net: dsa: microchip: Implement recommended
>>> reset timing")
>>> Reviewed-by: Florian Fainelli
>>> Signed-off-by: Marek Vasut
>>
, this configuration would be impossible for the user to do. Also,
> due to the same reason, it is impossible for the user to inadvertently
> delete these rules using tc. These rules do not collide in any way with
> tc-flower, they just consume some TCAM space, which is something we can
&
can be changed via the following device attribute:
>
> echo ocelot-8021q > /sys/class//dsa/tagging
>
> Signed-off-by: Vladimir Oltean
Reviewed-by: Florian Fainelli
--
Florian
od to all ports except ocelot->num_phys_ports (the CPU port
> module). All we change is that we use a read-modify-write to only add
> the CPU port module to the unknown unicast replicator, as opposed to
> doing a full write to the register.
>
> Signed-off-by: Vladimir Oltean
Reviewed-by: Florian Fainelli
--
Florian
On 1/20/2021 6:36 PM, Vladimir Oltean wrote:
> From: Vladimir Oltean
>
> Currently DSA exposes the following sysfs:
> $ cat /sys/class/net/eno2/dsa/tagging
> ocelot
>
> which is a read-only device attribute, introduced in the kernel as
> commit 98cdb4807123 ("net: dsa: Expose tagging protocol
was already taken in
> ocelot_bridge_stp_state_set. Also, we can rename "i" into "lag", to make
> it more clear what is it that we're iterating through.
>
> Signed-off-by: Vladimir Oltean
> Reviewed-by: Alexandre Belloni
Reviewed-by: Florian Fainelli
--
Florian
oves dsa_broadcast (a top-level function) to dsa2.c,
> where it really belonged in the first place, but had no companion so it
> stood with dsa_port_notify.
>
> Signed-off-by: Vladimir Oltean
Reviewed-by: Florian Fainelli
--
Florian
tch
> makes the inj_prefix and xtr_prefix variables apply only to the NPI
> port (which the switchdev ocelot_vsc7514 driver does not use).
>
> Signed-off-by: Vladimir Oltean
Reviewed-by: Florian Fainelli
--
Florian
1 - 100 of 5622 matches
Mail list logo
