On 5/27/2019 2:22 PM, Ioana Ciornei wrote:
> In the PHYLINK_DEV operation type, the PHYLINK infrastructure can work
> without an attached net_device. For printing usecases, instead, a struct
> device * should be passed to PHYLINK using the phylink_config structure.
>
> Also, netif_carrier_* calls ar guarded by the presence of a valid
> net_device. When using the PHYLINK_DEV operation type, we cannot check
> link status using the netif_carrier_ok() API so instead, keep an
> internal state of the MAC and call mac_link_{down,up} only when the link
> changed.
>
> Signed-off-by: Ioana Ciornei <[email protected]>
> Signed-off-by: Vladimir Oltean <[email protected]>
Should not this patch be re-ordered to be after patch #8? Other than that:
Reviewed-by: Florian Fainelli <[email protected]>
--
Florian
- [PATCH 02/11] net: phy: Guard against the presence of a n... Ioana Ciornei
- [PATCH 09/11] net: dsa: Move the phylink driver calls int... Ioana Ciornei
- Re: [PATCH 09/11] net: dsa: Move the phylink driver ... Florian Fainelli
- [PATCH 08/11] net: phylink: Add phylink_{printk,err,warn,... Ioana Ciornei
- Re: [PATCH 08/11] net: phylink: Add phylink_{printk,... Florian Fainelli
- [PATCH 06/11] net: phylink: Add struct phylink_config to ... Ioana Ciornei
- Re: [PATCH 06/11] net: phylink: Add struct phylink_c... Florian Fainelli
- [PATCH 11/11] net: dsa: sja1105: Fix broken fixed-link in... Ioana Ciornei
- [PATCH 05/11] net: phylink: Add phylink_mac_link_{up,down... Ioana Ciornei
- [PATCH 07/11] net: phylink: Add PHYLINK_DEV operation typ... Ioana Ciornei
- Re: [PATCH 07/11] net: phylink: Add PHYLINK_DEV oper... Florian Fainelli
- RE: [PATCH 07/11] net: phylink: Add PHYLINK_DEV ... Ioana Ciornei
