On 3/3/2018 1:12 PM, Guenter Roeck wrote:
> On 03/03/2018 12:48 PM, Guenter Roeck wrote:
>> On 03/03/2018 11:07 AM, Troy Kisky wrote:
>>> On 3/3/2018 8:32 AM, Guenter Roeck wrote:
>>>> Hi,
>>>>
>>>> since v4.15, I get the following runtime wa
On 3/3/2018 8:32 AM, Guenter Roeck wrote:
> Hi,
>
> since v4.15, I get the following runtime warning when running sabrelite images
> in qemu.
>
> irq 65: nobody cared (try booting with the "irqpoll" option)
> ...
> handlers:
> [<26292474>] fec_pps_interrupt
> Disabling IRQ #65
> fec 2188000.ether
On 1/2/2018 6:39 PM, Fugang Duan wrote:
> The static variable dev_id always plus one before netdev registerred.
> It should restore the dev_id value in the cases of probe error.
>
> Signed-off-by: Fugang Duan
> ---
> drivers/net/ethernet/freescale/fec_main.c | 1 +
> 1 file changed, 1 insertion(
rupt is for the PTP_CLOCK_PPS interrupts
This will help document what each interrupt does.
Signed-off-by: Troy Kisky
---
v2: replaced empty names with "int0","int1", or "int2"
reordered imx7 interrupts so that "int0", for queue 0, is first.
v3: renamed "
This is better for code locality and should slightly
speed up normal interrupts.
This also allows PPS clock output to start working for
i.mx7. This is because i.mx7 was already using the limit
of 3 interrupts, and needed another.
Signed-off-by: Troy Kisky
---
v2: made this change independent
On 10/31/2017 7:43 PM, Andy Duan wrote:
> From: Troy Kisky Sent: Wednesday, November
> 01, 2017 4:17 AM
>> This is better for code locality and should slightly speed up normal
>> interrupts.
>>
>> This also allows PPS clock output to start working for i.mx7. This i
This is better for code locality and should slightly
speed up normal interrupts.
This also allows PPS clock output to start working for
i.mx7. This is because i.mx7 was already using the limit
of 3 interrupts, and needed another.
Signed-off-by: Troy Kisky
---
v2: made this change independent
document what each interrupt does.
Signed-off-by: Troy Kisky
---
v2: replaced empty names with "int0","int1", or "int2"
reordered imx7 interrupts so that "int0", for queue 0, is first.
v3: renamed "ptp" interrupt to "pps", added binding d
This is better for code locality and should slightly
speed up normal interrupts.
This also allows PPS clock output to start working for
i.mx7. This is because i.mx7 was already using the limit
of 3 interrupts, and needed another.
Signed-off-by: Troy Kisky
---
v2: made this change independent
rupt is for the PTP_CLOCK_PPS interrupts
This will help document what each interrupt does.
Signed-off-by: Troy Kisky
---
v2: replaced empty names with "int0","int1", or "int2"
reordered imx7 interrupts so that "int0", for queue 0, is first.
v3: renamed &qu
On 10/18/2017 11:10 AM, Troy Kisky wrote:
> On 10/17/2017 7:30 PM, Andy Duan wrote:
>> From: Troy Kisky Sent: Wednesday, October
>> 18, 2017 5:34 AM
>>>>> This is better for code locality and should slightly speed up normal
>>> interrupts.
>>>>
On 10/17/2017 7:30 PM, Andy Duan wrote:
> From: Troy Kisky Sent: Wednesday, October
> 18, 2017 5:34 AM
>>>> This is better for code locality and should slightly speed up normal
>> interrupts.
>>>>
>>>> This also allows PPS clock output to start wo
On 10/15/2017 8:41 PM, Andy Duan wrote:
> From: Troy Kisky Sent: Saturday, October 14,
> 2017 10:10 AM
>> This is better for code locality and should slightly speed up normal
>> interrupts.
>>
>> This also allows PPS clock output to start working for i.mx7. This i
This is better for code locality and should slightly
speed up normal interrupts.
This also allows PPS clock output to start working for
i.mx7. This is because i.mx7 was already using the limit
of 3 interrupts, and needed another.
Signed-off-by: Troy Kisky
---
v2: made this change independent
rupt is for the PTP_CLOCK_PPS interrupts
This will help document what each interrupt does.
Signed-off-by: Troy Kisky
---
v2: replaced empty names with "int0","int1", or "int2"
reordered imx7 interrupts so that "int0", for queue 0, is first.
---
arch
On 10/2/2017 5:51 PM, Andrew Lunn wrote:
> On Mon, Oct 02, 2017 at 05:04:41PM -0700, Troy Kisky wrote:
>> imx7s/imx7d has the ptp interrupt newly added as well.
>> This will allow the ptp interrupt to have its own interrupt routine.
>>
>> Signed-off-by: Troy Kisky
&
imx7s/imx7d has the ptp interrupt newly added as well.
This will allow the ptp interrupt to have its own interrupt routine.
Signed-off-by: Troy Kisky
---
arch/arm/boot/dts/imx6qdl.dtsi | 1 +
arch/arm/boot/dts/imx6sx.dtsi | 2 ++
arch/arm/boot/dts/imx6ul.dtsi | 2 ++
arch/arm/boot/dts
This is better for code locality and should slightly
speed up normal interrupts.
This also allows PPS clock output to start working for
i.mx7. This is because i.mx7 was already using the limit
of 3 interrupts, and needed another.
Signed-off-by: Troy Kisky
---
If this patch is taken before the
fec_ptp_check_pps_event will return 1 if FEC_T_TF_MASK caused
an interrupt. Don't return IRQ_NONE in this case.
Signed-off-by: Troy Kisky
Acked-by: Fugang Duan
---
v3: New patch, came from feedback from another patch.
v4: Added Acked-by
Signed-off-by: Troy Kisky
---
drivers/net/eth
FEC_ENET_TS_TIMER is not checked in the interrupt routine
so there is no need to enable it.
Signed-off-by: Troy Kisky
Acked-by: Fugang Duan
---
v4: Added Acked-by
Signed-off-by: Troy Kisky
---
drivers/net/ethernet/freescale/fec.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions
Before queue 0 was always checked if any queue caused an interrupt.
It is better to just mark queue 0 if queue 0 has caused an interrupt.
Signed-off-by: Troy Kisky
Acked-by: Fugang Duan
---
v3: add Acked-by
v4: no change
Signed-off-by: Troy Kisky
---
drivers/net/ethernet/freescale
ernet: DMA-API: device driver tries to free DMA
memory it has not allocated [device address=0x] [size=66 bytes]
encountered by Holger
Signed-off-by: Troy Kisky
Tested-by:
Acked-by: Fugang Duan
---
v2: add ack
---
drivers/net/ethernet/freescale/fec_main.c | 8 +++-
1 file ch
On 4/21/2016 10:59 PM, Fugang Duan wrote:
> From: Troy Kisky Sent: Friday, April 22,
> 2016 10:01 AM
>> To: netdev@vger.kernel.org; da...@davemloft.net; Fugang Duan
>> ; lzn...@gmail.com
>> Cc: Fabio Estevam ; l.st...@pengutronix.de;
>> and...@lunn.ch; trem...@gmai
On 4/21/2016 10:59 PM, Fugang Duan wrote:
> From: Troy Kisky Sent: Friday, April 22,
> 2016 10:01 AM
>> To: netdev@vger.kernel.org; da...@davemloft.net; Fugang Duan
>> ; lzn...@gmail.com
>> Cc: Fabio Estevam ; l.st...@pengutronix.de;
>> and...@lunn.ch; trem...@gmai
ernet: DMA-API: device driver tries to free DMA
memory it has not allocated [device address=0x] [size=66 bytes]
encountered by Holger
Signed-off-by: Troy Kisky
Tested-by:
---
drivers/net/ethernet/freescale/fec_main.c | 8 +++-
1 file changed, 3 insertions(+), 5 deletions(-)
gt; (fec_enet_napi_q1+0x98/0xe8)
> [ 58.581589] r10:0800 r9:ef2ec580 r8: r7:0040 r6:0000
> r5:ef2ec000
I think I've already fixed this, but I've only submitted once.
commit 466cb4a2e5583d2e18470f30d5948edcf4b947f5
Author: Troy Kisky
Date: Wed Jan 20 12:52:1
On 4/6/2016 8:57 PM, David Miller wrote:
> From: Troy Kisky
> Date: Wed, 6 Apr 2016 17:42:47 -0700
>
>> Sure, that's an easy change. But if a TX int is what caused the
>> interrupt and masks them, and then a RX packet happens before napi
>> runs, do you want the
On 4/6/2016 8:58 PM, David Miller wrote:
> From: Troy Kisky
> Date: Wed, 6 Apr 2016 18:09:17 -0700
>
>> On 4/6/2016 2:20 PM, David Miller wrote:
>>>
>>> This is a way too large patch series.
>>>
>>> Please split it up into smaller, more logical,
On 4/6/2016 2:20 PM, David Miller wrote:
>
> This is a way too large patch series.
>
> Please split it up into smaller, more logical, pieces.
>
> Thanks.
>
If you apply the 1st 3 that have been acked, I'll be at 13.
Would I then send the next 5 for V4, and when that is applied
send another V
On 4/6/2016 2:20 PM, David Miller wrote:
> From: Troy Kisky
> Date: Tue, 5 Apr 2016 19:25:51 -0700
>
>> By clearing the NAPI interrupts in the NAPI routine
>> and not in the interrupt handler, we can reduce the
>> number of interrupts. We also don't need any stat
On 4/6/2016 9:43 AM, Troy Kisky wrote:
> On 4/6/2016 1:51 AM, Fugang Duan wrote:
>> From: Troy Kisky Sent: Wednesday, April 06,
>> 2016 10:26 AM
>>> To: netdev@vger.kernel.org; da...@davemloft.net; Fugang Duan
>>> ; lzn...@gmail.com
>>> Cc: Fabio
On 4/6/2016 1:51 AM, Fugang Duan wrote:
> From: Troy Kisky Sent: Wednesday, April 06,
> 2016 10:26 AM
>> To: netdev@vger.kernel.org; da...@davemloft.net; Fugang Duan
>> ; lzn...@gmail.com
>> Cc: Fabio Estevam ; l.st...@pengutronix.de;
>> and...@lunn.ch; trem...@gmai
If a tx int is lost, no need to reset
the fec. Just mark the event and call napi_schedule.
Signed-off-by: Troy Kisky
---
v3: no change
---
drivers/net/ethernet/freescale/fec_main.c | 38 ++-
1 file changed, 37 insertions(+), 1 deletion(-)
diff --git a/drivers/net
Eliminating calls to fec_enet_get_prevdesc shrinks
the code a little.
Signed-off-by: Troy Kisky
---
v3: Change commit message
s/unsigned status/unsigned int status/ as requested
---
drivers/net/ethernet/freescale/fec_main.c | 37 +--
1 file changed, 11 insertions
Create subroutine reset_tx_queue to have one place
to release any queued tx skbs.
Signed-off-by: Troy Kisky
---
v3: change commit message
---
drivers/net/ethernet/freescale/fec_main.c | 50 +++
1 file changed, 25 insertions(+), 25 deletions(-)
diff --git a/drivers
Move restart test to earlier in fec_txq() which saves one comparison.
Signed-off-by: Troy Kisky
---
v3: change commit message
---
drivers/net/ethernet/freescale/fec_main.c | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/drivers/net/ethernet/freescale/fec_main.c
When the tx queue is dumped, it is easier to see that this
entry is idle if cbd_sc is cleared after transmission.
Signed-off-by: Troy Kisky
---
v3: change commit message
---
drivers/net/ethernet/freescale/fec_main.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/net/ethernet
ch is 2010 interrupts.
Signed-off-by: Troy Kisky
---
v3:
Fix introduced bug of checking for FEC_ENET_TS_TIMER
before calling fec_ptp_check_pps_event
Changed commit message to show measured changes.
Used netdev_info instead of pr_info.
Fugang Duan suggested splitting TX and RX into two NAPI
con
fec_ptp_check_pps_event will return 1 if FEC_T_TF_MASK caused
an interrupt. Don't return IRQ_NONE in this case.
Signed-off-by: Troy Kisky
---
v3: New patch, came from feedback from another patch.
---
drivers/net/ethernet/freescale/fec_main.c | 4 ++--
1 file changed, 2 insertions(
Not assigning cbd_bufaddr on error will prevent trying to
unmap the error in case the FEC is reset.
Signed-off-by: Troy Kisky
---
v3: no change
---
drivers/net/ethernet/freescale/fec_main.c | 10 +++---
1 file changed, 7 insertions(+), 3 deletions(-)
diff --git a/drivers/net/ethernet
Make sure any pending tx buffers are unmapped when the
fec is restarted.
Signed-off-by: Troy Kisky
---
v3: no change
---
drivers/net/ethernet/freescale/fec_main.c | 11 ++-
1 file changed, 10 insertions(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/freescale/fec_main.c
b
Dump all tx queues, not just queue 0.
Also, disable fec interrupts first.
The interrupts will be reenabled in fec_restart.
Signed-off-by: Troy Kisky
---
v3: no change
---
drivers/net/ethernet/freescale/fec_main.c | 40 +--
1 file changed, 22 insertions(+), 18
-by: Troy Kisky
---
v3: change commit message
---
drivers/net/ethernet/freescale/fec_main.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/net/ethernet/freescale/fec_main.c
b/drivers/net/ethernet/freescale/fec_main.c
index 17140ea..3cd0cdf 100644
--- a/drivers/net/ethernet/freescale
Relying on the wrap bit of cdb_sc to stay valid once
initialized when the controller also writes to this byte
seems undesirable since we can easily know what the value
should be.
Signed-off-by: Troy Kisky
---
v3: change commit message
---
drivers/net/ethernet/freescale/fec_main.c | 38
FEC_ENET_TS_TIMER is not checked in the interrupt routine
so there is no need to enable it.
Signed-off-by: Troy Kisky
---
v3: New patch
Frank Li said "TS_TIMER should never be triggered."
when discussing another patch.
---
drivers/net/ethernet/freescale/fec.h | 4 ++--
1 file
If we only have 1 tx/rx queue, we need not check
the other queues.
Signed-off-by: Troy Kisky
---
v3: rebase changes only, fep is no longer passed as a parameter to
fec_rxq/fec_txq
---
drivers/net/ethernet/freescale/fec_main.c | 39 +--
1 file changed, 37 insertions
patch
The changes are noted on individual patches
My measured performance of this series is
before patch set
365 Mbits/sec Tx/407 RX
after patch set
374 Tx/427 Rx
Troy Kisky (16):
net: fec: only check queue 0 if RXF_0/TXF_0 interrupt is set
net: fec: remove unused interrupt FEC_ENET_TS_T
The queue_id is the qid member of struct bufdesc_prop.
Passing rxq/txq will allow the macro FEC_ENET_GET_QUQUE to be removed
in the next patch.
Signed-off-by: Troy Kisky
Acked-by: Fugang Duan
---
v3:
add Acked-by
combine with "net: fec: pass txq to fec_enet_tx_queue instead of que
Before queue 0 was always checked if any queue caused an interrupt.
It is better to just mark queue 0 if queue 0 has caused an interrupt.
Signed-off-by: Troy Kisky
Acked-by: Fugang Duan
---
v3: add Acked-by
---
drivers/net/ethernet/freescale/fec_main.c | 4 ++--
1 file changed, 2 insertions
On 3/29/2016 8:24 PM, Greg Ungerer wrote:
> Hi Troy,
>
> Commit 55cd48c8 ('net: fec: stop the "rcv is not +last, " error
> messages') adds a write to a register that is not present in all
> implementations of the FEC hardware module. None of the ColdFire
> SoC parts with the FEC module have the FT
On 3/4/2016 10:35 AM, Joe Perches wrote:
> On Fri, 2016-03-04 at 09:05 -0700, Troy Kisky wrote:
>> On 3/4/2016 3:06 AM, Fugang Duan wrote:
>>> From: Troy Kisky Sent: Thursday, February
>>> 25, 2016 8:37 AM
> []
>>>> Print the current interrupt fla
On 3/4/2016 9:38 AM, Russell King - ARM Linux wrote:
> On Fri, Mar 04, 2016 at 09:18:19AM -0700, Troy Kisky wrote:
>> On 3/4/2016 2:11 AM, Fugang Duan wrote:
>>> From: Troy Kisky Sent: Thursday, February
>>> 25, 2016 8:37 AM
>>>> To: netdev@vg
On 3/4/2016 12:41 AM, Fugang Duan wrote:
> From: Troy Kisky Sent: Thursday, March 03,
> 2016 12:14 AM
>> To: Fugang Duan ; netdev@vger.kernel.org;
>> da...@davemloft.net; b38...@freescale.com
>> Cc: fabio.este...@freescale.com; l.st...@pengutronix.de; and...@lunn.ch;
On 3/4/2016 2:11 AM, Fugang Duan wrote:
> From: Troy Kisky Sent: Thursday, February 25,
> 2016 8:37 AM
>> To: netdev@vger.kernel.org; da...@davemloft.net; b38...@freescale.com
>> Cc: fabio.este...@freescale.com; l.st...@pengutronix.de; and...@lunn.ch;
>> trem...@gmail.com
On 3/4/2016 3:06 AM, Fugang Duan wrote:
> From: Troy Kisky Sent: Thursday, February
> 25, 2016 8:37 AM
>> To: netdev@vger.kernel.org; da...@davemloft.net; b38...@freescale.com
>> Cc: fabio.este...@freescale.com; l.st...@pengutronix.de; and...@lunn.ch;
>> trem...@gmail.com
On 3/4/2016 2:29 AM, Fugang Duan wrote:
> From: Troy Kisky Sent: Thursday, February
> 25, 2016 8:37 AM
>> To: netdev@vger.kernel.org; da...@davemloft.net; b38...@freescale.com
>> Cc: fabio.este...@freescale.com; l.st...@pengutronix.de; and...@lunn.ch;
>> trem...@gmail.com
On 3/4/2016 2:33 AM, Fugang Duan wrote:
> From: Troy Kisky Sent: Thursday, February
> 25, 2016 8:37 AM
>> To: netdev@vger.kernel.org; da...@davemloft.net; b38...@freescale.com
>> Cc: fabio.este...@freescale.com; l.st...@pengutronix.de; and...@lunn.ch;
>> trem...@gmail.com
On 3/2/2016 9:47 AM, Zhi Li wrote:
> On Wed, Mar 2, 2016 at 10:12 AM, Troy Kisky
> wrote:
>> On 3/2/2016 8:13 AM, Fugang Duan wrote:
>>> From: Troy Kisky Sent: Thursday, February
>>> 25, 2016 8:37 AM
>>>>
>>>> -if (fep->ptp_clo
On 3/2/2016 8:13 AM, Fugang Duan wrote:
> From: Troy Kisky Sent: Thursday, February
> 25, 2016 8:37 AM
>> To: netdev@vger.kernel.org; da...@davemloft.net; b38...@freescale.com
>> Cc: fabio.este...@freescale.com; l.st...@pengutronix.de; and...@lunn.ch;
>> trem...@gmail.com
On 3/2/2016 8:16 AM, Fugang Duan wrote:
> From: Troy Kisky Sent: Thursday, February
> 25, 2016 8:37 AM
>> To: netdev@vger.kernel.org; da...@davemloft.net; b38...@freescale.com
>> Cc: fabio.este...@freescale.com; l.st...@pengutronix.de; and...@lunn.ch;
>&g
On 3/1/2016 3:26 PM, Zhi Li wrote:
> On Tue, Mar 1, 2016 at 3:51 PM, Troy Kisky
> wrote:
>> True, but fec_txq/fec_rxq is called in a loop.
>
> netdev_priv(ndev) is that pointer move.
> dev + ALIGN(sizeof(struct net_device), NETDEV_ALIGN)
>
> Modem compiler can handle
On 3/1/2016 2:06 PM, Zhi Li wrote:
> On Wed, Feb 24, 2016 at 6:36 PM, Troy Kisky
> wrote:
>> queue_id is the qid member of struct bufdesc_prop.
>>
>> Signed-off-by: Troy Kisky
>> ---
>> drivers/net/ethernet/freescale/fec_main.c | 17 ++---
>
We need that for a custom hardware that needs the reverse reset
sequence.
Signed-off-by: Bernhard Walle
---
Documentation/devicetree/bindings/net/fsl-fec.txt | 3 +++
drivers/net/ethernet/freescale/fec_main.c | 8 ++--
2 files changed, 9 insertions(+), 2 deletions(-)
diff --git a/Do
On 2/24/2016 7:52 PM, Joshua Clayton wrote:
> Hello Troy,
> I'm replying here instead of to a particular commit because several of
> the commit messages seem inadequate.
>
> The first line summaries all look good.
>
> The descriptions should each also include the "user visible impact" of
> the pa
On 2/25/2016 1:39 AM, Holger Schurig wrote:
> Hi Troy,
>
> what is the general aim of your patches? Stability? Speed? Cleanup?
>
1. Stability
2. performance
3. easier to read
4. more debug info
The 2nd goal is very hard to measure. It seems function alignment changes swamp
most any other im
queue_id is the qid member of struct bufdesc_prop.
Signed-off-by: Troy Kisky
---
drivers/net/ethernet/freescale/fec_main.c | 17 ++---
1 file changed, 6 insertions(+), 11 deletions(-)
diff --git a/drivers/net/ethernet/freescale/fec_main.c
b/drivers/net/ethernet/freescale
Before queue 0 was always checked if any queue caused an interrupt.
It is better to just mark queue 0 if queue 0 has caused an interrupt.
Signed-off-by: Troy Kisky
---
drivers/net/ethernet/freescale/fec_main.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net
Dump all tx queues, not just queue 0.
Also, disable fec interrupts first.
The interrupts will be reenabled in fec_restart.
Signed-off-by: Troy Kisky
---
drivers/net/ethernet/freescale/fec_main.c | 40 +--
1 file changed, 22 insertions(+), 18 deletions(-)
diff --git
Relying on the wrap bit to stay valid once initialized
when the controller also writes to this byte seems
undesirable since we can easily know what the value
should be.
Signed-off-by: Troy Kisky
---
drivers/net/ethernet/freescale/fec_main.c | 38 +--
1 file changed
FEC_ENET_RXF is 3 separate bits, we only check one queue
at a time. So, when the last queue is being checked, it is
bad to remove the interrupt on the 1st queue.
Also, since this is now done in the napi
routine and not the interrupt, it is not needed.
Signed-off-by: Troy Kisky
---
drivers/net
When the tx queue is dumped, it is easier to see that this
entry is idle.
Signed-off-by: Troy Kisky
---
drivers/net/ethernet/freescale/fec_main.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/net/ethernet/freescale/fec_main.c
b/drivers/net/ethernet/freescale/fec_main.c
index
If a tx int is lost, no need to reset
the fec. Just mark the event and call napi_schedule.
Signed-off-by: Troy Kisky
---
drivers/net/ethernet/freescale/fec_main.c | 38 ++-
1 file changed, 37 insertions(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/freescale
Print the current interrupt flags and mask and
the interrupt state during the last interrupt in
fec_timeout.
Signed-off-by: Troy Kisky
---
drivers/net/ethernet/freescale/fec.h | 1 +
drivers/net/ethernet/freescale/fec_main.c | 4
2 files changed, 5 insertions(+)
diff --git a/drivers
If we only have 1 tx/rx queue, we need not check
the other queues.
Signed-off-by: Troy Kisky
---
drivers/net/ethernet/freescale/fec_main.c | 39 +--
1 file changed, 37 insertions(+), 2 deletions(-)
diff --git a/drivers/net/ethernet/freescale/fec_main.c
b/drivers
This creates one place to release any queued
tx skbs.
Signed-off-by: Troy Kisky
---
drivers/net/ethernet/freescale/fec_main.c | 50 +++
1 file changed, 25 insertions(+), 25 deletions(-)
diff --git a/drivers/net/ethernet/freescale/fec_main.c
b/drivers/net/ethernet
This shrinks the code a little.
Signed-off-by: Troy Kisky
---
drivers/net/ethernet/freescale/fec_main.c | 37 +--
1 file changed, 11 insertions(+), 26 deletions(-)
diff --git a/drivers/net/ethernet/freescale/fec_main.c
b/drivers/net/ethernet/freescale/fec_main.c
Make sure any pending tx buffers are unmapped when the
fec is restarted.
Signed-off-by: Troy Kisky
---
drivers/net/ethernet/freescale/fec_main.c | 11 ++-
1 file changed, 10 insertions(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/freescale/fec_main.c
b/drivers/net/ethernet
Not assigning cbd_bufaddr on error will prevent trying to
unmap the error in case the FEC is reset.
Signed-off-by: Troy Kisky
---
drivers/net/ethernet/freescale/fec_main.c | 10 +++---
1 file changed, 7 insertions(+), 3 deletions(-)
diff --git a/drivers/net/ethernet/freescale/fec_main.c
b
This saves 1 comparison.
Signed-off-by: Troy Kisky
---
drivers/net/ethernet/freescale/fec_main.c | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/drivers/net/ethernet/freescale/fec_main.c
b/drivers/net/ethernet/freescale/fec_main.c
index b5ed287..1902897 100644
l now continue to
receive the previously pending packets.
Signed-off-by: Troy Kisky
---
drivers/net/ethernet/freescale/fec.h | 6 +-
drivers/net/ethernet/freescale/fec_main.c | 127 --
2 files changed, 50 insertions(+), 83 deletions(-)
diff --git a/drivers/net/eth
The queue_id is the qid member of struct bufdesc_prop.
Signed-off-by: Troy Kisky
---
drivers/net/ethernet/freescale/fec_main.c | 13 +
1 file changed, 5 insertions(+), 8 deletions(-)
diff --git a/drivers/net/ethernet/freescale/fec_main.c
b/drivers/net/ethernet/freescale/fec_main.c
h this series, and the rest of
my fec patches, for those who would like to test it.
https://github.com:boundarydevices/linux-imx6.git branch net-next_master
Troy Kisky (16):
SDCard
TX/RX
379/402 Before any patches
376/402 net: fec: only check queue 0 if RXF_0/TXF_0 interrupt is set
379/399 net:
On 2/6/2016 4:52 AM, Sergei Shtylyov wrote:
> Hello.
>
> On 2/6/2016 12:52 AM, Troy Kisky wrote:
>
>> If you don't own it, you shouldn't write to it.
>>
>> Signed-off-by: Troy Kisky
>> ---
>> drivers/net/ethernet/freescale/fec_main.c |
On 2/5/2016 6:03 PM, Joshua Clayton wrote:
> On Fri, 5 Feb 2016 14:52:49 -0700
> Troy Kisky wrote:
>
>> If you don't own it, you shouldn't write to it.
>>
>> Signed-off-by: Troy Kisky
>> ---
>> drivers/net/ethernet/freescale/fec_main.c | 14
ith this series, and the rest of
my fec patches, for those who would like to test it.
https://github.com:boundarydevices/linux-imx6.git branch net-next_master
Troy Kisky (8):
SDCard
TX/RX
378/405 before any patches
379/407 net: fec: stop the "rcv is not +last, " error messages
378/
There is no need for complex macros every time we need to activate
a queue. Also, no need to call skb_get_queue_mapping when we already
know which queue it is using.
Signed-off-by: Troy Kisky
---
drivers/net/ethernet/freescale/fec.h | 7 +
drivers/net/ethernet/freescale/fec_main.c
instead.
Signed-off-by: Troy Kisky
---
drivers/net/ethernet/freescale/fec_main.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/freescale/fec_main.c
b/drivers/net/ethernet/freescale/fec_main.c
index 162fa59..adbddfd 100644
--- a/drivers/net/ethernet
Unmap initial buffer on error.
Don't free skb until it has been unmapped.
Move cbd_bufaddr assignment closer to the mapping function.
Signed-off-by: Troy Kisky
---
drivers/net/ethernet/freescale/fec_main.c | 11 +++
1 file changed, 7 insertions(+), 4 deletions(-)
diff --git a/dr
This reduces code and gains speed.
Signed-off-by: Troy Kisky
---
drivers/net/ethernet/freescale/fec.h | 29 ++-
drivers/net/ethernet/freescale/fec_main.c | 288 --
2 files changed, 132 insertions(+), 185 deletions(-)
diff --git a/drivers/net/ethernet/freescale
If you don't own it, you shouldn't write to it.
Signed-off-by: Troy Kisky
---
drivers/net/ethernet/freescale/fec_main.c | 14 +-
1 file changed, 13 insertions(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/freescale/fec_main.c
b/drivers/net/ethernet/freescale/fec_ma
Only the interrupt routine processes this condition.
Signed-off-by: Troy Kisky
---
drivers/net/ethernet/freescale/fec.h | 1 +
drivers/net/ethernet/freescale/fec_main.c | 2 +-
2 files changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/freescale/fec.h
b/drivers/net
On an overrun, the other flags are not
valid, so don't check them.
Also, don't pass bad frames up the stack.
Signed-off-by: Troy Kisky
---
drivers/net/ethernet/freescale/fec_main.c | 36 +--
1 file changed, 15 insertions(+), 21 deletions(-)
diff --git a/d
Setting the FTRL register will stop the fec from
trying to use multiple receive buffers.
Signed-off-by: Troy Kisky
---
drivers/net/ethernet/freescale/fec.h | 1 +
drivers/net/ethernet/freescale/fec_main.c | 1 +
2 files changed, 2 insertions(+)
diff --git a/drivers/net/ethernet/freescale
On 1/28/2016 3:02 PM, Arnd Bergmann wrote:
> On Thursday 28 January 2016 14:25:32 Troy Kisky wrote:
>> Signed-off-by: Troy Kisky
>> ---
>> drivers/net/ethernet/freescale/fec_main.c | 4 ++--
>> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> [note: missi
Relying on the wrap bit to stay valid once initialized
when the controller also writes to this byte seems
undesirable since we can easily know what the value
should be.
Signed-off-by: Troy Kisky
---
drivers/net/ethernet/freescale/fec_main.c | 31 ++-
1 file changed
queue_id is the qid member of struct bufdesc_prop.
Signed-off-by: Troy Kisky
---
drivers/net/ethernet/freescale/fec_main.c | 17 ++---
1 file changed, 6 insertions(+), 11 deletions(-)
diff --git a/drivers/net/ethernet/freescale/fec_main.c
b/drivers/net/ethernet/freescale
Signed-off-by: Troy Kisky
---
drivers/net/ethernet/freescale/fec_main.c | 8 +++-
1 file changed, 3 insertions(+), 5 deletions(-)
diff --git a/drivers/net/ethernet/freescale/fec_main.c
b/drivers/net/ethernet/freescale/fec_main.c
index 380c8e2..cf53e21 100644
--- a/drivers/net/ethernet
FEC_ENET_RXF is 3 separate bits, we only check one queue
at a time. So, when the last queue is being checked, it is
bad to remove the interrupt on the 1st queue.
Also, since this is now done in the napi
routine and not the interrupt, it is not needed.
Signed-off-by: Troy Kisky
---
drivers/net
Signed-off-by: Troy Kisky
---
drivers/net/ethernet/freescale/fec_main.c | 12 +++-
1 file changed, 7 insertions(+), 5 deletions(-)
diff --git a/drivers/net/ethernet/freescale/fec_main.c
b/drivers/net/ethernet/freescale/fec_main.c
index da2e3c530..29c5781 100644
--- a/drivers/net
Print the current interrupt flags and mask and
the interrupt state during the last interrupt in
fec_timeout.
Signed-off-by: Troy Kisky
---
drivers/net/ethernet/freescale/fec.h | 1 +
drivers/net/ethernet/freescale/fec_main.c | 4
2 files changed, 5 insertions(+)
diff --git a/drivers
1 - 100 of 135 matches
Mail list logo
