On 3/2/2016 9:47 AM, Zhi Li wrote: > On Wed, Mar 2, 2016 at 10:12 AM, Troy Kisky > <troy.ki...@boundarydevices.com> wrote: >> On 3/2/2016 8:13 AM, Fugang Duan wrote: >>> From: Troy Kisky <troy.ki...@boundarydevices.com> Sent: Thursday, February >>> 25, 2016 8:37 AM >>>> >>>> - if (fep->ptp_clock) >>>> + if ((int_events & FEC_ENET_TS_TIMER) && fep->ptp_clock) >>>> fec_ptp_check_pps_event(fep); >>>> - >>> This is error in here. FEC compare timer event is not TS timer. >>> >>> >> >> >> So when should fec_ptp_check_pps_event be called ? On every interrupt ? > > Compare event is not showed in EIR register. Need check TCSR, please > see below code. > > uint fec_ptp_check_pps_event(struct fec_enet_private *fep) > { > xx > val = readl(fep->hwp + FEC_TCSR(channel)); > if (val & FEC_T_TF_MASK) { > }
So, should FEC_ENET_TS_TIMER be removed from FEC_DEFAULT_IMASK, since the interrupt routine never checks it ?