ethtool 5.7 released

responsibility, and I have every confidence that he will do a great job in that capacity for our community. Thanks, Michal! John -- John W. LinvilleSomeday the world will need a hero, and you linvi...@tuxdriver.com might be all we have. Be ready.

Re: [PATCH ethtool] ethtool: add support for newer SFF-8024 compliance codes

gt; Signed-off-by: Andy Roulin Thanks (belatedly) -- queued for next release! John -- John W. LinvilleSomeday the world will need a hero, and you linvi...@tuxdriver.com might be all we have. Be ready.

Re: [PATCH] ethtool.c: Report transceiver correctly

t; > Fixes: 33133abf3b77 ("ethtool.c: add support for ETHTOOL_xLINKSETTINGS > ioctls") > Signed-off-by: Florian Fainelli Thanks (belatedly) -- queued for next release! John -- John W. LinvilleSomeday the world will need a hero, and you linvi...@tuxdriver.com might be all we have. Be ready.

Re: [PATCH ethtool 0/2] improve the logic of fallback from netlink to ioctl

link/parser.c | 7 ++ > netlink/settings.c | 7 ++ > 7 files changed, 220 insertions(+), 73 deletions(-) Thanks (belatedly) -- queued for next release! John -- John W. LinvilleSomeday the world will need a hero, and you linvi...@tuxdriver.com might be all we have. Be ready.

Re: [PATCH ethtool] features: accept long legacy flag names when setting features

name but this name cannot be used to set the flag/feature. > > Accept both short and long legacy flag names in "ethool -K". > > Reported-by: Konstantin Kharlamov > Signed-off-by: Michal Kubecek Thanks (belatedly) -- queued for next release! John -- Jo

Re: [PATCH V3 ethtool] ethtool: Add support for Low Latency Reed Solomon

t; Reviewed-by: Eran Ben Elisha > Signed-off-by: Tariq Toukan Thanks (belatedly) -- queued for next release! John -- John W. LinvilleSomeday the world will need a hero, and you linvi...@tuxdriver.com might be all we have. Be ready.

ethtool 5.6 released

genetlink control * Feature: netlink: message format descriptions for rtnetlink * Feature: netlink: use pretty printing for ethtool netlink messages John P.S. If you are interested in maintaining ethtool, please let me know! -- John W. LinvilleSomeday the world will

Re: [PATCH ethtool] ethtool: dump nested registers

t sure what to do with this one, given the disucssion that followed. But since Dave merged "net: dsa: dump CPU port regs through master" for net-next, I went ahead and queued this one for the next release. If that was the wrong thing to do, speak-up now! Thanks, John -- John

Re: [PATCH ethtool] gitignore: ignore vim swapfiles and patches

*.patch to hide patches created by e.g. "git format-patch". > > Signed-off-by: Michal Kubecek Queued for next release...thanks! -- John W. LinvilleSomeday the world will need a hero, and you linvi...@tuxdriver.com might be all we have. Be ready.

Re: [PATCH v2] ethtool: igb: dump RR2DCDELAY register

a from the host memory. > > Signed-off-by: Artem Bityutskiy Queued for next release -- thanks! John -- John W. LinvilleSomeday the world will need a hero, and you linvi...@tuxdriver.com might be all we have. Be ready.

ethtool 5.2 released

file location macros in ethtool.spec John -- John W. LinvilleSomeday the world will need a hero, and you linvi...@tuxdriver.com might be all we have. Be ready.

Re: [PATCH ethtool] ethtool.spec: Use standard file location macros

ned-off-by: Tariq Toukan > --- > ethtool.spec.in | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) Thanks for the patch! Queued for next release... John -- John W. LinvilleSomeday the world will need a hero, and you linvi...@tuxdriver.com might be all we have. Be ready.

Re: [PATCH v2 0/2] Add 100BaseT1 and 1000BaseT1

letion(-) Thanks for the patches! Queued for next release... John -- John W. LinvilleSomeday the world will need a hero, and you linvi...@tuxdriver.com might be all we have. Be ready.

ethtool 5.1 released

e settings * Feature: support per-queue sub command --show-coalesce * Feature: support per-queue sub command --coalesce * Fix: fix up dump_coalesce output to match actual option names * Feature: fec: add pretty dump John -- John W. LinvilleSomeday the

Re: [PATCH v3] ethtool: Add bash-completion script

eck` and expectations. > * Stop using PKG_CHECK_MODULES due to unnecessary _CFLAGS/LIBS vars. > Use PKG_PROG_PKG_CONFIG then call $PKG_CONFIG directly. > > Changes in v2: > * Describe manual install and ./configure arguments in commit message. LGTM -- queued for next release. Thank

Re: [PATCH v2] ethtool: Add bash-completion script

On Tue, Apr 16, 2019 at 08:53:33PM -0600, Kevin Locke wrote: > On Tue, 2019-04-16 at 14:37 -0400, John W. Linville wrote: > > Overall, it looks good to me. But when I build with "make distcheck", > > I get this output: > > > > [...] > >

Re: [PATCH v2] ethtool: Add bash-completion script

rror 2 make[1]: Leaving directory '/home/linville/git/ethtool/ethtool-5.0/_build/sub' make: *** [Makefile:2347: distcheck] Error 1 It looks like somewhere you are using "$(bashcompletiondir)" instead of "$(DESTDIR)$(bashcompletiondir)", but I can't seem to find it. Perhaps you can find the change required to avoid this build error? Thanks, John -- John W. LinvilleSomeday the world will need a hero, and you linvi...@tuxdriver.com might be all we have. Be ready.

Re: [PATCH v2 0/4] ethtool: add support for new PHY tunable Fast Link Down

Down tunable to man page > > ethtool-copy.h | 44 +++ > ethtool.8.in | 28 +-- > ethtool.c | 98 +- > 3 files changed, 114 insertions(+), 56 deletions(-) > > -- > 2.21.0 Series queued for next rel

Re: Add a 'start N' option when specifying the Rx flow hash indirection table.

. > > Signed-off-by: Jonathan Lemon > Acked-by: Edward Cree Queued for next release... Thanks! John -- John W. LinvilleSomeday the world will need a hero, and you linvi...@tuxdriver.com might be all we have. Be ready.

Re: [PATCH 4/4] ethtool: add PHY Fast Link Down tunable to man page

soon as > >> possible. > >> +Some PHYs support a Fast Link Down feature, and partially even allow to > >> configure > >> +the period until until a broken link is reported as being down. > > > > Some PHYs support a Fast Link Down Feature and may allow configuration > > of the delay before a broken link is reported as being down. > > > OK > > >Andrew > > > Heiner > > -- John W. LinvilleSomeday the world will need a hero, and you linvi...@tuxdriver.com might be all we have. Be ready.

Re: [PATCH ethtool V2] ethtool: Add support for 200Gbps (50Gbps per lane) link mode

ned-off-by: Aya Levin > Signed-off-by: Tariq Toukan Queued for next release -- thanks! John -- John W. LinvilleSomeday the world will need a hero, and you linvi...@tuxdriver.com might be all we have. Be ready.

Re: [PATCH] ethtool: fec: add pretty dump

n 1 which corresponds to the opposite test. At the same time, > detail a few interesting registers of version 2. > > Kernels not patched for setting this version will cause ethtool to > dump the whole set of registers as it already does today. > > Signed-off-by: Vivien Didelot

Re: [PATCH v3 1/6] ethtool: move option parsing related code into function

e -- thanks! John -- John W. LinvilleSomeday the world will need a hero, and you linvi...@tuxdriver.com might be all we have. Be ready.

Re: [PATCH RESEND ethtool] ethtool: add 10000baseR_FEC link mode name

l " > output) and is not listed in the manual page. Add it to both. > > Signed-off-by: Michal Kubecek Queued for next release -- thanks! John -- John W. LinvilleSomeday the world will need a hero, and you linvi...@tuxdriver.com might be all we have. Be ready.

Re: [PATCH ethtool] ethtool: qsfp: fix special value comparison

16. > > Fixes: a5e73bb05ee4 ("ethtool:QSFP Plus/QSFP28 Diagnostics Information > Support") > Signed-off-by: Michal Kubecek LGTM -- queued for next release. Thanks, John -- John W. LinvilleSomeday the world will need a hero, and you linvi...@tuxdriver.com might be all we have. Be ready.

ethtool 5.0 released

E6352 * Feature: dsa: mv88e6xxx: add pretty dump for 88E6390 * Feature: dsa: mv88e6xxx: add pretty dump for others John -- John W. LinvilleSomeday the world will need a hero, and you linvi...@tuxdriver.com might be all we have. Be ready.

Re: [ethtool 1/6] ethtool: move option parsing related code into function

e[1]: Leaving directory '/home/linville/git/ethtool/ethtool-4.19/_build/sub' make: *** [Makefile:2186: distcheck] Error 1 ... I'll attach ./ethtool-4.19/_build/sub/test-suite.log to this message. Obviously we need whatever additional changes are needed to get 'make check-TESTS' t

Re: [PATCH] Revert "ethtool: change to new sane powerpc64 kernel headers"

#ifndef _LINUX_ETHTOOL_H > #define _LINUX_ETHTOOL_H > > -#ifdef __powerpc64__ > -/* Powerpc needs __SANE_USERSPACE_TYPES__ before to select > - * 'int-ll64.h' and avoid compile warnings when printing __u64 with %llu. > - */ > -#define __SANE_USERSPACE_TYPES__ > -#endif &g

Re: ethtool - manual changes in ethtool-copy.h

have to make sure to add your fragment > to it. > > As you only need to define the __SANE_USERSPACE_TYPES__ macro (on > ppc64), it might be possible to achieve the same goal in Makefile. > > Michal Kubecek Ooops -- thanks for noticing that Michal! Maciej, how soon might you be able to add

Re: [PATCH] ethtool: zero initialize coalesce struct

rt > of stale data. > > It seems to likely be some sort of time (a second's counter). > > Tested: > 'ethtool -c eth1' with old kernel now reports 'dmac: 0' where > previously it reported some sort of second counter. > > Signed-off-by

Re: [PATCH v2 0/7] ethtool: pretty dump mv88e6xxx registers

: > ethtool: dsa: add pretty dump > ethtool: dsa: mv88e6xxx: add pretty dump > ethtool: dsa: mv88e6xxx: add pretty dump for 88E6185 > ethtool: dsa: mv88e6xxx: add pretty dump for 88E6161 > ethtool: dsa: mv88e6xxx: add pretty dump for 88E6352 > ethtool: dsa: mv88e6xxx: add pretty dump for 88E6390 >

Re: [PATCH ethtool] ethtool: don't report UFO on kernels v4.14 and above

t only simple check for > this instead of implementing more generic solution like 'max_kernel_ver > field in struct off_flag_def'. > > Cc: John W. Linville > Signed-off-by: Ivan Vecera Queued for next release. -- John W. LinvilleSom

Re: [PATCH] ethtool: change to new sane powerpc64 kernel headers

__PPC64__ 1 > .#define _ARCH_PPC 1 > .#define __powerpc64__ 1 > .#define __PPC__ 1 > .#define __powerpc__ 1 > .#define _ARCH_PPC64 1 > > .#define __AARCH64_CMODEL_SMALL__ 1 > .#define __aarch64__ 1 > .#define __AARCH64EL__ 1 > .#define __ARM_NEON 1 > > Signed-off-by: Maciej Żenczykowski Queued for next release. -- John W. LinvilleSomeday the world will need a hero, and you linvi...@tuxdriver.com might be all we have. Be ready.

Re: [PATCH] rtlwifi: rtl818x: fix indentation issue

On Thu, Jan 17, 2019 at 03:28:59PM +, Colin King wrote: > From: Colin Ian King > > There is a statement that is indented too deeply. Fix this. > > Signed-off-by: Colin Ian King Acked-by: John W. Linville -- John W. LinvilleSomeday the world will need

ethtool 4.19 released

combinations of FEC modes * Fix: Fix uninitialized variable use at qsfp dump John -- John W. LinvilleSomeday the world will need a hero, and you linvi...@tuxdriver.com might be all we have. Be ready.

Re: [PATCH linux-firmware] linux-firmware: liquidio: fix GPL compliance issue

the kernel in question without having to announce themselves. The "send an email to i...@cavium.com" offer may (or may not) be sufficient for the letter of the law. But it seems both fragile and prone to subjective frustrations and delays for users to obtain the sources at some future date

Re: [PATCH ethtool v2] ethtool: Fix uninitialized variable use at qsfp dump

initialized at > sff8472_parse_eeprom function, to avoid the same issue here. > > Fixes: a5e73bb05ee4 ("ethtool:QSFP Plus/QSFP28 Diagnostics Information > Support") > Signed-off-by: Eran Ben Elisha OK, queued for next release... -- John W. LinvilleSom

Re: [RFC PATCH ethtool] ethtool: better syntax for combinations of FEC modes

On Thu, Oct 04, 2018 at 05:06:29PM +0100, Edward Cree wrote: > On 04/10/18 15:08, John W. Linville wrote: > > Ping? > > > > On Mon, Oct 01, 2018 at 02:59:10PM -0400, John W. Linville wrote: > >> Is this patch still RFC? > Feel free to de-RFC and apply it. Great

Re: [RFC PATCH ethtool] ethtool: better syntax for combinations of FEC modes

Ping? On Mon, Oct 01, 2018 at 02:59:10PM -0400, John W. Linville wrote: > Is this patch still RFC? > > On Wed, Sep 19, 2018 at 05:06:25PM +0100, Edward Cree wrote: > > Instead of commas, just have them as separate argvs. > > > > The parsing state machine might look h

Re: [RFC PATCH ethtool] ethtool: better syntax for combinations of FEC modes

12 +268,12 @@ static struct test_case { > { 1, "--set-eee devname advertise foo" }, > { 1, "--set-fec devname" }, > { 0, "--set-fec devname encoding auto" }, > - { 0, "--set-fec devname encoding off," }, > - { 0, "--set-f

Re: [PATCH ethtool] ethtool: support combinations of FEC modes

+++ b/test-cmdline.c > @@ -266,6 +266,15 @@ static struct test_case { > { 0, "--set-eee devname tx-timer 42 advertise 0x4321" }, > { 1, "--set-eee devname tx-timer foo" }, > { 1, "--set-eee devname advertise foo" }, > + { 1, "--s

ethtool 4.18 released

support for action value -2 (wake-up filter) * Fix: document WoL filters option also in help message * Feature: ixgbe dump strings for security registers John -- John W. LinvilleSomeday the world will need a hero, and you linvi...@tuxdriver.com

Re: [PATCH ethtool] ethtool: document WoL filters option also in help message

n page > > but not in the output of "ethtool --help". > > > > Signed-off-by: Michal Kubecek > > Acked-by: Florian Fainelli > > Thanks Michal! Yes, good eye! John -- John W. LinvilleSomeday the world will need a hero, and you linvi...@tuxdriver.com might be all we have. Be ready.

Re: [PATCH ethtool v2 0/3] ethtool: Wake-on-LAN using filters

4 files changed, 24 insertions(+), 8 deletions(-) Thanks, Florian -- LGTM! Patches merged and pushed-out, queued for next release (probably next week)... John -- John W. LinvilleSomeday the world will need a hero, and you linvi...@tuxdriver.com might be all we have. Be ready.

Re: incomplete firmware-version shown in ethtool -i

EXC** File > "/dfcxact/mtsn/J3002240/debug_yuhongw_18b_brcm/platform/modules/Run.py", line > 384, in runmain > 180625-11:26:57 EXC** result = func(*bares, **keywords) > 180625-11:26:57 EXC** File > "/dfcxact/mtsn/J3002240/debug_yuhongw_18b_brcm/repos/common/tests/broadcom_code_test.py", > line 37, in main > 180625-11:26:57 EXC** broadcom.verify_firmware_level(location) > 180625-11:26:57 EXC** File > "/dfcxact/mtsn/J3002240/debug_yuhongw_18b_brcm/repos/common/modules/Broadcom.py", > line 180, in verify_firmware_level > 180625-11:26:57 EXC** result, expected, actual = > self._verify_firmware_level(location) > 180625-11:26:57 EXC** File > "/dfcxact/mtsn/J3002240/debug_yuhongw_18b_brcm/repos/common/modules/Broadcom.py", > line 193, in _verify_firmware_level > 180625-11:26:57 EXC** actual_parts = version_tuple(actual) > 180625-11:26:57 EXC** File > "/dfcxact/mtsn/J3002240/debug_yuhongw_18b_brcm/repos/common/modules/Broadcom.py", > line 59, in version_tuple > 180625-11:26:57 EXC** return tuple(int(v, base) for v in > re.split(pattern, version)) > 180625-11:26:57 EXC** File > "/dfcxact/mtsn/J3002240/debug_yuhongw_18b_brcm/repos/common/modules/Broadcom.py", > line 59, in > 180625-11:26:57 EXC** return tuple(int(v, base) for v in > re.split(pattern, version)) > 180625-11:26:57 EXC** ValueError: invalid literal for int() with base 16: '' > 180625-11:26:57 FAIL FAIL > 180625-11:26:57 TESTE FAIL broadcom_code_test.py flash > > Globa Test Engineer > Email: wu...@lenovo.com<mailto:wu...@lenovo.com> > -- John W. LinvilleSomeday the world will need a hero, and you linvi...@tuxdriver.com might be all we have. Be ready.

ethtool 4.17 released

do_get_phy_tunable and do_set_phy_tunable * Feature: Add register dump support for MICROCHIP LAN78xx John -- John W. LinvilleSomeday the world will need a hero, and you linvi...@tuxdriver.com might be all we have. Be ready.

Re: [PATCH ethtool 1/6] ethtool: fix uninitialized return value

mmit IDs... Thanks! John -- John W. LinvilleSomeday the world will need a hero, and you linvi...@tuxdriver.com might be all we have. Be ready.

Re: [PATCH ethtool] ethtool: fix stack clash in do_get_phy_tunable and do_set_phy_tunable

s.data[0]. The same > problem also exists in do_set_phy_tunable(). > > Fixes: b0fe96dec90f ("Ethtool: Implements > ETHTOOL_PHY_GTUNABLE/ETHTOOL_PHY_STUNABLE and PHY downshift") > Signed-off-by: Michal Kubecek LGTM -- queued for next release... -- John W. Linville

Re: [ethtool] ethtool: Add register dump support for MICROCHIP LAN78xx

off-by: Raghuram Chary J LGTM -- queued for next release... John -- John W. LinvilleSomeday the world will need a hero, and you linvi...@tuxdriver.com might be all we have. Be ready.

ethtool 4.16 released

r the ring_cookie parameter * Feature: Add SFF 8636 date code parsing support John -- John W. LinvilleSomeday the world will need a hero, and you linvi...@tuxdriver.com might be all we have. Be ready.

Re: [PATCH ethtool] ethtool: don't fall back to grxfhindir when context was specified

ool: add support for extra RSS contexts and RSS > steering filters") > Signed-off-by: Edward Cree LGTM -- queued for next release... Thanks, John -- John W. LinvilleSomeday the world will need a hero, and you linvi...@tuxdriver.com might be all we have. Be ready.

Re: [PATCH ethtool 0/3] RSS ntuple filters

n | 28 > ethtool.c | 141 > + > internal.h | 4 +- > rxclass.c | 58 > 5 files changed, 227 insertions(+), 36 deletions(-) > LGTM -- queued for the next release...tha

Re: [ethtool,2/3] ethtool: show VF and queue in the help for -N

-by: Jeff Kirsher LGTM -- queued for ethtool-4.16... Thanks! John -- John W. LinvilleSomeday the world will need a hero, and you linvi...@tuxdriver.com might be all we have. Be ready.

Re: [ethtool, 3/3] ethtool: correct VF index values for the ring_cookie parameter

played output to show the correct > VF number. > > Signed-off-by: Jacob Keller > Tested-by: Andrew Bowers > Signed-off-by: Jeff Kirsher LGTM -- queued for ethtool-4.16... Thanks! John -- John W. LinvilleSomeday the world will need a hero, and you linvi...@tuxdriver.c

Re: [ethtool] ethtool: Add SFF 8636 date code parsing support

queued for ethtool-4.16... Thanks! John -- John W. LinvilleSomeday the world will need a hero, and you linvi...@tuxdriver.com might be all we have. Be ready.

Re: [ethtool, 1/3] ethtool: correct display of VF when showing vf/queue filters

ve one. > > Fixes: 36ee712b0fbc ("ethtool: support queue and VF fields for rxclass > filters", 2017-03-23) > Signed-off-by: Jacob Keller > Tested-by: Andrew Bowers > Signed-off-by: Jeff Kirsher LGTM -- queued for ethtool-4.16... Thanks! John -- John W. Linville

Re: [PATCH RESEND net-next 0/2] ntuple filters with RSS

e string must be enclosed in double quotes. > > > > This is the case for "John W. Linville" so please add proper > > quotes around such names and resend your patch series again. > Thank you for spotting this!  I looked at the headers and failed >  to notice anythin

ethtool 4.15 released

ewer John -- John W. LinvilleSomeday the world will need a hero, and you linvi...@tuxdriver.com might be all we have. Be ready.

Re: [PATCH ethtool v2] ethtool: Support for FEC encoding control

fecmode; > + int rv; > + > + parse_generic_cmdline(ctx, &changed, cmdline_fec, > + ARRAY_SIZE(cmdline_fec)); > + > + if (!fecmode_str) > + exit_bad_args(); > + > + fecmode = fecmode_str_to_type(fecmode_str); > + if (!fecmode) > + exit_bad_args(); > + > + feccmd.cmd = ETHTOOL_SFECPARAM; > + feccmd.fec = fecmode; > + rv = send_ioctl(ctx, &feccmd); > + if (rv != 0) { > + perror("Cannot set FEC settings"); > + return rv; > + } > + > + return 0; > +} > + > #ifndef TEST_ETHTOOL > int send_ioctl(struct cmd_context *ctx, void *cmd) > { > @@ -5000,6 +5116,9 @@ static const struct option { > " [ ap-shared ]\n" > " [ dedicated ]\n" > " [ all ]\n"}, > + { "--show-fec", 1, do_gfec, "Show FEC settings"}, > + { "--set-fec", 1, do_sfec, "Set FEC settings", > + " [ encoding auto|off|rs|baser ]\n"}, > { "-h|--help", 0, show_usage, "Show this help" }, > { "--version", 0, do_version, "Show version number" }, > {} > -- > 2.15.1 > > -- John W. LinvilleSomeday the world will need a hero, and you linvi...@tuxdriver.com might be all we have. Be ready.

Re: [PATCH ethtool] ethtool: Support for FEC encoding control

mask parameter can be indented on the next line using tabs and spaces as usual. I would prefer something similar to the call to parse_generic_cmdline in do_sfec below: > +static int do_sfec(struct cmd_context *ctx) > +{ > + char *fecmode_str = NULL; > + struct ethtool_fecparam

Re: [PATCH] ethtool: fix MFLCN register dump for 82599 and newer

On Fri, Dec 15, 2017 at 09:56:51AM +0800, Zhang Kang wrote: > Use MFLCN for 82599 and X540 HW instead of FCTRL. > > Signed-off-by: Zhang Kang > Signed-off-by: Gao Wayne > Signed-off-by: Wei Net Thanks, applied. -- John W. LinvilleSomeday the world will need

Re: [RFC PATCH 0/9] ethtool netlink interface (WiP)

| 19 + > net/core/ethtool_netlink.c | 2323 > ++++++ > 12 files changed, 3260 insertions(+), 137 deletions(-) > create mode 100644 Documentation/networking/ethtool-netlink.txt > create mode 100644 include/linux/ethtool_netlink.h > create mode 100644 include/uapi/linux/ethtool_netlink.h > create mode 100644 net/core/ethtool_common.c > create mode 100644 net/core/ethtool_common.h > create mode 100644 net/core/ethtool_netlink.c > > -- > 2.15.1 > > -- John W. LinvilleSomeday the world will need a hero, and you linvi...@tuxdriver.com might be all we have. Be ready.

Re: [PATCH v3 3/3] ethtool: Add ETHTOOL_RESET support via --reset command

gt; Add -shared onto end of components to specified shared version. > > Alternatively, you can specific component bitfield directly using > ethtool --reset DEVNAME flags %x > > Signed-off-by: Scott Branden -- John W. LinvilleSomeday the world will need

Re: [PATCH v3 2/3] ethtool-copy.h: sync with net-next

gned-off-by: David S. Miller > > Signed-off-by: Scott Branden -- John W. LinvilleSomeday the world will need a hero, and you linvi...@tuxdriver.com might be all we have. Be ready.

Re: [PATCH v3 1/3] Revert "ethtool: Add DMA Coalescing support"

57846 > Signed-off-by: Scott Branden -- John W. LinvilleSomeday the world will need a hero, and you linvi...@tuxdriver.com might be all we have. Be ready.

Re: [PATCH] ethtool: fix MFLCN register dump for 82599 and newer

something consistent and identifiable. John -- John W. LinvilleSomeday the world will need a hero, and you linvi...@tuxdriver.com might be all we have. Be ready.

Re: [ethtool] ethtool: Add extended compliance codes parsing to sfp modules

y: Eran Ben Elisha Applied -- sorry for the delay! John -- John W. LinvilleSomeday the world will need a hero, and you linvi...@tuxdriver.com might be all we have. Be ready.

Re: [ethtool] ethtool: Fix coding style warnings and errors reported by checkpatch

On Thu, Oct 26, 2017 at 05:44:43PM +0300, Gal Pressman wrote: > Checkpatch had a lot to say about ethtool.c, this will handle a lot of > the reported issues. > > Signed-off-by: Gal Pressman > Reviewed-by: Tariq Toukan Applied -- sorry for the delay! -- John W. Linville

Re: ethtool-copy.h out of sync with linux header file?

gt; > > linux kernel. > > > > > > As such, I am unable to commit a change to ethtool-copy.h to sync it > > > with net-next.  If I sync then ethtool will fail to compile. > > > > > > Please advise. > > > > > > Thanks, > > > > > >  Scott > > > > > > > > -- John W. LinvilleSomeday the world will need a hero, and you linvi...@tuxdriver.com might be all we have. Be ready.

ethtool 4.13 released

Offload error prints * Feature: stmmac: Add macros for number of registers * Feature: stmmac: Add DMA HW Feature Register John -- John W. LinvilleSomeday the world will need a hero, and you linvi...@tuxdriver.com might be all we have. Be ready.

Re: Ethtool question

ial feeling was like you, a no-op is not a failure. But someone convinced me otherwise...I will now endeavour to remember who that was and how they convinced me... Anyone else have input here? John -- John W. LinvilleSomeday the world will need a hero, and you linvi...@tuxdriver.com

Re: [ethtool] ethtool: Remove UDP Fragmentation Offload use from ethtool

t; > I would rather remove the warning, but leave the ability to switch UFO > on machines running old kernel but a recent ethtool. > > ethtool does not need to be downgraded every time we boot an old > kernel ;) No, definitely not. > Thanks ! Tariq, will you be reworking this

ethtool 4.11 released

queue and VF fields for rxclass filters * Feature: Add support for 2500baseT/5000baseT link modes * Fix: Fix SFF 8079 cable technology bit parsing * Fix: sync help output for -x/-X with man page John -- John W. LinvilleSomeday the world will need a hero, and

Re: ethtool-4.8.tar.gz checksum change

and not the .tar.gz file.) I downloaded the file from the website and verified against the matching version of the git tree locally as well. If you have any idea as to who is in charge of the OpenEmbedded build and can correct/remove this complaint, then please let me know and/or have t

Re: [PATCH ethtool] ethtool: Support for configurable RSS hash function

On Wed, Mar 29, 2017 at 02:56:38PM +0300, Gal Pressman wrote: > On 27/03/2017 21:02, John W. Linville wrote: > > On Sat, Mar 25, 2017 at 02:50:47PM -0700, Jakub Kicinski wrote: > >> On Wed, 8 Mar 2017 16:03:51 +0200, Gal Pressman wrote: > >>> This ethtool patch a

Re: [PATCH ethtool] ethtool: Support for configurable RSS hash function

ion: <--- from this patch > toeplitz: on > xor: off > crc32: off > > Reverting my patch is probably the easiest way forward, although I find > it more concise and easier to parse in test scripts :) Thanks for pointing-out this issue! I apologize for my own

ethtool 4.10 released

Implement ETHTOOL_PHY_GTUNABLE/ETHTOOL_PHY_STUNABLE and PHY downshift * Feature: add register dump support for fjes driver (-d option) John -- John W. LinvilleSomeday the world will need a hero, and you linvi...@tuxdriver.com might be all we have. Be ready.

Re: [PATCH v2] ethtool: do not vzalloc(0) on registers dump

-ENOMEM; > + regbuf = NULL; Any reason to prefer this over changing the declaration to include the assignment? void *regbuf = NULL; > + if (reglen) { > + regbuf = vzalloc(reglen); > + if (!regbuf) > + return -ENOMEM; > + } > > ops->get_regs(dev, ®s, regbuf); > > -- > 1.8.3.1 > > -- John W. LinvilleSomeday the world will need a hero, and you linvi...@tuxdriver.com might be all we have. Be ready.

Re: [PATCH] net: ethtool: avoid allocation failure for dump_regs

I forgot to Cc Johannes and Kalle... On Thu, Jan 19, 2017 at 09:15:09AM -0500, John W. Linville wrote: > On Thu, Jan 19, 2017 at 07:35:22AM -0500, David Arcari wrote: > > On 01/18/2017 11:45 AM, David Miller wrote: > > > From: David Arcari > > > Date: Wed,

Re: [PATCH] net: ethtool: avoid allocation failure for dump_regs

ethtool. Realistically, there are probably very few users to care. But I can't guarantee that the number is zero. Possible solutions: -- break userland ethtool for at76c50x-usb -- avoid 0-len allocation attempt (David Arcari's patch) -- make allocator accept a 0 le

Re: [PATCH ethtool v5 0/2] Adding downshift support to ethtool

L_PHY_STUNABLE and PHY > downshift > > ethtool-copy.h | 21 +++-- > ethtool.8.in | 40 > ethtool.c | 144 > + > 3 files changed, 202 insertions(+), 3 deletions(-) > > -- > 2.7.3 Merged. -- John W. LinvilleSomeday the world will need a hero, and you linvi...@tuxdriver.com might be all we have. Be ready.

Re: [PATCH net] geneve: avoid use-after-free of skb->data

y in the function call. > > Fixes: 08399efc6319 ("geneve: ensure ECN info is handled properly in all > tx/rx paths") > Signed-off-by: Sabrina Dubroca Reviewed-by: John W. Linville -- John W. LinvilleSomeday the world will need a hero, and you linvi...@tuxd

Re: [PATCH ethtool v4 1/2] ethtool-copy.h:sync with net

On Wed, Nov 23, 2016 at 10:24:47AM -0500, John W. Linville wrote: > It looks like this patch somehow misses the following commit: > > commit 85a624403c77c3f074931aefdfced59f61b668cb > Author: Jesse Brandeburg > Date: Thu Oct 13 16:13:55 2016 -0700 > > ethtool: silenc

Re: [PATCH ethtool v4 1/2] ethtool-copy.h:sync with net

TOOL_SLINKSETTINGS0x004d /* Set ethtool_link_settings > */ > - > +#define ETHTOOL_PHY_GTUNABLE 0x004e /* Get PHY tunable configuration */ > +#define ETHTOOL_PHY_STUNABLE 0x004f /* Set PHY tunable configuration */ > > /* compatibility with older code */ > #define SPARC_ETH_GSET ETHTOOL_GSET > -- > 2.7.3 > > -- John W. LinvilleSomeday the world will need a hero, and you linvi...@tuxdriver.com might be all we have. Be ready.

Re: [PATCH ethtool] ethtool: Fix the "advertise" parameter logic.

g_wanted == NULL. > > Signed-off-by: Michael Chan Thanks, Michael -- merging... John -- John W. LinvilleSomeday the world will need a hero, and you linvi...@tuxdriver.com might be all we have. Be ready.

Re: [PATCH resend] ethtool: add register dump support for fjes driver

0x > > Signed-off-by: Taku Izumi Thank you, Taku Izumi. I have merged this patch and will be pushing it shortly. I apologize for the delay. John -- John W. LinvilleSomeday the world will need a hero, and you linvi...@tuxdriver.com might be all we have. Be ready.

Re: [PATCH net 2/2] geneve: avoid using stale geneve socket.

t; mechanism to avoid this situation. > > Signed-off-by: Pravin B Shelar LGTM, although I reckon that Stephen's comment about RCU_INIT_POINTER applies to this patch as well. Either way... Acked-by: John W. Linville > --- > drivers/net/geneve.c | 45 +++

[PATCH v2] netfilter: fix type mismatch with error return from nft_parse_u32_check

"int", which happens to match the actual users of nft_parse_u32_check already. Found by Coverity, CID 1373930. Note that commit 21a9e0f1568ea ("netfilter: nft_exthdr: fix error handling in nft_exthdr_init()) attempted to address the issue, but did not address the return type o

Re: [PATCH] netfilter: fix type mismatch with error return from nft_parse_u32_check

On Tue, Oct 25, 2016 at 03:08:04PM -0400, John W. Linville wrote: > Commit 36b701fae12ac ("netfilter: nf_tables: validate maximum value of > u32 netlink attributes") introduced nft_parse_u32_check with a return > value of "unsigned int", yet on error it returns "

[PATCH] netfilter: fix type mismatch with error return from nft_parse_u32_check

"int", which happens to match the actual users of nft_parse_u32_check already. Found by Coverity, CID 1373930. Note that commit 21a9e0f1568ea ("netfilter: nft_exthdr: fix error handling in nft_exthdr_init()) attempted to address the issue, but did not address the return type o

ethtool 4.8 released

: Enhancing link mode bits to support 25G/50G/100G * Feature: add support for 1000BaseX and missing 10G link mode * Fixes: address Coverity issues 1363118 - 1363125 John -- John W. LinvilleSomeday the world will need a hero, and you linvi...@tuxdriver.com

Re: [PATCH 2/7] ethtool: avoid resource leak of strings in do_gprivflags

On Mon, Oct 03, 2016 at 01:54:26PM -0400, Jarod Wilson wrote: > On Fri, Sep 30, 2016 at 03:56:16PM -0400, John W. Linville wrote: > > Coverity issue: 1363119 > > Fixes: e1ee596326ae ("Add support for querying and setting private flags") > > >

[PATCH v2 2/7] ethtool: avoid resource leak of strings in do_gprivflags

Coverity issue: 1363119 Fixes: e1ee596326ae ("Add support for querying and setting private flags") Signed-off-by: John W. Linville Reviewed-by: Greg Rose --- ethtool.c | 14 ++ 1 file changed, 10 insertions(+), 4 deletions(-) diff --git a/ethtool.c b/ethtool.c index aa

[PATCH 3/7] ethtool: plug resource leaks of defs and features in do_gfeatures

Coverity issues: 1363120, 1363121 Fixes: 6042804cf6ec ("Change -k/-K options to use ETHTOOL_{G,S}FEATURES") Signed-off-by: John W. Linville --- ethtool.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/ethtool.c b/ethtool.c index 0885a61097ad..09486615a5bb 100644 --- a/ethto

[PATCH 2/7] ethtool: avoid resource leak of strings in do_gprivflags

Coverity issue: 1363119 Fixes: e1ee596326ae ("Add support for querying and setting private flags") Signed-off-by: John W. Linville --- ethtool.c | 18 +- 1 file changed, 13 insertions(+), 5 deletions(-) diff --git a/ethtool.c b/ethtool.c index aa3ef5ed2f75..0885a6109

[PATCH 5/7] ethtool: fix leakage of efeatures resources in do_sfeatures

Coverity issue: 1363122 Fixes: 6042804cf6ecc ("Change -k/-K options to use ETHTOOL_{G,S}FEATURES") Signed-off-by: John W. Linville --- ethtool.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/ethtool.c b/ethtool.c index 2fd3393ca5f6..840a5da157a9 100644 --- a/ethtool.c +++ b

[PATCH 4/7] ethtool: fix leakage of defs resources in do_sfeatures

Coverity issue: 1363123 Fixes: 6042804cf6ecc ("Change -k/-K options to use ETHTOOL_{G,S}FEATURES") Signed-off-by: John W. Linville --- ethtool.c | 41 - 1 file changed, 28 insertions(+), 13 deletions(-) diff --git a/ethtool.c b/ethto

[PATCH 1/7] ethtool: avoid NULL pointer dereference in do_permaddr

Coverity issue: 1363118 Fixes: fef1c4a19703 ("ethtool: add get permanent address option") Signed-off-by: John W. Linville --- ethtool.c | 5 + 1 file changed, 5 insertions(+) diff --git a/ethtool.c b/ethtool.c index 6287b559c699..aa3ef5ed2f75 100644 --- a/ethtool.c +++ b

[PATCH 6/7] ethtool: fix leakage of strings resources in do_sprivflags

Coverity issue: 1363124 Fixes: e1ee596326ae ("Add support for querying and setting private flags") Signed-off-by: John W. Linville --- ethtool.c | 19 +-- 1 file changed, 13 insertions(+), 6 deletions(-) diff --git a/ethtool.c b/ethtool.c index 840a5da157a9..406cfd2f9

[PATCH 0/7] ethtool: misc fixes for Coverity issues

those issues "fixed" both to avoid them as distractions and just to promote better coding practices overall. These are "fresh off the press" -- I'll re-review them again before applying and pushing them. I appreciate any extra eyeballs that can review them as w

  1   2   3   4   5   6   7   8   9   >