On Thu, Mar 14, 2019 at 07:33:16PM +0100, Michal Kubecek wrote:
> One of the warnings gcc issues when building ethtool with -Wall seems to
> point to an actual problem:
>
> qsfp.c: In function 'sff8636_show_dom':
> qsfp.c:709:57: warning: comparison is always false due to limited range of
> data type [-Wtype-limits]
> if ((sd.sfp_temp[MCURR] == 0x0) || (sd.sfp_temp[MCURR] == 0xFFFF))
> ^~
>
> Rather than writing the special value as -1 which would be a bit confusing,
> cast 0xFFFF to __s16.
>
> Fixes: a5e73bb05ee4 ("ethtool:QSFP Plus/QSFP28 Diagnostics Information
> Support")
> Signed-off-by: Michal Kubecek <[email protected]>
LGTM -- queued for next release.
Thanks,
John
--
John W. Linville Someday the world will need a hero, and you
[email protected] might be all we have. Be ready.
