On Tue, Nov 22, 2016 at 06:55:47PM -0500, Michael Chan wrote: > From: Michael Chan <mc...@broadcom.com> > > The current code ignores the value of the advertise parameter. For example, > > ethtool -s ethx advertise 0x1000 > > The full_advertising_wanted parameter of 0x1000 is not passed to the kernel. > The reason is that advertising_wanted is NULL in this case, and ethtool > will think that the user has given no advertisement input and so it will > proceed to pass all supported advertisement speeds to the kernel. > > The older legacy ethtool with similar logic worked because > advertising_wanted was an integer and could take on -1 and 0. It would pass > the full_advertising_wanted value if advertising_wanted == -1. > > This fix is to pass all supported advertisement speeds only when both > advertising_wanted == NULL && full_advertising_wanted == NULL. > > Signed-off-by: Michael Chan <michael.c...@broadcom.com>
Thanks, Michael -- merging... John -- John W. Linville Someday the world will need a hero, and you linvi...@tuxdriver.com might be all we have. Be ready.
