Re: [BUG] possible issue with ixgbe

2021-04-14 Thread Ian Kumlien
So after some digging, the error seems to start in fq? It doesn't seem like the adapter says anything on it's own but fq is complaining - switched to pfifo_fast for now Also, FYI this interface is configured for jumboframes (local interface) On Mon, Apr 12, 2021 at 8:41 PM Ian Kuml

[BUG] possible issue with ixgbe

2021-04-12 Thread Ian Kumlien
Hi, I've encountered this a few times now, been moving kernels since there's been things fixed that looked related... but... [959642.297143] [ cut here ] [959642.297149] NETDEV WATCHDOG: eno1 (ixgbe): transmit queue 2 timed out [959642.297189] WARNING: CPU: 3 PID: 0 at net

Re: [PATCH 1/3] PCI/ASPM: Use the path max in L1 ASPM latency check

2020-12-17 Thread Ian Kumlien
On Thu, Dec 17, 2020 at 12:21 AM Bjorn Helgaas wrote: > > On Wed, Dec 16, 2020 at 12:20:53PM +0100, Ian Kumlien wrote: > > On Wed, Dec 16, 2020 at 1:08 AM Bjorn Helgaas wrote: > > > On Tue, Dec 15, 2020 at 02:09:12PM +0100, Ian Kumlien wrote: > > > > On Tue, Dec

Re: [PATCH 1/3] PCI/ASPM: Use the path max in L1 ASPM latency check

2020-12-16 Thread Ian Kumlien
On Wed, Dec 16, 2020 at 1:08 AM Bjorn Helgaas wrote: > > On Tue, Dec 15, 2020 at 02:09:12PM +0100, Ian Kumlien wrote: > > On Tue, Dec 15, 2020 at 1:40 AM Bjorn Helgaas wrote: > > > > > > On Mon, Dec 14, 2020 at 11:56:31PM +0100, Ian Kumlien wrote: > > >

Re: [PATCH 1/3] PCI/ASPM: Use the path max in L1 ASPM latency check

2020-12-15 Thread Ian Kumlien
On Tue, Dec 15, 2020 at 1:40 AM Bjorn Helgaas wrote: > > On Mon, Dec 14, 2020 at 11:56:31PM +0100, Ian Kumlien wrote: > > On Mon, Dec 14, 2020 at 8:19 PM Bjorn Helgaas wrote: > > > > If you're interested, you could probably unload the Realtek drivers, > >

Re: [PATCH 1/3] PCI/ASPM: Use the path max in L1 ASPM latency check

2020-12-14 Thread Ian Kumlien
On Mon, Dec 14, 2020 at 8:19 PM Bjorn Helgaas wrote: > > On Mon, Dec 14, 2020 at 04:47:32PM +0100, Ian Kumlien wrote: > > On Mon, Dec 14, 2020 at 3:02 PM Bjorn Helgaas wrote: > > > On Mon, Dec 14, 2020 at 10:14:18AM +0100, Ian Kumlien wrote: > > > > On Mon, Dec

Re: [PATCH 1/3] PCI/ASPM: Use the path max in L1 ASPM latency check

2020-12-14 Thread Ian Kumlien
On Mon, Dec 14, 2020 at 3:02 PM Bjorn Helgaas wrote: > > On Mon, Dec 14, 2020 at 10:14:18AM +0100, Ian Kumlien wrote: > > On Mon, Dec 14, 2020 at 6:44 AM Bjorn Helgaas wrote: > > > > > > [+cc Jesse, Tony, David, Jakub, Heiner, lists in case there's an ASPM &g

Re: [PATCH 1/3] PCI/ASPM: Use the path max in L1 ASPM latency check

2020-12-14 Thread Ian Kumlien
ormance, but AFAICT the devices in that path give us > no reason to disable L1. If I understand the spec correctly, the > Realtek device should not be relevant to the I211 path.] > > On Sun, Dec 13, 2020 at 10:39:53PM +0100, Ian Kumlien wrote: > > On Sun, Dec 13, 2020 at 12:47 AM

Re: [PATCH net] ixgbe: fix probing of multi-port devices with one MDIO

2020-10-16 Thread Ian Kumlien
her ports of x550em without an error. Nice, that fixes it! You can add a: Tested-by: Ian Kumlien ;) > Fixes: 09ef193fef7e ("net: ethernet: ixgbe: check the return value of > ixgbe_mii_bus_init()") > Reported-by: Ian Kumlien > Signed-off-by: Jakub Kicinski

Re: ixgbe - only presenting one out of four interfaces on 5.9

2020-10-16 Thread Ian Kumlien
On Fri, Oct 16, 2020 at 9:21 PM Jakub Kicinski wrote: > > On Fri, 16 Oct 2020 11:35:15 +0200 Ian Kumlien wrote: > > Adding netdev, someone might have a clue of what to look at... > > > > On Mon, Oct 12, 2020 at 9:20 PM Ian Kumlien wrote: > > > > > > Hi,

Re: ixgbe - only presenting one out of four interfaces on 5.9

2020-10-16 Thread Ian Kumlien
Adding netdev, someone might have a clue of what to look at... On Mon, Oct 12, 2020 at 9:20 PM Ian Kumlien wrote: > > Hi, > > I was really surprised when i rebooted my firewall and there was > network issues, I was even more surprised when > only one of the four ports of my i

Re: [Intel-wired-lan] NAT performance issue 944mbit -> ~40mbit

2020-07-24 Thread Ian Kumlien
On Fri, Jul 24, 2020 at 2:01 PM Ian Kumlien wrote: > > On Fri, Jul 17, 2020 at 3:45 PM Ian Kumlien wrote: [--8<--] > As a side note, would something like this fix it - not even compile tested > > > diff --git a/drivers/net/ethernet/intel/igb/igb_main.c > b/driver

Re: [Intel-wired-lan] NAT performance issue 944mbit -> ~40mbit

2020-07-24 Thread Ian Kumlien
On Fri, Jul 17, 2020 at 3:45 PM Ian Kumlien wrote: > > On Fri, Jul 17, 2020 at 2:09 AM Alexander Duyck > wrote: > > On Thu, Jul 16, 2020 at 12:47 PM Ian Kumlien wrote: > > > > Sorry, tried to respond via the phone, used the webbrowser version but > > > still

Re: [Intel-wired-lan] NAT performance issue 944mbit -> ~40mbit

2020-07-17 Thread Ian Kumlien
On Fri, Jul 17, 2020 at 2:09 AM Alexander Duyck wrote: > On Thu, Jul 16, 2020 at 12:47 PM Ian Kumlien wrote: > > Sorry, tried to respond via the phone, used the webbrowser version but > > still html mails... :/ > > On Thu, Jul 16, 2020 at 5:18 PM Alexander Duyck > >

Re: [Intel-wired-lan] NAT performance issue 944mbit -> ~40mbit

2020-07-16 Thread Ian Kumlien
Sorry, tried to respond via the phone, used the webbrowser version but still html mails... :/ On Thu, Jul 16, 2020 at 5:18 PM Alexander Duyck wrote: > On Wed, Jul 15, 2020 at 5:00 PM Ian Kumlien wrote: > > On Thu, Jul 16, 2020 at 1:42 AM Alexander Duyck > > wrote: > > >

Re: [Intel-wired-lan] NAT performance issue 944mbit -> ~40mbit

2020-07-15 Thread Ian Kumlien
On Thu, Jul 16, 2020 at 1:42 AM Alexander Duyck wrote: > On Wed, Jul 15, 2020 at 3:51 PM Ian Kumlien wrote: > > On Thu, Jul 16, 2020 at 12:32 AM Alexander Duyck > > wrote: > > > On Wed, Jul 15, 2020 at 3:00 PM Ian Kumlien wrote: > > > > On Wed, Jul 15, 20

Re: [Intel-wired-lan] NAT performance issue 944mbit -> ~40mbit

2020-07-15 Thread Ian Kumlien
On Thu, Jul 16, 2020 at 12:32 AM Alexander Duyck wrote: > On Wed, Jul 15, 2020 at 3:00 PM Ian Kumlien wrote: > > On Wed, Jul 15, 2020 at 11:40 PM Jakub Kicinski wrote: > > > On Wed, 15 Jul 2020 23:12:23 +0200 Ian Kumlien wrote: > > > > On Wed, Jul 15

Re: NAT performance issue 944mbit -> ~40mbit

2020-07-15 Thread Ian Kumlien
On Wed, Jul 15, 2020 at 11:40 PM Jakub Kicinski wrote: > On Wed, 15 Jul 2020 23:12:23 +0200 Ian Kumlien wrote: > > On Wed, Jul 15, 2020 at 11:02 PM Ian Kumlien wrote: > > > On Wed, Jul 15, 2020 at 10:31 PM Jakub Kicinski wrote: > > > > On Wed, 15 Jul 2020 22

Re: NAT performance issue 944mbit -> ~40mbit

2020-07-15 Thread Ian Kumlien
On Wed, Jul 15, 2020 at 11:02 PM Ian Kumlien wrote: > On Wed, Jul 15, 2020 at 10:31 PM Jakub Kicinski wrote: > > On Wed, 15 Jul 2020 22:05:58 +0200 Ian Kumlien wrote: > > > After a lot of debugging it turns out that the bug is in igb... > > > > > >

Re: NAT performance issue 944mbit -> ~40mbit

2020-07-15 Thread Ian Kumlien
On Wed, Jul 15, 2020 at 10:31 PM Jakub Kicinski wrote: > On Wed, 15 Jul 2020 22:05:58 +0200 Ian Kumlien wrote: > > After a lot of debugging it turns out that the bug is in igb... > > > > driver: igb > > version: 5.6.0-k > > firmware-version: 0. 6-1 > >

Re: NAT performance issue 944mbit -> ~40mbit

2020-07-15 Thread Ian Kumlien
n Sat, Jul 11, 2020 at 5:53 PM Ian Kumlien wrote: > > Hi, > > I first detected this with 5.7.6 but it seems to apply as far back as 5.6.1... > (so, 5.7.8 client -> nat (5.6.1 -> 5.8-rc4 -> server 5.7.7) > > It seems to me that the window size doesn't advance, so i d

NAT performance issue 944mbit -> ~40mbit

2020-07-11 Thread Ian Kumlien
Hi, I first detected this with 5.7.6 but it seems to apply as far back as 5.6.1... (so, 5.7.8 client -> nat (5.6.1 -> 5.8-rc4 -> server 5.7.7) It seems to me that the window size doesn't advance, so i did revert the tcp: grow window for OOO packets only for SACK flows [1] but it did no difference

Re: bnx2x - odd behaviour

2019-04-24 Thread Ian Kumlien
s: bnx2x --- > Thanks, > Sudarsana > > -Original Message- > > From: Ian Kumlien > > Sent: Wednesday, April 17, 2019 6:51 PM > > To: Sudarsana Reddy Kalluru > > Cc: Linux Kernel Network Developers ; Ariel Elior > > ; Ameen Rahman > > Subject: Re: b

Re: bnx2x - odd behaviour

2019-04-17 Thread Ian Kumlien
On Wed, Apr 17, 2019 at 3:05 PM Sudarsana Reddy Kalluru wrote: > > > -Original Message- > > From: Ian Kumlien > > Sent: Wednesday, April 17, 2019 4:32 PM > > To: Sudarsana Reddy Kalluru > > Cc: Linux Kernel Network Developers ; Ariel Elior > >

Re: bnx2x - odd behaviour

2019-04-17 Thread Ian Kumlien
in 5.x? > Thanks, > Sudarsana > > -Original Message- > > From: Ian Kumlien > > Sent: Friday, April 12, 2019 4:39 PM > > To: Sudarsana Reddy Kalluru > > Cc: Linux Kernel Network Developers ; Ariel Elior > > > > Subject: Re: bnx2x - odd

[BUG?] arp_cache: neighbor table overflow... and DoS

2019-04-17 Thread Ian Kumlien
Hi, I'm part of a team running a small:ish cloud - we have an issue atm where neutron thinks that some hosts exists and should be linked. This results in a arp flood - which on it's own is not a problem. As soon as we get "neighbour: arp_cache: neighbor table overflow!" the machine stops respondi

Re: bnx2x - odd behaviour

2019-04-12 Thread Ian Kumlien
ank you =) > Thanks, > Sudarsana > > -Original Message- > > From: Ian Kumlien > > Sent: Friday, April 12, 2019 2:44 PM > > To: Sudarsana Reddy Kalluru > > Cc: Linux Kernel Network Developers ; Ariel Elior > > > > Subject: Re: bnx2x - odd behav

Re: bnx2x - odd behaviour

2019-04-12 Thread Ian Kumlien
Finally! Just had a machine with the same issue! On Thu, Apr 11, 2019 at 10:56 AM Ian Kumlien wrote: > > On Thu, Apr 4, 2019 at 4:27 PM Sudarsana Reddy Kalluru > wrote: > > > > Hi, > >We are not aware of this issue. Please collect the register dump i.e., > &g

Re: bnx2x - odd behaviour

2019-04-11 Thread Ian Kumlien
ll trying to recreate the original issue > Thanks, > Sudarsana > > -Original Message- > > From: netdev-ow...@vger.kernel.org On > > Behalf Of Ian Kumlien > > Sent: Wednesday, April 3, 2019 8:31 PM > > To: Linux Kernel Network Developers ; A

bnx2x - odd behaviour

2019-04-03 Thread Ian Kumlien
Hi, We just had this happen on 5.0.2 It looks like the interface went down, ended up in a broken state and a ip li set down/up dev enp2s0f0 made it work again It looks really weird and I haven't really seen anything like it, anyone with a clue? dmesg: [1310361.808694] bnx2x :02:00.0 en

Re: [ISSUE][4.20.6] mlx5 and checksum failures

2019-02-13 Thread Ian Kumlien
One last update on this, 4.20.8 compiled with the same compiler works - I still suspect that it was fixed by: net/mlx5e: Force CHECKSUM_UNNECESSARY for short ethernet frames Anyway, we can forget about it now ;) On Sat, Feb 9, 2019 at 4:54 PM Ian Kumlien wrote: > > On Fri, Feb 8, 2019 a

Re: [ISSUE][4.20.6] mlx5 and checksum failures

2019-02-09 Thread Ian Kumlien
On Fri, Feb 8, 2019 at 5:29 PM Ian Kumlien wrote > On Thu, Feb 7, 2019 at 11:01 PM Ian Kumlien wrote: > > On Thu, Feb 7, 2019 at 7:43 PM Saeed Mahameed > > wrote: > > > On Thu, Feb 7, 2019 at 2:17 AM Ian Kumlien wrote: > > > > On Thu, Feb 7, 2019 at 2:

Re: [ISSUE][4.20.6] mlx5 and checksum failures

2019-02-08 Thread Ian Kumlien
On Thu, Feb 7, 2019 at 11:01 PM Ian Kumlien wrote: > On Thu, Feb 7, 2019 at 7:43 PM Saeed Mahameed > wrote: > > On Thu, Feb 7, 2019 at 2:17 AM Ian Kumlien wrote: > > > On Thu, Feb 7, 2019 at 2:01 AM Saeed Mahameed > > > wrote: > > > >

Re: [ISSUE][4.20.6] mlx5 and checksum failures

2019-02-07 Thread Ian Kumlien
On Thu, Feb 7, 2019 at 7:43 PM Saeed Mahameed wrote: > > On Thu, Feb 7, 2019 at 2:17 AM Ian Kumlien wrote: > > > > On Thu, Feb 7, 2019 at 2:01 AM Saeed Mahameed > > wrote: > > > On Wed, Feb 6, 2019 at 3:00 PM Ian Kumlien wrote: > > > > It changes

Re: [ISSUE][4.20.6] mlx5 and checksum failures

2019-02-07 Thread Ian Kumlien
On Thu, Feb 7, 2019 at 2:01 AM Saeed Mahameed wrote: > On Wed, Feb 6, 2019 at 3:00 PM Ian Kumlien wrote: > > It changes directly after the first hw checksum failure, I don't know why =/ > > weird, Maybe a real check-summing issue/corruption on the PCI ?! Actually, i

Re: [ISSUE][4.20.6] mlx5 and checksum failures

2019-02-06 Thread Ian Kumlien
On Wed, Feb 6, 2019 at 11:49 PM Cong Wang wrote: > > On Wed, Feb 6, 2019 at 2:41 PM Ian Kumlien wrote: > > > > On Wed, Feb 6, 2019 at 11:38 PM Cong Wang wrote: > > > On Wed, Feb 6, 2019 at 2:15 PM Ian Kumlien wrote: > > > > Could we please schedule this

Re: [ISSUE][4.20.6] mlx5 and checksum failures

2019-02-06 Thread Ian Kumlien
On Wed, Feb 6, 2019 at 11:38 PM Cong Wang wrote: > On Wed, Feb 6, 2019 at 2:15 PM Ian Kumlien wrote: > > Could we please schedule this for 4.19 and 4.20 - it's kinda breaking things > > It doesn't break anything, packets are _not_ dropped, only that the > warn

Re: [ISSUE][4.20.6] mlx5 and checksum failures

2019-02-06 Thread Ian Kumlien
On Wed, Feb 6, 2019 at 11:22 PM David Miller wrote: > > From: Ian Kumlien > Date: Wed, 6 Feb 2019 23:12:53 +0100 > > > Could we please schedule this for 4.19 and 4.20 - it's kinda breaking things > > Its... there: > > https://patchwork.ozlabs.org/bundle/davem/s

Re: [ISSUE][4.20.6] mlx5 and checksum failures

2019-02-06 Thread Ian Kumlien
On Wed, Feb 6, 2019 at 11:03 PM David Miller wrote: > From: Saeed Mahameed > Date: Wed, 6 Feb 2019 17:18:55 + > > On Wed, 2019-02-06 at 17:16 +0100, Ian Kumlien wrote: > >> Hi, > >> > >> I'm hitting an issue that i think is fixed by the following

[ISSUE][4.20.6] mlx5 and checksum failures

2019-02-06 Thread Ian Kumlien
Hi, I'm hitting an issue that i think is fixed by the following patch, i haven't verified it yet - but it looks like it should go on the stable queue(?) (And yes, I did look, and couldn't find it ;)) commit e8c8b53ccaff568fef4c13a6ccaf08bf241aa01a Author: Cong Wang Date: Mon Dec 3 22:14:04 20

Re: [BUG] moving fq back to clock monotonic breaks my setup

2019-01-11 Thread Ian Kumlien
On Fri, Jan 11, 2019 at 10:35 AM Eric Dumazet wrote: > On Thu, Jan 10, 2019 at 12:55 AM Paolo Abeni wrote: > > On Thu, 2019-01-10 at 09:25 +0100, Ian Kumlien wrote: > > > > > This works, and so does: > > > https://marc.info/?l=linux-netdev&m=154696956604748

Re: [BUG] moving fq back to clock monotonic breaks my setup

2019-01-10 Thread Ian Kumlien
On Thu, Jan 10, 2019 at 6:53 AM Eric Dumazet wrote: > On Wed, Jan 9, 2019 at 4:48 PM Ian Kumlien wrote: > > > > Hi, > > > > Just been trough ~5+ hours of bisecting and eventually actually found > > the culprit =) > > > > commit fb420d5d91c1

[BUG] moving fq back to clock monotonic breaks my setup

2019-01-09 Thread Ian Kumlien
Hi, Just been trough ~5+ hours of bisecting and eventually actually found the culprit =) commit fb420d5d91c1274d5966917725e71f27ed092a85 (refs/bisect/bad) Author: Eric Dumazet Date: Fri Sep 28 10:28:44 2018 -0700 tcp/fq: move back to CLOCK_MONOTONIC [--8<--] So this might be because my

Re: [BUG] v4.20 - bridge not getting DHCP responses? (works in 4.19.13)

2019-01-09 Thread Ian Kumlien
Confirmed, sending a new mail with summary etc On Thu, Jan 10, 2019 at 1:16 AM Ian Kumlien wrote: > > On Wed, Jan 9, 2019 at 12:17 AM Ian Kumlien wrote: > > On Wed, Jan 9, 2019, 00:09 Florian Fainelli > [--8<---] > > >> > when looking at "git log v4.

Re: [BUG] v4.20 - bridge not getting DHCP responses? (works in 4.19.13)

2019-01-09 Thread Ian Kumlien
On Wed, Jan 9, 2019 at 12:17 AM Ian Kumlien wrote: > On Wed, Jan 9, 2019, 00:09 Florian Fainelli > > when looking at "git log v4.19...v4.20 >> > drivers/net/ethernet/intel/ixgbe/" nothing else really stands out... >> > The machine is also running NAT for my ho

Re: [BUG] v4.20 - bridge not getting DHCP responses? (works in 4.19.13)

2019-01-08 Thread Ian Kumlien
On Tue, Jan 8, 2019 at 11:51 PM Stephen Hemminger wrote: > On Tue, 8 Jan 2019 23:10:04 +0100 > Ian Kumlien wrote: > > On Sun, Jan 6, 2019 at 11:21 PM Ian Kumlien wrote: > > > > > > [Sorry for the repost, screwed up the netdev address...] > > > > > &g

Re: [BUG] v4.20 - bridge not getting DHCP responses? (works in 4.19.13)

2019-01-08 Thread Ian Kumlien
On Sun, Jan 6, 2019 at 11:21 PM Ian Kumlien wrote: > > [Sorry for the repost, screwed up the netdev address...] > > Hi, > > Switching from 4.19.x -> 4.20 resulted in DHCP not working for my VM:s. > > My firewall (which also runs the dhcpd) runs VM:s and it doe

Fwd: [BUG] v4.20 - bridge not getting DHCP responses? (works in 4.19.13)

2019-01-06 Thread Ian Kumlien
[Sorry for the repost, screwed up the netdev address...] Hi, Switching from 4.19.x -> 4.20 resulted in DHCP not working for my VM:s. My firewall (which also runs the dhcpd) runs VM:s and it does this by having physical interfaces attached to bridges - which the VM:s in turn attach to. Since 4.2

Re: [RFC] change the default Kconfig value of mlx5_en

2017-04-22 Thread Ian Kumlien
On Sat, Apr 22, 2017 at 3:07 AM, Saeed Mahameed wrote: > On Sat, Apr 22, 2017 at 3:47 AM, Ian Kumlien wrote: >> On Sat, Apr 22, 2017 at 2:34 AM, Saeed Mahameed >> wrote: >>> On Sat, Apr 22, 2017 at 2:10 AM, Ian Kumlien wrote: >>>> Sorry, >>>>

Re: [RFC] change the default Kconfig value of mlx5_en

2017-04-21 Thread Ian Kumlien
On Sat, Apr 22, 2017 at 2:34 AM, Saeed Mahameed wrote: > On Sat, Apr 22, 2017 at 2:10 AM, Ian Kumlien wrote: >> Sorry, >> >> Back again, fighting cold, hot whiskey has been consumed... >> >> Something like this would perhaps be a better solution: >> >&g

Re: [RFC] change the default Kconfig value of mlx5_en

2017-04-21 Thread Ian Kumlien
Sorry, Back again, fighting cold, hot whiskey has been consumed... Something like this would perhaps be a better solution: diff --git a/drivers/net/ethernet/mellanox/mlx5/core/main.c b/drivers/net/ethernet/mellanox/mlx5/core/main.c index 60154a175bd3..fe192e247601 100644 --- a/drivers/net/ethern

Re: [RFC] change the default Kconfig value of mlx5_en

2017-04-21 Thread Ian Kumlien
On Fri, Apr 21, 2017 at 9:47 PM, David Miller wrote: > From: Ian Kumlien > Date: Fri, 21 Apr 2017 21:45:00 +0200 > >> The mellanox driver supports both ethernet and infiniband, but it >> is located in the ethernet drivers - the ethernet support should >> default to &

[RFC] change the default Kconfig value of mlx5_en

2017-04-21 Thread Ian Kumlien
e ethernet support should default to 'yes'. Signed-off-by: Ian Kumlien --- drivers/net/ethernet/mellanox/mlx5/core/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/mellanox/mlx5/core/Kconfig b/drivers/net/ethernet/mellanox/mlx5/core/Kconf

Re: 4.9.2 panic, __skb_flow_dissect, gro?

2017-01-11 Thread Ian Kumlien
On Wed, Jan 11, 2017 at 2:08 AM, David Miller wrote: > From: Denys Fedoryshchenko > Date: Wed, 11 Jan 2017 01:49:34 +0200 > >> It seems this patch solve issue. I hope it will go to stable asap, >> because without it loaded routers crashing almost instantly on 4.9. > > I will submit this soon. Bt

Re: 4.9.2 panic, __skb_flow_dissect, gro?

2017-01-10 Thread Ian Kumlien
Added David Miller to CC since he said it was queued for stable, maybe he can comment On Wed, Jan 11, 2017 at 12:49 AM, Denys Fedoryshchenko wrote: > It seems this patch solve issue. I hope it will go to stable asap, because > without it loaded routers crashing almost instantly on 4.9. I'm also

[PATCH] Update pptp handling to avoid null pointer deref. v2

2017-01-02 Thread Ian Kumlien
80 Fixes: ab10dccb1160 ("rps: Inspect PPTP encapsulated by GRE to get flow hash") Signed-off-by: Ian Kumlien --- net/core/flow_dissector.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/net/core/flow_dissector.c b/net/core/flow_dissector.c index c6d8207ffa7e..

Re: [PATCH] Update pptp handling to avoid null pointer deref.

2017-01-02 Thread Ian Kumlien
On Mon, Jan 2, 2017 at 5:07 AM, David Miller wrote: > From: Ian Kumlien > Date: Mon, 2 Jan 2017 00:19:36 +0100 > >> __skb_flow_dissect can be called with a skb or a data packet, either >> can be NULL. All calls seems to have been moved to __skb_header_pointer >> exc

[PATCH] Update pptp handling to avoid null pointer deref.

2017-01-01 Thread Ian Kumlien
00080 --- Signed-off-by: Ian Kumlien --- net/core/flow_dissector.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/net/core/flow_dissector.c b/net/core/flow_dissector.c index c6d8207ffa7e..32e4e0158846 100644 --- a/net/core/flow_dissector.c +++ b/net/core/flow_dissector.c

Re: [BUG] 4.9 - kernel oops when pptp connection is established and the kernel doesn't have pptp modules compiled

2017-01-01 Thread Ian Kumlien
nhoff + offset, +sizeof(_ppp_hdr), +data, hlen, _ppp_hdr); if (!ppp_hdr) goto out_bad; Will send a patch with signed off by n' all. On Sun, Jan 1, 2017 at 6:31 PM, Ian Kumlien

Re: [BUG] 4.9 - kernel oops when pptp connection is established and the kernel doesn't have pptp modules compiled

2017-01-01 Thread Ian Kumlien
On Fri, Dec 30, 2016 at 11:48 PM, Ian Kumlien wrote: > Hi, > > Been fighting with "crash" to get it to help me to analyze my crash > dumps... This is the output from vmcore-dmesg. > > This is 100% reproducible... > > Config that lets the connec

[SKY2] Problems (2.6.24-rc3-git1)

2007-11-24 Thread Ian Kumlien
done=442 NETDEV WATCHDOG: eth0: transmit timed out sky2 eth0: tx timeout sky2 eth0: transmit ring 442 .. 461 report=442 done=442 And it continues until i press the reset button. -- Ian Kumlien -- http://pomac.netswarm.net signature.asc Description: This is a digitally signed message part

Re: [PATCH] sky2: jumbo frame regression fix

2007-10-03 Thread Ian Kumlien
On ons, 2007-10-03 at 14:04 -0400, Bill Davidsen wrote: > Ian Kumlien wrote: > > On tis, 2007-10-02 at 18:02 -0700, Stephen Hemminger wrote: > >> Remove unneeded check that caused problems with jumbo frame sizes. > >> The check was recently added and is wrong. > >&

Re: [PATCH] sky2: jumbo frame regression fix

2007-10-03 Thread Ian Kumlien
On tis, 2007-10-02 at 21:59 -0700, Stephen Hemminger wrote: > On Wed, 03 Oct 2007 03:34:34 +0200 > Ian Kumlien <[EMAIL PROTECTED]> wrote: > > > On tis, 2007-10-02 at 18:02 -0700, Stephen Hemminger wrote: > > > Remove unneeded check that caused problems with jumbo fr

Re: [PATCH] sky2: jumbo frame regression fix

2007-10-02 Thread Ian Kumlien
orking. Now running with 9k mtu with no errors, =) It also seems that the FIFO bug was the one that affected me before, damn odd race that one. > Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> Tested-by: Ian Kumlien <[EMAIL PROTECTED]> (if that tag exists now) Btw, Sorry b

Re: [BUG] Sky2 driver in 2.6.22-rc5-git1-cfs-v17

2007-06-24 Thread Ian Kumlien
On tor, 2007-06-21 at 21:13 -0700, Stephen Hemminger wrote: > On Fri, 22 Jun 2007 04:45:25 +0200 > Ian Kumlien <[EMAIL PROTECTED]> wrote: > > > On tor, 2007-06-21 at 18:57 -0700, Stephen Hemminger wrote: > > > Redirected of LKML, netdev is the proper list. > &

Re: [BUG] Sky2 driver in 2.6.22-rc5-git1-cfs-v17

2007-06-22 Thread Ian Kumlien
On tor, 2007-06-21 at 21:13 -0700, Stephen Hemminger wrote: > On Fri, 22 Jun 2007 04:45:25 +0200 > Ian Kumlien <[EMAIL PROTECTED]> wrote: > > > On tor, 2007-06-21 at 18:57 -0700, Stephen Hemminger wrote: > > > Redirected of LKML, netdev is the proper list. > &

Re: [BUG] Sky2 driver in 2.6.22-rc5-git1-cfs-v17

2007-06-21 Thread Ian Kumlien
On tor, 2007-06-21 at 18:57 -0700, Stephen Hemminger wrote: > Redirected of LKML, netdev is the proper list. Thanks =) > On Thu, 21 Jun 2007 22:51:32 +0200 > Ian Kumlien <[EMAIL PROTECTED]> wrote: > > > Hi, > > > > recently have started to see this in my d

Re: [PATCH] Revert sky2 to 0.13a

2006-02-27 Thread Ian Kumlien
pos = (long)entry->mask_base; <== ... Doesn't that mean that we, a: read 64 bit from memory. b: save it in a 32 bit area? (esp since it seems to be a address pointer, which could also be using higher memory areas... but then i dunno what a void __iomem * is, but i assume that it will be 64 bits here =)) -- Ian Kumlien -- http://pomac.netswarm.net signature.asc Description: This is a digitally signed message part

Re: [PATCH] Revert sky2 to 0.13a

2006-02-26 Thread Ian Kumlien
On Sun, 2006-02-26 at 23:38 +0100, Carl-Daniel Hailfinger wrote: > Ian Kumlien schrieb: > > I also saw some oddities... portage stopped working, i dunno if this can > > be MSI related or so, else something is trashing memory in a very > > special way =P > > Yes, 0.15 ca

Re: [PATCH] Revert sky2 to 0.13a

2006-02-26 Thread Ian Kumlien
On Sun, 2006-02-26 at 16:47 +0100, Arjan van de Ven wrote: > On Sun, 2006-02-26 at 16:00 +0100, Ian Kumlien wrote: > > On Sun, 2006-02-26 at 09:57 +0100, Wolfgang Hoffmann wrote: > > > On Sunday 26 February 2006 03:03, Stephen Hemminger wrote: > > > > Instead of whi

Re: [PATCH] Revert sky2 to 0.13a

2006-02-26 Thread Ian Kumlien
On Sat, 2006-02-25 at 18:03 -0800, Stephen Hemminger wrote: > Instead of whining, try this. I'm sorry to say that this failed after 12h 33m =P -- Ian Kumlien -- http://pomac.netswarm.net signature.asc Description: This is a digitally signed message part

Re: [PATCH] Revert sky2 to 0.13a

2006-02-26 Thread Ian Kumlien
ee vendor chip specs > arrive soon and feel it's not worth the hassle, that's fine for me, too. My last real test with sky2 was at 205gb, which made me think that it's more of a race and not data dependant (read, 2 boxes doing ping -f -s 8000)... > In the meanwhile,

Re: [PATCH] Revert sky2 to 0.13a

2006-02-25 Thread Ian Kumlien
On Sat, 2006-02-25 at 18:03 -0800, Stephen Hemminger wrote: > Instead of whining, try this. Applied and compiled, rebooting in a bit =) -- Ian Kumlien -- http://pomac.netswarm.net signature.asc Description: This is a digitally signed message part

Re: [PATCH] Revert sky2 to 0.13a

2006-02-25 Thread Ian Kumlien
hack the driver source, esp if they themselves have a system that shows the breakage. -- Ian Kumlien -- http://pomac.netswarm.net signature.asc Description: This is a digitally signed message part

[SKY2] 2.6.16-rc4-git7. Still broken.

2006-02-25 Thread Ian Kumlien
ETDEV WATCHDOG: eth0: transmit timed out sky2 eth0: tx timeout Should those patches have fixed all flaws? -- Ian Kumlien -- http://pomac.netswarm.net signature.asc Description: This is a digitally signed message part

Re: [RFT] sky2 0.16

2006-02-19 Thread Ian Kumlien
r a statement about MSI complexity vs common APIC irqs... (I know that there was some MSI bugs before thats why i retried when they were fixed, running -rc4 since it was released now) -- Ian Kumlien -- http://pomac.netswarm.net signature.asc Description: This is a digitally signed message part

Re: [RFT] sky2 0.16

2006-02-19 Thread Ian Kumlien
that 0.16 just handles the (work_done < to_do) scenario, but not the > "packets arrived since start of this function"? Well, I have to admit I have > no real understanding of what all this magic driver code does ;-) Couldn't that be added to 0.16/0.17 so we could try

Re: [RFT] sky2 0.16

2006-02-18 Thread Ian Kumlien
kt:145* [314] pkt:42* [315] pkt:42* [316] pkt:42* [317] pkt:42* [318] pkt:42* [319] pkt:42* [320] pkt:42* [321] pkt:42* [322] pkt:42* [323] pkt:42* [324] pkt:42* [325] pkt:42* [326] pkt:42* -- Ian Kumlien -- http://pomac.netswarm.net signature.asc Description: This is a digitally signed message part

Re: [RFT] sky2 0.16

2006-02-16 Thread Ian Kumlien
#x27;s now up and running... However i did cat the status information and i assume thats supposed to only work in a frozen state, since it doesn't work when it's running =) I hope to have information for you by tomorrow 13, 14 or so CET since it usually hangs when i'm sleeping (da

Re: [SKY2] a outdated patch (seems to fix my problems)

2006-02-16 Thread Ian Kumlien
On Thu, 2006-02-16 at 11:25 +0100, Andi Kleen wrote: > On Thursday 16 February 2006 00:31, Ian Kumlien wrote: > > (Sorry, resent due to wrong message in CC, sending again to keep > > consistency) > > > > I have been having problems for some while with sky2 on my machine

Re: [SKY2] a outdated patch (seems to fix my problems)

2006-02-16 Thread Ian Kumlien
On Thu, 2006-02-16 at 11:25 +0100, Andi Kleen wrote: > On Thursday 16 February 2006 00:31, Ian Kumlien wrote: > > (Sorry, resent due to wrong message in CC, sending again to keep > > consistency) > > > > I have been having problems for some while with sky2 on my machine

Re: [SKY2] a outdated patch (seems to fix my problems)

2006-02-16 Thread Ian Kumlien
--- > On Thursday 16 February 2006 00:31, Ian Kumlien wrote: > > (Sorry, resent due to wrong message in CC, sending again to keep > > consistency) > > > > I have been having problems for some while with sky2 on my machine even > > with sky2 0.15

[SKY2] a outdated patch (seems to fix my problems)

2006-02-15 Thread Ian Kumlien
(Sorry, resent due to wrong message in CC, sending again to keep consistency) I have been having problems for some while with sky2 on my machine even with sky2 0.15 (as in 2.6.16-rc3-git4) But, i found a patch from Stephen that noone seemed to have commented on, so i thought i'd better try it out