> -邮件原件-
> 发件人: Magnus Karlsson [mailto:magnus.karls...@gmail.com]
> 发送时间: 2020年7月6日 14:13
> 收件人: Li,Rongqing
> 抄送: intel-wired-lan ; Björn Töpel
> ; Karlsson, Magnus ;
> Netdev
> 主题: Re: [Intel-wired-lan] [bug ?] i40e_rx_buffer_flip should not be called for
> redirected xsk copy mode
>
On Sun, Jul 05, 2020 at 01:45:50PM -0700, Florian Fainelli wrote:
>
>
> On 7/5/2020 11:29 AM, Andrew Lunn wrote:
> > ntohs() expects to be passed a __be16. Correct the type of the
> > variable holding the sequence ID.
> >
> > Cc: Richard Cochran
> > Signed-off-by: Andrew Lunn
>
> Reviewed-by:
Sun, Jul 05, 2020 at 08:03:01PM CEST, step...@networkplumber.org wrote:
>On Mon, 29 Jun 2020 13:13:04 +0530
>Vasundhara Volam wrote:
>
>> Add support for reading board serial_number to devlink info
>> subcommand. Example:
>>
>> $ devlink dev info pci/:af:00.0 -jp
>> {
>> "info": {
>>
Hello,
syzbot found the following crash on:
HEAD commit:7cc2a8ea Merge tag 'block-5.8-2020-07-01' of git://git.ker..
git tree: upstream
console output: https://syzkaller.appspot.com/x/log.txt?x=123532a710
kernel config: https://syzkaller.appspot.com/x/.config?x=183dd243398ba7ec
das
Hello,
syzbot found the following crash on:
HEAD commit:cb8e59cc Merge git://git.kernel.org/pub/scm/linux/kernel/g..
git tree: bpf-next
console output: https://syzkaller.appspot.com/x/log.txt?x=1446cfd310
kernel config: https://syzkaller.appspot.com/x/.config?x=a16ddbc78955e3a9
das
Hello,
syzbot found the following crash on:
HEAD commit:2b04a661 Merge branch 'cxgb4-add-mirror-action-support-for..
git tree: net-next
console output: https://syzkaller.appspot.com/x/log.txt?x=12d9b86b10
kernel config: https://syzkaller.appspot.com/x/.config?x=2172f4d0dbc37e27
das
On Sun, 05 Jul 2020 00:20:18 -0700
syzbot wrote:
> Hello,
>
> syzbot found the following crash on:
It is WARN that trigger this, due to panic_on_warn set.
It's great to see that syzbot report these, as the WARN_ONCE is meant
to catch drivers that forget to init xdp->frame_sz. In this case it
On Sun, Jul 5, 2020 at 10:19 AM Eli Cohen wrote:
>
> On Fri, Jul 03, 2020 at 12:33:58PM +0300, Or Gerlitz wrote:
> > On Fri, Jul 3, 2020 at 1:24 AM Saeed Mahameed wrote:
> > > From: Eli Cohen
> > >
> > > Net devices might be removed. For example, a vxlan device could be
> > > deleted and its ifn
Thank you RongQing for reporting this. I will take a look at it and
produce a patch.
/Magnus
On Thu, Jul 2, 2020 at 11:33 AM Li,Rongqing wrote:
>
> Hi:
>
>
>
> i40e_rx_buffer_flip to xsk copy mode can lead to data corruption, like the
> following flow:
>
>
>
> 1. first skb is not for xsk, and f
syzbot has found a reproducer for the following crash on:
HEAD commit:9e50b94b Add linux-next specific files for 20200703
git tree: linux-next
console output: https://syzkaller.appspot.com/x/log.txt?x=13e6ec3310
kernel config: https://syzkaller.appspot.com/x/.config?x=f99cc0faa1476e
On Sun, Jul 5, 2020 at 7:33 AM wenxu wrote:
> Thanks， I also think It is ok do fragment in the mirred output.
Please stop doing it. There is no way to make this acceptable.
You must be smart enough to find solutions elsewhere, possibly
not even in TC at all. It would be best if you can solve thi
On Thu, Jul 2, 2020 at 5:47 PM Marcelo Ricardo Leitner
wrote:
>
> in this case a act_output_it_well could do it. ;-)
Yeah, still much better than making "mirred" do "mirror, redirect, frag,
defrag", can't we all agree it is too late to rename mirred? :)
Please do not try to add any arbitrary fun
On Sun, Jul 5, 2020 at 7:34 AM wrote:
> +static int nf_ct_frag_reinit(struct ipq *qp)
> +{
> + unsigned int sum_truesize = 0;
> +
> + if (!mod_timer(&qp->q.timer, jiffies + qp->q.fqdir->timeout)) {
> + refcount_inc(&qp->q.refcnt);
> + return -ETIMEDOUT;
> +
On Sun, Jul 05, 2020 at 12:07:31PM -0600, David Ahern wrote:
> On 7/5/20 12:04 PM, Leon Romanovsky wrote:
> > RDMA_NLDEV_NUM_OPS is not a command, but enum item to help calculate array
> > size, exactly like devlink_command in include/uapi/linux/devlink.h.
>
> ok. usually the last field is __FOO_MA
On Sun, Jul 05, 2020 at 12:14:38PM -0600, David Ahern wrote:
> On 6/24/20 4:40 AM, Leon Romanovsky wrote:
> > From: Leon Romanovsky
> >
> > Changelog:
> > v1:
> > * Kernel part was accepted, so this series has correct SHA for the
> >kernel header update patch.
> > * Aligned implementation to
From: Sven Van Asbroeck Sent: Sunday, July 5, 2020 11:34
PM
>
> ext phy-| \
> | |
> enet_ref-o--|M |pad--| \
>| |_/ | |
>| |M |mac_gtx
>| | |
>
--
Grüße Herr / Frau,
Benötigen Sie finanzielle Unterstützung (Darlehen)?
Sprechen Sie mit uns bei Banca IMI S.P.A, wir lösen Ihre finanziellen
Probleme.
Unser Zinssatz beträgt 1,3% Jahreszinssatz. Bitte bewerben Sie sich
jetzt und geben Sie folgende Bewerbungsdetails ein:
Vollständiger
Hi all,
This patch series untangles the ethtool netlink dependency with PHYLIB
which exists because the cable test feature calls directly into PHY
library functions. The approach taken here is to introduce
ethtool_phy_ops function pointers which can be dynamically registered
when PHYLIB loads.
Fl
Now that we have introduced ethtool_phy_ops and the PHY library
dynamically registers its operations with that function pointer, we can
remove the direct PHYLIB dependency in favor of using dynamic
operations.
Signed-off-by: Florian Fainelli
---
net/Kconfig | 1 -
net/ethtool/cablet
Utilize ethtool_set_ethtool_phy_ops to register a suitable set of PHY
ethtool operations in a dynamic fashion such that ethtool will no longer
directy reference PHY library symbols.
Signed-off-by: Florian Fainelli
---
drivers/net/phy/phy_device.c | 7 +++
1 file changed, 7 insertions(+)
dif
In order to decouple ethtool from its PHY library dependency, define an
ethtool_phy_ops singleton which can be overriden by the PHY library when
it loads with an appropriate set of function pointers.
Signed-off-by: Florian Fainelli
---
include/linux/ethtool.h | 25 +
net/
On 2020/07/04 20:33, Toke Høiland-Jørgensen wrote:
Toshiaki Makita writes:
On 2020/07/04 5:26, Toke Høiland-Jørgensen wrote:
...
+/* A getter for the SKB protocol field which will handle VLAN tags consistently
+ * whether VLAN acceleration is enabled or not.
+ */
+static inline __be16 skb_prot
On Thu, Feb 27, 2020 at 11:50:11PM -0800, syzbot wrote:
> Hello,
>
> syzbot found the following crash on:
>
> HEAD commit:f8788d86 Linux 5.6-rc3
> git tree: upstream
> console output: https://syzkaller.appspot.com/x/log.txt?x=13005fd9e0
> kernel config: https://syzkaller.appspot.co
From: Randy Dunlap
Fix table formatting to eliminate warnings.
Documentation/networking/ethtool-netlink.rst:509: WARNING: Malformed table.
Documentation/networking/ethtool-netlink.rst:522: WARNING: Malformed table.
Documentation/networking/ethtool-netlink.rst:543: WARNING: Malformed table.
Docum
Hi all,
On Fri, 26 Jun 2020 10:05:27 +1000 Stephen Rothwell
wrote:
>
> Today's linux-next merge of the bpf-next tree got a conflict in:
>
> tools/testing/selftests/bpf/progs/bpf_iter_netlink.c
>
> between commits:
>
> 9c82a63cf370 ("libbpf: Fix CO-RE relocs against .text section")
> 647
When this driver transmits data,
first this driver will remove a pseudo header of 1 byte,
then the lapb module will prepend the LAPB header of 2 or 3 bytes,
then this driver will prepend a length field of 2 bytes,
then the underlying Ethernet device will prepend its own header.
So, the hea
On Sun, Jul 5, 2020 at 2:50 PM Jamal Hadi Salim wrote:
> BTW, nothing in skbedit is against computing what the new metadata
> should be.
Yup.
>
> IMO: A good arguement to not make it part of skbedit is if it adds
> unnecessary complexity to skbedit or policy definitions.
>
TCA_HASH_ALG_L4 liter
On Sun, Jul 5, 2020 at 10:26 AM Ariel Levkovich wrote:
> However I believe that from a concept point of view, using it is wrong.
>
> In my honest opinion, the concept here is to perform some calculation on
> the packet itself and its headers while the skb->hash field
>
> is the storage location of
On Thu, Jul 02, 2020 at 04:11:08PM +0300, Amit Cohen wrote:
> Currently, device drivers can only indicate to user space if the network
> link is up or down, without additional information.
>
> This patch set expand link-state to allow these drivers to expose more
> information to user space about
On Sun, Jul 05, 2020 at 08:25:33PM +0200, Andrew Lunn wrote:
> > Hello Andrew,
> >
> > could you please test this update of netlink/desc-ethtool.c on top of
> > your series? The userspace messages look as expected but I'm not sure if
> > I have a device with cable test support available to test pr
On Sun, Jul 05, 2020 at 06:24:21PM +0200, Andrew Lunn wrote:
> On Sun, Jul 05, 2020 at 02:44:47AM +0200, Michal Kubecek wrote:
> > On Wed, Jul 01, 2020 at 03:07:37AM +0200, Andrew Lunn wrote:
> > > Add the user space side of the ethtool cable test.
> > >
> > > The TDR output is most useful when fe
On Sun, Jul 5, 2020 at 10:42 PM Andrew Lunn wrote:
> Oddly, GENMASK() requires signed bit numbers, so that it can compare
> them for < 0. If passed an unsigned type, we get warnings about the
> test never being true.
>
> Signed-off-by: Andrew Lunn
I just resent my RTL8366RB series and I picked
The code in net/8021q/vlan.c, vlan_device_event() sets
VLAN 0 for a VLAN-capable ethernet device when it
comes up.
Since the RTL8366 DSA switches must have a VLAN and
PVID set up for any packets to come through we have
already set up default VLAN for each port as part of
bringing the switch online
The RTL8366 DSA switches will not work unless we set
up a default VLAN for each port. We are currently using
e.g. VLAN 1..6 for a 5-port switch as default VLANs.
This is not very helpful for users, move it to allocate
the top VLANs for default instead, for example on
RTL8366RB there are 16 VLANs s
We loop over the ports to initialize the default VLAN
and PVID for each port. As we need to reuse the
code to reinitialize a single port, break out the
function rtl8366_set_default_vlan_and_pvid().
Cc: DENG Qingfang
Cc: Mauri Sandberg
Reviewed-by: Andrew Lunn
Signed-off-by: Linus Walleij
---
C
This implements the known parts of the Realtek 4 byte
tag protocol version 0xA, as found in the RTL8366RB
DSA switch.
It is designated as protocol version 0xA as a
different Realtek 4 byte tag format with protocol
version 0x9 is known to exist in the Realtek RTL8306
chips.
The tag and switch chip
This activates the support to use the CPU tag to properly
direct ingress traffic to the right port.
Bit 15 in register RTL8368RB_CPU_CTRL_REG can be set to
1 to disable the insertion of the CPU tag which is what
the code currently does. The bit 15 define calls this
setting RTL8368RB_CPU_INSTAG whi
This adds rudimentary DSA tagging and fixes up some VLAN
issues in the RTL8366RB driver and in the RTL8366 core
in general.
Linus Walleij (5):
net: dsa: tag_rtl4_a: Implement Realtek 4 byte A tag
net: dsa: rtl8366rb: Support the CPU DSA tag
net: dsa: rtl8366: Split out default VLAN config
[ sorry for the delay; was on PTO for a couple weeks ]
On 6/24/20 10:32 AM, Brian Rak wrote:
> Hi,
>
> We're hitting an issue where the kernel with either hang indefinitely or
> immediately crash when IPv6 nexthops are used along with the `rpfilter`
> ip6tables module. The following commands tri
On Thu, Jun 18, 2020 at 5:24 AM Florian Fainelli wrote:
> On 6/17/2020 1:31 AM, Linus Walleij wrote:
> > Make sure that setting VLAN 0 has the same effect
> > and does not try to actually tell the hardware to use
> > VLAN 0 on the port because that will not work.
>
> Why, you are not really descr
On Sun, Jul 05, 2020 at 07:54:46PM +0200, Andrew Lunn wrote:
> Add the user space side of the ethtool cable test.
>
> The TDR output is most useful when fed to some other tool which can
> visualize the data. So add JSON support, by borrowing code from
> iproute2.
>
> v2:
> man page fixes.
>
> v3
From: Andrew Lunn
Date: Sun, 5 Jul 2020 22:55:55 +0200
> Since lan9303_adjust_link() is a void function, there is no option to
> return an error. So just remove the variable and lets any errors be
> discarded.
>
> Cc: Egil Hjelmeland
> Signed-off-by: Andrew Lunn
Applied to net-next.
From: Andrew Lunn
Date: Sun, 5 Jul 2020 23:05:08 +0200
> The comments before struct vsc73xx_platform and struct vsc73xx_spi use
> kerneldoc format, but then fail to document the members of these
> structures. All the structure members are self evident, and the driver
> has not other kerneldoc co
From: Andrew Lunn
Date: Sun, 5 Jul 2020 22:55:55 +0200
> Since lan9303_adjust_link() is a void function, there is no option to
> return an error. So just remove the variable and lets any errors be
> discarded.
>
> Cc: Egil Hjelmeland
> Signed-off-by: Andrew Lunn
Applied to net-next.
From: Florian Fainelli
Date: Sun, 5 Jul 2020 13:49:10 -0700
>
>
> On 7/5/2020 1:42 PM, Andrew Lunn wrote:
>> Oddly, GENMASK() requires signed bit numbers, so that it can compare
>> them for < 0. If passed an unsigned type, we get warnings about the
>> test never being true.
>>
>> Signed-off-by
From: Andrew Lunn
Date: Sun, 5 Jul 2020 22:36:22 +0200
> Fixup most of the C=1 W=1 warnings in these drivers.
Series applied with patch #1 and #2's subjects fixed.
From: Andrew Lunn
Date: Sun, 5 Jul 2020 21:38:06 +0200
> Make the mv88e6xxx driver build cleanly with C=1 W=1.
Series applied, thanks.
From: Andrew Lunn
Date: Sun, 5 Jul 2020 21:30:03 +0200
> Mostly not using __be16 when decoding packet contents.
Series applied with patch #1's subject fixed.
On Thu, 2020-07-02 at 21:10 +0200, Christian Brauner wrote:
> On Thu, Jul 02, 2020 at 08:17:38AM -0500, Eric W. Biederman wrote:
> > Matt Bennett writes:
> >
> > > Previously the connector functionality could only be used by processes
> > > running in the
> > > default network namespace. This me
On Thu, 2020-07-02 at 13:59 -0500, Eric W. Biederman wrote:
> Matt Bennett writes:
>
> > Previously the connector functionality could only be used by processes
> > running in the
> > default network namespace. This meant that any process that uses the
> > connector functionality
> > could not o
From: Vladimir Oltean
Date: Sat, 4 Jul 2020 15:45:01 +0300
> From: Vladimir Oltean
>
> This is an overhaul of the Felix switch driver's PHYLINK operations.
>
> Patches 1, 3, 4 and 5 are cleanup, patch 2 is adding a new feature and
> and patch 6 is adaptation to the new format of an existing p
Now that we have the logical indirection table, we can return these
proper logical indices directly to ethtool -x instead of the physical
IDs.
v3: Use ALIGN() to round up the RSS table size.
Reported-by: Jakub Kicinski
Signed-off-by: Michael Chan
---
drivers/net/ethernet/broadcom/bnxt/bnxt_eth
The driver currently does not keep track of the logical RSS indirection
table. The hardware RSS table is set up with standard default ring
distribution when initializing the chip. This makes it difficult to
support user sepcified indirection table entries. As a first step, add
the logical table
Now that we have the logical table, we can fill the HW RSS table
using the logical table's entries and converting them to the HW
specific format. Re-initialize the logical table to standard
distribution if the number of RX rings changes during ring reservation.
v2: Use ALIGN() to roundup the RSS
From: Edwin Peer
The hardware VLAN offload feature on our NIC does not have separate
knobs for handling customer and service tags on RX. Either offloading
of both must be enabled or both must be disabled. Introduce definitions
for the combined feature set in order to clean up the code and make
th
With the new infrastructure in place, we can now support the setting of
the indirection table from ethtool.
When changing channels, in a rare case that firmware cannot reserve the
rings that were promised, the RSS map will revert to default.
v3: Add warning messages when firmware cannot reserve t
From: Edwin Peer
Bare-metal use cases require giving firmware and the embedded
application processor control over VLAN offloads. The driver should
not attempt to override or utilize this feature in such scenarios
since it will not work as expected.
Signed-off-by: Edwin Peer
Signed-off-by: Micha
On some chips, this varies based on the number of RX rings. Add this
helper function and refactor the existing code to use it.
Signed-off-by: Michael Chan
---
drivers/net/ethernet/broadcom/bnxt/bnxt.c | 13 +++--
drivers/net/ethernet/broadcom/bnxt/bnxt.h | 1 +
2 files changed, 12 inse
Currently, we allocate one page for the hardware DMA RSS indirection
table. While the size is currently big enough for all chips, future
chip variations may support bigger sizes, so it is better to calculate
and store the chip specific size and allocate accordingly.
Signed-off-by: Michael Chan
-
This patchset implements ethtool -X to setup user-defined RSS indirection
table. The new infrastructure also allows the proper logical ring index
to be used to populate the RSS indirection when queried by ethtool -x.
Prior to these patches, we were incorrectly populating the output of
ethtool -x w
Hi Ariel,
On 2020-07-05 1:26 p.m., Ariel Levkovich wrote:
On 7/3/20 7:22 AM, Jamal Hadi Salim wrote:
[..]
Hi Jamal,
I agree that using skbedit makes some sense and can provide the same
functionality.
However I believe that from a concept point of view, using it is wrong.
In my honest opi
Hi Florian,
On Sun, Jul 05, 2020 at 02:09:30PM -0700, Florian Fainelli wrote:
>
>
> On 7/5/2020 9:16 AM, Vladimir Oltean wrote:
> > From: Vladimir Oltean
> >
> > state->speed holds a value of 10, 100, 1000 or 2500, but
> > SYS_MAC_FC_CFG_FC_LINK_SPEED expects a value in the range 0, 1, 2 or 3.
On 7/5/2020 9:16 AM, Vladimir Oltean wrote:
> From: Vladimir Oltean
>
> Phylink now requires that parameters established through
> auto-negotiation be written into the MAC at the time of the
> mac_link_up() callback. In the case of felix, that means taking the port
> out of reset, setting the
On 7/5/2020 9:16 AM, Vladimir Oltean wrote:
> From: Vladimir Oltean
>
> Phylink uses the .mac_an_restart method to offer the user an
> implementation of the "ethtool -r" behavior, when the media-side auto
> negotiation can be restarted by the local MAC PCS. This is the case for
> fiber modes 1
On 7/5/2020 9:16 AM, Vladimir Oltean wrote:
> From: Vladimir Oltean
>
> The driver appears to write to BMCR_SPEED and BMCR_DUPLEX, fields which
> are read-only, since they are actually configured through the
> vendor-specific IF_MODE (0x14) register.
>
> But the reason we're writing back the
On 7/5/2020 9:16 AM, Vladimir Oltean wrote:
> From: Vladimir Oltean
>
> state->speed holds a value of 10, 100, 1000 or 2500, but
> SYS_MAC_FC_CFG_FC_LINK_SPEED expects a value in the range 0, 1, 2 or 3.
>
> So set the correct speed encoding into this register.
>
> Signed-off-by: Vladimir Olt
On 7/5/2020 9:16 AM, Vladimir Oltean wrote:
> From: Vladimir Oltean
>
> In VSC9959, the PCS is the one who performs rate adaptation (symbol
> duplication) to the speed negotiated by the PHY. The MAC is unaware of
> that and must remain configured for gigabit. If it is configured at
> OCELOT_SP
On 7/5/2020 2:05 PM, Andrew Lunn wrote:
> The comments before struct vsc73xx_platform and struct vsc73xx_spi use
> kerneldoc format, but then fail to document the members of these
> structures. All the structure members are self evident, and the driver
> has not other kerneldoc comments, so chan
The comments before struct vsc73xx_platform and struct vsc73xx_spi use
kerneldoc format, but then fail to document the members of these
structures. All the structure members are self evident, and the driver
has not other kerneldoc comments, so change these to plain comments to
avoid warnings.
Sign
On 7/5/2020 1:55 PM, Andrew Lunn wrote:
> Since lan9303_adjust_link() is a void function, there is no option to
> return an error. So just remove the variable and lets any errors be
> discarded.
>
> Cc: Egil Hjelmeland
> Signed-off-by: Andrew Lunn
Reviewed-by: Florian Fainelli
--
Florian
Since lan9303_adjust_link() is a void function, there is no option to
return an error. So just remove the variable and lets any errors be
discarded.
Cc: Egil Hjelmeland
Signed-off-by: Andrew Lunn
---
drivers/net/dsa/lan9303-core.c | 7 +++
1 file changed, 3 insertions(+), 4 deletions(-)
di
On 7/5/2020 11:29 AM, Andrew Lunn wrote:
> To ensure that the octoen MDIO driver has been loaded, the Cavium
s/octoen/octeon/
> ethernet drivers reference a dummy symbol in the MDIO driver. This
> forces it to be loaded first. And this symbol has not been cleanly
> implemented, resulting in wa
On 7/5/2020 1:42 PM, Andrew Lunn wrote:
> Oddly, GENMASK() requires signed bit numbers, so that it can compare
> them for < 0. If passed an unsigned type, we get warnings about the
> test never being true.
>
> Signed-off-by: Andrew Lunn
The subject should also be prefixed with "net: " similar
On 7/5/2020 11:29 AM, Andrew Lunn wrote:
> The MIPS low level register access functions seem to be missing
> __iomem annotation. This cases lots of sparse warnings, when code
s/cases/causes/g
> casts off the __iomem. Make the Cavium MDIO drivers cleaner by pushing
> the casts lower down into t
On 7/5/2020 11:29 AM, Andrew Lunn wrote:
> ntohs() expects to be passed a __be16. Correct the type of the
> variable holding the sequence ID.
>
> Cc: Richard Cochran
> Signed-off-by: Andrew Lunn
Reviewed-by: Florian Fainelli
--
Florian
On 7/5/2020 11:29 AM, Andrew Lunn wrote:
> This array is not used outside of phy_device.c, so make it static.
>
> Signed-off-by: Andrew Lunn
Reviewed-by: Florian Fainelli
--
Florian
On 7/5/2020 11:29 AM, Andrew Lunn wrote:
> Avoid the W=1 warning that symbol 'genphy_c45_driver' was not
> declared. Should it be static?
>
> Declare it on the phy header file.
>
> Signed-off-by: Andrew Lunn
Reviewed-by: Florian Fainelli
--
Florian
On 7/5/2020 12:30 PM, Andrew Lunn wrote:
> net/dsa/tag_lan9303.c:76:24: warning: incorrect type in assignment (different
> base types)
> net/dsa/tag_lan9303.c:76:24:expected unsigned short [usertype]
> net/dsa/tag_lan9303.c:76:24:got restricted __be16 [usertype]
> net/dsa/tag_lan9303.c:
On 7/5/2020 11:29 AM, Andrew Lunn wrote:
> Correct the kerneldoc for a few structure and function calls,
> as reported by C=1 W=1.
>
> Cc: Alexandru Ardelean
> Signed-off-by: Andrew Lunn
Reviewed-by: Florian Fainelli
--
Florian
On 7/5/2020 12:30 PM, Andrew Lunn wrote:
> net/dsa/tag_qca.c:48:15: warning: incorrect type in assignment (different
> base types)
> net/dsa/tag_qca.c:48:15:expected unsigned short [usertype]
> net/dsa/tag_qca.c:48:15:got restricted __be16 [usertype]
> net/dsa/tag_qca.c:68:13: warning:
Oddly, GENMASK() requires signed bit numbers, so that it can compare
them for < 0. If passed an unsigned type, we get warnings about the
test never being true.
Signed-off-by: Andrew Lunn
---
drivers/net/dsa/rtl8366.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net
On 7/5/2020 12:30 PM, Andrew Lunn wrote:
> net/dsa/tag_mtk.c:84:13: warning: incorrect type in assignment (different
> base types)
> net/dsa/tag_mtk.c:84:13:expected restricted __be16 [usertype] hdr
> net/dsa/tag_mtk.c:84:13:got int
> net/dsa/tag_mtk.c:94:17: warning: restricted __be16
On 7/5/2020 12:30 PM, Andrew Lunn wrote:
> cpu_to_be16 returns a __be16 value. So what it is assigned to needs to
> have the same type to avoid warnings.
>
> Signed-off-by: Andrew Lunn
Reviewed-by: Florian Fainelli
--
Florian
On 7/5/2020 12:30 PM, Andrew Lunn wrote:
> net/dsa/slave.c:505:13: warning: incorrect type in initializer (different
> address spaces)
> net/dsa/slave.c:505:13:expected void const [noderef] *__vpp_verify
> net/dsa/slave.c:505:13:got struct pcpu_sw_netstats *
>
> Add the needed _percpu
On 7/5/2020 1:36 PM, Andrew Lunn wrote:
> Oddly, GENMASK() requires signed bit numbers, so that it can compare
> them for < 0. If passed an unsigned type, we get warnings about the
> test never being true. There is no danger of overflow here, udf is
> always a u8, so there is plenty of space whe
On 7/5/2020 1:36 PM, Andrew Lunn wrote:
> leX_to_cpu() expects to be passed an __leX type.
>
> Signed-off-by: Andrew Lunn
Reviewed-by: Florian Fainelli
--
Florian
On 7/5/2020 1:36 PM, Andrew Lunn wrote:
> A __be16 variable should be initialised with a __be16 value. So add a
> htons(). In this case it is pointless, given the value being assigned
> is 0x, but it stops sparse from warnings.
>
> Signed-off-by: Andrew Lunn
The subject should be:
net:
leX_to_cpu() expects to be passed an __leX type.
Signed-off-by: Andrew Lunn
---
drivers/net/dsa/b53/b53_spi.c | 26 ++
1 file changed, 18 insertions(+), 8 deletions(-)
diff --git a/drivers/net/dsa/b53/b53_spi.c b/drivers/net/dsa/b53/b53_spi.c
index f89f5308a99b..7abec8da
Fixup most of the C=1 W=1 warnings in these drivers.
Andrew Lunn (3):
net: dsa: b53: Fixup endianness warnings
dsa: bcm_sf2: Initialize __be16 with a __be16 value
dsa: bmc_sf2: Pass GENMASK() signed bits
drivers/net/dsa/b53/b53_spi.c | 26 ++
drivers/net/dsa/bcm_sf2
Oddly, GENMASK() requires signed bit numbers, so that it can compare
them for < 0. If passed an unsigned type, we get warnings about the
test never being true. There is no danger of overflow here, udf is
always a u8, so there is plenty of space when expanding to an int.
Signed-off-by: Andrew Lunn
A __be16 variable should be initialised with a __be16 value. So add a
htons(). In this case it is pointless, given the value being assigned
is 0x, but it stops sparse from warnings.
Signed-off-by: Andrew Lunn
---
drivers/net/dsa/bcm_sf2_cfp.c | 4 ++--
1 file changed, 2 insertions(+), 2 del
Hello!
On 30.06.2020 8:22, Yoshihiro Shimoda wrote:
From: Yoshihiro Shimoda, Sent: Tuesday, May 26, 2020 6:47 PM
According to the report of [1], this driver is possible to cause
the following error in ravb_tx_timeout_work().
ravb e680.ethernet ethernet: failed to switch device to config m
On Sun, Jul 05, 2020 at 01:10:54PM -0700, Linus Torvalds wrote:
> On Fri, Jul 3, 2020 at 8:50 AM Kees Cook wrote:
> >
> > With 67 kthreads on a booted system, this patch does not immediately
> > blow up...
>
> Did you try making read/write inc/dec that thing too? Or does that
> just blow up with
On 7/5/20 10:49 PM, Linus Lüssing wrote:
On Sun, Jul 05, 2020 at 10:11:39PM +0300, Nikolay Aleksandrov wrote:
On 7/5/20 10:08 PM, Linus Lüssing wrote:
On Sun, Jul 05, 2020 at 09:33:13PM +0300, Nikolay Aleksandrov wrote:
On 05/07/2020 21:22, Linus Lüssing wrote:
Commit e57f61858b7c ("net: brid
On Fri, Jul 3, 2020 at 8:50 AM Kees Cook wrote:
>
> With 67 kthreads on a booted system, this patch does not immediately
> blow up...
Did you try making read/write inc/dec that thing too? Or does that
just blow up with tons of warnings?
Linus
Some adapters (e.g. RTL8723CS) advertise that they have more than
2 pages for local ext features, but they don't support any features
declared in these pages. RTL8723CS reports max_page = 2 and declares
support for sync train and secure connection, but it responds with
either garbage or with error
Pinebook has an RTL8723CS WiFi + BT chip, BT is connected to UART1
and uses PL5 as device wake GPIO, PL6 as host wake GPIO the I2C
controlling signals are connected to R_I2C bus.
Enable it in the device tree.
Signed-off-by: Vasily Khoruzhick
---
.../arm64/boot/dts/allwinner/sun50i-a64-pinebook.
Pinebook uses RTL8723CS for WiFi and bluetooth. Unfortunately RTL8723CS
has broken BT-4.1 support, so it requires a quirk.
Add a quirk, wire up 8723CS support in btrtl and enable bluetooth
in Pinebook dts.
Vasily Khoruzhick (3):
Bluetooth: Add new quirk for broken local ext features max_page
The Realtek RTL8723CS is SDIO WiFi chip. It also contains a Bluetooth
module which is connected via UART to the host.
It shares lmp subversion with 8703B, so Realtek's userspace
initialization tool (rtk_hciattach) differentiates varieties of RTL8723CS
(CG, VF, XX) with RTL8703B using vendor's comm
On Sun, Jul 05, 2020 at 10:11:39PM +0300, Nikolay Aleksandrov wrote:
> On 7/5/20 10:08 PM, Linus Lüssing wrote:
> > On Sun, Jul 05, 2020 at 09:33:13PM +0300, Nikolay Aleksandrov wrote:
> > > On 05/07/2020 21:22, Linus Lüssing wrote:
> > > > Commit e57f61858b7c ("net: bridge: mcast: fix stale nsrcs
1 - 100 of 202 matches
Mail list logo
