Hi Florian, On Sun, Jul 05, 2020 at 02:09:30PM -0700, Florian Fainelli wrote: > > > On 7/5/2020 9:16 AM, Vladimir Oltean wrote: > > From: Vladimir Oltean <vladimir.olt...@nxp.com> > > > > state->speed holds a value of 10, 100, 1000 or 2500, but > > SYS_MAC_FC_CFG_FC_LINK_SPEED expects a value in the range 0, 1, 2 or 3. > > > > So set the correct speed encoding into this register. > > > > Signed-off-by: Vladimir Oltean <vladimir.olt...@nxp.com> > > Reviewed-by: Florian Fainelli <f.faine...@gmail.com> > > Did you want to provide a Fixes: tag for this change? > -- > Florian
I am not really sure how fine-grained this really is. Some testing with dedicated testing equipment was done even with the old values, and I don't remember that it raised any eyebrows at the time. I would prefer to not use the "Fixes:" tag here, just to be on the safe side. Thanks, -Vladimir
