Oddly, GENMASK() requires signed bit numbers, so that it can compare
them for < 0. If passed an unsigned type, we get warnings about the
test never being true.

Signed-off-by: Andrew Lunn <and...@lunn.ch>
---
 drivers/net/dsa/rtl8366.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/dsa/rtl8366.c b/drivers/net/dsa/rtl8366.c
index ac88caca5ad4..993cf3ac59d9 100644
--- a/drivers/net/dsa/rtl8366.c
+++ b/drivers/net/dsa/rtl8366.c
@@ -272,7 +272,7 @@ int rtl8366_init_vlan(struct realtek_smi *smi)
                        /* For the CPU port, make all ports members of this
                         * VLAN.
                         */
-                       mask = GENMASK(smi->num_ports - 1, 0);
+                       mask = GENMASK((int)smi->num_ports - 1, 0);
                else
                        /* For all other ports, enable itself plus the
                         * CPU port.
-- 
2.27.0.rc2

Reply via email to