>
> Series applied.
>
> Please follow up with a patch that makes the new structures use
> "__packed" instead of the full expanion.
Thanks, David!
Sure will do this.
Regards
Igor
The added test includes the following subtests:
- test verifier change for btf_id_or_null
- test load/create_iter/read for
ipv6_route/netlink/bpf_map/task/task_file
- test anon bpf iterator
- test anon bpf iterator reading one char at a time
- test file bpf iterator
- test overflow
Macro DEFINE_BPF_ITER_FUNC is implemented so target
can define an init function to capture the BTF type
which represents the target.
The bpf_iter_meta is a structure holding meta data, common
to all targets in the bpf program.
Additional marker functions are called before/after
bpf_seq_read() sho
Add bpf_reg_type PTR_TO_BTF_ID_OR_NULL support.
For tracing/iter program, the bpf program context
definition, e.g., for previous bpf_map target, looks like
struct bpf_iter__bpf_map {
struct bpf_iter_meta *meta;
struct bpf_map *map;
};
The kernel guarantees that meta is not NULL, but
ma
This patch added netlink and ipv6_route targets, using
the same seq_ops (except show() and minor changes for stop())
for /proc/net/{netlink,ipv6_route}.
The net namespace for these targets are the current net
namespace at file open stage, similar to
/proc/net/{netlink,ipv6_route} reference countin
This specifically to handle the case like below:
// ptr below is a socket ptr identified by PTR_TO_BTF_ID
u64 param[2] = { ptr, val };
bpf_seq_printf(seq, fmt, sizeof(fmt), param, sizeof(param));
In this case, the 16 bytes stack for "param" contains:
8 bytes for ptr with spilled PTR_TO
The implementation is arbitrary, just to show how the bpf programs
can be written for bpf_map/task/task_file. They can be costomized
for specific needs.
For example, for bpf_map, the iterator prints out:
$ cat /sys/fs/bpf/my_bpf_map
id refcnt usercnt locked_vm
32
Only the tasks belonging to "current" pid namespace
are enumerated.
For task/file target, the bpf program will have access to
struct task_struct *task
u32 fd
struct file *file
where fd/file is an open file for the task.
Signed-off-by: Yonghong Song
---
kernel/bpf/Makefile| 2 +-
ker
Two bpf programs are added in this patch for netlink and ipv6_route
target. On my VM, I am able to achieve identical
results compared to /proc/net/netlink and /proc/net/ipv6_route.
$ cat /proc/net/netlink
sk Eth PidGroups Rmem Wmem Dump Locks
DropsInode
Currently, only one command is supported
bpftool iter pin
It will pin the trace/iter bpf program in
the object file to the
where should be on a bpffs mount.
For example,
$ bpftool iter pin ./bpf_iter_ipv6_route.o \
/sys/fs/bpf/my_route
User can then do a `cat` to print out the result
The paranoidal pointer check in IRQ handler looks very strange - it
really protects us only against bogus drivers which request IRQ line
with null pointer dev_id. However, the code fragment is incorrect
because the dev pointer is used before the actual check which leads
to undefined behavior. Remov
In /proc/net/ipv6_route, we have
struct fib6_info {
struct fib6_table *fib6_table;
...
struct fib6_nh fib6_nh[0];
}
struct fib6_nh {
struct fib_nh_common nh_common;
struct rt6_info **rt6i_pcpu;
struct rt6_exception_bucket *rt6i_exception_bucket;
};
struct fib_nh_co
Implement seq_file operations to traverse all maps.
Signed-off-by: Yonghong Song
---
include/linux/bpf.h | 1 +
kernel/bpf/Makefile | 2 +-
kernel/bpf/map_iter.c | 107 ++
kernel/bpf/syscall.c | 19
4 files changed, 128 insertions(+), 1
Two new libbpf APIs are added to support bpf_iter:
- bpf_program__attach_iter
Given a bpf program and additional parameters, which is
none now, returns a bpf_link.
- bpf_iter_create
syscall level API to create a bpf iterator.
The macro BPF_SEQ_PRINTF are also introduced. The format
A new bpf command BPF_ITER_CREATE is added.
The anonymous bpf iterator is seq_file based.
The seq_file private data are referenced by targets.
The bpf_iter infrastructure allocated additional space
at seq_file->private before the space used by targets
to store some meta data, e.g.,
prog: p
Two helpers bpf_seq_printf and bpf_seq_write, are added for
writing data to the seq_file buffer.
bpf_seq_printf supports common format string flag/width/type
fields so at least I can get identical results for
netlink and ipv6_route targets.
For bpf_seq_printf and bpf_seq_write, return value -EOVE
Motivation:
The current way to dump kernel data structures mostly:
1. /proc system
2. various specific tools like "ss" which requires kernel support.
3. drgn
The dropback for the first two is that whenever you want to dump more, you
need change the kernel. For example, Martin want
To produce a file bpf iterator, the fd must be
corresponding to a link_fd assocciated with a
trace/iter program. When the pinned file is
opened, a seq_file will be generated.
Signed-off-by: Yonghong Song
---
include/linux/bpf.h | 2 ++
kernel/bpf/bpf_iter.c | 17 -
kernel/bpf/
bpf iterator uses seq_file to provide a lossless
way to transfer data to user space. But we want to call
bpf program after all objects have been traversed, and
bpf program may write additional data to the
seq_file buffer. The current seq_read() does not work
for this use case.
Besides allowing sto
Given a bpf program, the step to create an anonymous bpf iterator is:
- create a bpf_iter_link, which combines bpf program and the target.
In the future, there could be more information recorded in the link.
A link_fd will be returned to the user space.
- create an anonymous bpf iterato
The target can call bpf_iter_reg_target() to register itself.
The needed information:
target: target name
seq_ops: the seq_file operations for the target
init_seq_private target callback to initialize seq_priv during file open
fini_seq_private target callback to clean u
Added BPF_LINK_UPDATE support for tracing/iter programs.
This way, a file based bpf iterator, which holds a reference
to the link, can have its bpf program updated without
creating new files.
Signed-off-by: Yonghong Song
---
kernel/bpf/bpf_iter.c | 31 +++
1 file chan
A bpf_iter program is a tracing program with attach type
BPF_TRACE_ITER. The load attribute
attach_btf_id
is used by the verifier against a particular kernel function,
which represents a target, e.g., __bpf_iter__bpf_map
for target bpf_map which is implemented later.
The program return value mus
> … Thus add a call of the function
> “nfp_nsp_close” for the completion of the exception handling.
I suggest to mention also the addition of a jump target because of
a Linux coding style concern.
…
> +++ b/drivers/net/ethernet/netronome/nfp/abm/main.c
…
> @@ -300,12 +297,16 @@ nfp_abm_vnic_set_
From: Maor Gottlieb
The fs_core already supports creation of rules with multiple
actions/destinations. Refactor fs_core to handle the case
when don't trap rule is created with destination. Adapt the
calling code in the driver.
Signed-off-by: Maor Gottlieb
Reviewed-by: Mark Zhang
Reviewed-by: M
From: Leon Romanovsky
Changelog
v1:
* Rebased on latest rdma-next
* Removed attr_is_valid() check from flags
v0: https://lore.kernel.org/linux-rdma/20200413135220.934007-1-l...@kernel.org
-
Hi,
This code from Naor refacto
From: Maor Gottlieb
Currently, fs_core supports rule of forward the traffic
to continue matching in the next priority, now we add support
to forward the traffic matching in the next namespace.
Signed-off-by: Maor Gottlieb
Reviewed-by: Mark Bloch
Reviewed-by: Mark Zhang
Signed-off-by: Leon Rom
There is a DSA master reference counting issue, but with dsa-loop, the
DSA master is already properly reference counted thanks to the
dev_get_by_name() call, I will keep digging.
Thank you Florain.
I am not dsa expert, am debugging the call chain.
- Allen
please ignore it, i send it by accident.
On Mon, May 04, 2020 at 06:33:18AM +0200, Oleksij Rempel wrote:
> changes v3:
> - rename port_mode to master_slave
> - move validation code to net/ethtool/linkmodes.c
> - add UNSUPPORTED state and avoid sending unsupported fields
> - more formatting and n
changes v3:
- rename port_mode to master_slave
- move validation code to net/ethtool/linkmodes.c
- add UNSUPPORTED state and avoid sending unsupported fields
- more formatting and naming fixes
- tja11xx: support only force mode
- tja11xx: mark state as unsupported
changes v3:
- provide separate
When an application connects to the TIPC topology server and subscribes
to some services, a new connection is created along with some objects -
'tipc_subscription' to store related data correspondingly...
However, there is one omission in the connection handling that when the
connection or applicat
Prior to 1d27732f411d ("net: dsa: setup and teardown ports"), we would
not treat failures to set-up an user port as fatal, but after this
commit we would, which is a regression for some systems where interfaces
may be declared in the Device Tree, but the underlying hardware may not
be present (plug
On 5/3/2020 2:06 PM, Florian Fainelli wrote:
> Le 2020-05-01 à 10:58, Allen a écrit :
It maps to "eth0". Please let me know if you need further details.
>>>
>>> I suppose I should have been clearer, what network device driver created
>>> eth0?
>>>
>>
>> This was seen on a VM.
>> eth
syzbot suspects this bug was fixed by commit:
commit 4b793acdca0050739b99ace6a8b9e7f717f57c6b
Author: Taehee Yoo
Date: Fri Feb 28 18:01:46 2020 +
hsr: use netdev_err() instead of WARN_ONCE()
bisection log: https://syzkaller.appspot.com/x/bisect.txt?x=130746ffe0
start commit: ea
On 5/1/2020 2:14 AM, Jiri Pirko wrote:
Hi all.
First, I would like to apologize for very long email. But I think it
would be beneficial to the see the whole picture, where we are going.
Currently we are working internally on several features with
need of extension of the current devlink infr
Hi Christoph,
On Fri, 24 Apr 2020 08:43:36 +0200 Christoph Hellwig wrote:
>
> Extern declarations in .c files are a bad style and can lead to
> mismatches. Use existing definitions in headers where they exist,
> and otherwise move the external declarations to suitable header
> files.
>
> Signed
Hi Saeed:
When I saw this commit last year:
commit 57c7fce14b1ad512a42abe33cb721a2ea3520d4b
Author: Fan Li
Date: Mon Dec 16 14:46:15 2019 +0200
net/mlx5: Increase the max number of channels to 128
I was expecting to be able to increase the number of channels on larger
systems (e.g., 96 c
From: Karsten Graul
Date: Sun, 3 May 2020 14:38:39 +0200
> These patches add the 'add link' and 'delete link' processing as
> SMC server and client. This processing allows to establish and
> remove links of a link group dynamically.
>
> v2: Fix mess up with unused static functions. Merge patch
From: Dejin Zheng
Date: Sun, 3 May 2020 20:32:26 +0800
> A call of the function macb_init() can fail in the function
> fu540_c000_init. The related system resources were not released
> then. use devm_platform_ioremap_resource() to replace ioremap()
> to fix it.
>
> Fixes: c218ad559020ff9 ("macb
From:
Date: Sun, 3 May 2020 09:52:09 +
> From: Sameeh Jubran
>
>
> Difference from v2:
> * dropped patch "net: ena: move llq configuration from ena_probe to
> ena_device_init()"
> * reworked patch ""net: ena: implement ena_com_get_admin_polling_mode() to
> drop the prototype
>
> Differ
From: Bjørn Mork
Date: Sun, 03 May 2020 09:13:58 +0200
> Matt Jolly writes:
>
>> Add support for Dell Wireless 5816e to drivers/net/usb/qmi_wwan.c
>>
>> Signed-off-by: Matt Jolly
...
> Looks fine to me. Please add to the stable queue as well, Thanks.
>
> Acked-by: Bjørn Mork
Applied and
On 5/3/2020 3:47 PM, Vladimir Oltean wrote:
> Hi Florian,
>
> On Mon, 4 May 2020 at 01:45, Florian Fainelli wrote:
>>
>>
>>
>> On 5/3/2020 2:10 PM, Vladimir Oltean wrote:
>>> From: Vladimir Oltean
>>>
>>> To be able to perform mirroring and redirection through tc-flower
>>> offloads (the impl
From: Eric Dumazet
Date: Sat, 2 May 2020 20:09:25 -0700
> Do not assume the attribute has the right size.
>
> Fixes: aea5f654e6b7 ("net/sched: add skbprio scheduler")
> Signed-off-by: Eric Dumazet
> Reported-by: syzbot
Applied and queued up for -stable, thanks Eric.
From: Eric Dumazet
Date: Sat, 2 May 2020 19:54:17 -0700
> This series is focused on better layout of struct fq_flow to
> reduce number of cache line misses in fq_enqueue() and dequeue operations.
>
> Eric Dumazet (5):
> net_sched: sch_fq: avoid touching f->next from fq_gc()
> net_sched: sch
Hi Florian,
On Mon, 4 May 2020 at 01:45, Florian Fainelli wrote:
>
>
>
> On 5/3/2020 2:10 PM, Vladimir Oltean wrote:
> > From: Vladimir Oltean
> >
> > To be able to perform mirroring and redirection through tc-flower
> > offloads (the implementation of which is given raw access to the
> > flow_c
On 5/3/2020 2:10 PM, Vladimir Oltean wrote:
> From: Vladimir Oltean
>
> To be able to perform mirroring and redirection through tc-flower
> offloads (the implementation of which is given raw access to the
> flow_cls_offload structure), switch drivers need to be able to call
> these functions o
On 5/3/2020 3:20 PM, Vladimir Oltean wrote:
> From: Vladimir Oltean
>
> One may notice that automatically-learnt entries 'never' expire, even
> though the bridge configures the address age period at 300 seconds.
>
> Actually the value written to hardware corresponds to a time interval
> 1000
On 5/3/2020 3:20 PM, Vladimir Oltean wrote:
> From: Vladimir Oltean
>
> When running 'bridge fdb dump' on Felix, sometimes learnt and static MAC
> addresses would appear, sometimes they wouldn't.
>
> Turns out, the MAC table has 4096 entries on VSC7514 (Ocelot) and 8192
> entries on VSC9959 (
From: Vladimir Oltean
When running 'bridge fdb dump' on Felix, sometimes learnt and static MAC
addresses would appear, sometimes they wouldn't.
Turns out, the MAC table has 4096 entries on VSC7514 (Ocelot) and 8192
entries on VSC9959 (Felix), so the existing code from the Ocelot common
library o
From: Vladimir Oltean
One may notice that automatically-learnt entries 'never' expire, even
though the bridge configures the address age period at 300 seconds.
Actually the value written to hardware corresponds to a time interval
1000 times higher than intended, i.e. 83 hours.
Fixes: a556c76adc
From: Vladimir Oltean
This series fixes the following problems:
- Dynamically learnt addresses never expiring (neither for Ocelot nor
for Felix)
- Half of the FDB not visible in 'bridge fdb show' (for Felix only)
Vladimir Oltean (2):
net: dsa: ocelot: the MAC table on Felix is twice as large
From: Vladimir Oltean
Somewhat similar to dsa_tree_find, dsa_switch_find returns a dsa_switch
structure pointer by searching for its tree index and switch index (the
parameters from dsa,member). To be used, for example, by drivers who
implement .crosschip_bridge_join and need a reference to the o
From: Vladimir Oltean
Commit 8db0a2ee2c63 ("net: bridge: reject DSA-enabled master netdevices
as bridge members") added a special check in br_if.c in order to check
for a DSA master network device with a tagging protocol configured. This
was done because back then, such devices, once enslaved in
From: Vladimir Oltean
sja1105 uses dsa_8021q for DSA tagging, a format which is VLAN at heart
and which is compatible with cascading. A complete description of this
tagging format is in net/dsa/tag_8021q.c, but a quick summary is that
each external-facing port tags incoming frames with a unique p
From: Vladimir Oltean
One way of utilizing DSA is by cascading switches which do not all have
compatible taggers. Consider the following real-life topology:
+---+
| LS1028A
From: Vladimir Oltean
This series adds support for boards where DSA switches of multiple types
are cascaded together. Actually this type of setup was brought up before
on netdev, and it looks like utilizing disjoint trees is the way to go:
https://lkml.org/lkml/2019/7/7/225
The trouble with dis
From: Vladimir Oltean
Restrict the TTEthernet hardware support on this switch to operate as
closely as possible to IEEE 802.1Qci as possible. This means that it can
perform PTP-time-based ingress admission control on streams identified
by {DMAC, VID, PCP}, which is useful when trying to ensure th
From: Vladimir Oltean
Virtual links are a sja1105 hardware concept of executing various flow
actions based on a key extracted from the frame's DMAC, VID and PCP.
Currently the tc-flower offload code supports only parsing the DMAC if
that is the broadcast MAC address, and the VLAN PCP. Extract th
From: Vladimir Oltean
Implement tc-flower offloads for redirect, trap and drop using
non-critical virtual links.
Commands which were tested to work are:
# Send frames received on swp2 with a DA of 42:be:24:9b:76:20 to the
# CPU and to swp3. This type of key (DA only) when the port's VLAN
From: Vladimir Oltean
Expose the TTEthernet hardware features of the switch using standard
tc-flower actions: trap, drop, redirect and gate.
Vladimir Oltean (6):
net: dsa: export dsa_slave_dev_check and dsa_slave_to_port
net: dsa: sja1105: add static tables for virtual links
net: dsa: sja1
From: Vladimir Oltean
Add some verbiage describing how the hardware features of the switch are
exposed to users through tc-flower.
Signed-off-by: Vladimir Oltean
---
Changes from RFC:
Patch is new.
Documentation/networking/dsa/sja1105.rst | 116 +++
1 file changed, 116 ins
From: Vladimir Oltean
This patch adds the register definitions for the:
- VL Lookup Table
- VL Policing Table
- VL Forwarding Table
- VL Forwarding Parameters Table
These are needed in order to perform TTEthernet operations: QoS
classification, flow-based policing and/or frame redirecting with t
From: Vladimir Oltean
To be able to perform mirroring and redirection through tc-flower
offloads (the implementation of which is given raw access to the
flow_cls_offload structure), switch drivers need to be able to call
these functions on act->dev.
Signed-off-by: Vladimir Oltean
---
Changes fr
Le 2020-05-01 à 10:58, Allen a écrit :
>>>
>>> It maps to "eth0". Please let me know if you need further details.
>>
>> I suppose I should have been clearer, what network device driver created
>> eth0?
>>
>
> This was seen on a VM.
> eth0 [52:54:00:c1:cd:65]: virtio_net (up)
I have reproduced
From: Qiushi Wu
In function nfp_abm_vnic_set_mac, pointer nsp is allocated by nfp_nsp_open.
But when nfp_nsp_has_hwinfo_lookup fail, the pointer is not released,
which can lead to a memory leak bug. Thus add a call of the function
“nfp_nsp_close” for the completion of the exception handling.
Fix
> … Thus add a call of the function
> “nfp_nsp_close” for the completion of the exception handling.
Thanks for your positive response.
I imagined that a small patch series would be more reasonable
than this direct change combination.
…
> +++ b/drivers/net/ethernet/netronome/nfp/abm/main.c
…
>
On Sat, May 2, 2020 at 4:29 AM Lese Doru Calin
wrote:
>
> In this year's edition of GSoC, there is a project idea for CRIU to add
> support
> for checkpoint/restore of cork-ed UDP sockets. But to add it, the kernel API
> needs
> to be extended.
> This is what this patch does. It adds a new comma
From: Qiushi Wu
In function nfp_abm_vnic_set_mac, pointer nsp is allocated by nfp_nsp_open.
But when nfp_nsp_has_hwinfo_lookup fail, the pointer is not released,
which can lead to a memory leak bug. Thus add a call of the function
“nfp_nsp_close” for the completion of the exception handling.
Fix
The AR8031/AR8033 and the AR8035 support cable diagnostics. Adding
driver support is straightforward, so lets add it.
The PHY just do one pair at a time, so we have to start the test four
times. The cable_test_get_status() can block and therefore we can just
busy polling the test completion and co
Sort the items in the compatible string list in increasing number of SoC.
Signed-off-by: Lad Prabhakar
Reviewed-by: Sergei Shtylyov
Reviewed-by: Geert Uytterhoeven
---
Changes for v2:
* Included renesas,ether in subject instead of sh_eth.
* Included Reviewed-by tags.
Documentation/devicetr
On 03/05/2020 at 14:32, Dejin Zheng wrote:
> A call of the function macb_init() can fail in the function
> fu540_c000_init. The related system resources were not released
> then. use devm_platform_ioremap_resource() to replace ioremap()
> to fix it.
>
> Fixes: c218ad559020ff9 ("macb: Add support f
Hi,
On 3.5.2020 11.33, Heiner Kallweit wrote:
On 03.05.2020 04:28, Lauri Jakku wrote:
Hi,
On 3.5.2020 4.34, Lauri Jakku wrote:
Hi,
On 3.5.2020 3.11, Lauri Jakku wrote:
On 3.5.2020 2.15, Heiner Kallweit wrote:
On 03.05.2020 00:42, Lauri Jakku wrote:
Hi,
On 2.5.2020 20.56, Lauri Jakku w
From: Karstens, Nate
> Sent: 01 May 2020 15:45
> Thanks for the suggestion. I looked into it and noticed that
> do_close_on_exec() appears to have some
> optimizations as well:
>
> > set = fdt->close_on_exec[i];
> > if (!set)
> > continue;
>
> If we interleave the close-on-exec and close-on-
On 2020-04-30 11:53 p.m., Cong Wang wrote:
When we tell kernel to dump filters from root (:),
those filters on ingress (:) are matched, but their
true parents must be dumped as they are. However, kernel
dumps just whatever we tell it, that is either :
or ::
$ nl
On 2020-05-03 8:02 a.m., Jamal Hadi Salim wrote:
On 2020-05-02 10:28 p.m., Cong Wang wrote:
On Sat, May 2, 2020 at 2:19 AM Jamal Hadi Salim wrote:
On 2020-05-02 4:48 a.m., Jamal Hadi Salim wrote:
[..]
Note:
tc filter show dev dummy0 root
should not show that filter. OTOH,
tc filter show de
This patch finalizes the ADD_LINK processing of new links. Receive the
CONFIRM_LINK request from peer, complete the link initialization,
register all used buffers with the IB device and finally send the
CONFIRM_LINK response, which completes the ADD_LINK processing.
And activate smc_llc_cli_add_lin
First set of functions to process an ADD_LINK LLC request as an SMC
client. Find an alternate IB device, determine the new link group type
and get the index for the new link. Then ready the link, map the buffers
and send an ADD_LINK LLC response. If any error occurs, send a reject
LLC message and t
Part of the SMC client new link establishment process is the exchange of
rkeys for all used buffers.
Add new LLC message type ADD_LINK_CONTINUE which is used to exchange
rkeys of all current RMB buffers. Add functions to iterate over all
used RMB buffers of the link group, and implement the ADD_LIN
When a link group moved from asymmetric to symmetric state then the
dangling asymmetric link can be deleted. Add smc_llc_find_asym_link() to
find the respective link and add smc_llc_delete_asym_link() to delete
it.
Signed-off-by: Karsten Graul
Reviewed-by: Ursula Braun
---
net/smc/smc_llc.c | 8
Add smc_llc_process_srv_delete_link() to process a DELETE_LINK request
as SMC server. When the request is to delete ALL links then terminate
the whole link group. If not, find the link to delete by its link_id,
send the DELETE_LINK request LLC message and wait for the response.
No matter if a respo
As SMC server, when a second link was deleted, trigger the setup of an
asymmetric link. Do this by enqueueing a local ADD_LINK message which
is processed by the LLC layer as if it were received from peer. Do the
same when a new IB port became active and a new link could be created.
smc_llc_srv_add_
These patches add the 'add link' and 'delete link' processing as
SMC server and client. This processing allows to establish and
remove links of a link group dynamically.
v2: Fix mess up with unused static functions. Merge patch 8 into patch 4.
Postpone patch 13 to next series.
Karsten Graul
Introduce a work that is scheduled when a new DELETE_LINK LLC request is
received. The work will call either the SMC client or SMC server
DELETE_LINK processing.
And use the LLC flow framework to process incoming DELETE_LINK LLC
messages, scheduling the llc_del_link_work for those events.
With thes
First set of functions to process an ADD_LINK LLC request as an SMC
server. Find an alternate IB device, determine the new link group type
and get the index for the new link. Then initialize the link and send
the ADD_LINK LLC message to the peer. Save the contents of the response,
ready the link, m
Part of SMC server new link establishment is the exchange of rkeys for
used buffers.
Loop over all used RMB buffers and send ADD_LINK_CONTINUE LLC messages
to the peer.
Signed-off-by: Karsten Graul
Reviewed-by: Ursula Braun
---
net/smc/smc_llc.c | 43 ++-
Add smc_llc_process_cli_delete_link() to process a DELETE_LINK request
as SMC client. When the request is to delete ALL links then terminate
the whole link group. If not, find the link to delete by its link_id,
send the DELETE_LINK response LLC message and then clear the deleted
link. Finally deter
This patch finalizes the ADD_LINK processing of new links. Send the
CONFIRM_LINK request to the peer, receive the response and set link
state to ACTIVE.
Signed-off-by: Karsten Graul
Reviewed-by: Ursula Braun
---
net/smc/smc_llc.c | 29 -
1 file changed, 28 insertions
A call of the function macb_init() can fail in the function
fu540_c000_init. The related system resources were not released
then. use devm_platform_ioremap_resource() to replace ioremap()
to fix it.
Fixes: c218ad559020ff9 ("macb: Add support for SiFive FU540-C000")
Cc: Andy Shevchenko
Reviewed-by
On 2020-05-02 10:28 p.m., Cong Wang wrote:
On Sat, May 2, 2020 at 2:19 AM Jamal Hadi Salim wrote:
On 2020-05-02 4:48 a.m., Jamal Hadi Salim wrote:
[..]
Note:
tc filter show dev dummy0 root
should not show that filter. OTOH,
tc filter show dev dummy0 parent :
should.
Hmm, but we use TC
…
> Fix this issue by adding nfp_nsp_close(nsp) in the error path.
How do you think about a wording variant like the following?
Subject:
[PATCH v2] nfp: abm: Fix incomplete release of system resources in
nfp_abm_vnic_set_mac()
Change description:
…
Thus add a call of the function
> -Original Message-
> From: Jakub Kicinski
> Sent: Tuesday, April 28, 2020 10:05 PM
> To: Jubran, Samih
> Cc: da...@davemloft.net; netdev@vger.kernel.org; Kiyanovski, Arthur
> ; Woodhouse, David ;
> Machulsky, Zorik ; Matushevsky, Alexander
> ; Bshara, Saeed ; Wilson,
> Matt ; Liguori
> -Original Message-
> From: Jakub Kicinski
> Sent: Tuesday, April 28, 2020 10:46 PM
> To: Jubran, Samih
> Cc: da...@davemloft.net; netdev@vger.kernel.org; Kiyanovski, Arthur
> ; Woodhouse, David ;
> Machulsky, Zorik ; Matushevsky, Alexander
> ; Bshara, Saeed ; Wilson,
> Matt ; Liguori
From: Sameeh Jubran
The macros in ena_com.h have inconsistent spaces between
the macro name and it's value.
This commit sets all the macros to have a single space between
the name and value.
Signed-off-by: Arthur Kiyanovski
Signed-off-by: Sameeh Jubran
---
drivers/net/ethernet/amazon/ena/ena
From: Sameeh Jubran
Current code does not allow setting the hash function without
changing the key. This commit enables it.
To achieve this we separate ena_com_get_hash_function() to 2 functions:
ena_com_get_hash_function() - which gets only the hash function, and
ena_com_get_hash_key() - which
From: Sameeh Jubran
Add unmask interrupts statistics to ethtool.
Signed-off-by: Netanel Belgazal
Signed-off-by: Arthur Kiyanovski
Signed-off-by: Sameeh Jubran
---
drivers/net/ethernet/amazon/ena/ena_ethtool.c | 1 +
drivers/net/ethernet/amazon/ena/ena_netdev.c | 3 +++
drivers/net/ethernet/
From: Arthur Kiyanovski
Currently when ena_set_hash_function() fails the hash function is
restored to the previous value by calling an admin command to get
the hash function from the device.
In this commit we avoid the admin command, by saving the previous
hash function before calling ena_set_ha
From: Arthur Kiyanovski
Extract code to ena_indirection_table_set() to make
the code cleaner.
Signed-off-by: Sameeh Jubran
Signed-off-by: Arthur Kiyanovski
---
drivers/net/ethernet/amazon/ena/ena_ethtool.c | 48 ---
1 file changed, 30 insertions(+), 18 deletions(-)
diff --git
From: Sameeh Jubran
Both key and func parameters are pointers on the stack.
Setting them to NULL does nothing.
The original intent was to leave the key and func unset in this case,
but for this to happen nothing needs to be done as the calling
function ethtool_get_rxfh() already clears key and fu
From: Sameeh Jubran
Difference from v2:
* dropped patch "net: ena: move llq configuration from ena_probe to
ena_device_init()"
* reworked patch ""net: ena: implement ena_com_get_admin_polling_mode() to drop
the prototype
Difference from v1:
* reodered paches #01 and #02.
* dropped adding Rx/
From: Sameeh Jubran
This commit contains 2 cosmetic changes:
1. Use ena_com_check_supported_feature_id() in
ena_com_hash_key_fill_default_key() instead of rewriting
its implementation. This also saves us a superfluous admin
command by using the cached value.
2. Change if conditions in
1 - 100 of 107 matches
Mail list logo
