> … Thus add a call of the function
> “nfp_nsp_close” for the completion of the exception handling.

Thanks for your positive response.

I imagined that a small patch series would be more reasonable
than this direct change combination.


…
> +++ b/drivers/net/ethernet/netronome/nfp/abm/main.c
…
>       ether_addr_copy(nn->dp.netdev->perm_addr, mac_addr);
> +
> +generate_random_address:
> +     eth_hw_addr_random(nn->dp.netdev);
> +     return;
>  }
…

Unfortunately, you interpreted my update suggestion in a questionable way
at this source code place.
I guess that the following code variant can be considered instead.

        ether_addr_copy(nn->dp.netdev->perm_addr, mac_addr);
+       return;
+
+generate_random_address:
+       eth_hw_addr_random(nn->dp.netdev);
 }


Regards,
Markus

Reply via email to