> … Thus add a call of the function > “nfp_nsp_close” for the completion of the exception handling.
I suggest to mention also the addition of a jump target because of a Linux coding style concern. … > +++ b/drivers/net/ethernet/netronome/nfp/abm/main.c … > @@ -300,12 +297,16 @@ nfp_abm_vnic_set_mac(struct nfp_pf *pf, struct nfp_abm > *abm, struct nfp_net *nn, … > +generate_random_address: > + eth_hw_addr_random(nn->dp.netdev); > + return; > } … I recommend to apply the check “RETURN_VOID” once more. https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/scripts/checkpatch.pl?id=0e698dfa282211e414076f9dc7e83c1c288314fd#n4866 Regards, Markus
