> -----Original Message-----
> From: Jakub Kicinski <[email protected]>
> Sent: Tuesday, April 28, 2020 10:46 PM
> To: Jubran, Samih <[email protected]>
> Cc: [email protected]; [email protected]; Kiyanovski, Arthur
> <[email protected]>; Woodhouse, David <[email protected]>;
> Machulsky, Zorik <[email protected]>; Matushevsky, Alexander
> <[email protected]>; Bshara, Saeed <[email protected]>; Wilson,
> Matt <[email protected]>; Liguori, Anthony <[email protected]>;
> Bshara, Nafea <[email protected]>; Tzalik, Guy <[email protected]>;
> Belgazal, Netanel <[email protected]>; Saidi, Ali
> <[email protected]>; Herrenschmidt, Benjamin <[email protected]>;
> Dagan, Noam <[email protected]>
> Subject: RE: [EXTERNAL] [PATCH V2 net-next 11/13] net: ena: move llq
> configuration from ena_probe to ena_device_init()
>
> CAUTION: This email originated from outside of the organization. Do not click
> links or open attachments unless you can confirm the sender and know the
> content is safe.
>
>
>
> On Tue, 28 Apr 2020 07:27:24 +0000 [email protected] wrote:
> > + ena_dev->mem_bar = devm_ioremap_wc(&pdev->dev,
> > + pci_resource_start(pdev,
> > ENA_MEM_BAR),
> > + pci_resource_len(pdev,
> > ENA_MEM_BAR));
>
> Is there anything that'd undo the mapping in case of reset?
>
> The use of devm_ functions outside of probe seems questionable.
I agree, dropped patch in v3.
