> -----Original Message-----
> From: Jakub Kicinski <k...@kernel.org>
> Sent: Tuesday, April 28, 2020 10:46 PM
> To: Jubran, Samih <same...@amazon.com>
> Cc: da...@davemloft.net; netdev@vger.kernel.org; Kiyanovski, Arthur
> <akiy...@amazon.com>; Woodhouse, David <d...@amazon.co.uk>;
> Machulsky, Zorik <zo...@amazon.com>; Matushevsky, Alexander
> <ma...@amazon.com>; Bshara, Saeed <sae...@amazon.com>; Wilson,
> Matt <m...@amazon.com>; Liguori, Anthony <aligu...@amazon.com>;
> Bshara, Nafea <na...@amazon.com>; Tzalik, Guy <gtza...@amazon.com>;
> Belgazal, Netanel <neta...@amazon.com>; Saidi, Ali
> <alisa...@amazon.com>; Herrenschmidt, Benjamin <b...@amazon.com>;
> Dagan, Noam <nda...@amazon.com>
> Subject: RE: [EXTERNAL] [PATCH V2 net-next 11/13] net: ena: move llq
> configuration from ena_probe to ena_device_init()
>
> CAUTION: This email originated from outside of the organization. Do not click
> links or open attachments unless you can confirm the sender and know the
> content is safe.
>
>
>
> On Tue, 28 Apr 2020 07:27:24 +0000 same...@amazon.com wrote:
> > + ena_dev->mem_bar = devm_ioremap_wc(&pdev->dev,
> > + pci_resource_start(pdev,
> > ENA_MEM_BAR),
> > + pci_resource_len(pdev,
> > ENA_MEM_BAR));
>
> Is there anything that'd undo the mapping in case of reset?
>
> The use of devm_ functions outside of probe seems questionable.
I agree, dropped patch in v3.
