Re: [PATCH net-next v4 08/10] net: openvswitch: fix possible memleak on destroy flow-table

2019-10-21 Thread Pravin Shelar
On Sun, Oct 20, 2019 at 10:02 PM Tonghao Zhang wrote: > > On Sat, Oct 19, 2019 at 2:12 AM Pravin Shelar wrote: > > > > On Thu, Oct 17, 2019 at 8:16 PM Tonghao Zhang > > wrote: > > > > > > On Fri, Oct 18, 2019 at 6:38 AM Pravin Shelar wrote: > > > > > > > > On Wed, Oct 16, 2019 at 5:50 AM wrot

RE: [PATCH net-next 5/6] dpaa_eth: change DMA device

2019-10-21 Thread Madalin-cristian Bucur
> -Original Message- > From: Jakub Kicinski > Sent: Tuesday, October 22, 2019 7:23 AM > To: Madalin-cristian Bucur > Cc: da...@davemloft.net; netdev@vger.kernel.org; Roy Pledge > ; Laurentiu Tudor > Subject: Re: [PATCH net-next 5/6] dpaa_eth: change DMA device > > On Mon, 21 Oct 2019 12

RE: [PATCH net-next 0/6] DPAA Ethernet changes

2019-10-21 Thread Madalin-cristian Bucur
> -Original Message- > From: Jakub Kicinski > Sent: Tuesday, October 22, 2019 7:26 AM > To: Madalin-cristian Bucur > Cc: da...@davemloft.net; netdev@vger.kernel.org; Roy Pledge > ; Laurentiu Tudor > Subject: Re: [PATCH net-next 0/6] DPAA Ethernet changes > > On Mon, 21 Oct 2019 12:27:51

Re: [patch net-next v3 3/3] devlink: add format requirement for devlink object names

2019-10-21 Thread Jiri Pirko
Mon, Oct 21, 2019 at 06:11:33PM CEST, dsah...@gmail.com wrote: >On 10/21/19 9:56 AM, Jiri Pirko wrote: >> >> I forgot to update the desc. Uppercase chars are now allowed as Andrew >> requested. Regarding dash, it could be allowed of course. But why isn't >> "_" enough. I mean, I think it would be

Re: [PATCH net 2/5] bnxt_en: Fix devlink NVRAM related byte order related issues.

2019-10-21 Thread Michael Chan
On Mon, Oct 21, 2019 at 9:14 PM Jakub Kicinski wrote: > > On Mon, 21 Oct 2019 01:34:26 -0400, Michael Chan wrote: > > diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt_devlink.c > > b/drivers/net/ethernet/broadcom/bnxt/bnxt_devlink.c > > index 68f74f5..bd4b9f3 100644 > > --- a/drivers/net/ethe

Re: [PATCH] net: forcedeth: add xmit_more support

2019-10-21 Thread Zhu Yanjun
On 2019/10/21 23:33, Jakub Kicinski wrote: On Mon, 21 Oct 2019 17:56:06 +0800, Zhu Yanjun wrote: On 2019/10/19 6:48, Jakub Kicinski wrote: On Fri, 18 Oct 2019 06:01:25 -0400, Zhu Yanjun wrote: This change adds support for xmit_more based on the igb commit 6f19e12f6230 ("igb: flush when in xm

Re: [bpf-next PATCH] bpf: libbpf, support older style kprobe load

2019-10-21 Thread John Fastabend
Andrii Nakryiko wrote: > On Sat, Oct 19, 2019 at 1:30 AM John Fastabend > wrote: > > > > Following ./Documentation/trace/kprobetrace.rst add support for loading > > kprobes programs on older kernels. > > > > My main concern with this is that this code is born bit-rotten, > because selftests are

[PATCH net-next 1/4] page_pool: Add API to update numa node

2019-10-21 Thread Saeed Mahameed
Add page_pool_update_nid() to be called by page pool consumers when they detect numa node changes. It will update the page pool nid value to start allocating from the new effective numa node. This is to mitigate page pool allocating pages from a wrong numa node, where the pool was originally allo

[PATCH net-next 3/4] page_pool: Restructure __page_pool_put_page()

2019-10-21 Thread Saeed Mahameed
From: Jonathan Lemon 1) Rename functions to reflect what they are actually doing. 2) Unify the condition to keep a page. 3) When page can't be kept in cache, fallback to releasing page to page allocator in one place, instead of calling it from multiple conditions, and reuse __page_pool_return_p

[PATCH net-next 0/4] page_pool: API for numa node change handling

2019-10-21 Thread Saeed Mahameed
Hi Dave & Jesper, This series extends page pool API to allow page pool consumers to update page pool numa node on the fly. This is required since on some systems, rx rings irqs can migrate between numa nodes, due to irq balancer or user defined scripts, current page pool has no way to know of such

[PATCH net-next 4/4] net/mlx5e: Rx, Update page pool numa node when changed

2019-10-21 Thread Saeed Mahameed
Once every napi poll cycle, check if numa node is different than the page pool's numa id, and update it using page_pool_update_nid(). Alternatively, we could have registered an irq affinity change handler, but page_pool_update_nid() must be called from napi context anyways, so the handler won't ac

[PATCH net-next 2/4] page_pool: Don't recycle non-reusable pages

2019-10-21 Thread Saeed Mahameed
A page is NOT reusable when at least one of the following is true: 1) allocated when system was under some pressure. (page_is_pfmemalloc) 2) belongs to a different NUMA node than pool->p.nid. To update pool->p.nid users should call page_pool_update_nid(). Holding on to such pages in the pool will

Re: [PATCH net-next 0/6] DPAA Ethernet changes

2019-10-21 Thread Jakub Kicinski
On Mon, 21 Oct 2019 12:27:51 +, Madalin-cristian Bucur wrote: > Here's a series of changes for the DPAA Ethernet, addressing minor > or unapparent issues in the codebase, adding probe ordering based on > a recently added DPAA QMan API, removing some redundant code. Hi Madalin! Patch 2 looks l

Re: [PATCH net-next 5/6] dpaa_eth: change DMA device

2019-10-21 Thread Jakub Kicinski
On Mon, 21 Oct 2019 12:28:02 +, Madalin-cristian Bucur wrote: > The DPAA Ethernet driver is using the FMan MAC as the device for DMA > mapping. This is not actually correct, as the real DMA device is the > FMan port (the FMan Rx port for reception and the FMan Tx port for > transmission). Chang

Re: [PATCH net 2/5] bnxt_en: Fix devlink NVRAM related byte order related issues.

2019-10-21 Thread Jakub Kicinski
On Mon, 21 Oct 2019 01:34:26 -0400, Michael Chan wrote: > diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt_devlink.c > b/drivers/net/ethernet/broadcom/bnxt/bnxt_devlink.c > index 68f74f5..bd4b9f3 100644 > --- a/drivers/net/ethernet/broadcom/bnxt/bnxt_devlink.c > +++ b/drivers/net/ethernet/broa

Re: [net-next] tipc: improve throughput between nodes in netns

2019-10-21 Thread Eric Dumazet
On 10/21/19 8:33 PM, Hoang Le wrote: > Hi Eric, > > Thanks for quick feedback. > See my inline answer. > > Regards, > Hoang > -Original Message- > From: Eric Dumazet > Sent: Tuesday, October 22, 2019 9:41 AM > To: Hoang Le ; jon.ma...@ericsson.com; > ma...@donjonn.com; tipc-discuss.

RE: [net-next] tipc: improve throughput between nodes in netns

2019-10-21 Thread Hoang Le
Hi Eric, Thanks for quick feedback. See my inline answer. Regards, Hoang -Original Message- From: Eric Dumazet Sent: Tuesday, October 22, 2019 9:41 AM To: Hoang Le ; jon.ma...@ericsson.com; ma...@donjonn.com; tipc-discuss...@lists.sourceforge.net; netdev@vger.kernel.org Subject: Re: [n

Re: [net-next v3 0/5][pull request] 1GbE Intel Wired LAN Driver Updates 2019-10-21

2019-10-21 Thread Jakub Kicinski
On Mon, 21 Oct 2019 11:01:38 -0700, Jeff Kirsher wrote: > This series contains updates to e1000e and igc only. > > Sasha adds stream control transmission protocol (SCTP) CRC checksum > support for igc. Also added S0ix support to the e1000e driver. Then > added multicast support by adding the add

Re: [bpf-next PATCH] bpf: libbpf, support older style kprobe load

2019-10-21 Thread Andrii Nakryiko
On Sat, Oct 19, 2019 at 1:30 AM John Fastabend wrote: > > Following ./Documentation/trace/kprobetrace.rst add support for loading > kprobes programs on older kernels. > My main concern with this is that this code is born bit-rotten, because selftests are never testing the legacy code path. How di

Re: [net-next] tipc: improve throughput between nodes in netns

2019-10-21 Thread Eric Dumazet
On 10/21/19 7:20 PM, Hoang Le wrote: > n->net = net; > n->capabilities = capabilities; > + n->pnet = NULL; > + for_each_net_rcu(tmp) { This does not scale well, if say you have a thousand netns ? > + tn_peer = net_generic(tmp, tipc_net_id); > + if (!

[net-next] tipc: improve throughput between nodes in netns

2019-10-21 Thread Hoang Le
Currently, TIPC transports intra-node user data messages directly socket to socket, hence shortcutting all the lower layers of the communication stack. This gives TIPC very good intra node performance, both regarding throughput and latency. We now introduce a similar mechanism for TIPC data traffi

Re: [net-next] tcp: add TCP_INFO status for failed client TFO

2019-10-21 Thread Neal Cardwell
On Mon, Oct 21, 2019 at 5:11 PM Jason Baron wrote: > > > > On 10/21/19 4:36 PM, Eric Dumazet wrote: > > On Mon, Oct 21, 2019 at 12:53 PM Christoph Paasch wrote: > >> > > > >> Actually, longterm I hope we would be able to get rid of the > >> blackhole-detection and fallback heuristics. In a far di

[PATCH v5 0/2] mv88e6xxx: Allow config of ATU hash algorithm

2019-10-21 Thread Andrew Lunn
v2: Pass a pointer for where the hash should be stored, return a plain errno, or 0. Document the parameter. v3: Document type of parameter, and valid range Add break statements to default clause of switch Directly use ctx->val.vu8 v4: Consistently use devlink, not a mix of devlink and dl. Fix

[PATCH v5 1/2] net: dsa: Add support for devlink device parameters

2019-10-21 Thread Andrew Lunn
Add plumbing to allow DSA drivers to register parameters with devlink. To keep with the abstraction, the DSA drivers pass the ds structure to these helpers, and the DSA core then translates that to the devlink structure associated to the device. Signed-off-by: Andrew Lunn Acked-by: Jiri Pirko R

[PATCH v5 2/2] net: dsa: mv88e6xxx: Add devlink param for ATU hash algorithm.

2019-10-21 Thread Andrew Lunn
Some of the marvell switches have bits controlling the hash algorithm the ATU uses for MAC addresses. In some industrial settings, where all the devices are from the same manufacture, and hence use the same OUI, the default hashing algorithm is not optimal. Allow the other algorithms to be selected

Re: Crash when receiving FIN-ACK in TCP_FIN_WAIT1 state

2019-10-21 Thread Neal Cardwell
On Mon, Oct 21, 2019 at 8:04 PM Subash Abhinov Kasiviswanathan wrote: > > > Interesting! As tcp_input.c summarizes, "packets_out is > > SND.NXT-SND.UNA counted in packets". In the normal operation of a > > socket, tp->packets_out should not be 0 if any of those other fields > > are non-zero. > > >

Re: [PATCH 00/10] IXP4xx networking cleanups

2019-10-21 Thread Jakub Kicinski
On Mon, 21 Oct 2019 02:08:14 +0200, Linus Walleij wrote: > This is a patch series which jams together Arnds and mine > cleanups for the IXP4xx networking. > > I also have patches for device tree support but that > requires more elaborate work, this series is some of > mine and some of Arnds patche

Re: [PATCH 07/10] net: ehernet: ixp4xx: Use devm_alloc_etherdev()

2019-10-21 Thread Jakub Kicinski
On Mon, 21 Oct 2019 02:08:21 +0200, Linus Walleij wrote: > Using the devm_alloc_etherdev() function simplifies the error > path. I also patch the message to use dev_info(). > > Signed-off-by: Linus Walleij > --- > drivers/net/ethernet/xscale/ixp4xx_eth.c | 18 ++ > 1 file changed

Re: [PATCH 05/10] net: ethernet: ixp4xx: Standard module init

2019-10-21 Thread Jakub Kicinski
On Mon, 21 Oct 2019 02:08:19 +0200, Linus Walleij wrote: > @@ -1376,7 +1365,7 @@ static const struct net_device_ops ixp4xx_netdev_ops = { > .ndo_validate_addr = eth_validate_addr, > }; > > -static int eth_init_one(struct platform_device *pdev) > +static int ixp4xx_eth_probe(struct platform

[PATCH net-next] net: of_get_phy_mode: Change API to solve int/unit warnings

2019-10-21 Thread Andrew Lunn
Before this change of_get_phy_mode() returned an enum, phy_interface_t. On error, -ENODEV etc, is returned. If the result of the function is stored in a variable of type phy_interface_t, and the compiler has decided to represent this as an unsigned int, comparision with -ENODEV etc, is a signed vs

Re: [ovs-dev] [PATCH net-next v4 00/10] optimize openvswitch flow looking up

2019-10-21 Thread Tonghao Zhang
On Tue, Oct 22, 2019 at 1:14 AM William Tu wrote: > > On Wed, Oct 16, 2019 at 5:50 AM wrote: > > > > From: Tonghao Zhang > > > > This series patch optimize openvswitch for performance or simplify > > codes. > > > > Patch 1, 2, 4: Port Pravin B Shelar patches to > > linux upstream with little cha

Re: [PATCH net-next 3/4] dpaa2-eth: add MAC/PHY support through phylink

2019-10-21 Thread Andrew Lunn
Hi Ioana > +static int dpaa2_eth_connect_mac(struct dpaa2_eth_priv *priv) > +{ > + struct fsl_mc_device *dpni_dev, *dpmac_dev; > + struct dpaa2_mac *mac; > + int err; > + > + dpni_dev = to_fsl_mc_device(priv->net_dev->dev.parent); > + dpmac_dev = fsl_mc_get_endpoint(dpni_dev);

[PATCH net] selftests: Make l2tp.sh executable

2019-10-21 Thread David Ahern
From: David Ahern Kernel test robot reported that the l2tp.sh test script failed: # selftests: net: l2tp.sh # Warning: file l2tp.sh is not executable, correct this. Set executable bits. Fixes: e858ef1cd4bc ("selftests: Add l2tp tests") Reported-by: kernel test robot Signed-off-by: Davi

Re: [net-next] tcp: add TCP_INFO status for failed client TFO

2019-10-21 Thread Christoph Paasch
On 21/10/19 - 14:27:24, Jason Baron wrote: > > > On 10/21/19 2:02 PM, Yuchung Cheng wrote: > > Thanks for the patch. Detailed comments below > > > > On Fri, Oct 18, 2019 at 4:58 PM Neal Cardwell wrote: > >> > >> On Fri, Oct 18, 2019 at 3:03 PM Jason Baron wrote: > >>> > >>> The TCPI_OPT_SYN_DA

Re: Crash when receiving FIN-ACK in TCP_FIN_WAIT1 state

2019-10-21 Thread Subash Abhinov Kasiviswanathan
Interesting! As tcp_input.c summarizes, "packets_out is SND.NXT-SND.UNA counted in packets". In the normal operation of a socket, tp->packets_out should not be 0 if any of those other fields are non-zero. The tcp_write_queue_purge() function sets packets_out to 0: https://git.kernel.org/pub/scm

Re: [PATCH bpf-next] libbpf: make LIBBPF_OPTS macro strictly a variable declaration

2019-10-21 Thread Andrii Nakryiko
On Mon, Oct 21, 2019 at 12:01 PM Jakub Sitnicki wrote: > > On Mon, Oct 21, 2019 at 06:57 PM CEST, Andrii Nakryiko wrote: > > LIBBPF_OPTS is implemented as a mix of field declaration and memset > > + assignment. This makes it neither variable declaration nor purely > > statements, which is a proble

Re: [PATCH bpf-next v3 1/5] bpf: Support chain calling multiple BPF programs after each other

2019-10-21 Thread Edward Cree
On 15/10/2019 19:33, Edward Cree wrote: > But I think we'll >  need to prototype things with static linking first so that we can be >  sure of the linker semantics we want, before we try to put a new dynamic >  linker in the kernel. For anyone wanting to follow my progress on this, the first-draft

Re: [PATCH iproute2-next] Add tc-BPF example for a TCP pure ack recognizer

2019-10-21 Thread Stephen Hemminger
On Tue, 1 May 2018 11:32:41 -0700 Dave Taht wrote: > +/* SPDX-License-Identifier: GPL-2.0 */ > +/* > + * Copyright 2017 Google Inc. > + * > + * This program is free software; you can redistribute it and/or > + * modify it under the terms of the GNU General Public License > + * as published by th

Re: [PATCH] bpftool: Try to read btf as raw data if elf read fails

2019-10-21 Thread Jakub Kicinski
On Mon, 21 Oct 2019 16:02:27 +0200, Jiri Olsa wrote: > > > static int do_dump(int argc, char **argv) > > > { > > > struct btf *btf = NULL; > > > @@ -397,7 +429,7 @@ static int do_dump(int argc, char **argv) > > > __u32 btf_id = -1; > > > const char *src; > > > int fd = -1; > > > - int err

Re: [PATCH net-next 2/4] bus: fsl-mc: add the fsl_mc_get_endpoint function

2019-10-21 Thread Andrew Lunn
Hi Ioana > +/** > + * dprc_get_connection() - Get connected endpoint and link status if > connection > + * exists. > + * @mc_io: Pointer to MC portal's I/O object > + * @cmd_flags: Command flags; one or more of 'MC_CMD_FLAG_' > + * @token: Token of DPRC object > + * @e

[PATCH net-next 1/4] dpaa2-eth: update the TX frame queues on DPNI_IRQ_EVENT_ENDPOINT_CHANGED

2019-10-21 Thread Ioana Ciornei
Currently the function is called at every link up event, although the FQID values will only change when the DPNI is disconnected from the current object and reconnected to a different one. The patch also avoids the forward declaration of update_tx_fqids. Signed-off-by: Ioana Ciornei --- drivers

[PATCH net-next 0/4] dpaa2-eth: add MAC/PHY support through phylink

2019-10-21 Thread Ioana Ciornei
The dpaa2-eth driver now has support for connecting to its associated PHY device found through standard OF bindings. The PHY interraction is handled by PHYLINK and even though, at the moment, only RGMII_* phy modes are supported by the driver, this is just the first step into adding the necessary c

[PATCH net-next 2/4] bus: fsl-mc: add the fsl_mc_get_endpoint function

2019-10-21 Thread Ioana Ciornei
Using the newly added fsl_mc_get_endpoint function a fsl-mc driver can find its associated endpoint (another object at the other link of a MC firmware link). The API will be used in the following patch in order to discover the connected DPMAC object of a DPNI. Also, the fsl_mc_device_lookup funct

[PATCH net-next 3/4] dpaa2-eth: add MAC/PHY support through phylink

2019-10-21 Thread Ioana Ciornei
The dpaa2-eth driver now has support for connecting to its associated PHY device found through standard OF bindings. This happens when the DPNI object (that the driver probes on) gets connected to a DPMAC. When that happens, the device tree is looked up by the DPMAC ID, and the associated PHY bind

[PATCH net-next 4/4] net: documentation: add docs for MAC/PHY support in DPAA2

2019-10-21 Thread Ioana Ciornei
Add documentation file for the MAC/PHY support in the DPAA2 architecture. This describes the architecture and implementation of the interface between phylink and a DPAA2 network driver. Signed-off-by: Ioana Ciornei --- .../device_drivers/freescale/dpaa2/index.rst | 1 + .../freescale/dpa

Re: [PATCH bpf v4] xdp: Handle device unregister for devmap_hash map type

2019-10-21 Thread Alexei Starovoitov
On Sat, Oct 19, 2019 at 4:19 AM Toke Høiland-Jørgensen wrote: > > It seems I forgot to add handling of devmap_hash type maps to the device > unregister hook for devmaps. This omission causes devices to not be > properly released, which causes hangs. > > Fix this by adding the missing handler. > >

Re: [Intel-wired-lan] FW: [PATCH bpf-next 2/4] xsk: allow AF_XDP sockets to receive packets directly from a queue

2019-10-21 Thread Alexei Starovoitov
On Mon, Oct 21, 2019 at 1:10 PM Samudrala, Sridhar wrote: > > On 10/20/2019 10:12 AM, Björn Töpel wrote: > > On Sun, 20 Oct 2019 at 12:15, Toke Høiland-Jørgensen > > wrote: > >> > >> Alexei Starovoitov writes: > >> > >>> On Fri, Oct 18, 2019 at 05:45:26PM -0700, Samudrala, Sridhar wrote: >

Re: [PATCH 00/10 net-next] page_pool cleanups

2019-10-21 Thread Jonathan Lemon
On 21 Oct 2019, at 12:08, Saeed Mahameed wrote: > On Fri, 2019-10-18 at 16:32 -0700, Jonathan Lemon wrote: >> >> On 18 Oct 2019, at 13:50, Saeed Mahameed wrote: >> >>> On Wed, 2019-10-16 at 15:50 -0700, Jonathan Lemon wrote: This patch combines work from various people: - part of Tari

Re: [net-next] tcp: add TCP_INFO status for failed client TFO

2019-10-21 Thread Jason Baron
On 10/21/19 4:36 PM, Eric Dumazet wrote: > On Mon, Oct 21, 2019 at 12:53 PM Christoph Paasch wrote: >> > >> Actually, longterm I hope we would be able to get rid of the >> blackhole-detection and fallback heuristics. In a far distant future where >> these middleboxes have been weeded out ;-) >

[PATCH net-next v2 0/2] net: dsa: mv88e6xxx: Add support for port mirroring

2019-10-21 Thread Iwan R Timmer
This patch serie add support for port mirroring in the mv88e6xx switch driver. The first patch changes the set_egress_port function to allow different egress ports for egress and ingress traffic. The second patch adds the actual code for port mirroring support. Tested on a 88E6176 with: tc qdisc

[PATCH net-next v2 1/2] net: dsa: mv88e6xxx: Split monitor port configuration

2019-10-21 Thread Iwan R Timmer
Separate the configuration of the egress and ingress monitor port. This allows the port mirror functionality to do ingress and egress port mirroring to separate ports. Signed-off-by: Iwan R Timmer --- drivers/net/dsa/mv88e6xxx/chip.c| 9 - drivers/net/dsa/mv88e6xxx/chip.h| 3 ++

[PATCH net-next v2 2/2] net: dsa: mv88e6xxx: Add support for port mirroring

2019-10-21 Thread Iwan R Timmer
Add support for configuring port mirroring through the cls_matchall classifier. We do a full ingress and/or egress capture towards a capture port. It allows setting a different capture port for ingress and egress traffic. It keeps track of the mirrored ports and the destination ports to prevent ch

Re: [net-next] tcp: add TCP_INFO status for failed client TFO

2019-10-21 Thread Eric Dumazet
On Mon, Oct 21, 2019 at 12:53 PM Christoph Paasch wrote: > > Actually, longterm I hope we would be able to get rid of the > blackhole-detection and fallback heuristics. In a far distant future where > these middleboxes have been weeded out ;-) > > So, do we really want to eternalize this as part

Re: [PATCH net] net: openvswitch: free vport unless register_netdevice() succeeds

2019-10-21 Thread Gregory Rose
On 10/21/2019 3:01 AM, Stefano Brivio wrote: From: Hillf Danton syzbot found the following crash on: HEAD commit:1e78030e Merge tag 'mmc-v5.3-rc1' of git://git.kernel.org/.. git tree: upstream console output: https://syzkaller.appspot.com/x/log.txt?x=148d3d1a60 kernel config: ht

Re: [Intel-wired-lan] FW: [PATCH bpf-next 2/4] xsk: allow AF_XDP sockets to receive packets directly from a queue

2019-10-21 Thread Samudrala, Sridhar
On 10/20/2019 10:12 AM, Björn Töpel wrote: On Sun, 20 Oct 2019 at 12:15, Toke Høiland-Jørgensen wrote: Alexei Starovoitov writes: On Fri, Oct 18, 2019 at 05:45:26PM -0700, Samudrala, Sridhar wrote: On 10/18/2019 5:14 PM, Alexei Starovoitov wrote: On Fri, Oct 18, 2019 at 11:40:07AM -0700,

[PATCH net-next 1/4] flow_dissector: add meaningful comments

2019-10-21 Thread Matteo Croce
Documents two piece of code which can't be understood at a glance. Signed-off-by: Matteo Croce --- include/net/flow_dissector.h | 1 + net/core/flow_dissector.c| 6 ++ 2 files changed, 7 insertions(+) diff --git a/include/net/flow_dissector.h b/include/net/flow_dissector.h index 90bd210

[PATCH net-next 4/4] r8169: remove rtl_hw_start_8168bef

2019-10-21 Thread Heiner Kallweit
We can remove rtl_hw_start_8168bef() and use rtl_hw_start_8168b() instead because setting register Config4 is done in rtl_jumbo_config(), being called from rtl_hw_start(). Signed-off-by: Heiner Kallweit --- drivers/net/ethernet/realtek/r8169_main.c | 15 --- 1 file changed, 4 inserti

[PATCH net-next 3/4] r8169: remove rtl_hw_start_8168dp

2019-10-21 Thread Heiner Kallweit
We can remove rtl_hw_start_8168dp() because it's the same as rtl_hw_start_8168dp() now. Signed-off-by: Heiner Kallweit --- drivers/net/ethernet/realtek/r8169_main.c | 9 + 1 file changed, 1 insertion(+), 8 deletions(-) diff --git a/drivers/net/ethernet/realtek/r8169_main.c b/drivers/ne

[PATCH net-next 2/4] r8169: simplify setting PCI_EXP_DEVCTL_NOSNOOP_EN

2019-10-21 Thread Heiner Kallweit
r8168b_0_hw_jumbo_enable() and r8168b_0_hw_jumbo_disable() both do the same and just set PCI_EXP_DEVCTL_NOSNOOP_EN. We can simplify the code by moving this setting for RTL8168B to rtl_hw_start_8168(). Signed-off-by: Heiner Kallweit --- drivers/net/ethernet/realtek/r8169_main.c | 34 +++--

[PATCH net-next 1/4] r8169: remove fiddling with the PCIe max read request size

2019-10-21 Thread Heiner Kallweit
The attempt to improve performance by changing the PCIe max read request size was added in the vendor driver more than 10 years back and copied to r8169 driver. In the vendor driver this has been removed long ago. Obviously it had no effect, also in my tests I didn't see any difference. Typically t

[PATCH net-next 0/4] r8169: remove fiddling with the PCIe max read request size

2019-10-21 Thread Heiner Kallweit
The attempt to improve performance by changing the PCIe max read request size was added in the vendor driver more than 10 years back and copied to r8169 driver. In the vendor driver this has been removed long ago. Obviously it had no effect, also in my tests I didn't see any difference. Typically t

Re: [PATCH v14 4/5] tools/testing/selftests/bpf: Add self-tests for new helper.

2019-10-21 Thread Andrii Nakryiko
On Mon, Oct 21, 2019 at 12:14 PM Carlos Antonio Neira Bustos wrote: > > On Mon, Oct 21, 2019 at 11:20:01AM -0700, Andrii Nakryiko wrote: > > On Sat, Oct 19, 2019 at 1:58 AM Yonghong Song wrote: > > > > > > > > > > > > On 10/17/19 8:00 AM, Carlos Neira wrote: > > > > Self tests added for new helpe

Re: [PATCH v14 4/5] tools/testing/selftests/bpf: Add self-tests for new helper.

2019-10-21 Thread Carlos Antonio Neira Bustos
On Mon, Oct 21, 2019 at 11:20:01AM -0700, Andrii Nakryiko wrote: > On Sat, Oct 19, 2019 at 1:58 AM Yonghong Song wrote: > > > > > > > > On 10/17/19 8:00 AM, Carlos Neira wrote: > > > Self tests added for new helper > > > > > > Signed-off-by: Carlos Neira > > > --- > > > .../bpf/prog_tests/get_n

Re: [PATCH 00/10 net-next] page_pool cleanups

2019-10-21 Thread Saeed Mahameed
On Fri, 2019-10-18 at 16:32 -0700, Jonathan Lemon wrote: > > On 18 Oct 2019, at 13:50, Saeed Mahameed wrote: > > > On Wed, 2019-10-16 at 15:50 -0700, Jonathan Lemon wrote: > > > This patch combines work from various people: > > > - part of Tariq's work to move the DMA mapping from > > > the mlx

Re: [net-next] tcp: add TCP_INFO status for failed client TFO

2019-10-21 Thread William Dauchy
Hello Eric, On Mon, Oct 21, 2019 at 9:02 PM Eric Dumazet wrote: > Reporting tsval/tsecr values were not well defined and seemed quite > experimental to me. > > TCP fastopen would use 2 unused bits, not real extra cost here. > > This is persistent information after the connect(), while your tsval

Re: [PATCH bpf-next] libbpf: make LIBBPF_OPTS macro strictly a variable declaration

2019-10-21 Thread Jakub Sitnicki
On Mon, Oct 21, 2019 at 06:57 PM CEST, Andrii Nakryiko wrote: > LIBBPF_OPTS is implemented as a mix of field declaration and memset > + assignment. This makes it neither variable declaration nor purely > statements, which is a problem, because you can't mix it with either > other variable declarati

Re: [net-next] tcp: add TCP_INFO status for failed client TFO

2019-10-21 Thread Eric Dumazet
On 10/21/19 11:49 AM, William Dauchy wrote: > I'm curious what would be the arguments compared to creating a new > getsockopt() to fetch this data? Reporting tsval/tsecr values were not well defined and seemed quite experimental to me. TCP fastopen would use 2 unused bits, not real extra co

Re: [net-next] tcp: add TCP_INFO status for failed client TFO

2019-10-21 Thread William Dauchy
Hello Jason, On Sat, Oct 19, 2019 at 11:10 AM Jason Baron wrote: > The TCPI_OPT_SYN_DATA bit as part of tcpi_options currently reports whether > or not data-in-SYN was ack'd on both the client and server side. We'd like > to gather more information on the client-side in the failure case in order

Re: [net-next] tcp: add TCP_INFO status for failed client TFO

2019-10-21 Thread Jason Baron
On 10/21/19 2:02 PM, Yuchung Cheng wrote: > Thanks for the patch. Detailed comments below > > On Fri, Oct 18, 2019 at 4:58 PM Neal Cardwell wrote: >> >> On Fri, Oct 18, 2019 at 3:03 PM Jason Baron wrote: >>> >>> The TCPI_OPT_SYN_DATA bit as part of tcpi_options currently reports whether >>> o

Re: [PATCH net-next] net/sched: act_police: re-use tcf_tm_dump()

2019-10-21 Thread David Miller
From: Davide Caratti Date: Sat, 19 Oct 2019 18:49:32 +0200 > Use tcf_tm_dump(), instead of an open coded variant (no functional change > in this patch). > > Signed-off-by: Davide Caratti Applied.

Re: [PATCH v14 4/5] tools/testing/selftests/bpf: Add self-tests for new helper.

2019-10-21 Thread Andrii Nakryiko
On Sat, Oct 19, 2019 at 1:58 AM Yonghong Song wrote: > > > > On 10/17/19 8:00 AM, Carlos Neira wrote: > > Self tests added for new helper > > > > Signed-off-by: Carlos Neira > > --- > > .../bpf/prog_tests/get_ns_current_pid_tgid.c | 96 +++ > > .../bpf/progs/get_ns_current_pid

Re: [PATCH bpf-next] libbpf: make LIBBPF_OPTS macro strictly a variable declaration

2019-10-21 Thread Yonghong Song
On 10/21/19 10:38 AM, Andrii Nakryiko wrote: > On Mon, Oct 21, 2019 at 10:18 AM Toke Høiland-Jørgensen > wrote: >> >> Andrii Nakryiko writes: >> >>> LIBBPF_OPTS is implemented as a mix of field declaration and memset >>> + assignment. This makes it neither variable declaration nor purely >>> s

Re: Crash when receiving FIN-ACK in TCP_FIN_WAIT1 state

2019-10-21 Thread Josh Hunt
On Mon, Oct 21, 2019 at 10:42 AM Subash Abhinov Kasiviswanathan wrote: > > > Please give us a pointer to the exact git tree and sha1. > > > > I do not analyze TCP stack problems without an exact starting point, > > or at least a crystal ball, which I do not have. > > Hi Eric > > We are at this com

Re: [net-next] tcp: add TCP_INFO status for failed client TFO

2019-10-21 Thread Yuchung Cheng
Thanks for the patch. Detailed comments below On Fri, Oct 18, 2019 at 4:58 PM Neal Cardwell wrote: > > On Fri, Oct 18, 2019 at 3:03 PM Jason Baron wrote: > > > > The TCPI_OPT_SYN_DATA bit as part of tcpi_options currently reports whether > > or not data-in-SYN was ack'd on both the client and se

[net-next v3 2/5] e1000e: Add support for S0ix

2019-10-21 Thread Jeff Kirsher
From: Sasha Neftin Implement flow for S0ix support. Modern SoCs support S0ix low power states during idle periods, which are sub-states of ACPI S0 that increase power saving while supporting an instant-on experience for providing lower latency that ACPI S0. The S0ix states shut off parts of the S

[net-next v3 4/5] igc: Add Rx checksum support

2019-10-21 Thread Jeff Kirsher
From: Sasha Neftin Extend the socket buffer field process and add Rx checksum functionality Minor: fix indentation with tab instead of spaces. Signed-off-by: Sasha Neftin Tested-by: Aaron Brown Signed-off-by: Jeff Kirsher --- drivers/net/ethernet/intel/igc/igc_defines.h | 5 ++- drivers/net

[net-next v3 3/5] igc: Add set_rx_mode support

2019-10-21 Thread Jeff Kirsher
From: Sasha Neftin Add multicast addresses list to the MTA table. Implement basic Rx mode support. Add option for IPv6 address settings. Signed-off-by: Sasha Neftin Tested-by: Aaron Brown Signed-off-by: Jeff Kirsher --- drivers/net/ethernet/intel/igc/igc_defines.h | 3 + drivers/net/ethern

[net-next v3 1/5] igc: Add SCTP CRC checksumming functionality

2019-10-21 Thread Jeff Kirsher
From: Sasha Neftin Add stream control transmission protocol CRC checksum. Signed-off-by: Sasha Neftin Tested-by: Aaron Brown Signed-off-by: Jeff Kirsher --- drivers/net/ethernet/intel/igc/igc_main.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/ethernet/intel/igc/igc_main.c

[net-next v3 0/5][pull request] 1GbE Intel Wired LAN Driver Updates 2019-10-21

2019-10-21 Thread Jeff Kirsher
This series contains updates to e1000e and igc only. Sasha adds stream control transmission protocol (SCTP) CRC checksum support for igc. Also added S0ix support to the e1000e driver. Then added multicast support by adding the address list to the MTA table and providing the option for IPv6 addre

[net-next v3 5/5] igc: Clean up unused shadow_vfta pointer

2019-10-21 Thread Jeff Kirsher
From: Sasha Neftin VLAN filter table array not implemented yet and shadow_vfta pointer not used. Clean up the code and remove the unused shadow_vfta pointer. Signed-off-by: Sasha Neftin Tested-by: Aaron Brown Signed-off-by: Jeff Kirsher --- drivers/net/ethernet/intel/igc/igc.h | 1 - dr

Re: [ovs-dev] [PATCH net-next v4 05/10] net: openvswitch: optimize flow-mask looking up

2019-10-21 Thread William Tu
> > Hi Tonghao, > > > > Does this improve performance? After all, the original code simply > > check whether the mask is NULL, then goto next mask. > I tested the performance, but I disable the mask cache, and use the > dpdk-pktgen to generate packets: > The test ovs flow: > ovs-dpctl add-dp system

Re: [PATCH] ipv4: fix IPSKB_FRAG_PMTU handling with fragmentation

2019-10-21 Thread David Miller
From: Eric Dumazet Date: Sat, 19 Oct 2019 09:26:37 -0700 > This patch removes the iph field from the state structure, which is not > properly initialized. Instead, add a new field to make the "do we want > to set DF" be the state bit and move the code to set the DF flag from > ip_frag_next(). >

Re: [PATCH net-next 0/2] net: phy: marvell: support downshift as PHY tunable

2019-10-21 Thread David Miller
From: Heiner Kallweit Date: Sat, 19 Oct 2019 15:56:34 +0200 > So far downshift is implemented for one small use case only and can't > be controlled from userspace. So let's implement this feature properly > as a PHY tunable so that it can be controlled via ethtool. Series applied, thanks.

Re: [Intel-wired-lan] [PATCH] igb: dont drop packets if rx flow control is enabled

2019-10-21 Thread Alexander Duyck
On Mon, Oct 21, 2019 at 9:44 AM Robert Beckett wrote: > > If rx flow control has been enabled (via autoneg or forced), packets > should not be dropped due to rx descriptor ring exhaustion. Instead > pause frames should be used to apply back pressure. > > Move SRRCTL setup to its own function for e

Re: Crash when receiving FIN-ACK in TCP_FIN_WAIT1 state

2019-10-21 Thread Subash Abhinov Kasiviswanathan
Please give us a pointer to the exact git tree and sha1. I do not analyze TCP stack problems without an exact starting point, or at least a crystal ball, which I do not have. Hi Eric We are at this commit - Merge 4.19.75 into android-4.19-q. https://android.googlesource.com/kernel/common/+/cf

Re: [PATCH net-next 1/1] tc-testing: updated pedit TDC tests

2019-10-21 Thread David Miller
From: Roman Mashak Date: Sat, 19 Oct 2019 09:45:53 -0400 > Added test cases for IP header operations: > - set tos/precedence > - add value to tos/precedence > - clear tos/precedence > - invert tos/precedence > > Signed-off-by: Roman Mashak Applied.

Re: [PATCH bpf-next] libbpf: make LIBBPF_OPTS macro strictly a variable declaration

2019-10-21 Thread Andrii Nakryiko
On Mon, Oct 21, 2019 at 10:18 AM Toke Høiland-Jørgensen wrote: > > Andrii Nakryiko writes: > > > LIBBPF_OPTS is implemented as a mix of field declaration and memset > > + assignment. This makes it neither variable declaration nor purely > > statements, which is a problem, because you can't mix it

Re: [PATCH v5 net-next 0/7] add XDP support to mvneta driver

2019-10-21 Thread David Miller
From: Lorenzo Bianconi Date: Sat, 19 Oct 2019 10:13:20 +0200 > Add XDP support to mvneta driver for devices that rely on software > buffer management. Supported verdicts are: > - XDP_DROP > - XDP_PASS > - XDP_REDIRECT > - XDP_TX > Moreover set ndo_xdp_xmit net_device_ops function pointer in order

Re: [PATCH net-next 1/2] UDP tunnel encapsulation module for tunnelling different protocols like MPLS,IP,NSH etc.

2019-10-21 Thread Jiri Benc
On Fri, 18 Oct 2019 13:03:56 -0700, Tom Herbert wrote: > More specifically fou allows encapsulation of anything that has an IP > protocol number. That includes an L3 protocols that have been assigned > a number (e.g. MPLS, GRE, IPv6, IPv4, EtherIP). So the only need for > an alternate method to do

Re: [PATCH bpf-next] libbpf: make LIBBPF_OPTS macro strictly a variable declaration

2019-10-21 Thread Toke Høiland-Jørgensen
Andrii Nakryiko writes: > LIBBPF_OPTS is implemented as a mix of field declaration and memset > + assignment. This makes it neither variable declaration nor purely > statements, which is a problem, because you can't mix it with either > other variable declarations nor other function statements, b

Re: [ovs-dev] [PATCH net-next v4 00/10] optimize openvswitch flow looking up

2019-10-21 Thread William Tu
On Wed, Oct 16, 2019 at 5:50 AM wrote: > > From: Tonghao Zhang > > This series patch optimize openvswitch for performance or simplify > codes. > > Patch 1, 2, 4: Port Pravin B Shelar patches to > linux upstream with little changes. btw, should we keep Pravin as the author of the above three patc

[PATCH bpf-next] libbpf: make LIBBPF_OPTS macro strictly a variable declaration

2019-10-21 Thread Andrii Nakryiko
LIBBPF_OPTS is implemented as a mix of field declaration and memset + assignment. This makes it neither variable declaration nor purely statements, which is a problem, because you can't mix it with either other variable declarations nor other function statements, because C90 compiler mode emits war

[PATCH] igb: dont drop packets if rx flow control is enabled

2019-10-21 Thread Robert Beckett
If rx flow control has been enabled (via autoneg or forced), packets should not be dropped due to rx descriptor ring exhaustion. Instead pause frames should be used to apply back pressure. Move SRRCTL setup to its own function for easy reuse and only set drop enable bit if rx flow control is not e

Re: [PATCH 1/3] ethtool: correctly interpret bitrate of 255

2019-10-21 Thread Simon Horman
On Mon, Oct 21, 2019 at 09:09:44AM +0100, Russell King - ARM Linux admin wrote: > On Mon, Oct 21, 2019 at 09:40:31AM +0200, Simon Horman wrote: > > On Fri, Oct 18, 2019 at 09:31:13PM +0100, Russell King wrote: > > > From: Russell King > > > > > > A bitrate of 255 is special, it means the bitrate

Re: [pull request][net 00/15] Mellanox, mlx5 kTLS fixes 18-10-2019

2019-10-21 Thread David Miller
From: Saeed Mahameed Date: Fri, 18 Oct 2019 19:37:59 + > This series introduces kTLS related fixes to mlx5 driver from Tariq, > and two misc memory leak fixes form Navid Emamdoost. > > Please pull and let me know if there is any problem. Puleld. > I would appreciate it if you queue up kTLS

Re: [patch net-next v3 3/3] devlink: add format requirement for devlink object names

2019-10-21 Thread David Ahern
On 10/21/19 9:56 AM, Jiri Pirko wrote: > > I forgot to update the desc. Uppercase chars are now allowed as Andrew > requested. Regarding dash, it could be allowed of course. But why isn't > "_" enough. I mean, I think it would be good to maintain allowed chars > within a limit. That's a personal

Re: [PATCH bpf v4] xdp: Handle device unregister for devmap_hash map type

2019-10-21 Thread Martin Lau
On Sat, Oct 19, 2019 at 01:19:31PM +0200, Toke Høiland-Jørgensen wrote: > It seems I forgot to add handling of devmap_hash type maps to the device > unregister hook for devmaps. This omission causes devices to not be > properly released, which causes hangs. > > Fix this by adding the missing handl

Re: [patch net-next v3 3/3] devlink: add format requirement for devlink object names

2019-10-21 Thread Jiri Pirko
Mon, Oct 21, 2019 at 05:20:07PM CEST, dsah...@gmail.com wrote: >On 10/21/19 8:26 AM, Jiri Pirko wrote: >> From: Jiri Pirko >> >> Currently, the name format is not required by the code, however it is >> required during patch review. All params added until now are in-lined >> with the following for

Re: [PATCH bpf-next v2] libbpf: use implicit XSKMAP lookup from AF_XDP XDP program

2019-10-21 Thread Toke Høiland-Jørgensen
Björn Töpel writes: > On Mon, 21 Oct 2019 at 15:37, Björn Töpel wrote: >> >> On Mon, 21 Oct 2019 at 14:19, Toke Høiland-Jørgensen wrote: >> > >> > Björn Töpel writes: >> > >> [...] >> > > >> > > bpf_redirect_map() returns a 32-bit signed int, so the upper 32-bit >> > > will need to be cleared.

Re: [PATCH] net: forcedeth: add xmit_more support

2019-10-21 Thread Jakub Kicinski
On Mon, 21 Oct 2019 17:56:06 +0800, Zhu Yanjun wrote: > On 2019/10/19 6:48, Jakub Kicinski wrote: > > On Fri, 18 Oct 2019 06:01:25 -0400, Zhu Yanjun wrote: > >> This change adds support for xmit_more based on the igb commit 6f19e12f6230 > >> ("igb: flush when in xmit_more mode and under descripto

  1   2   >