Mon, Oct 21, 2019 at 05:20:07PM CEST, dsah...@gmail.com wrote: >On 10/21/19 8:26 AM, Jiri Pirko wrote: >> From: Jiri Pirko <j...@mellanox.com> >> >> Currently, the name format is not required by the code, however it is >> required during patch review. All params added until now are in-lined >> with the following format: >> 1) lowercase characters, digits and underscored are allowed >> 2) underscore is neither at the beginning nor at the end and >> there is no more than one in a row. >> >> Add checker to the code to require this format from drivers and warn if >> they don't follow. This applies to params, resources, reporters, >> traps, trap groups, dpipe tables and dpipe fields. >> > >This seems random and without any real cause. There is no reason to >exclude dash and uppercase for example in the names.
I forgot to update the desc. Uppercase chars are now allowed as Andrew requested. Regarding dash, it could be allowed of course. But why isn't "_" enough. I mean, I think it would be good to maintain allowed chars within a limit. >
