On Mon, 21 Oct 2019 02:08:21 +0200, Linus Walleij wrote: > Using the devm_alloc_etherdev() function simplifies the error > path. I also patch the message to use dev_info(). > > Signed-off-by: Linus Walleij <linus.wall...@linaro.org> > --- > drivers/net/ethernet/xscale/ixp4xx_eth.c | 18 ++++++------------ > 1 file changed, 6 insertions(+), 12 deletions(-) > > diff --git a/drivers/net/ethernet/xscale/ixp4xx_eth.c > b/drivers/net/ethernet/xscale/ixp4xx_eth.c > index fbe328693de5..df18d8ebb170 100644 > --- a/drivers/net/ethernet/xscale/ixp4xx_eth.c > +++ b/drivers/net/ethernet/xscale/ixp4xx_eth.c > @@ -1378,7 +1378,7 @@ static int ixp4xx_eth_probe(struct platform_device > *pdev) > > plat = dev_get_platdata(dev); > > - if (!(ndev = alloc_etherdev(sizeof(struct port)))) > + if (!(ndev = devm_alloc_etherdev(dev, sizeof(struct port)))) > return -ENOMEM; > > SET_NETDEV_DEV(ndev, dev);
Okay, I see you do devm_ here.. please reorder the patches, then.
