[PATCH net-next v2 1/3] flow_offload: move tc indirect block to flow offload

2019-07-25 Thread wenxu
From: wenxu move tc indirect block to flow_offload and rename it to flow indirect block.The nf_tables can use the indr block architecture. Signed-off-by: wenxu --- v2: make use of flow_block from Pablo flow_indr_rhashtable_init advice by jakub.kicinski drivers/net/ethernet/mellanox/mlx5/

[PATCH net-next v2 0/3] flow_offload: add indr-block in nf_table_offload

2019-07-25 Thread wenxu
From: wenxu This series patch make nftables offload support the vlan and tunnel device offload through indr-block architecture. The first patch mv tc indr block to flow offload and rename to flow-indr-block. Because the new flow-indr-block can't get the tcf_block directly. The second patch provi

[PATCH net-next v2 3/3] netfilter: nf_tables_offload: support indr block call

2019-07-25 Thread wenxu
From: wenxu nftable support indr-block call. It makes nftable an offload vlan and tunnel device. nft add table netdev firewall nft add chain netdev firewall aclout { type filter hook ingress offload device mlx_pf0vf0 priority - 300 \; } nft add rule netdev firewall aclout ip daddr 10.0.0.1 fwd

[PATCH net-next v2 2/3] flow_offload: Support get tcf block immediately

2019-07-25 Thread wenxu
From: wenxu Because the new flow-indr-block can't get the tcf_block directly. It provide a callback to find the tcf block immediately when the device register and contain a ingress block. Signed-off-by: wenxu --- v2: make use of flow_block include/net/flow_offload.h | 4 net/core/flow_o

Re: [PATCH bpf-next 2/6] bpf: add BPF_MAP_DUMP command to dump more than one entry per call

2019-07-25 Thread Yonghong Song
On 7/25/19 6:47 PM, Alexei Starovoitov wrote: > On Thu, Jul 25, 2019 at 6:24 PM Brian Vazquez > wrote: >> >> On Thu, Jul 25, 2019 at 4:54 PM Alexei Starovoitov >> wrote: >>> >>> On Thu, Jul 25, 2019 at 04:25:53PM -0700, Brian Vazquez wrote: >>> If prev_key is deleted before map_get_next_ke

Re: [PATCH bpf-next 2/6] bpf: add BPF_MAP_DUMP command to dump more than one entry per call

2019-07-25 Thread Alexei Starovoitov
On Thu, Jul 25, 2019 at 6:24 PM Brian Vazquez wrote: > > On Thu, Jul 25, 2019 at 4:54 PM Alexei Starovoitov > wrote: > > > > On Thu, Jul 25, 2019 at 04:25:53PM -0700, Brian Vazquez wrote: > > > > > > If prev_key is deleted before map_get_next_key(), we get the first > > > > > > key > > > > > > a

Re: [PATCH net-next 07/11] net: hns3: adds debug messages to identify eth down cause

2019-07-25 Thread Jakub Kicinski
On Thu, 25 Jul 2019 21:59:08 +, Saeed Mahameed wrote: > I couldn't find any rules regarding what to put in kernel log, Maybe > someone can share ?. but i vaguely remember that the recommendation > for device drivers is to put nothing, only error/warning messages. FWIW my understanding is also

Re: [PATCH bpf-next 2/6] bpf: add BPF_MAP_DUMP command to dump more than one entry per call

2019-07-25 Thread Brian Vazquez
On Thu, Jul 25, 2019 at 4:54 PM Alexei Starovoitov wrote: > > On Thu, Jul 25, 2019 at 04:25:53PM -0700, Brian Vazquez wrote: > > > > > If prev_key is deleted before map_get_next_key(), we get the first key > > > > > again. This is pretty weird. > > > > > > > > Yes, I know. But note that the curren

RE: [PATCH 0/8] can: flexcan: add CAN FD support for NXP Flexcan

2019-07-25 Thread Joakim Zhang
> -Original Message- > From: Marc Kleine-Budde > Sent: 2019年7月25日 18:37 > To: Joakim Zhang ; linux-...@vger.kernel.org > Cc: w...@grandegger.com; dl-linux-imx ; > netdev@vger.kernel.org > Subject: Re: [PATCH 0/8] can: flexcan: add CAN FD support for NXP Flexcan > > On 7/25/19 9:53 AM, Ma

Re: [PATCH bpf-next v3 0/7] bpf/flow_dissector: support input flags

2019-07-25 Thread Alexei Starovoitov
On Thu, Jul 25, 2019 at 3:52 PM Stanislav Fomichev wrote: > > C flow dissector supports input flags that tell it to customize parsing > by either stopping early or trying to parse as deep as possible. > BPF flow dissector always parses as deep as possible which is sub-optimal. > Pass input flags t

Re: [PATCH bpf-next v10 0/2] bpf: Allow bpf_skb_event_output for more prog types

2019-07-25 Thread Alexei Starovoitov
On Tue, Jul 23, 2019 at 5:07 PM Allan Zhang wrote: > > Software event output is only enabled by a few prog types right now (TC, > LWT out, XDP, sockops). Many other skb based prog types need > bpf_skb_event_output to produce software event. > > More prog types are enabled to access bpf_skb_event_o

Re: pull-request: bpf 2019-07-25

2019-07-25 Thread David Miller
From: Alexei Starovoitov Date: Thu, 25 Jul 2019 10:35:41 -0700 > The following pull-request contains BPF updates for your *net* tree. > > The main changes are: > > 1) fix segfault in libbpf, from Andrii. > > 2) fix gso_segs access, from Eric. > > 3) tls/sockmap fixes, from Jakub and John. >

Re: [PATCH net] selftests/net: add missing gitignores (ipv6_flowlabel)

2019-07-25 Thread David Miller
From: Jakub Kicinski Date: Wed, 24 Jul 2019 17:07:14 -0700 > ipv6_flowlabel and ipv6_flowlabel_mgr are missing from > gitignore. Quentin points out that the original > commit 3fb321fde22d ("selftests/net: ipv6 flowlabel") > did add ignore entries, they are just missing the "ipv6_" > prefix. > >

Re: [PATCH v4 net-next 18/19] ionic: Add coalesce and other features

2019-07-25 Thread Saeed Mahameed
On Mon, 2019-07-22 at 14:40 -0700, Shannon Nelson wrote: > Interrupt coalescing, tunable copybreak value, and > tx timeout. > > Signed-off-by: Shannon Nelson > --- > drivers/net/ethernet/pensando/ionic/ionic.h | 2 +- > .../ethernet/pensando/ionic/ionic_ethtool.c | 105 > ++

Re: [PATCH net 1/1] bnx2x: Disable multi-cos feature.

2019-07-25 Thread David Miller
From: Sudarsana Reddy Kalluru Date: Tue, 23 Jul 2019 19:32:41 -0700 > Commit 3968d38917eb ("bnx2x: Fix Multi-Cos.") which enabled multi-cos > feature after prolonged time in driver added some regression causing > numerous issues (sudden reboots, tx timeout etc.) reported by customers. > We plan t

Re: [PATCH v4 net-next 15/19] ionic: Add netdev-event handling

2019-07-25 Thread Saeed Mahameed
On Mon, 2019-07-22 at 14:40 -0700, Shannon Nelson wrote: > When the netdev gets a new name from userland, pass that name > down to the NIC for internal tracking. > Just out of curiosity, why your NIC internal device/firmware need to keep tracking of the netdev name ?

Re: [PATCH v4 net-next 14/19] ionic: Add Tx and Rx handling

2019-07-25 Thread Saeed Mahameed
On Mon, 2019-07-22 at 14:40 -0700, Shannon Nelson wrote: > Add both the Tx and Rx queue setup and handling. The related > stats display comes later. Instead of using the generic napi > routines used by the slow-path commands, the Tx and Rx paths > are simplified and inlined in one file in order t

Re: [PATCH bpf-next 06/10] selftests/bpf: add CO-RE relocs array tests

2019-07-25 Thread Alexei Starovoitov
On Wed, Jul 24, 2019 at 12:27:38PM -0700, Andrii Nakryiko wrote: > Add tests for various array handling/relocation scenarios. > > Signed-off-by: Andrii Nakryiko ... > + > +#define CORE_READ(dst, src) \ > + bpf_probe_read(dst, sizeof(*src), __builtin_preserve_access_index(src)) This is the ke

Re: [PATCH bpf-next 02/10] libbpf: implement BPF CO-RE offset relocation algorithm

2019-07-25 Thread Alexei Starovoitov
On Wed, Jul 24, 2019 at 12:27:34PM -0700, Andrii Nakryiko wrote: > This patch implements the core logic for BPF CO-RE offsets relocations. > All the details are described in code comments. > > Signed-off-by: Andrii Nakryiko > --- > tools/lib/bpf/libbpf.c | 866 +++

Re: [net-next 0/2] tipc: link changeover issues

2019-07-25 Thread David Miller
From: Tuong Lien Date: Wed, 24 Jul 2019 08:56:10 +0700 > This patch series is to resolve some issues found with the current link > changeover mechanism, it also includes an optimization for the link > synching. Series applied, thank you.

[PATCH bpf-next v3 6/7] bpf/flow_dissector: support ipv6 flow_label and BPF_FLOW_DISSECTOR_F_STOP_AT_FLOW_LABEL

2019-07-25 Thread Stanislav Fomichev
Add support for exporting ipv6 flow label via bpf_flow_keys. Export flow label from bpf_flow.c and also return early when BPF_FLOW_DISSECTOR_F_STOP_AT_FLOW_LABEL is passed. Acked-by: Petar Penkov Acked-by: Willem de Bruijn Acked-by: Song Liu Cc: Song Liu Cc: Willem de Bruijn Cc: Petar Penkov

[PATCH bpf-next v3 3/7] bpf/flow_dissector: support flags in BPF_PROG_TEST_RUN

2019-07-25 Thread Stanislav Fomichev
This will allow us to write tests for those flags. v2: * Swap kfree(data) and kfree(user_ctx) (Song Liu) Acked-by: Petar Penkov Acked-by: Willem de Bruijn Acked-by: Song Liu Cc: Song Liu Cc: Willem de Bruijn Cc: Petar Penkov Signed-off-by: Stanislav Fomichev --- net/bpf/test_run.c | 39 ++

[PATCH bpf-next v3 2/7] bpf/flow_dissector: document flags

2019-07-25 Thread Stanislav Fomichev
Describe what each input flag does and who uses it. Acked-by: Petar Penkov Acked-by: Willem de Bruijn Acked-by: Song Liu Cc: Song Liu Cc: Willem de Bruijn Cc: Petar Penkov Signed-off-by: Stanislav Fomichev --- Documentation/bpf/prog_flow_dissector.rst | 18 ++ 1 file change

[PATCH bpf-next v3 0/7] bpf/flow_dissector: support input flags

2019-07-25 Thread Stanislav Fomichev
C flow dissector supports input flags that tell it to customize parsing by either stopping early or trying to parse as deep as possible. BPF flow dissector always parses as deep as possible which is sub-optimal. Pass input flags to the BPF flow dissector as well so it can make the same decisions.

[PATCH bpf-next v3 1/7] bpf/flow_dissector: pass input flags to BPF flow dissector program

2019-07-25 Thread Stanislav Fomichev
C flow dissector supports input flags that tell it to customize parsing by either stopping early or trying to parse as deep as possible. Pass those flags to the BPF flow dissector so it can make the same decisions. In the next commits I'll add support for those flags to our reference bpf_flow.c v3

[PATCH bpf-next v3 4/7] tools/bpf: sync bpf_flow_keys flags

2019-07-25 Thread Stanislav Fomichev
Export bpf_flow_keys flags to tools/libbpf/selftests. Acked-by: Petar Penkov Acked-by: Willem de Bruijn Acked-by: Song Liu Cc: Song Liu Cc: Willem de Bruijn Cc: Petar Penkov Signed-off-by: Stanislav Fomichev --- tools/include/uapi/linux/bpf.h | 5 + 1 file changed, 5 insertions(+) dif

[PATCH bpf-next v3 5/7] selftests/bpf: support BPF_FLOW_DISSECTOR_F_PARSE_1ST_FRAG

2019-07-25 Thread Stanislav Fomichev
bpf_flow.c: exit early unless BPF_FLOW_DISSECTOR_F_PARSE_1ST_FRAG is passed in flags. Also, set ip_proto earlier, this makes sure we have correct value with fragmented packets. Add selftest cases to test ipv4/ipv6 fragments and skip eth_get_headlen tests that don't have BPF_FLOW_DISSECTOR_F_PARSE_

[PATCH bpf-next v3 7/7] selftests/bpf: support BPF_FLOW_DISSECTOR_F_STOP_AT_ENCAP

2019-07-25 Thread Stanislav Fomichev
Exit as soon as we found that packet is encapped when BPF_FLOW_DISSECTOR_F_STOP_AT_ENCAP is passed. Add appropriate selftest cases. v2: * Subtract sizeof(struct iphdr) from .iph_inner.tot_len (Willem de Bruijn) Acked-by: Petar Penkov Acked-by: Willem de Bruijn Acked-by: Song Liu Cc: Song Liu

Re: [PATCH net-next 1/2] net sched: update skbedit action for batched events operations

2019-07-25 Thread Roman Mashak
David Miller writes: > From: Roman Mashak > Date: Fri, 12 Jul 2019 18:21:59 -0400 > >> Add get_fill_size() routine used to calculate the action size >> when building a batch of events. >> >> Signed-off-by: Roman Mashak > > Please add an appropriate Fixes: tag, and also when you respin this pro

Re: [PATCH net-next 2/2] mlx4/en_netdev: call notifiers when hw_enc_features change

2019-07-25 Thread Saeed Mahameed
On Thu, 2019-07-25 at 14:25 +0200, Davide Caratti wrote: > On Wed, 2019-07-24 at 20:47 +, Saeed Mahameed wrote: > > On Wed, 2019-07-24 at 16:02 +0200, Davide Caratti wrote: > > > ensure to call netdev_features_change() when the driver flips its > > > hw_enc_features bits. > > > > > > Signed-of

Re: [PATCH] net/mlx5e: Fix zero table prio set by user.

2019-07-25 Thread Saeed Mahameed
On Thu, 2019-07-25 at 19:24 +0800, we...@ucloud.cn wrote: > From: wenxu > > The flow_cls_common_offload prio is zero > > It leads the invalid table prio in hw. > > Error: Could not process rule: Invalid argument > > kernel log: > mlx5_core :81:00.0: E-Switch: Failed to create FDB Table err

Re: [PATCH net-next 2/2] qed: Add API for flashing the nvm attributes.

2019-07-25 Thread Saeed Mahameed
On Thu, 2019-07-25 at 00:48 +, Sudarsana Reddy Kalluru wrote: > > > > > -Original Message- > > From: Saeed Mahameed > > Sent: Thursday, July 25, 2019 1:13 AM > > To: Sudarsana Reddy Kalluru ; > > da...@davemloft.net > > Cc: Ariel Elior ; Michal Kalderon > > ; netdev@vger.kernel.org >

Re: [net 9/9] Documentation: TLS: fix stat counters description

2019-07-25 Thread Jakub Kicinski
On Thu, 25 Jul 2019 20:36:52 +, Saeed Mahameed wrote: > From: Tariq Toukan > > Add missing description of counters. > Split tx_tls_encrypted counter into two, to give packets > and bytes indications. > > Fixes: f42c104f2ec9 ("Documentation: add TLS offload documentation") > Suggested-by: Jak

Re: [net 8/9] nfp: tls: rename tls packet counters

2019-07-25 Thread Jakub Kicinski
On Thu, 25 Jul 2019 20:36:50 +, Saeed Mahameed wrote: > From: Tariq Toukan > > Align to the naming convention in TLS documentation. > > Fixes: 51a5e563298d ("nfp: tls: add basic statistics") > Suggested-by: Jakub Kicinski > Signed-off-by: Tariq Toukan > Signed-off-by: Saeed Mahameed Acke

Re: [net 7/9] net/mlx5e: kTLS, Call WARN_ONCE on netdev mismatch

2019-07-25 Thread Jakub Kicinski
On Thu, 25 Jul 2019 20:36:48 +, Saeed Mahameed wrote: > From: Tariq Toukan > > A netdev mismatch in the processed TLS SKB should not occur, > and indicates a kernel bug. > Add WARN_ONCE to spot such cases. > > Fixes: d2ead1f360e8 ("net/mlx5e: Add kTLS TX HW offload support") > Suggested-by:

Re: [net 7/9] net/mlx5e: kTLS, Call WARN_ONCE on netdev mismatch

2019-07-25 Thread Jakub Kicinski
On Thu, 25 Jul 2019 20:36:48 +, Saeed Mahameed wrote: > From: Tariq Toukan > > A netdev mismatch in the processed TLS SKB should not occur, > and indicates a kernel bug. > Add WARN_ONCE to spot such cases. > > Fixes: d2ead1f360e8 ("net/mlx5e: Add kTLS TX HW offload support") > Suggested-by:

[net 7/9] net/mlx5e: kTLS, Call WARN_ONCE on netdev mismatch

2019-07-25 Thread Saeed Mahameed
From: Tariq Toukan A netdev mismatch in the processed TLS SKB should not occur, and indicates a kernel bug. Add WARN_ONCE to spot such cases. Fixes: d2ead1f360e8 ("net/mlx5e: Add kTLS TX HW offload support") Suggested-by: Jakub Kicinski Signed-off-by: Tariq Toukan Signed-off-by: Saeed Mahameed

[net 8/9] nfp: tls: rename tls packet counters

2019-07-25 Thread Saeed Mahameed
From: Tariq Toukan Align to the naming convention in TLS documentation. Fixes: 51a5e563298d ("nfp: tls: add basic statistics") Suggested-by: Jakub Kicinski Signed-off-by: Tariq Toukan Signed-off-by: Saeed Mahameed --- drivers/net/ethernet/netronome/nfp/nfp_net_ethtool.c | 4 ++-- 1 file chan

[net 9/9] Documentation: TLS: fix stat counters description

2019-07-25 Thread Saeed Mahameed
From: Tariq Toukan Add missing description of counters. Split tx_tls_encrypted counter into two, to give packets and bytes indications. Fixes: f42c104f2ec9 ("Documentation: add TLS offload documentation") Suggested-by: Jakub Kicinski Signed-off-by: Tariq Toukan Signed-off-by: Saeed Mahameed -

[net 2/9] net/mlx5: Add missing RDMA_RX capabilities

2019-07-25 Thread Saeed Mahameed
From: Maor Gottlieb New flow table type RDMA_RX was added but the MLX5_CAP_FLOW_TABLE_TYPE didn't handle this new flow table type. This means that MLX5_CAP_FLOW_TABLE_TYPE returns an empty capability to this flow table type. Update both the macro and the maximum supported flow table type to RDMA

[net 6/9] net/mlx5e: Prevent encap flow counter update async to user query

2019-07-25 Thread Saeed Mahameed
From: Ariel Levkovich This patch prevents a race between user invoked cached counters query and a neighbor last usage updater. The cached flow counter stats can be queried by calling "mlx5_fc_query_cached" which provides the number of bytes and packets that passed via this flow since the last ti

[net 3/9] net/mlx5: Fix modify_cq_in alignment

2019-07-25 Thread Saeed Mahameed
From: Edward Srouji Fix modify_cq_in alignment to match the device specification. After this fix the 'cq_umem_valid' field will be in the right offset. Cc: # 4.19 Fixes: bd37197554eb ("net/mlx5: Update mlx5_ifc with DEVX UID bits") Signed-off-by: Edward Srouji Reviewed-by: Yishai Hadas Signed

[net 4/9] net/mlx5e: Fix wrong max num channels indication

2019-07-25 Thread Saeed Mahameed
From: Tariq Toukan No XSK support in the enhanced IPoIB driver and representors. Add a profile property to specify this, and enhance the logic that calculates the max number of channels to take it into account. Fixes: db05815b36cb ("net/mlx5e: Add XSK zero-copy support") Signed-off-by: Tariq Tou

[net 5/9] net/mlx5e: Fix matching of speed to PRM link modes

2019-07-25 Thread Saeed Mahameed
From: Aya Levin Speed translation is performed based on legacy or extended PTYS register. Translate speed with respect to: 1) Capability bit of extended PTYS table. 2) User request: a) When auto-negotiation is turned on, inspect advertisement whether it contains extended link modes. b) When au

[net 1/9] net/mlx5: Use reversed order when unregister devices

2019-07-25 Thread Saeed Mahameed
From: Mark Zhang When lag is active, which is controlled by the bonded mlx5e netdev, mlx5 interface unregestering must happen in the reverse order where rdma is unregistered (unloaded) first, to guarantee all references to the lag context in hardware is removed, then remove mlx5e netdev interface

[pull request][net 0/9] Mellanox, mlx5 fixes 2019-07-25

2019-07-25 Thread Saeed Mahameed
Hi Dave, This series introduces some fixes to mlx5 driver. 1) Ariel is addressing an issue with enacp flow counter race condition 2) Aya fixes ethtool speed handling 3) Edward fixes modify_cq hw bits alignment 4) Maor fixes RDMA_RX capabilities handling 5) Mark reverses unregister devices order

Re: [PATCH] sis900: add support for ethtool's EEPROM dump

2019-07-25 Thread Andrew Lunn
On Thu, Jul 25, 2019 at 09:48:06PM +0200, Sergej Benilov wrote: > Implement ethtool's EEPROM dump command (ethtool -e|--eeprom-dump). > > Thx to Andrew Lunn for comments. > > Signed-off-by: Sergej Benilov Reviewed-by: Andrew Lunn Andrew

Re: [PATCH bpf-next v2 1/7] bpf/flow_dissector: pass input flags to BPF flow dissector program

2019-07-25 Thread Stanislav Fomichev
On 07/25, Alexei Starovoitov wrote: > On Thu, Jul 25, 2019 at 08:33:36AM -0700, Stanislav Fomichev wrote: > > C flow dissector supports input flags that tell it to customize parsing > > by either stopping early or trying to parse as deep as possible. Pass > > those flags to the BPF flow dissector s

Re: [PATCH bpf-next v2 1/7] bpf/flow_dissector: pass input flags to BPF flow dissector program

2019-07-25 Thread Alexei Starovoitov
On Thu, Jul 25, 2019 at 08:33:36AM -0700, Stanislav Fomichev wrote: > C flow dissector supports input flags that tell it to customize parsing > by either stopping early or trying to parse as deep as possible. Pass > those flags to the BPF flow dissector so it can make the same > decisions. In the n

Re: [PATCH v6 rdma-next 1/6] RDMA/core: Create mmap database and cookie helper functions

2019-07-25 Thread Jason Gunthorpe
On Thu, Jul 25, 2019 at 07:34:15PM +, Michal Kalderon wrote: > > > + ibdev_dbg(ucontext->device, > > > + "mmap: obj[0x%p] key[%#llx] addr[%#llx] len[%#llx] > > removed\n", > > > + entry->obj, key, entry->address, entry->length); > > > + > > > + return entry; > > > +} > > > +

Re: [PATCH] sis900: add support for ethtool --eeprom-dump

2019-07-25 Thread Sergej Benilov
On Thu, 25 Jul 2019 at 20:20, Andrew Lunn wrote: > > On Thu, Jul 25, 2019 at 06:41:41PM +0200, Sergej Benilov wrote: > > On Thu, 25 Jul 2019 at 18:25, Andrew Lunn wrote: > > > > > > > +static int sis900_read_eeprom(struct net_device *net_dev, u8 *buf) > > > > +{ > > > > + struct sis900_privat

[PATCH] sis900: add support for ethtool's EEPROM dump

2019-07-25 Thread Sergej Benilov
Implement ethtool's EEPROM dump command (ethtool -e|--eeprom-dump). Thx to Andrew Lunn for comments. Signed-off-by: Sergej Benilov --- drivers/net/ethernet/sis/sis900.c | 68 +++ 1 file changed, 68 insertions(+) diff --git a/drivers/net/ethernet/sis/sis900.c b/driv

RE: [EXT] Re: [PATCH v6 rdma-next 0/6] RDMA/qedr: Use the doorbell overflow recovery mechanism for RDMA

2019-07-25 Thread Michal Kalderon
> From: Jason Gunthorpe > Sent: Thursday, July 25, 2019 9:02 PM > > External Email > > -- > On Tue, Jul 09, 2019 at 05:17:29PM +0300, Michal Kalderon wrote: > > This patch series uses the doorbell overflow recovery mechanism > >

RE: [EXT] Re: [PATCH v6 rdma-next 5/6] RDMA/qedr: Add doorbell overflow recovery support

2019-07-25 Thread Michal Kalderon
> From: Jason Gunthorpe > Sent: Thursday, July 25, 2019 9:01 PM > > External Email > > -- > On Tue, Jul 09, 2019 at 05:17:34PM +0300, Michal Kalderon wrote: > > > +static int qedr_init_user_db_rec(struct ib_udata *udata, > > +

[PATCH v3 03/14] NFC: nxp-nci: Get rid of platform data

2019-07-25 Thread Andy Shevchenko
Legacy platform data must go away. We are on the safe side here since there are no users of it in the kernel. If anyone by any odd reason needs it the GPIO lookup tables and built-in device properties at your service. Signed-off-by: Andy Shevchenko Tested-by: Sedat Dilek --- MAINTAINERS

[PATCH v3 06/14] NFC: nxp-nci: Get rid of code duplication in ->probe()

2019-07-25 Thread Andy Shevchenko
Since OF and ACPI case almost the same get rid of code duplication by moving gpiod_get() calls directly to ->probe(). Signed-off-by: Andy Shevchenko Tested-by: Sedat Dilek --- drivers/nfc/nxp-nci/i2c.c | 68 +-- 1 file changed, 15 insertions(+), 53 deletions(

[PATCH v3 09/14] NFC: nxp-nci: Drop of_match_ptr() use

2019-07-25 Thread Andy Shevchenko
There is no need to guard OF device ID table with of_match_ptr(). Otherwise we would get a defined but not used data. Signed-off-by: Andy Shevchenko Tested-by: Sedat Dilek --- drivers/nfc/nxp-nci/i2c.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/nfc/nxp-nci/i2c.c

[PATCH v3 11/14] NFC: nxp-nci: Remove unused macro pr_fmt()

2019-07-25 Thread Andy Shevchenko
The macro had never been used. Signed-off-by: Andy Shevchenko Tested-by: Sedat Dilek --- drivers/nfc/nxp-nci/i2c.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/nfc/nxp-nci/i2c.c b/drivers/nfc/nxp-nci/i2c.c index 59b0a02a813d..307bd2afbe05 100644 --- a/drivers/nfc/nxp-nci/i2c.c +

[PATCH v3 07/14] NFC: nxp-nci: Get rid of useless label

2019-07-25 Thread Andy Shevchenko
Return directly in ->probe() since there no special cleaning is needed. Signed-off-by: Andy Shevchenko Tested-by: Sedat Dilek --- drivers/nfc/nxp-nci/i2c.c | 12 1 file changed, 4 insertions(+), 8 deletions(-) diff --git a/drivers/nfc/nxp-nci/i2c.c b/drivers/nfc/nxp-nci/i2c.c inde

[PATCH v3 12/14] NFC: nxp-nci: Remove 'default n' for the core

2019-07-25 Thread Andy Shevchenko
It seems contributors follow the style of Kconfig entries where explicit 'default n' is present. The default 'default' is 'n' already, thus, drop these lines from Kconfig to make it more clear. Signed-off-by: Andy Shevchenko Tested-by: Sedat Dilek --- drivers/nfc/nxp-nci/Kconfig | 1 - 1 file

[PATCH v3 04/14] NFC: nxp-nci: Convert to use GPIO descriptor

2019-07-25 Thread Andy Shevchenko
Since we got rid of platform data, the driver may use GPIO descriptor directly. Signed-off-by: Andy Shevchenko Tested-by: Sedat Dilek --- drivers/nfc/nxp-nci/core.c | 1 - drivers/nfc/nxp-nci/i2c.c | 60 ++ 2 files changed, 15 insertions(+), 46 deletions(-)

[PATCH v3 05/14] NFC: nxp-nci: Add GPIO ACPI mapping table

2019-07-25 Thread Andy Shevchenko
In order to unify GPIO resource request prepare gpiod_get_index() to behave correctly when there is no mapping provided by firmware. Here we add explicit mapping between _CRS GpioIo() resources and their names used in the driver. Signed-off-by: Andy Shevchenko Tested-by: Sedat Dilek --- driver

[PATCH v3 13/14] NFC: nxp-nci: Clarify on supported chips

2019-07-25 Thread Andy Shevchenko
From: Sedat Dilek This patch clarifies on the supported NXP NCI chips and families and lists PN547 and PN548 separately which are known as NPC100 respectively NPC300. This helps to find informations and identify drivers on vendor's support websites. For details see the discussion in [1] and [2]

[PATCH v3 10/14] NFC: nxp-nci: Drop comma in terminator lines

2019-07-25 Thread Andy Shevchenko
There is no need to have a comma after terminator entry in the arrays of IDs. This may prevent the misguided addition behind the terminator without compiler notice. Drop the comma in terminator lines for good. Signed-off-by: Andy Shevchenko Tested-by: Sedat Dilek --- drivers/nfc/nxp-nci/i2c.c

[PATCH v3 14/14] NFC: nxp-nci: Fix recommendation for NFC_NXP_NCI_I2C Kconfig

2019-07-25 Thread Andy Shevchenko
From: Sedat Dilek This is a simple cleanup to the Kconfig help text as discussed in [1]. [1] https://marc.info/?t=15577443561&r=1&w=2 Suggested-by: Andy Shevchenko Suggested-by: Oleg Zhurakivskyy Signed-off-by: Sedat Dilek Signed-off-by: Andy Shevchenko --- drivers/nfc/nxp-nci/Kconfig

[PATCH v3 08/14] NFC: nxp-nci: Constify acpi_device_id

2019-07-25 Thread Andy Shevchenko
The content of acpi_device_id is not supposed to change at runtime. All functions working with acpi_device_id provided by work with const acpi_device_id. So mark the non-const structs as const. Signed-off-by: Andy Shevchenko Tested-by: Sedat Dilek --- drivers/nfc/nxp-nci/i2c.c | 2 +- 1 file c

RE: [PATCH v6 rdma-next 1/6] RDMA/core: Create mmap database and cookie helper functions

2019-07-25 Thread Michal Kalderon
> From: linux-rdma-ow...@vger.kernel.org ow...@vger.kernel.org> On Behalf Of Jason Gunthorpe > > On Tue, Jul 09, 2019 at 05:17:30PM +0300, Michal Kalderon wrote: > > Create some common API's for adding entries to a xa_mmap. > > Searching for an entry and freeing one. > > > > The code was copied f

[PATCH v3 02/14] NFC: nxp-nci: Add NXP1001 to the ACPI ID table

2019-07-25 Thread Andy Shevchenko
It seems a lot of laptops are equipped with NXP NFC300 chip with the ACPI ID NXP1001 as per DSDT. Append it to the driver's ACPI ID table. Reported-by: Sedat Dilek Signed-off-by: Andy Shevchenko Tested-by: Sedat Dilek --- drivers/nfc/nxp-nci/i2c.c | 1 + 1 file changed, 1 insertion(+) diff -

[PATCH v3 01/14] NFC: fix attrs checks in netlink interface

2019-07-25 Thread Andy Shevchenko
From: Andrey Konovalov nfc_genl_deactivate_target() relies on the NFC_ATTR_TARGET_INDEX attribute being present, but doesn't check whether it is actually provided by the user. Same goes for nfc_genl_fw_download() and NFC_ATTR_FIRMWARE_NAME. This patch adds appropriate checks. Found with syzkall

Re: [PATCH bpf-next 02/10] libbpf: implement BPF CO-RE offset relocation algorithm

2019-07-25 Thread Song Liu
> On Jul 24, 2019, at 12:27 PM, Andrii Nakryiko wrote: > > This patch implements the core logic for BPF CO-RE offsets relocations. > All the details are described in code comments. Some description in the change log is still useful. Please at least copy-paste key comments here. And, this i

Re: [PATCH net-next 3/3] dt-bindings: net: ethernet: Update mt7622 docs and dts to reflect the new phylink API

2019-07-25 Thread Andrew Lunn
> + gmac0: mac@0 { > + compatible = "mediatek,eth-mac"; > + reg = <0>; > + phy-mode = "sgmii"; > + > + fixed-link { > + speed = <2500>; > + full-duplex; > + pause; > + }; > +

Re: [PATCH net-next 1/3] flow_offload: move tc indirect block to flow offload

2019-07-25 Thread Jakub Kicinski
Please provide cover letter for the patch set. On Thu, 25 Jul 2019 17:55:31 +0800, we...@ucloud.cn wrote: > +static bool rhash_table_init; > +int flow_indr_rhashtable_init(void) > +{ > + int err = 0; > + > + if (!rhash_table_init) { > + err = rhashtable_init(&indr_setup_block_h

ethtool 5.2 released

2019-07-25 Thread John W. Linville
ethtool version 5.2 has been released. Home page: https://www.kernel.org/pub/software/network/ethtool/ Download link: https://www.kernel.org/pub/software/network/ethtool/ethtool-5.2.tar.xz Release notes: * Feature: Add 100BaseT1 and 1000BaseT1 link modes * Feature: Use standard f

Re: [PATCH v2] tun: mark small packets as owned by the tap sock

2019-07-25 Thread David Miller
From: Alexis Bauvin Date: Tue, 23 Jul 2019 16:23:01 +0200 > - v1 -> v2: Move skb_set_owner_w to __tun_build_skb to reduce patch size > > Small packets going out of a tap device go through an optimized code > path that uses build_skb() rather than sock_alloc_send_pskb(). The > latter calls skb_se

Re: [PATCH net-next 0/2] mlxsw: Two small updates

2019-07-25 Thread David Miller
From: Ido Schimmel Date: Tue, 23 Jul 2019 10:57:40 +0300 > From: Ido Schimmel > > Patch #1, from Amit, exposes the size of the key-value database (KVD) > where different entries (e.g., routes, neighbours) are stored in the > device. This allows users to understand how many entries can be > offl

Re: [RFC] dt-bindings: net: phy: Add subnode for LED configuration

2019-07-25 Thread Andrew Lunn
> As of now I don't plan to expose the label to userspace by the PHY > driver/framework itself. Great. With that change, i think this proposed binding is O.K. Andrew

Re: [PATCH net 0/2] DIM fixes for 5.3

2019-07-25 Thread David Miller
From: Leon Romanovsky Date: Tue, 23 Jul 2019 10:22:46 +0300 > Those two fixes for recently merged DIM patches, both exposed through > RDMa DIM usage. Series applied.

Re: [Patch net] ife: error out when nla attributes are empty

2019-07-25 Thread David Miller
From: Cong Wang Date: Mon, 22 Jul 2019 21:43:00 -0700 > act_ife at least requires TCA_IFE_PARMS, so we have to bail out > when there is no attribute passed in. > > Reported-by: syzbot+fbb5b288c9cb6a2ee...@syzkaller.appspotmail.com > Fixes: ef6980b6becb ("introduce IFE action") > Cc: Jamal Hadi S

Re: [PATCH] net-next: ag71xx: Rearrange ag711xx struct to remove holes

2019-07-25 Thread David Miller
From: Rosen Penev Date: Mon, 22 Jul 2019 20:43:09 -0700 > Removed cacheline_aligned attribute to ring structs. This actually > causes holes in the ag71xx struc as well as lower performance. If you are legitimizing a change because of performance you must provide detailed performance results

Re: [PATCH] sis900: add support for ethtool --eeprom-dump

2019-07-25 Thread Andrew Lunn
On Thu, Jul 25, 2019 at 06:41:41PM +0200, Sergej Benilov wrote: > On Thu, 25 Jul 2019 at 18:25, Andrew Lunn wrote: > > > > > +static int sis900_read_eeprom(struct net_device *net_dev, u8 *buf) > > > +{ > > > + struct sis900_private *sis_priv = netdev_priv(net_dev); > > > + void __iomem *io

[PATCH net] net: qualcomm: rmnet: Fix incorrect UL checksum offload logic

2019-07-25 Thread Subash Abhinov Kasiviswanathan
The udp_ip4_ind bit is set only for IPv4 UDP non-fragmented packets so that the hardware can flip the checksum to 0x if the computed checksum is 0 per RFC768. However, this bit had to be set for IPv6 UDP non fragmented packets as well per hardware requirements. Otherwise, IPv6 UDP packets with

Re: [PATCH v6 rdma-next 4/6] qed*: Change dpi_addr to be denoted with __iomem

2019-07-25 Thread Jason Gunthorpe
On Tue, Jul 09, 2019 at 05:17:33PM +0300, Michal Kalderon wrote: > Several casts were required around dpi_addr parameter in qed_rdma_if.h > This is an address on the doorbell bar and should therefore be marked > with __iomem. > > Reported-by: Jason Gunthorpe > Signed-off-by: Ariel Elior > Signed

Re: [PATCH v6 rdma-next 0/6] RDMA/qedr: Use the doorbell overflow recovery mechanism for RDMA

2019-07-25 Thread Jason Gunthorpe
On Tue, Jul 09, 2019 at 05:17:29PM +0300, Michal Kalderon wrote: > This patch series uses the doorbell overflow recovery mechanism > introduced in > commit 36907cd5cd72 ("qed: Add doorbell overflow recovery mechanism") > for rdma ( RoCE and iWARP ) > > The first three patches modify the core code

Re: [PATCH v6 rdma-next 5/6] RDMA/qedr: Add doorbell overflow recovery support

2019-07-25 Thread Jason Gunthorpe
On Tue, Jul 09, 2019 at 05:17:34PM +0300, Michal Kalderon wrote: > +static int qedr_init_user_db_rec(struct ib_udata *udata, > + struct qedr_dev *dev, struct qedr_userq *q, > + bool requires_db_rec) > +{ > + struct qedr_ucontext *uctx =

Re: [PATCH v6 rdma-next 1/6] RDMA/core: Create mmap database and cookie helper functions

2019-07-25 Thread Jason Gunthorpe
On Tue, Jul 09, 2019 at 05:17:30PM +0300, Michal Kalderon wrote: > Create some common API's for adding entries to a xa_mmap. > Searching for an entry and freeing one. > > The code was copied from the efa driver almost as is, just renamed > function to be generic and not efa specific. > > Signed-o

Re: [PATCH bpf-next v2 5/7] selftests/bpf: support FLOW_DISSECTOR_F_PARSE_1ST_FRAG

2019-07-25 Thread Song Liu
> On Jul 25, 2019, at 8:33 AM, Stanislav Fomichev wrote: > > bpf_flow.c: exit early unless FLOW_DISSECTOR_F_PARSE_1ST_FRAG is passed > in flags. Also, set ip_proto earlier, this makes sure we have correct > value with fragmented packets. > > Add selftest cases to test ipv4/ipv6 fragments and

pull-request: bpf 2019-07-25

2019-07-25 Thread Alexei Starovoitov
Hi David, The following pull-request contains BPF updates for your *net* tree. The main changes are: 1) fix segfault in libbpf, from Andrii. 2) fix gso_segs access, from Eric. 3) tls/sockmap fixes, from Jakub and John. Please consider pulling these changes from: git://git.kernel.org/pub/sc

Re: [PATCH bpf-next v3 00/11] XDP unaligned chunk placement support

2019-07-25 Thread Jonathan Lemon
On 25 Jul 2019, at 8:56, Richardson, Bruce wrote: >> -Original Message- >> From: Jonathan Lemon [mailto:jonathan.le...@gmail.com] >> Sent: Thursday, July 25, 2019 4:39 PM >> To: Laatz, Kevin >> Cc: netdev@vger.kernel.org; a...@kernel.org; dan...@iogearbox.net; Topel, >> Bjorn ; Karlsso

Re: TSN - tc usage for a tbs setup

2019-07-25 Thread Vinicius Costa Gomes
Hi, Stéphane Ancelot writes: > Hi, > > I am trying to setup my network queue for offline time based configuration. > > initial setup is : > > tc qdisc show dev eth1: > > qdisc mq 0: root > > qdisc pfifo_fast 0: parent :1 bands 3 priomap  1 2 2 2 1 2 0 0 1 1 1 1 1 > 1 1 1 > > > I won't need pfif

Re: [PATCH v2 bpf] libbpf: silence GCC8 warning about string truncation

2019-07-25 Thread Alexei Starovoitov
On Wed, Jul 24, 2019 at 10:46 PM Andrii Nakryiko wrote: > > Despite a proper NULL-termination after strncpy(..., ..., IFNAMSIZ - 1), > GCC8 still complains about *expected* string truncation: > > xsk.c:330:2: error: 'strncpy' output may be truncated copying 15 bytes > from a string of length 1

Re: [PATCH bpf-next v2 0/7] bpf/flow_dissector: support input flags

2019-07-25 Thread Petar Penkov
Thanks! For the series: Acked-by: Petar Penkov On Thu, Jul 25, 2019 at 8:33 AM Stanislav Fomichev wrote: > > C flow dissector supports input flags that tell it to customize parsing > by either stopping early or trying to parse as deep as possible. > BPF flow dissector always parses as deep as p

Re: [PATCH bpf-next v3 03/11] xsk: add support to allow unaligned chunk placement

2019-07-25 Thread Laatz, Kevin
On 25/07/2019 03:22, Jakub Kicinski wrote: On Wed, 24 Jul 2019 05:10:35 +, Kevin Laatz wrote: Currently, addresses are chunk size aligned. This means, we are very restricted in terms of where we can place chunk within the umem. For example, if we have a chunk size of 2k, then our chunks can

Re: [PATCH bpf-next v3 06/11] mlx5e: modify driver for handling offsets

2019-07-25 Thread Laatz, Kevin
On 25/07/2019 11:15, Maxim Mikityanskiy wrote: On 2019-07-24 08:10, Kevin Laatz wrote: With the addition of the unaligned chunks option, we need to make sure we handle the offsets accordingly based on the mode we are currently running in. This patch modifies the driver to appropriately mask the

Re: [PATCH bpf-next v3 08/11] samples/bpf: add unaligned chunks mode support to xdpsock

2019-07-25 Thread Laatz, Kevin
On 25/07/2019 10:43, Maxim Mikityanskiy wrote: On 2019-07-24 08:10, Kevin Laatz wrote: This patch adds support for the unaligned chunks mode. The addition of the unaligned chunks option will allow users to run the application with more relaxed chunk placement in the XDP umem. Unaligned chunks

Re: [PATCH bpf-next v3 03/11] xsk: add support to allow unaligned chunk placement

2019-07-25 Thread Laatz, Kevin
On 25/07/2019 10:27, Maxim Mikityanskiy wrote: On 2019-07-24 08:10, Kevin Laatz wrote: Currently, addresses are chunk size aligned. This means, we are very restricted in terms of where we can place chunk within the umem. For example, if we have a chunk size of 2k, then our chunks can only be p

Re: [PATCH] sis900: add support for ethtool --eeprom-dump

2019-07-25 Thread Sergej Benilov
On Thu, 25 Jul 2019 at 18:25, Andrew Lunn wrote: > > > +static int sis900_read_eeprom(struct net_device *net_dev, u8 *buf) > > +{ > > + struct sis900_private *sis_priv = netdev_priv(net_dev); > > + void __iomem *ioaddr = sis_priv->ioaddr; > > + int wait, ret = -EAGAIN; > > + u16 si

Re: [PATCH v3 0/7] Convert skb_frag_t to bio_vec

2019-07-25 Thread Jonathan Lemon
On 22 Jul 2019, at 20:08, Matthew Wilcox wrote: > From: "Matthew Wilcox (Oracle)" > > The skb_frag_t and bio_vec are fundamentally the same (page, offset, > length) tuple. This patch series unifies the two, leaving the > skb_frag_t typedef in place. This has the immediate advantage that > we

Re: [PATCH] sis900: add support for ethtool --eeprom-dump

2019-07-25 Thread Andrew Lunn
> +static int sis900_read_eeprom(struct net_device *net_dev, u8 *buf) > +{ > + struct sis900_private *sis_priv = netdev_priv(net_dev); > + void __iomem *ioaddr = sis_priv->ioaddr; > + int wait, ret = -EAGAIN; > + u16 signature; > + u16 *ebuf = (u16 *)buf; > + int i; > + > +

Re: [PATCH V2 3/3] net: dsa: ksz: Add Microchip KSZ8795 DSA driver

2019-07-25 Thread Andrew Lunn
On Thu, Jul 25, 2019 at 05:05:52PM +0200, Marek Vasut wrote: Hi Marek > +static void ksz8795_phy_setup(struct ksz_device *dev, int port, > + struct phy_device *phy) > +{ > + if (port < dev->phy_port_cnt) { > + /* > + * SUPPORTED_Asym_Pause an

[PATCH] sis900: add support for ethtool --eeprom-dump

2019-07-25 Thread Sergej Benilov
Implement ethtool's EEPROM dump command (ethtool -e|--eeprom-dump). Signed-off-by: Sergej Benilov --- drivers/net/ethernet/sis/sis900.c | 68 +++ 1 file changed, 68 insertions(+) diff --git a/drivers/net/ethernet/sis/sis900.c b/drivers/net/ethernet/sis/sis900.c inde

  1   2   >