Re: [PATCH V2 3/3] net: dsa: ksz: Add Microchip KSZ8795 DSA driver

[Andrew Lunn]

On Thu, Jul 25, 2019 at 05:05:52PM +0200, Marek Vasut wrote:

Hi Marek

> +static void ksz8795_phy_setup(struct ksz_device *dev, int port,
> +                           struct phy_device *phy)
> +{
> +     if (port < dev->phy_port_cnt) {
> +             /*
> +              * SUPPORTED_Asym_Pause and SUPPORTED_Pause can be removed to
> +              * disable flow control when rate limiting is used.
> +              */
> +             linkmode_copy(phy->advertising, phy->supported);
> +     }
> +}

Please could you drop this, since your testing seems to indicate it is
not needed.

    Thanks
        Andrew