On Thu, 2019-07-25 at 00:48 +0000, Sudarsana Reddy Kalluru wrote:
> > > 
> > -----Original Message-----
> > From: Saeed Mahameed <sae...@mellanox.com>
> > Sent: Thursday, July 25, 2019 1:13 AM
> > To: Sudarsana Reddy Kalluru <skall...@marvell.com>;
> > da...@davemloft.net
> > Cc: Ariel Elior <ael...@marvell.com>; Michal Kalderon
> > <mkalde...@marvell.com>; netdev@vger.kernel.org
> > Subject: [EXT] Re: [PATCH net-next 2/2] qed: Add API for flashing
> > the nvm
> > attributes.
> > 
> > External Email
> > 
> > -----------------------------------------------------------------
> > -----
> > On Tue, 2019-07-23 at 21:51 -0700, Sudarsana Reddy Kalluru wrote:
> > > The patch adds driver interface for reading the NVM config
> > > request and
> > > update the attributes on nvm config flash partition.
> > > 
> > 
> > You didn't not use the get_cfg API you added in previous patch.
> Thanks for your review. Will move this API to the next patch series
> which will plan to send shortly.
> 
> > Also can you please clarify how the user reads/write from/to NVM
> > config
> > ? i mean what UAPIs and tools are being used ?
> NVM config/partition will be updated using ethtool flash update
> command (i.e., ethtool -f) just like the update of 
> other flash partitions of qed device. Example code path,
>   ethool-flash_device --> qede_flash_device() --> qed_nvm_flash() --> 
> qed_nvm_flash_cfg_write()
> 

I see, thanks for the clarification.

Reply via email to