Re: [PATCH v2 bpf-next 1/4] bpf: unprivileged BPF access via /dev/bpf

2019-07-23 Thread Song Liu
> On Jul 23, 2019, at 6:40 PM, Andy Lutomirski wrote: > > > >> On Jul 23, 2019, at 3:56 PM, Song Liu wrote: >> >> >> >>> On Jul 23, 2019, at 8:11 AM, Andy Lutomirski wrote: >>> >>> On Mon, Jul 22, 2019 at 1:54 PM Song Liu wrote: Hi Andy, Lorenz, and all, > On Jul 2

Re: [bpf-next 2/6] tcp: add skb-less helpers to retrieve SYN cookie

2019-07-23 Thread kbuild test robot
Hi Petar, Thank you for the patch! Yet something to improve: [auto build test ERROR on bpf-next/master] url: https://github.com/0day-ci/linux/commits/Petar-Penkov/Introduce-a-BPF-helper-to-generate-SYN-cookies/20190723-235628 base: https://kernel.googlesource.com/pub/scm/linux/kernel/git

Re: [bpf-next 2/6] tcp: add skb-less helpers to retrieve SYN cookie

2019-07-23 Thread kbuild test robot
Hi Petar, Thank you for the patch! Yet something to improve: [auto build test ERROR on bpf-next/master] url: https://github.com/0day-ci/linux/commits/Petar-Penkov/Introduce-a-BPF-helper-to-generate-SYN-cookies/20190723-235628 base: https://kernel.googlesource.com/pub/scm/linux/kernel/git

[PATCH net-next v2 2/8] net: atheros: Use dev_get_drvdata

2019-07-23 Thread Chuhong Yuan
Instead of using to_pci_dev + pci_get_drvdata, use dev_get_drvdata to make code simpler. Signed-off-by: Chuhong Yuan --- Changes in v2: - Change pci_set_drvdata to dev_set_drvdata to keep consistency. drivers/net/ethernet/atheros/alx/main.c | 8 +++- drivers/net/ethernet/athe

[PATCH net-next v2 1/8] net: 3com: 3c59x: Use dev_get_drvdata

2019-07-23 Thread Chuhong Yuan
Instead of using to_pci_dev + pci_get_drvdata, use dev_get_drvdata to make code simpler. Signed-off-by: Chuhong Yuan --- Changes in v2: - Change pci_set_drvdata to dev_set_drvdata to keep consistency. drivers/net/ethernet/3com/3c59x.c | 8 +++- 1 file changed, 3 insertions(+), 5 delet

Re: kernel v5.3.0-rc1

2019-07-23 Thread Heiner Kallweit
On 24.07.2019 03:38, Bob Gleitsmann wrote: > Hello, > > > I had problems with network functionality in kernel v5.3.0-rc1. I was > not able to ping local devices with ip address or internet points by > name. I have been testing git kernels for a while and this is the first > time this has happened

Re: [PATCH] qca8k: enable port flow control

2019-07-23 Thread xiaofeis
Hi Andrew Thanks for your comments. I have sent a new patch based on net-next tree. Thanks Xiaofeis On 2019-07-19 21:13, Andrew Lunn wrote: On Fri, Jul 19, 2019 at 10:53:11AM +0800, xiaofeis wrote: Set phy device advertising to enable MAC flow control. Change-Id: Ibf0f554b072fc73136ec9f7ff

[PATCH v2] net: dsa: qca8k: enable port flow control

2019-07-23 Thread xiaofeis
Set phy device advertising to enable MAC flow control. Signed-off-by: Xiaofei Shen --- drivers/net/dsa/qca8k.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/net/dsa/qca8k.c b/drivers/net/dsa/qca8k.c index 232e8cc..c5ac426 100644 --- a/drivers/net/dsa/qca8k.c +++

[PATCH net-next 1/2] qed: Add APIs for NVM config attributes.

2019-07-23 Thread Sudarsana Reddy Kalluru
The patch adds APIs for reading/configuring the NVM config attributes using Management FW interfaces. Signed-off-by: Sudarsana Reddy Kalluru Signed-off-by: Ariel Elior --- drivers/net/ethernet/qlogic/qed/qed_hsi.h | 17 drivers/net/ethernet/qlogic/qed/qed_mcp.c | 64 +++

[PATCH net-next 0/2] qed: Support for NVM config attributes.

2019-07-23 Thread Sudarsana Reddy Kalluru
The patch series add support for managing the NVM config attributes. Patch (1) adds interfaces for read/write config attributes from MFW. Patch (2) adds driver interface for updating the config attributes. Sudarsana Reddy Kalluru (2): qed: Add APIs for NVM config attributes. qed: Add API for f

[PATCH net-next 2/2] qed: Add API for flashing the nvm attributes.

2019-07-23 Thread Sudarsana Reddy Kalluru
The patch adds driver interface for reading the NVM config request and update the attributes on nvm config flash partition. Signed-off-by: Sudarsana Reddy Kalluru Signed-off-by: Ariel Elior --- drivers/net/ethernet/qlogic/qed/qed_main.c | 65 ++ include/linux/qed/qed

[net-next:master 7/33] drivers/target/iscsi/cxgbit/cxgbit_target.c:1451:47-48: Unneeded semicolon

2019-07-23 Thread kbuild test robot
tree: https://kernel.googlesource.com/pub/scm/linux/kernel/git/davem/net-next.git master head: 3e3bb69589e482e0783f28d4cd1d8e56fda0bcbb commit: d7840976e3915669382c62ddd1700960f348328e [7/33] net: Use skb accessors in network drivers If you fix the issue, kindly add following tag Reported-b

[PATCH] net: fix semicolon.cocci warnings

2019-07-23 Thread kbuild test robot
From: kbuild test robot drivers/target/iscsi/cxgbit/cxgbit_target.c:1451:47-48: Unneeded semicolon Remove unneeded semicolon. Generated by: scripts/coccinelle/misc/semicolon.cocci Fixes: d7840976e391 ("net: Use skb accessors in network drivers") CC: Matthew Wilcox (Oracle) Signed-off-by: kb

[PATCH 03/12] block: bio_release_pages: use flags arg instead of bool

2019-07-23 Thread john . hubbard
From: John Hubbard In commit d241a95f3514 ("block: optionally mark pages dirty in bio_release_pages"), new "bool mark_dirty" argument was added to bio_release_pages. In upcoming work, another bool argument (to indicate that the pages came from get_user_pages) is going to be added. That's one boo

Re: [PATCH mlx5-next] net/mlx5: Fix modify_cq_in alignment

2019-07-23 Thread Leon Romanovsky
On Tue, Jul 23, 2019 at 08:34:07PM +, Saeed Mahameed wrote: > On Tue, 2019-07-23 at 13:02 -0700, David Miller wrote: > > From: Leon Romanovsky > > Date: Tue, 23 Jul 2019 22:04:14 +0300 > > > > > The intention was to have this patch in shared mlx5 branch, which > > > is > > > picked by RDMA too

[PATCH net 1/1] bnx2x: Disable multi-cos feature.

2019-07-23 Thread Sudarsana Reddy Kalluru
Commit 3968d38917eb ("bnx2x: Fix Multi-Cos.") which enabled multi-cos feature after prolonged time in driver added some regression causing numerous issues (sudden reboots, tx timeout etc.) reported by customers. We plan to backout this commit and submit proper fix once we have root cause of issues

Re: [net-next 6/6] e1000e: disable force K1-off feature

2019-07-23 Thread Jeff Kirsher
On Tue, 2019-07-23 at 14:04 -0700, David Miller wrote: > From: Jeff Kirsher > Date: Tue, 23 Jul 2019 10:36:50 -0700 > > > diff --git a/drivers/net/ethernet/intel/e1000e/hw.h > > b/drivers/net/ethernet/intel/e1000e/hw.h > > index eff75bd8a8f0..e3c71fd093ee 100644 > > --- a/drivers/net/ethernet/int

Re: [PATCH v2] tun: mark small packets as owned by the tap sock

2019-07-23 Thread Jason Wang
On 2019/7/23 下午10:23, Alexis Bauvin wrote: - v1 -> v2: Move skb_set_owner_w to __tun_build_skb to reduce patch size Small packets going out of a tap device go through an optimized code path that uses build_skb() rather than sock_alloc_send_pskb(). The latter calls skb_set_owner_w(), but the sm

[net-next 1/2] tipc: optimize link synching mechanism

2019-07-23 Thread Tuong Lien
This commit along with the next one are to resolve the issues with the link changeover mechanism. See that commit for details. Basically, for the link synching, from now on, we will send only one single ("dummy") SYNCH message to peer. The SYNCH message does not contain any data, just a header con

[net-next 0/2] tipc: link changeover issues

2019-07-23 Thread Tuong Lien
This patch series is to resolve some issues found with the current link changeover mechanism, it also includes an optimization for the link synching. Tuong Lien (2): tipc: optimize link synching mechanism tipc: fix changeover issues due to large packet net/tipc/link.c | 119 +

[net-next 2/2] tipc: fix changeover issues due to large packet

2019-07-23 Thread Tuong Lien
In conjunction with changing the interfaces' MTU (e.g. especially in the case of a bonding) where the TIPC links are brought up and down in a short time, a couple of issues were detected with the current link changeover mechanism: 1) When one link is up but immediately forced down again, the failo

Re: [PATCH v2 bpf-next 1/4] bpf: unprivileged BPF access via /dev/bpf

2019-07-23 Thread Andy Lutomirski
> On Jul 23, 2019, at 3:56 PM, Song Liu wrote: > > > >> On Jul 23, 2019, at 8:11 AM, Andy Lutomirski wrote: >> >> On Mon, Jul 22, 2019 at 1:54 PM Song Liu wrote: >>> >>> Hi Andy, Lorenz, and all, >>> On Jul 2, 2019, at 2:32 PM, Andy Lutomirski wrote: On Tue, Jul 2, 2019

kernel v5.3.0-rc1

2019-07-23 Thread Bob Gleitsmann
Hello, I had problems with network functionality in kernel v5.3.0-rc1. I was not able to ping local devices with ip address or internet points by name. I have been testing git kernels for a while and this is the first time this has happened, i.e., it didn't happen with v5.2.0. One interesting thi

Re: [PATCH v3 6/7] net: Rename skb_frag_t size to bv_len

2019-07-23 Thread Matthew Wilcox
On Tue, Jul 23, 2019 at 10:33:59PM +, Saeed Mahameed wrote: > > struct skb_frag_struct { > > struct page *bv_page; > > - __u32 size; > > + unsigned int bv_len; > > __u32 page_offset; > > Why do you keep page_offset name and type as is ? it will make the last > patch much cleaner i

Re: [PATCH v3 4/7] net: Reorder the contents of skb_frag_t

2019-07-23 Thread Matthew Wilcox
On Tue, Jul 23, 2019 at 10:29:06PM +, Saeed Mahameed wrote: > On Fri, 2019-07-12 at 06:43 -0700, Matthew Wilcox wrote: > > From: "Matthew Wilcox (Oracle)" > > > > Match the layout of bio_vec. > > > > Signed-off-by: Matthew Wilcox (Oracle) > > --- > > include/linux/skbuff.h | 2 +- > > 1 fi

Re: [PATCH v4 net-next 02/19] ionic: Add hardware init and device commands

2019-07-23 Thread Shannon Nelson
On 7/23/19 4:47 PM, Saeed Mahameed wrote: On Mon, 2019-07-22 at 14:40 -0700, Shannon Nelson wrote: The ionic device has a small set of PCI registers, including a device control and data space, and a large set of message commands. Signed-off-by: Shannon Nelson --- drivers/net/ethernet/pensand

Re: [PATCH v4 net-next 11/19] ionic: Add Rx filter and rx_mode ndo support

2019-07-23 Thread Shannon Nelson
On 7/23/19 4:06 PM, David Miller wrote: From: Shannon Nelson Date: Tue, 23 Jul 2019 15:50:43 -0700 On 7/23/19 2:33 PM, David Miller wrote: Generally interface address changes are expected to be synchronous. Yeah, this bothers me a bit as well, but the address change calls come in under spin_

Re: [PATCH v4 net-next 11/19] ionic: Add Rx filter and rx_mode ndo support

2019-07-23 Thread Shannon Nelson
On 7/23/19 4:54 PM, Saeed Mahameed wrote: On Tue, 2019-07-23 at 16:06 -0700, David Miller wrote: From: Shannon Nelson Date: Tue, 23 Jul 2019 15:50:43 -0700 On 7/23/19 2:33 PM, David Miller wrote: Generally interface address changes are expected to be synchronous. Yeah, this bothers me a bit

Re: [bpf-next 3/6] bpf: add bpf_tcp_gen_syncookie helper

2019-07-23 Thread Petar Penkov
On Tue, Jul 23, 2019 at 5:33 AM Toke Høiland-Jørgensen wrote: > > Petar Penkov writes: > > > From: Petar Penkov > > > > This helper function allows BPF programs to try to generate SYN > > cookies, given a reference to a listener socket. The function works > > from XDP and with an skb context sin

[PATCH bpf-next v10 0/2] bpf: Allow bpf_skb_event_output for more prog types

2019-07-23 Thread Allan Zhang
Software event output is only enabled by a few prog types right now (TC, LWT out, XDP, sockops). Many other skb based prog types need bpf_skb_event_output to produce software event. More prog types are enabled to access bpf_skb_event_output in this patch. v10 changes: Resubmit (v9 is submitted wh

[PATCH bpf-next v10 1/2] bpf: Allow bpf_skb_event_output for a few prog types

2019-07-23 Thread Allan Zhang
Software event output is only enabled by a few prog types right now (TC, LWT out, XDP, sockops). Many other skb based prog types need bpf_skb_event_output to produce software event. Added socket_filter, cg_skb, sk_skb prog types to generate sw event. Test bpf code is generated from code snippet:

Re: [PATCH v4 net-next 11/19] ionic: Add Rx filter and rx_mode ndo support

2019-07-23 Thread Shannon Nelson
On 7/23/19 4:20 PM, Saeed Mahameed wrote: On Mon, 2019-07-22 at 14:40 -0700, Shannon Nelson wrote: @@ -607,6 +947,8 @@ static void ionic_lif_free(struct lif *lif) ionic_qcqs_free(lif); ionic_lif_reset(lif); I don't think you want deferred.work running while reset is execu

[PATCH bpf-next v10 2/2] selftests/bpf: Add selftests for bpf_perf_event_output

2019-07-23 Thread Allan Zhang
Software event output is only enabled by a few prog types. This test is to ensure that all supported types are enabled for bpf_perf_event_output successfully. Signed-off-by: Allan Zhang Acked-by: Song Liu --- tools/testing/selftests/bpf/test_verifier.c | 12 ++- .../selftests/bpf/verifier/eve

Re: [PATCH v4 net-next 11/19] ionic: Add Rx filter and rx_mode ndo support

2019-07-23 Thread Saeed Mahameed
On Tue, 2019-07-23 at 16:06 -0700, David Miller wrote: > From: Shannon Nelson > Date: Tue, 23 Jul 2019 15:50:43 -0700 > > > On 7/23/19 2:33 PM, David Miller wrote: > > > Generally interface address changes are expected to be > > > synchronous. > > Yeah, this bothers me a bit as well, but the addr

Re: [PATCH v4 net-next 02/19] ionic: Add hardware init and device commands

2019-07-23 Thread Saeed Mahameed
On Mon, 2019-07-22 at 14:40 -0700, Shannon Nelson wrote: > The ionic device has a small set of PCI registers, including a > device control and data space, and a large set of message > commands. > > Signed-off-by: Shannon Nelson > --- > drivers/net/ethernet/pensando/ionic/Makefile |2 +- > d

Re: [PATCH iproute2] etf: make printing of variable JSON friendly

2019-07-23 Thread Stephen Hemminger
On Tue, 23 Jul 2019 21:34:46 + "Patel, Vedang" wrote: > > On Jul 22, 2019, at 5:11 PM, David Ahern wrote: > > > > On 7/22/19 1:11 PM, Patel, Vedang wrote: > >> > >> > >>> On Jul 22, 2019, at 11:21 AM, David Ahern wrote: > >>> > >>> On 7/19/19 3:40 PM, Vedang Patel wrote: > In

Re: [PATCH v4 net-next 02/19] ionic: Add hardware init and device commands

2019-07-23 Thread Shannon Nelson
On 7/23/19 4:05 PM, David Miller wrote: From: Shannon Nelson Date: Tue, 23 Jul 2019 15:50:22 -0700 On 7/23/19 2:18 PM, David Miller wrote: From: Shannon Nelson Date: Mon, 22 Jul 2019 14:40:06 -0700 +void ionic_init_devinfo(struct ionic_dev *idev) +{ + idev->dev_info.asic_type = ioread8(&id

Re: [PATCH v4 net-next 11/19] ionic: Add Rx filter and rx_mode ndo support

2019-07-23 Thread Saeed Mahameed
On Mon, 2019-07-22 at 14:40 -0700, Shannon Nelson wrote: > Add the Rx filtering and rx_mode NDO callbacks. Also add > the deferred work thread handling needed to manage the filter > requests otuside of the netif_addr_lock spinlock. > > Signed-off-by: Shannon Nelson > --- > .../net/ethernet/pens

Re: [PATCH v2 bpf-next 0/5] switch samples and tests to libbpf perf buffer API

2019-07-23 Thread Alexei Starovoitov
On 7/23/19 2:34 PM, Andrii Nakryiko wrote: > There were few more tests and samples that were using custom perf buffer setup > code from trace_helpers.h. This patch set gets rid of all the usages of those > and removes helpers themselves. Libbpf provides nicer, but equally powerful > set of APIs to

Re: [PATCH v4 net-next 11/19] ionic: Add Rx filter and rx_mode ndo support

2019-07-23 Thread David Miller
From: Shannon Nelson Date: Tue, 23 Jul 2019 15:50:43 -0700 > On 7/23/19 2:33 PM, David Miller wrote: >> Generally interface address changes are expected to be synchronous. > Yeah, this bothers me a bit as well, but the address change calls come > in under spin_lock_bh(), and I'm reluctant to make

Re: [PATCH v4 net-next 02/19] ionic: Add hardware init and device commands

2019-07-23 Thread David Miller
From: Shannon Nelson Date: Tue, 23 Jul 2019 15:50:22 -0700 > On 7/23/19 2:18 PM, David Miller wrote: >> From: Shannon Nelson >> Date: Mon, 22 Jul 2019 14:40:06 -0700 >> >>> +void ionic_init_devinfo(struct ionic_dev *idev) >>> +{ >>> + idev->dev_info.asic_type = ioread8(&idev->dev_info_regs->asic

Re: [PATCH v2 bpf-next] libbpf: provide more helpful message on uninitialized global var

2019-07-23 Thread Alexei Starovoitov
On 7/23/19 3:03 PM, Song Liu wrote: >> On Jul 23, 2019, at 2:11 PM, Andrii Nakryiko wrote: >> >> When BPF program defines uninitialized global variable, it's put into >> a special COMMON section. Libbpf will reject such programs, but will >> provide very unhelpful message with garbage-looking sect

Re: [PATCH v2 bpf-next 1/4] bpf: unprivileged BPF access via /dev/bpf

2019-07-23 Thread Song Liu
> On Jul 23, 2019, at 8:11 AM, Andy Lutomirski wrote: > > On Mon, Jul 22, 2019 at 1:54 PM Song Liu wrote: >> >> Hi Andy, Lorenz, and all, >> >>> On Jul 2, 2019, at 2:32 PM, Andy Lutomirski wrote: >>> >>> On Tue, Jul 2, 2019 at 2:04 PM Kees Cook wrote: On Mon, Jul 01, 2019 at 0

Re: [PATCH v4 net-next 11/19] ionic: Add Rx filter and rx_mode ndo support

2019-07-23 Thread Saeed Mahameed
On Tue, 2019-07-23 at 14:33 -0700, David Miller wrote: > From: Shannon Nelson > Date: Mon, 22 Jul 2019 14:40:15 -0700 > > > + if (in_interrupt()) { > > + work = kzalloc(sizeof(*work), GFP_ATOMIC); > > + if (!work) { > > + netdev_err(lif->netdev, "%s OOM\n",

Re: [PATCH v4 net-next 13/19] ionic: Add initial ethtool support

2019-07-23 Thread Shannon Nelson
On 7/23/19 2:35 PM, David Miller wrote: From: Shannon Nelson Date: Mon, 22 Jul 2019 14:40:17 -0700 +static int ionic_get_link_ksettings(struct net_device *netdev, + struct ethtool_link_ksettings *ks) +{ + struct lif *lif = netdev_priv(netdev); + st

Re: [PATCH v4 net-next 19/19] ionic: Add basic devlink interface

2019-07-23 Thread Shannon Nelson
On 7/23/19 2:40 PM, David Miller wrote: From: Shannon Nelson Date: Mon, 22 Jul 2019 14:40:23 -0700 +struct ionic *ionic_devlink_alloc(struct device *dev) +{ + struct devlink *dl; + struct ionic *ionic; Reverse christmas tree please. Yep, I missed this one. Thanks for your revie

Re: [PATCH v4 net-next 06/19] ionic: Add basic adminq support

2019-07-23 Thread Shannon Nelson
On 7/23/19 2:27 PM, David Miller wrote: From: Shannon Nelson Date: Mon, 22 Jul 2019 14:40:10 -0700 +struct queue { ... +struct cq { ... +struct napi_stats { ... +struct q_stats { ... +struct qcq { Using names like these and "dev_queue" are just asking for conflicts with the gl

Re: [PATCH v4 net-next 11/19] ionic: Add Rx filter and rx_mode ndo support

2019-07-23 Thread Shannon Nelson
On 7/23/19 2:33 PM, David Miller wrote: From: Shannon Nelson Date: Mon, 22 Jul 2019 14:40:15 -0700 + if (in_interrupt()) { + work = kzalloc(sizeof(*work), GFP_ATOMIC); + if (!work) { + netdev_err(lif->netdev, "%s OOM\n", __func__); +

Re: [PATCH v4 net-next 02/19] ionic: Add hardware init and device commands

2019-07-23 Thread Shannon Nelson
On 7/23/19 2:18 PM, David Miller wrote: From: Shannon Nelson Date: Mon, 22 Jul 2019 14:40:06 -0700 +void ionic_init_devinfo(struct ionic_dev *idev) +{ + idev->dev_info.asic_type = ioread8(&idev->dev_info_regs->asic_type); + idev->dev_info.asic_rev = ioread8(&idev->dev_info_regs->as

Re: [PATCH v4 net-next 05/19] ionic: Add interrupts and doorbells

2019-07-23 Thread Shannon Nelson
On 7/23/19 2:24 PM, David Miller wrote: From: Shannon Nelson Date: Mon, 22 Jul 2019 14:40:09 -0700 The ionic interrupt model is based on interrupt control blocks accessed through the PCI BAR. Doorbell registers are used by the driver to signal to the NIC that requests are waiting on the messa

Re: [PATCH v3 6/7] net: Rename skb_frag_t size to bv_len

2019-07-23 Thread Saeed Mahameed
On Fri, 2019-07-12 at 06:43 -0700, Matthew Wilcox wrote: > From: "Matthew Wilcox (Oracle)" > > Improved compatibility with bvec > > Signed-off-by: Matthew Wilcox (Oracle) > --- > include/linux/skbuff.h | 10 +- > 1 file changed, 5 insertions(+), 5 deletions(-) > > diff --git a/include

Re: [PATCH v3 4/7] net: Reorder the contents of skb_frag_t

2019-07-23 Thread Saeed Mahameed
On Fri, 2019-07-12 at 06:43 -0700, Matthew Wilcox wrote: > From: "Matthew Wilcox (Oracle)" > > Match the layout of bio_vec. > > Signed-off-by: Matthew Wilcox (Oracle) > --- > include/linux/skbuff.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/include/linux/skbuff.h

Re: [PATCH bpf] libbpf: fix using uninitialized ioctl results

2019-07-23 Thread Alexei Starovoitov
On Tue, Jul 23, 2019 at 5:08 AM Ilya Maximets wrote: > > 'channels.max_combined' initialized only on ioctl success and > errno is only valid on ioctl failure. > > The code doesn't produce any runtime issues, but makes memory > sanitizers angry: > > Conditional jump or move depends on uninitialise

Re: [PATCH v2 bpf-next] libbpf: provide more helpful message on uninitialized global var

2019-07-23 Thread Song Liu
> On Jul 23, 2019, at 2:11 PM, Andrii Nakryiko wrote: > > When BPF program defines uninitialized global variable, it's put into > a special COMMON section. Libbpf will reject such programs, but will > provide very unhelpful message with garbage-looking section index. > > This patch detects sp

Re: [PATCH v2 bpf-next 1/5] selftests/bpf: convert test_get_stack_raw_tp to perf_buffer API

2019-07-23 Thread Song Liu
> On Jul 23, 2019, at 2:34 PM, Andrii Nakryiko wrote: > > Convert test_get_stack_raw_tp test to new perf_buffer API. > > Signed-off-by: Andrii Nakryiko Acked-by: Song Liu

[PATCH bpf-next] libbpf: silence GCC8 warning about string truncation

2019-07-23 Thread Andrii Nakryiko
Despite a proper NULL-termination after strncpy(..., ..., IFNAMSIZ - 1), GCC8 still complains about *expected* string truncation: xsk.c:330:2: error: 'strncpy' output may be truncated copying 15 bytes from a string of length 15 [-Werror=stringop-truncation] strncpy(ifr.ifr_name, xsk->ifnam

Re: [PATCH v4 net-next 18/19] ionic: Add coalesce and other features

2019-07-23 Thread David Miller
From: Shannon Nelson Date: Mon, 22 Jul 2019 14:40:22 -0700 > diff --git a/drivers/net/ethernet/pensando/ionic/ionic_ethtool.c > b/drivers/net/ethernet/pensando/ionic/ionic_ethtool.c > index 742d7d47f4d8..e6b579a40b70 100644 > --- a/drivers/net/ethernet/pensando/ionic/ionic_ethtool.c > +++ b/driv

Re: [PATCH v4 net-next 19/19] ionic: Add basic devlink interface

2019-07-23 Thread David Miller
From: Shannon Nelson Date: Mon, 22 Jul 2019 14:40:23 -0700 > +struct ionic *ionic_devlink_alloc(struct device *dev) > +{ > + struct devlink *dl; > + struct ionic *ionic; Reverse christmas tree please.

Re: [PATCH v4 net-next 14/19] ionic: Add Tx and Rx handling

2019-07-23 Thread David Miller
From: Shannon Nelson Date: Mon, 22 Jul 2019 14:40:18 -0700 > Add both the Tx and Rx queue setup and handling. The related > stats display comes later. Instead of using the generic napi > routines used by the slow-path commands, the Tx and Rx paths > are simplified and inlined in one file in ord

[PATCH v2 bpf-next 5/5] selftests/bpf: remove perf buffer helpers

2019-07-23 Thread Andrii Nakryiko
libbpf's perf_buffer API supersedes trace_helper.h's helpers. Remove those helpers after all existing users were already moved to perf_buffer API. Signed-off-by: Andrii Nakryiko Acked-by: Song Liu --- tools/testing/selftests/bpf/trace_helpers.c | 125 tools/testing/selftest

[PATCH v2 bpf-next 4/5] samples/bpf: switch trace_output sample to perf_buffer API

2019-07-23 Thread Andrii Nakryiko
Convert trace_output sample to libbpf's perf_buffer API. Signed-off-by: Andrii Nakryiko Acked-by: Song Liu --- samples/bpf/trace_output_user.c | 43 +++-- 1 file changed, 14 insertions(+), 29 deletions(-) diff --git a/samples/bpf/trace_output_user.c b/samples/bpf/tr

[PATCH v2 bpf-next 3/5] samples/bpf: convert xdp_sample_pkts_user to perf_buffer API

2019-07-23 Thread Andrii Nakryiko
Convert xdp_sample_pkts_user to libbpf's perf_buffer API. Signed-off-by: Andrii Nakryiko Acked-by: Song Liu Acked-by: Toke Høiland-Jørgensen --- samples/bpf/xdp_sample_pkts_user.c | 61 +- 1 file changed, 17 insertions(+), 44 deletions(-) diff --git a/samples/bpf/x

[PATCH v2 bpf-next 1/5] selftests/bpf: convert test_get_stack_raw_tp to perf_buffer API

2019-07-23 Thread Andrii Nakryiko
Convert test_get_stack_raw_tp test to new perf_buffer API. Signed-off-by: Andrii Nakryiko --- .../bpf/prog_tests/get_stack_raw_tp.c | 78 ++- .../bpf/progs/test_get_stack_rawtp.c | 2 +- 2 files changed, 44 insertions(+), 36 deletions(-) diff --git a/tools/test

[PATCH v2 bpf-next 0/5] switch samples and tests to libbpf perf buffer API

2019-07-23 Thread Andrii Nakryiko
There were few more tests and samples that were using custom perf buffer setup code from trace_helpers.h. This patch set gets rid of all the usages of those and removes helpers themselves. Libbpf provides nicer, but equally powerful set of APIs to work with perf ring buffers, so let's have all the

Re: [PATCH iproute2] etf: make printing of variable JSON friendly

2019-07-23 Thread Patel, Vedang
> On Jul 22, 2019, at 5:11 PM, David Ahern wrote: > > On 7/22/19 1:11 PM, Patel, Vedang wrote: >> >> >>> On Jul 22, 2019, at 11:21 AM, David Ahern wrote: >>> >>> On 7/19/19 3:40 PM, Vedang Patel wrote: In iproute2 txtime-assist series, it was pointed out that print_bool() should b

Re: [PATCH v4 net-next 13/19] ionic: Add initial ethtool support

2019-07-23 Thread David Miller
From: Shannon Nelson Date: Mon, 22 Jul 2019 14:40:17 -0700 > +static int ionic_get_link_ksettings(struct net_device *netdev, > + struct ethtool_link_ksettings *ks) > +{ > + struct lif *lif = netdev_priv(netdev); > + struct ionic_dev *idev = &lif->ionic->ide

[PATCH v2 bpf-next 2/5] selftests/bpf: switch test_tcpnotify to perf_buffer API

2019-07-23 Thread Andrii Nakryiko
Switch test_tcpnotify test to use libbpf's perf_buffer API instead of re-implementing portion of it. Signed-off-by: Andrii Nakryiko Acked-by: Song Liu --- .../selftests/bpf/test_tcpnotify_user.c | 90 --- 1 file changed, 36 insertions(+), 54 deletions(-) diff --git a/tool

Re: [PATCH v4 net-next 11/19] ionic: Add Rx filter and rx_mode ndo support

2019-07-23 Thread David Miller
From: Shannon Nelson Date: Mon, 22 Jul 2019 14:40:15 -0700 > + if (in_interrupt()) { > + work = kzalloc(sizeof(*work), GFP_ATOMIC); > + if (!work) { > + netdev_err(lif->netdev, "%s OOM\n", __func__); > + return -ENOMEM; > +

Re: [PATCH v4 net-next 06/19] ionic: Add basic adminq support

2019-07-23 Thread David Miller
From: Shannon Nelson Date: Mon, 22 Jul 2019 14:40:10 -0700 > +struct queue { ... > +struct cq { ... > +struct napi_stats { ... > +struct q_stats { ... > +struct qcq { Using names like these and "dev_queue" are just asking for conflicts with the global datastructure namespace both now and in

Re: [PATCH v4 net-next 05/19] ionic: Add interrupts and doorbells

2019-07-23 Thread David Miller
From: Shannon Nelson Date: Mon, 22 Jul 2019 14:40:09 -0700 > The ionic interrupt model is based on interrupt control blocks > accessed through the PCI BAR. Doorbell registers are used by > the driver to signal to the NIC that requests are waiting on > the message queues. Interrupts are used by

Re: [PATCH v4 net-next 02/19] ionic: Add hardware init and device commands

2019-07-23 Thread David Miller
From: Shannon Nelson Date: Mon, 22 Jul 2019 14:40:06 -0700 > +void ionic_init_devinfo(struct ionic_dev *idev) > +{ > + idev->dev_info.asic_type = ioread8(&idev->dev_info_regs->asic_type); > + idev->dev_info.asic_rev = ioread8(&idev->dev_info_regs->asic_rev); > + > + memcpy_fromio(idev

Re: [net-next 0/6][pull request] 1GbE Intel Wired LAN Driver Updates 2019-07-23

2019-07-23 Thread Saeed Mahameed
On Tue, 2019-07-23 at 10:36 -0700, Jeff Kirsher wrote: > This series contains updates to igc and e1000e client drivers only. > > Sasha provides a couple of cleanups to remove code that is not needed > and reduce structure sizes. Updated the MAC reset flow to use the > device reset flow instead of

Re: [PATCH bpf 0/2] bpf: gso_segs fixes

2019-07-23 Thread Alexei Starovoitov
On Tue, Jul 23, 2019 at 3:15 AM Eric Dumazet wrote: > > First patch changes the kernel, second patch > adds a new test. > > Note that other patches might be needed to take > care of similar issues in sock_ops_convert_ctx_access() > and SOCK_OPS_GET_FIELD() Nice catch! Applied to bpf tree. Thanks

[PATCH v2 bpf-next] libbpf: provide more helpful message on uninitialized global var

2019-07-23 Thread Andrii Nakryiko
When BPF program defines uninitialized global variable, it's put into a special COMMON section. Libbpf will reject such programs, but will provide very unhelpful message with garbage-looking section index. This patch detects special section cases and gives more explicit error message. Signed-off-

Re: [PATCH v1] net: thunderx: Use fwnode_get_mac_address()

2019-07-23 Thread David Miller
From: Andy Shevchenko Date: Tue, 23 Jul 2019 23:03:43 +0300 > Replace the custom implementation with fwnode_get_mac_address, > which works on both DT and ACPI platforms. > > While here, replace memcpy() by ether_addr_copy(). > > Signed-off-by: Andy Shevchenko Applied.

Re: [PATCH v2 00/10] XDP unaligned chunk placement support

2019-07-23 Thread Alexei Starovoitov
Johnathan, Bjorn, Jakub, Please review! The patch set has been pending for a week. On Tue, Jul 16, 2019 at 4:21 AM Kevin Laatz wrote: > > This patch set adds the ability to use unaligned chunks in the XDP umem. > > Currently, all chunk addresses passed to the umem are masked to be chunk > size al

Re: [PATCH net-next 1/1] tc-testing: added tdc tests for [b|p]fifo qdisc

2019-07-23 Thread David Miller
From: Roman Mashak Date: Tue, 23 Jul 2019 15:01:59 -0400 > Signed-off-by: Roman Mashak Always love to see new tests... Applied.

Re: [net-next 6/6] e1000e: disable force K1-off feature

2019-07-23 Thread David Miller
From: Jeff Kirsher Date: Tue, 23 Jul 2019 10:36:50 -0700 > diff --git a/drivers/net/ethernet/intel/e1000e/hw.h > b/drivers/net/ethernet/intel/e1000e/hw.h > index eff75bd8a8f0..e3c71fd093ee 100644 > --- a/drivers/net/ethernet/intel/e1000e/hw.h > +++ b/drivers/net/ethernet/intel/e1000e/hw.h > @@ -

Re: [PATCH bpf v3] bpf: fix narrower loads on s390

2019-07-23 Thread Alexei Starovoitov
On Fri, Jul 19, 2019 at 2:18 AM Ilya Leoshkevich wrote: > > The very first check in test_pkt_md_access is failing on s390, which > happens because loading a part of a struct __sk_buff field produces > an incorrect result. > > The preprocessed code of the check is: > > { > __u8 tmp = *((vol

Re: [PATCH net-next] dpaa2-eth: Don't use netif_receive_skb_list for TCP frames

2019-07-23 Thread David Miller
From: Ioana Radulescu Date: Tue, 23 Jul 2019 20:28:43 +0300 > Using Rx skb bulking for all frames may negatively impact the > performance in some TCP termination scenarios, as it effectively > bypasses GRO. "may"? Please provide numbers so that we know exactly whether it actually hurts performa

Re: [PATCH v1] hv_sock: Use consistent types for UUIDs

2019-07-23 Thread David Miller
From: Andy Shevchenko Date: Tue, 23 Jul 2019 19:39:43 +0300 > The rest of Hyper-V code is using new types for UUID handling. > Convert hv_sock as well. > > Signed-off-by: Andy Shevchenko Applied to net-next.

Re: [PATCH] sky2: Disable MSI on ASUS P6T

2019-07-23 Thread David Miller
From: Takashi Iwai Date: Tue, 23 Jul 2019 17:15:25 +0200 > The onboard sky2 NIC on ASUS P6T WS PRO doesn't work after PM resume > due to the infamous IRQ problem. Disabling MSI works around it, so > let's add it to the blacklist. > > Unfortunately the BIOS on the machine doesn't fill the standa

Re: [PATCH net-next 0/4] nfp: Offload MPLS actions

2019-07-23 Thread David Miller
From: John Hurley Date: Tue, 23 Jul 2019 15:33:58 +0100 > The module act_mpls has recently been added to the kernel. This allows the > manipulation of MPLS headers on packets including push, pop and modify. > Add these new actions and parameters to the intermediate representation > API for hardwa

Re: [bpf-next 6/6] selftests/bpf: add test for bpf_tcp_gen_syncookie

2019-07-23 Thread Alexei Starovoitov
On Tue, Jul 23, 2019 at 10:37:29AM +0100, Lorenz Bauer wrote: > On Tue, 23 Jul 2019 at 01:20, Petar Penkov wrote: > > +static __always_inline __s64 gen_syncookie(void *data_end, struct bpf_sock > > *sk, > > + void *iph, __u32 ip_size, > > +

Re: [PATCH net-next v2] net/mlx5e: xsk: dynamically allocate mlx5e_channel_param

2019-07-23 Thread David Miller
From: Maxim Mikityanskiy Date: Tue, 23 Jul 2019 12:02:26 + > From: Arnd Bergmann > > The structure is too large to put on the stack, resulting in a > warning on 32-bit ARM: > > drivers/net/ethernet/mellanox/mlx5/core/en/xsk/setup.c:59:5: error: stack > frame size of 1344 bytes in function

Re: [PATCH] net: dsa: mv88e6xxx: chip: Add of_node_put() before return

2019-07-23 Thread David Miller
From: Nishka Dasgupta Date: Tue, 23 Jul 2019 16:13:07 +0530 > Each iteration of for_each_available_child_of_node puts the previous > node, but in the case of a return from the middle of the loop, there is > no put, thus causing a memory leak. Hence add an of_node_put before the > return. > Issue

Re: [PATCH mlx5-next] net/mlx5: Fix modify_cq_in alignment

2019-07-23 Thread Saeed Mahameed
On Tue, 2019-07-23 at 13:02 -0700, David Miller wrote: > From: Leon Romanovsky > Date: Tue, 23 Jul 2019 22:04:14 +0300 > > > The intention was to have this patch in shared mlx5 branch, which > > is > > picked by RDMA too. This "Cc: stable@..." together with merge > > through > > RDMA will ensure

Re: [PATCH mlx5-next] net/mlx5: Fix modify_cq_in alignment

2019-07-23 Thread Saeed Mahameed
On Tue, 2019-07-23 at 22:04 +0300, Leon Romanovsky wrote: > On Tue, Jul 23, 2019 at 11:28:50AM -0700, David Miller wrote: > > From: Leon Romanovsky > > Date: Tue, 23 Jul 2019 10:12:55 +0300 > > > > > From: Edward Srouji > > > > > > Fix modify_cq_in alignment to match the device specification. >

Re: [PATCH net 0/2] selftests: forwarding: GRE multipath fixes

2019-07-23 Thread David Miller
From: Ido Schimmel Date: Tue, 23 Jul 2019 11:19:24 +0300 > From: Ido Schimmel > > Patch #1 ensures IPv4 forwarding is enabled during the test. > > Patch #2 fixes the flower filters used to measure the distribution of > the traffic between the two nexthops, so that the test will pass > regardle

[PATCH v1] net: thunderx: Use fwnode_get_mac_address()

2019-07-23 Thread Andy Shevchenko
Replace the custom implementation with fwnode_get_mac_address, which works on both DT and ACPI platforms. While here, replace memcpy() by ether_addr_copy(). Signed-off-by: Andy Shevchenko --- .../net/ethernet/cavium/thunder/thunder_bgx.c | 18 ++ 1 file changed, 6 insertions(+)

Re: [PATCH mlx5-next] net/mlx5: Fix modify_cq_in alignment

2019-07-23 Thread David Miller
From: Leon Romanovsky Date: Tue, 23 Jul 2019 22:04:14 +0300 > The intention was to have this patch in shared mlx5 branch, which is > picked by RDMA too. This "Cc: stable@..." together with merge through > RDMA will ensure that such patch will be part of stable automatically. Why wouldn't it come

Re: [patch iproute2 1/2] tc: action: fix crash caused by incorrect *argv check

2019-07-23 Thread Jiri Pirko
Tue, Jul 23, 2019 at 07:54:01PM CEST, step...@networkplumber.org wrote: >On Tue, 23 Jul 2019 13:25:37 +0200 >Jiri Pirko wrote: > >> From: Jiri Pirko >> >> One cannot depend on *argv being null in case of no arg is left on the >> command line. For example in batch mode, this is not always true. C

Re: [PATCH mlx5-next] net/mlx5: Fix modify_cq_in alignment

2019-07-23 Thread Leon Romanovsky
On Tue, Jul 23, 2019 at 11:28:50AM -0700, David Miller wrote: > From: Leon Romanovsky > Date: Tue, 23 Jul 2019 10:12:55 +0300 > > > From: Edward Srouji > > > > Fix modify_cq_in alignment to match the device specification. > > After this fix the 'cq_umem_valid' field will be in the right offset. >

[PATCH net-next 1/1] tc-testing: added tdc tests for [b|p]fifo qdisc

2019-07-23 Thread Roman Mashak
Signed-off-by: Roman Mashak --- .../selftests/tc-testing/tc-tests/qdiscs/fifo.json | 304 + 1 file changed, 304 insertions(+) create mode 100644 tools/testing/selftests/tc-testing/tc-tests/qdiscs/fifo.json diff --git a/tools/testing/selftests/tc-testing/tc-tests/qdiscs/fifo.

Re: [net-next:master 13/14] drivers/net/ethernet/faraday/ftgmac100.c:777:13: error: 'skb_frag_t {aka struct bio_vec}' has no member named 'size'

2019-07-23 Thread David Miller
From: Matthew Wilcox Date: Tue, 23 Jul 2019 04:52:38 -0700 > On Tue, Jul 23, 2019 at 08:58:44AM +, René van Dorst wrote: >> Hi Matthew, >> >> I see the same issue for the mediatek/mtk_eth_soc driver. > > Thanks, Rene. The root problem for both of these drivers is that neither > are built o

Re: [PATCH] net-ipv6-ndisc: add support for RFC7710 RA Captive Portal Identifier

2019-07-23 Thread David Miller
From: Maciej Żenczykowski Date: Tue, 23 Jul 2019 17:52:17 +0800 >> Applied to net-next > > Any chance we could get this into LTS releases? It's a new feature, not a bug fix. So no.

Re: [net-next:master 13/14] drivers/net/ethernet/faraday/ftgmac100.c:777:13: error: 'skb_frag_t {aka struct bio_vec}' has no member named 'size'

2019-07-23 Thread David Miller
Fixes as follows: >From 084323f62b0b976c9fd931d86c5d2553af5eb9f7 Mon Sep 17 00:00:00 2001 From: "David S. Miller" Date: Tue, 23 Jul 2019 11:45:44 -0700 Subject: [PATCH] ftgmac100: Fix build. MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding

Re: [PATCH net-next] qlge: Move drivers/net/ethernet/qlogic/qlge/ to drivers/staging/qlge/

2019-07-23 Thread David Miller
From: Benjamin Poirier Date: Tue, 23 Jul 2019 15:14:13 +0900 > The hardware has been declared EOL by the vendor more than 5 years ago. > What's more relevant to the Linux kernel is that the quality of this driver > is not on par with many other mainline drivers. > > Cc: Manish Chopra > Message-

Re: [PATCH mlx5-next] net/mlx5: Fix modify_cq_in alignment

2019-07-23 Thread David Miller
From: Leon Romanovsky Date: Tue, 23 Jul 2019 10:12:55 +0300 > From: Edward Srouji > > Fix modify_cq_in alignment to match the device specification. > After this fix the 'cq_umem_valid' field will be in the right offset. > > Cc: # 4.19 > Fixes: bd37197554eb ("net/mlx5: Update mlx5_ifc with DEV

Re: [PATCH net 1/2] linux/dim: Fix overflow in dim calculation

2019-07-23 Thread Leon Romanovsky
On Tue, Jul 23, 2019 at 05:22:43PM +, Saeed Mahameed wrote: > On Tue, 2019-07-23 at 10:22 +0300, Leon Romanovsky wrote: > > From: Yamin Friedman > > > > While using net_dim, a dim_sample was used without ever initializing > > the > > comps value. Added use of DIV_ROUND_DOWN_ULL() to prevent po

  1   2   >