On 7/23/19 2:35 PM, David Miller wrote:
From: Shannon Nelson <snel...@pensando.io> Date: Mon, 22 Jul 2019 14:40:17 -0700+static int ionic_get_link_ksettings(struct net_device *netdev, + struct ethtool_link_ksettings *ks) +{ + struct lif *lif = netdev_priv(netdev); + struct ionic_dev *idev = &lif->ionic->idev; + int copper_seen = 0;Reverse christmas tree ordering here please.
Sure. Most of these are because I wanted to do the one assignment first, from which the others are based. I'll rework these to add the init lines after the declarations. Same in the other files.
sln
+static int ionic_set_link_ksettings(struct net_device *netdev, + const struct ethtool_link_ksettings *ks) +{ + struct lif *lif = netdev_priv(netdev); + struct ionic *ionic = lif->ionic; + struct ionic_dev *idev = &lif->ionic->idev; + u8 fec_type = PORT_FEC_TYPE_NONE; + u32 req_rs, req_fc; + int err = 0;Likewise.+static void ionic_get_pauseparam(struct net_device *netdev, + struct ethtool_pauseparam *pause) +{ + struct lif *lif = netdev_priv(netdev); + struct ionic_dev *idev = &lif->ionic->idev; + uint8_t pause_type = idev->port_info->config.pause_type;Likewise.+static int ionic_set_pauseparam(struct net_device *netdev, + struct ethtool_pauseparam *pause) +{ + struct lif *lif = netdev_priv(netdev); + struct ionic *ionic = lif->ionic; + struct ionic_dev *idev = &lif->ionic->idev; + u32 requested_pause; + int err;Likewise.+static int ionic_get_module_info(struct net_device *netdev, + struct ethtool_modinfo *modinfo) + +{ + struct lif *lif = netdev_priv(netdev); + struct ionic_dev *idev = &lif->ionic->idev; + struct xcvr_status *xcvr;Likewise.+static int ionic_get_module_eeprom(struct net_device *netdev, + struct ethtool_eeprom *ee, + u8 *data) +{ + struct lif *lif = netdev_priv(netdev); + struct ionic_dev *idev = &lif->ionic->idev; + struct xcvr_status *xcvr; + u32 len;Likewise.
