On Fri, 2019-07-12 at 06:43 -0700, Matthew Wilcox wrote:
> From: "Matthew Wilcox (Oracle)" <wi...@infradead.org>
>
> Improved compatibility with bvec
>
> Signed-off-by: Matthew Wilcox (Oracle) <wi...@infradead.org>
> ---
> include/linux/skbuff.h | 10 +++++-----
> 1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/include/linux/skbuff.h b/include/linux/skbuff.h
> index 8076e2ba8349..e849e411d1f3 100644
> --- a/include/linux/skbuff.h
> +++ b/include/linux/skbuff.h
> @@ -312,7 +312,7 @@ typedef struct skb_frag_struct skb_frag_t;
>
> struct skb_frag_struct {
> struct page *bv_page;
> - __u32 size;
> + unsigned int bv_len;
> __u32 page_offset;
Why do you keep page_offset name and type as is ? it will make the last
patch much cleaner if you change it to "unsigned int bv_offset".
unsigned int and __u32 on both 32bit and 64bit are the same aren't they
?
> };
>
> @@ -322,7 +322,7 @@ struct skb_frag_struct {
> */
> static inline unsigned int skb_frag_size(const skb_frag_t *frag)
> {
> - return frag->size;
> + return frag->bv_len;
> }
>
> /**
> @@ -332,7 +332,7 @@ static inline unsigned int skb_frag_size(const
> skb_frag_t *frag)
> */
> static inline void skb_frag_size_set(skb_frag_t *frag, unsigned int
> size)
> {
> - frag->size = size;
> + frag->bv_len = size;
> }
>
> /**
> @@ -342,7 +342,7 @@ static inline void skb_frag_size_set(skb_frag_t
> *frag, unsigned int size)
> */
> static inline void skb_frag_size_add(skb_frag_t *frag, int delta)
> {
> - frag->size += delta;
> + frag->bv_len += delta;
> }
>
> /**
> @@ -352,7 +352,7 @@ static inline void skb_frag_size_add(skb_frag_t
> *frag, int delta)
> */
> static inline void skb_frag_size_sub(skb_frag_t *frag, int delta)
> {
> - frag->size -= delta;
> + frag->bv_len -= delta;
> }
>
> /**
