Tue, Jul 23, 2019 at 07:54:01PM CEST, step...@networkplumber.org wrote: >On Tue, 23 Jul 2019 13:25:37 +0200 >Jiri Pirko <j...@resnulli.us> wrote: > >> From: Jiri Pirko <j...@mellanox.com> >> >> One cannot depend on *argv being null in case of no arg is left on the >> command line. For example in batch mode, this is not always true. Check >> argc instead to prevent crash. >> >> Reported-by: Alex Kushnarov <alexand...@mellanox.com> >> Fixes: fd8b3d2c1b9b ("actions: Add support for user cookies") >> Signed-off-by: Jiri Pirko <j...@mellanox.com> > >Actually makeargs does NULL terminate the last arg so what input >to batchmode is breaking this?
Interesting, there must be another but out there then. My input is: filter add dev testdummy parent ffff: protocol all prio 11000 flower action drop filter add dev testdummy parent ffff: protocol ipv4 prio 1 flower dst_mac 11:22:33:44:55:66 action drop