Re: [PATCH V2] mm: Replace all open encodings for NUMA_NO_NODE

2018-11-26 Thread Michael Ellerman
Anshuman Khandual writes: > At present there are multiple places where invalid node number is encoded > as -1. Even though implicitly understood it is always better to have macros > in there. Replace these open encodings for an invalid node number with the > global macro NUMA_NO_NODE. This helps r

Re: [net] xfrm_user: use xfrm_state_put to free xfrm_state_alloc return value

2018-11-26 Thread Steffen Klassert
On Thu, Nov 22, 2018 at 10:43:21PM +0800, Herbert Xu wrote: > On Wed, Nov 21, 2018 at 09:09:23PM +0100, Mathias Krause wrote: > > > > -- >8 -- > > > > Subject: [PATCH] xfrm_user: fix freeing of xfrm states on acquire > > > > Commit 565f0fa902b6 ("xfrm: use a dedicated slab cache for struct > > x

[PATCH] NFC: netlink: remove unexpected nfc_put_device

2018-11-26 Thread Pan Bian
The functions nfc_genl_llc_set_params and nfc_genl_llc_sdreq drops the reference to dev via nfc_put_device on the error branch that no local device is found. However, the error handling block reads dev's field and then put dev again. This may result in use-after-free bugs. The patch removes the une

Re: [PATCH] can: flexcan: Implement CAN Runtime PM

2018-11-26 Thread Marc Kleine-Budde
On 11/27/18 8:44 AM, Joakim Zhang wrote: >>> Flexcan will be disabled during suspend if no wakeup function required >>> and enabled after resume accordingly. During this period, we could >>> explicitly disable clocks. >>> >>> Implement Runtime PM which will: >>> 1) Keep device in suspend state (clo

Re: [PATCH v3 13/13] nvme-tcp: add NVMe over TCP host driver

2018-11-26 Thread Sagi Grimberg
This looks odd.  It's not really the timeout handlers job to call nvme_end_request here. Well.. if we are not yet LIVE, we will not trigger error recovery, which means nothing will complete this command so something needs to do it... I think that we need it for rdma too.. yes we do. and w

[PATCH V2] can: flexcan: implement can Runtime PM

2018-11-26 Thread Joakim Zhang
From: Aisheng Dong Flexcan will be disabled during suspend if no wakeup function required and enabled after resume accordingly. During this period, we could explicitly disable clocks. Implement Runtime PM which will: 1) Keep device in suspend state (clocks disabled) if it's not openned. 2) Make

Re: [PATCH nvme-cli v3 15/13] nvme: Add TCP transport

2018-11-26 Thread Sagi Grimberg
The cli parts good to me. Is there any forseeable issue if I apply these ahead of the kernel integration? I don't see any, but just want to confirm since its all in one series. I don't see an issue, note that its on top of the sqflow patch [1] that I've been meaning to ping you on. [PATCH nvme-

RE: [PATCH] can: flexcan: Implement CAN Runtime PM

2018-11-26 Thread Joakim Zhang
> -Original Message- > From: Marc Kleine-Budde > Sent: 2018年11月21日 22:36 > To: Joakim Zhang ; w...@grandegger.com; > da...@davemloft.net > Cc: linux-...@vger.kernel.org; netdev@vger.kernel.org; > linux-ker...@vger.kernel.org; dl-linux-imx ; Aisheng > DONG > Subject: Re: [PATCH] can: flex

Re: [PATCH -next] pps: using ERR_PTR instead of NULL while pps_register_source fails

2018-11-26 Thread Greg KH
On Mon, Nov 26, 2018 at 11:43:06AM +0100, Rodolfo Giometti wrote: > On 26/11/2018 11:24, YueHaibing wrote: > > pps_register_source() has keeps error codes in a local variable, > > but it does not make use of the code. This patch let it return > > the errcode in case of failure. > > > > Suggested-b

Re: consistency for statistics with XDP mode

2018-11-26 Thread Toshiaki Makita
On 2018/11/26 10:37, Toshiaki Makita wrote: > On 2018/11/23 1:43, David Ahern wrote: >> On 11/21/18 5:53 PM, Toshiaki Makita wrote: We really need consistency in the counters and at a minimum, users should be able to track packet and byte counters for both Rx and Tx including XDP. >>

[PATCH] libceph: fix use after free

2018-11-26 Thread Pan Bian
The function ceph_monc_handle_map calls kfree(old) to free the old monitor map, old points to monc->monmap. However, after that, it reads monc->monmap->epoch and passes it to __ceph_monc_got_map. This result in a use-after-free bug. The patch moves the free operation after the call to __ceph_monc_g

[PATCH net-next 2/2] bnx2x: Add storm FW version to ethtool driver query output.

2018-11-26 Thread Sudarsana Reddy Kalluru
The patch populates the Storm FW version in the ethtool driver query data. Signed-off-by: Sudarsana Reddy Kalluru Signed-off-by: Ariel Elior --- drivers/net/ethernet/broadcom/bnx2x/bnx2x_ethtool.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/drivers/net/ethernet/broadcom/bnx2x/bnx2

[PATCH net-next 0/2] bnx2x: Popoulate firmware versions in driver info query.

2018-11-26 Thread Sudarsana Reddy Kalluru
From: Sudarsana Reddy Kalluru The patch series populates MBI and storm firware versions in the ethtool driver info query. Please consider applying it to 'net-next' tree. Sudarsana Reddy Kalluru (2): bnx2x: Add MBI version to ethtool driver query output. bnx2x: Add storm FW version to ethtoo

[PATCH net-next 1/2] bnx2x: Add MBI version to ethtool driver query output.

2018-11-26 Thread Sudarsana Reddy Kalluru
The patch populates the MBI version in the ethtool driver query data. Adding 'extended_dev_info_shared_cfg' structure describing the nvram structure, this is required to access the mbi version string. Signed-off-by: Sudarsana Reddy Kalluru Signed-off-by: Ariel Elior --- .../net/ethernet/broadco

Re: [PATCH v2 4/4] net: macb: Add support for suspend/resume with full power down

2018-11-26 Thread Harini Katakam
Hi Claudiu, On Mon, Nov 26, 2018 at 8:16 PM wrote: > > > > On 26.11.2018 09:07, Harini Katakam wrote: > > In the previous version you said you encountered some crashes while > stressing this part if macb_open()/macb_close() was used in here. Could you > share the tests so that I can debug it on

[PATCH net-next] cxgb4: number of VFs supported is not always 16

2018-11-26 Thread Ganesh Goudar
Total number of VFs supported by PF is used determine the last byte of VF's mac address. Number of VFs supported is not always 16, use the variable nvfs to get the number of VFs supported rather than hard coding it to 16. Signed-off-by: Casey Leedom Signed-off-by: Ganesh Goudar --- drivers/net/

Re: [PATCH net-next v3 00/13] virtio: support packed ring

2018-11-26 Thread David Miller
From: "Michael S. Tsirkin" Date: Tue, 27 Nov 2018 01:08:08 -0500 > On Wed, Nov 21, 2018 at 06:03:17PM +0800, Tiwei Bie wrote: >> Hi, >> >> This patch set implements packed ring support in virtio driver. >> >> A performance test between pktgen (pktgen_sample03_burst_single_flow.sh) >> and DPDK v

Re: [PATCH net-next v3 00/13] virtio: support packed ring

2018-11-26 Thread Michael S. Tsirkin
On Wed, Nov 21, 2018 at 06:03:17PM +0800, Tiwei Bie wrote: > Hi, > > This patch set implements packed ring support in virtio driver. > > A performance test between pktgen (pktgen_sample03_burst_single_flow.sh) > and DPDK vhost (testpmd/rxonly/vhost-PMD) has been done, I saw > ~30% performance gai

Re: [PATCH v5 5/6] vxlan: handle underlay VRF changes

2018-11-26 Thread Roopa Prabhu
On Mon, Nov 26, 2018 at 5:04 PM Alexis Bauvin wrote: > > When underlay VRF changes, either because the lower device itself changed, > or its VRF changed, this patch releases the current socket of the VXLAN > device and recreates another one in the right VRF. This allows for > on-the-fly change of

[PATCH bpf] sparc: Adjust bpf JIT prologue for PSEUDO calls.

2018-11-26 Thread David Miller
Move all arguments into output registers from input registers. This path is exercised by test_verifier.c's "calls: two calls with args" test. Adjust BPF_TAILCALL_PROLOGUE_SKIP as needed. Let's also make the prologue length a constant size regardless of the combination of ->saw_frame_pointer an

Re: [PATCH v2 1/4] net: macb: Check MDIO state before read/write and use timeouts

2018-11-26 Thread Harini Katakam
Hi Andrew, > > +#define MACB_IDLE_MASK (1 << MACB_IDLE_OFFSET) > > I think you could use the MACB_BIT() macro here. > > But otherwise, > > Reviewed-by: Andrew Lunn Thanks, will fix this in next series. Regards, Harini

Re: [PATCH v2 1/4] net: macb: Check MDIO state before read/write and use timeouts

2018-11-26 Thread Harini Katakam
Hi Claudiu, On Mon, Nov 26, 2018 at 8:22 PM Andrew Lunn wrote: > > On Mon, Nov 26, 2018 at 02:46:01PM +, claudiu.bez...@microchip.com wrote: > > Hi Harini, > > > > On 26.11.2018 09:07, Harini Katakam wrote: > > > From: Harini Katakam > > > > > > Replace the while loop in MDIO read/write funct

[PATCH bpf-next 1/3] bpf: btf: check name validity for various types

2018-11-26 Thread Yonghong Song
Commit 2667a2626f4d ("bpf: btf: Add BTF_KIND_FUNC and BTF_KIND_FUNC_PROTO") checked the name validity for BTF_KIND_FUNC/BTF_KIND_FUNC_PROTO types such that: . BTF_KIND_FUNC must have a valid identifier name . BTF_KIND_PROTO must have a null name . The argument name of BTF_KIND_FUNC/BTF_KIND_FUNC

[PATCH bpf-next 2/3] tools/bpf: fix two test_btf unit test cases

2018-11-26 Thread Yonghong Song
From: Martin KaFai Lau There are two unit test cases, which should encode TYPEDEF type, but instead encode PTR type. The error is flagged out after enforcing name checking in the previous patch. Fixes: c0fa1b6c3efc ("bpf: btf: Add BTF tests") Signed-off-by: Martin KaFai Lau Signed-off-by: Yongh

[PATCH bpf-next 3/3] tools/bpf: add addition type tests to test_btf

2018-11-26 Thread Yonghong Song
The following additional unit testcases are added to test_btf: BTF raw test[65] (typedef (invalid name, name_off = 0)): OK BTF raw test[66] (typedef (invalid name, invalid identifier)): OK BTF raw test[67] (ptr type (invalid name, name_off <> 0)): OK BTF raw test[68] (volatile type (invalid

[PATCH bpf-next 0/3] bpf: btf: check name validity for various types

2018-11-26 Thread Yonghong Song
Commit 2667a2626f4d ("bpf: btf: Add BTF_KIND_FUNC and BTF_KIND_FUNC_PROTO") checked the name validity for BTF_KIND_FUNC/FUNC_PROTO types. This patch added name checking for PTR, ARRAY, VOLATILE, TYPEDEF, CONST, RESTRICT, STRUCT, UNION, ENUM and FWD types. Such a strict name checking makes BTF more

Re: [Intel-wired-lan] [PATCH net] ixgbe: recognize 1000BaseLX SFP modules as 1Gbps

2018-11-26 Thread David Miller
From: Josh Elsasser Date: Mon, 26 Nov 2018 16:54:11 -0800 > Jeff Kirsher wrote: > >> No need to re-spin the patch, just reply with the additional "Fixes" >> tag and if patchwork does not pick it up, I will add it to the patch I >> have in my tree for validation and review. > > Thanks, let’s tr

Re: [PATCH] mv88e6060 station roaming

2018-11-26 Thread Andrew Lunn
On Mon, Nov 26, 2018 at 09:31:02PM -0200, Alacn wrote: > hello, > > I'm sending a patch for Marvell 88e6060 driver. > > Problem description: > Multiple APs with inter-AP roaming connected to different ports, > when station moves from one AP on one port to another AP on another port, > traffic flo

Re: [PATCH] mv88e6060 station roaming

2018-11-26 Thread Andrew Lunn
On Mon, Nov 26, 2018 at 09:31:02PM -0200, Alacn wrote: > hello, > > I'm sending a patch for Marvell 88e6060 driver. > > Problem description: > Multiple APs with inter-AP roaming connected to different ports, > when station moves from one AP on one port to another AP on another port, > traffic flo

Re: [iproute2-next PATCH v4] tc: flower: Classify packets based port ranges

2018-11-26 Thread Stephen Hemminger
On Mon, 26 Nov 2018 17:56:10 -0800 "Nambiar, Amritha" wrote: > On 11/26/2018 4:43 PM, David Ahern wrote: > > On 11/26/18 5:23 PM, Nambiar, Amritha wrote: > >>> Can tc flower use something similar to ip ru with single port or port > >>> range handled like this? > >>> > >>> },{ > >>>

Re: [PATCH bpf-next v2 0/4] libbpf: ABI versioning and documentation

2018-11-26 Thread Alexei Starovoitov
On Fri, Nov 23, 2018 at 04:44:31PM -0800, Andrey Ignatov wrote: > This patch set adds ABI versioning and documentation to libbpf. > > Patch 1 renames btf_get_from_id to btf__get_from_id to follow naming > convention. > Patch 2 adds version script and has more details on ABI versioning. > Patch 3 a

Re: [RFCv3 PATCH 1/6] uacce: Add documents for WarpDrive/uacce

2018-11-26 Thread Kenneth Lee
On Tue, Nov 20, 2018 at 10:30:55AM +0800, Kenneth Lee wrote: > Date: Tue, 20 Nov 2018 10:30:55 +0800 > From: Kenneth Lee > To: Leon Romanovsky > CC: Tim Sell , linux-...@vger.kernel.org, > Alexander Shishkin , Zaibo Xu > , zhangfei@foxmail.com, linux...@huawei.com, > haojian.zhu...@linaro.

Re: [PATCH net-next 1/2] br_netfilter: add struct netns_brnf

2018-11-26 Thread Christian Brauner
On Tue, Nov 27, 2018 at 01:20:47AM +0100, Pablo Neira Ayuso wrote: > Hi, > > On Wed, Nov 07, 2018 at 02:48:58PM +0100, Christian Brauner wrote: > [...] > > diff --git a/include/net/netns/netfilter.h b/include/net/netns/netfilter.h > > index ca043342c0eb..eedbd1ac940e 100644 > > --- a/include/net/n

Re: [PATCH bpf] bpf, doc: add entries of who looks over which jits

2018-11-26 Thread Alexei Starovoitov
On Tue, Nov 27, 2018 at 01:21:00AM +0100, Daniel Borkmann wrote: > Make the high-level BPF JIT entry a general 'catch-all' and add > architecture specific entries to make it more clear who actively > maintains which BPF JIT compiler. The list (L) address implies > that this eventually lands in the

Re: [RFC -next v0 1/3] bpf: modular maps

2018-11-26 Thread Alexei Starovoitov
On Sun, Nov 25, 2018 at 01:09:17PM -0500, Aaron Conole wrote: > This commit allows for map operations to be loaded by an lkm, rather than > needing to be baked into the kernel at compile time. Nack. Please see Documentation/bpf/bpf_design_QA.rst

Re: [PATCH bpf-next 0/2] bpf: support proper non-jit func info

2018-11-26 Thread Alexei Starovoitov
On Sat, Nov 24, 2018 at 11:20:43PM -0800, Yonghong Song wrote: > Commit 838e96904ff3 ("bpf: Introduce bpf_func_info") > added bpf func info support. The userspace is able > to get better ksym's for bpf programs with jit, and > is able to print out func prototypes. > > For a program containing func

Re: [iproute2-next PATCH v4] tc: flower: Classify packets based port ranges

2018-11-26 Thread Nambiar, Amritha
On 11/26/2018 4:43 PM, David Ahern wrote: > On 11/26/18 5:23 PM, Nambiar, Amritha wrote: >>> Can tc flower use something similar to ip ru with single port or port >>> range handled like this? >>> >>> },{ >>> "priority": 32764, >>> "src": "172.16.1.0", >>> "srclen": 24, >

Re: [PATCH bpf] sparc: Correct ctx->saw_frame_pointer logic.

2018-11-26 Thread Alexei Starovoitov
On Mon, Nov 26, 2018 at 02:52:18PM -0800, David Miller wrote: > > We need to initialize the frame pointer register not just if it is > seen as a source operand, but also if it is seen as the destination > operand of a store or an atomic instruction (which effectively is a > source operand). > > T

Re: [PATCH bpf] sparc: Fix JIT fused branch convergance.

2018-11-26 Thread Alexei Starovoitov
On Mon, Nov 26, 2018 at 01:03:46PM -0800, David Miller wrote: > > On T4 and later sparc64 cpus we can use the fused compare and branch > instruction. > > However, it can only be used if the branch destination is in the range > of a signed 10-bit immediate offset. This amounts to 1024 > instructi

Re: [PATCH bpf 0/2] Fix for arm64 jit

2018-11-26 Thread Alexei Starovoitov
On Mon, Nov 26, 2018 at 02:05:37PM +0100, Daniel Borkmann wrote: > This set contains a fix for arm64 BPF JIT. First patch generalizes > ppc64 way of retrieving subprog into bpf_jit_get_func_addr() as core > code and uses the same on arm64 in second patch. Tested on both arm64 > and ppc64. > > Than

Re: [v5, PATCH 2/2] dt-binding: mediatek-dwmac: add binding document for MediaTek MT2712 DWMAC

2018-11-26 Thread biao huang
Dear Rob, Thanks for your comments. On Mon, 2018-11-26 at 15:46 -0600, Rob Herring wrote: > On Fri, Nov 23, 2018 at 09:31:16AM +0800, biao huang wrote: > > Dear Andrew, > > > > Thanks for you remind. > > > > Sincerely, I respect any comment from any reviewer. If I didn't reply > >

Re: [PATCH net-next] net: ethernet: ti: cpsw: drop vid0 configuration in dual_mac modey

2018-11-26 Thread Grygorii Strashko
On 11/26/18 2:07 PM, Ivan Khoronzhuk wrote: > On Mon, Nov 26, 2018 at 12:57:20PM -0600, Grygorii Strashko wrote: >> >> >> On 11/26/18 10:26 AM, Ivan Khoronzhuk wrote: >>> On Sun, Nov 25, 2018 at 05:46:26PM -0600, Grygorii Strashko wrote: In dual_mac mode CPSW driver uses vid1 and vid2 by de

[PATCH v5 3/6] vxlan: add support for underlay in non-default VRF

2018-11-26 Thread Alexis Bauvin
Creating a VXLAN device with is underlay in the non-default VRF makes egress route lookup fail or incorrect since it will resolve in the default VRF, and ingress fail because the socket listens in the default VRF. This patch binds the underlying UDP tunnel socket to the l3mdev of the lower device

[PATCH v5 2/6] l3mdev: add function to retreive upper master

2018-11-26 Thread Alexis Bauvin
Existing functions to retreive the l3mdev of a device did not walk the master chain to find the upper master. This patch adds a function to find the l3mdev, even indirect through e.g. a bridge: +--+ | | | vrf-blue | | | ++-+ | | ++-+ | |

[PATCH v5 0/6] Add VRF support for VXLAN underlay

2018-11-26 Thread Alexis Bauvin
v4 -> v5: - move test script to its own patch (6/6) - add schematic for test script - apply David Ahern comments to the test script v3 -> v4: - rename vxlan_is_in_l3mdev_chain to netdev_is_upper master - move it to net/core/dev.c - make it return bool instead of int - check if remote_ifindex is ze

[PATCH v5 6/6] test/net: Add script for VXLAN underlay in a VRF

2018-11-26 Thread Alexis Bauvin
This script tests the support of a VXLAN underlay in a non-default VRF. It does so by simulating two hypervisors and two VMs, an extended L2 between the VMs with the hypervisors as VTEPs with the underlay in a VRF, and finally by pinging the two VMs. It also tests that moving the underlay from a

[PATCH v5 5/6] vxlan: handle underlay VRF changes

2018-11-26 Thread Alexis Bauvin
When underlay VRF changes, either because the lower device itself changed, or its VRF changed, this patch releases the current socket of the VXLAN device and recreates another one in the right VRF. This allows for on-the-fly change of the underlay VRF of a VXLAN device. Signed-off-by: Alexis Bauvi

[PATCH v5 4/6] netdev: add netdev_is_upper_master

2018-11-26 Thread Alexis Bauvin
In preparation of next patch, this function allows to check if a device is a master, be it direct or indirect, of another one. It walks up the master chain until it finds the device, or there is no more master. This allows to check e.g. if br-blue is a master of eth0: +--+ | vrf-blu

[PATCH v5 1/6] udp_tunnel: add config option to bind to a device

2018-11-26 Thread Alexis Bauvin
UDP tunnel sockets are always opened unbound to a specific device. This patch allow the socket to be bound on a custom device, which incidentally makes UDP tunnels VRF-aware if binding to an l3mdev. Signed-off-by: Alexis Bauvin Reviewed-by: Amine Kherbouche Reviewed-by: David Ahern Tested-by: A

Re: [RFC v4 3/5] vxlan: add support for underlay in non-default VRF

2018-11-26 Thread Alexis Bauvin
Le 27 nov. 2018 à 01:46, David Ahern a écrit : > On 11/26/18 5:41 PM, Alexis Bauvin wrote: >> Le 26 nov. 2018 à 18:54, David Ahern a écrit : >>> On 11/26/18 9:32 AM, Alexis Bauvin wrote: Thanks for the review. I’ll send a v5 if you have no other comment on this version! >>> >>> A few c

[iproute2-next PATCH v5] tc: flower: Classify packets based port ranges

2018-11-26 Thread Amritha Nambiar
Added support for filtering based on port ranges. UAPI changes have been accepted into net-next. Example: 1. Match on a port range: - $ tc filter add dev enp4s0 protocol ip parent :\ prio 1 flower ip_proto tcp dst_port 20-30 skip_hw\ action drop $ tc -s filter show

Re: [Intel-wired-lan] [PATCH net] ixgbe: recognize 1000BaseLX SFP modules as 1Gbps

2018-11-26 Thread Josh Elsasser
Jeff Kirsher wrote: > No need to re-spin the patch, just reply with the additional "Fixes" > tag and if patchwork does not pick it up, I will add it to the patch I > have in my tree for validation and review. Thanks, let’s try that. Fixes: e23f33367882 ("ixgbe: Fix 1G and 10G link stability for

Re: [RFC v4 3/5] vxlan: add support for underlay in non-default VRF

2018-11-26 Thread David Ahern
On 11/26/18 5:41 PM, Alexis Bauvin wrote: > Le 26 nov. 2018 à 18:54, David Ahern a écrit : >> On 11/26/18 9:32 AM, Alexis Bauvin wrote: >>> Thanks for the review. I’ll send a v5 if you have no other comment on >>> this version! >> >> A few comments on the test script; see attached which has the ch

Re: [iproute2-next PATCH v4] tc: flower: Classify packets based port ranges

2018-11-26 Thread David Ahern
On 11/26/18 5:23 PM, Nambiar, Amritha wrote: >> Can tc flower use something similar to ip ru with single port or port >> range handled like this? >> >> },{ >> "priority": 32764, >> "src": "172.16.1.0", >> "srclen": 24, >> "ipproto": "tcp", >> "sport": 110

Re: [RFC v4 3/5] vxlan: add support for underlay in non-default VRF

2018-11-26 Thread Alexis Bauvin
Le 26 nov. 2018 à 18:54, David Ahern a écrit : > On 11/26/18 9:32 AM, Alexis Bauvin wrote: >> Thanks for the review. I’ll send a v5 if you have no other comment on >> this version! > > A few comments on the test script; see attached which has the changes. > > Mainly the cleanup does not need to

Re: Can decnet be deprecated?

2018-11-26 Thread Stephen Hemminger
On Sat, 24 Nov 2018 17:12:48 -0700 David Ahern wrote: > IPX was moved to staging at the end of last year. Can decnet follow > suit? git log seems to indicate no active development in a very long time. > > David I have no problem with dropping decnet support from iproute first. Presumably anyone

Re: [PATCH net] bonding: fix 802.3ad state sent to partner when unbinding slave

2018-11-26 Thread Jay Vosburgh
Toni Peltonen wrote: >Previously when unbinding a slave the 802.3ad implementation only told >partner that the port is not suitable for aggregation by setting the port >aggregation state from aggregatable to individual. This is not enough. If the >physical layer still stays up and we only unbinde

Re: [iproute2-next PATCH v4] tc: flower: Classify packets based port ranges

2018-11-26 Thread Nambiar, Amritha
On 11/21/2018 1:42 PM, David Ahern wrote: > On 11/20/18 11:17 PM, Amritha Nambiar wrote: >> diff --git a/tc/f_flower.c b/tc/f_flower.c >> index 65fca04..722647d 100644 >> --- a/tc/f_flower.c >> +++ b/tc/f_flower.c >> @@ -494,6 +494,68 @@ static int flower_parse_port(char *str, __u8 ip_proto, >>

[PATCH bpf] bpf, doc: add entries of who looks over which jits

2018-11-26 Thread Daniel Borkmann
Make the high-level BPF JIT entry a general 'catch-all' and add architecture specific entries to make it more clear who actively maintains which BPF JIT compiler. The list (L) address implies that this eventually lands in the bpf patchwork bucket. Goal is that this set of responsible developers lis

Re: [PATCH net-next 1/2] br_netfilter: add struct netns_brnf

2018-11-26 Thread Pablo Neira Ayuso
Hi, On Wed, Nov 07, 2018 at 02:48:58PM +0100, Christian Brauner wrote: [...] > diff --git a/include/net/netns/netfilter.h b/include/net/netns/netfilter.h > index ca043342c0eb..eedbd1ac940e 100644 > --- a/include/net/netns/netfilter.h > +++ b/include/net/netns/netfilter.h > @@ -35,4 +35,20 @@ struc

[no subject]

2018-11-26 Thread Offer
-- -- Guten Tag, Wir sind eine registrierte private Geldverleiher. Wir geben Kredite an Firmen, Einzelpersonen, die ihre finanzielle Status auf der ganzen Welt aktualisieren müssen, mit minimalen jährlichen Zinsen von 2% .reply, wenn nötig. Good Day, We are a registered private money lender. We

Re: iproute2 compile and linking errors on Fedora 19

2018-11-26 Thread Stephen Hemminger
On Tue, 31 Oct 2017 16:28:20 -0700 Cong Wang wrote: > On Tue, Oct 31, 2017 at 2:10 PM, Stephen Hemminger > wrote: > > > > IPPROTO_MH comes from include/uapi/linux/in6.h > > Maybe it is trying to use old kernel headers from libc. > > So newer iproute2 is not supposed to work with older > kerne

Re: [PATCH v3 13/13] nvme-tcp: add NVMe over TCP host driver

2018-11-26 Thread Max Gurtovoy
+static enum blk_eh_timer_return +nvme_tcp_timeout(struct request *rq, bool reserved) +{ +    struct nvme_tcp_request *req = blk_mq_rq_to_pdu(rq); +    struct nvme_tcp_ctrl *ctrl = req->queue->ctrl; +    struct nvme_tcp_cmd_pdu *pdu = req->pdu; + +    dev_dbg(ctrl->ctrl.device, +    "queue %d

Re: [PATCH net] ixgbe: recognize 1000BaseLX SFP modules as 1Gbps

2018-11-26 Thread Jeff Kirsher
On Mon, 2018-11-26 at 09:54 -0800, Josh Elsasser wrote: > Bjørn Mork wrote: > > > Not that it matters much I guess, but I think LX SFPs were > > unsupported > > at that time. The LX support appears to have been added under the > > radar > > while refactoring ixgbe_setup_sfp_modules_X550em in comm

RE: [Intel-wired-lan] [PATCH net] ixgbe: recognize 1000BaseLX SFP modules as 1Gbps

2018-11-26 Thread Bowers, AndrewX
> -Original Message- > From: Intel-wired-lan [mailto:intel-wired-lan-boun...@osuosl.org] On > Behalf Of Josh Elsasser > Sent: Saturday, November 24, 2018 12:58 PM > To: intel-wired-...@lists.osuosl.org > Cc: netdev@vger.kernel.org; David S. Miller ; Josh > Elsasser ; linux-ker...@vger.kerne

RE: [Intel-wired-lan] [PATCH 1/1] drivers/net/i40e: define proper net_device::neigh_priv_len

2018-11-26 Thread Bowers, AndrewX
> -Original Message- > From: Intel-wired-lan [mailto:intel-wired-lan-boun...@osuosl.org] On > Behalf Of Konstantin Khorenko > Sent: Friday, November 23, 2018 8:10 AM > To: Kirsher, Jeffrey T > Cc: netdev@vger.kernel.org; intel-wired-...@lists.osuosl.org; linux- > ker...@vger.kernel.org; Ko

[PATCH net] bonding: fix 802.3ad state sent to partner when unbinding slave

2018-11-26 Thread Toni Peltonen
Previously when unbinding a slave the 802.3ad implementation only told partner that the port is not suitable for aggregation by setting the port aggregation state from aggregatable to individual. This is not enough. If the physical layer still stays up and we only unbinded this port from the bond t

Re: [RFC PATCH 0/3] sk_buff: add skb extension infrastructure

2018-11-26 Thread Eric Dumazet
On 11/26/2018 03:38 AM, Florian Westphal wrote: > The (out-of-tree) Multipath-TCP implementation needs a significant amount > of extra space in the skb control buffer. > > Increasing skb->cb[] size in mainline is a non-starter for memory and > and performance reasons (f.e. increase in cb size a

[PATCH bpf] sparc: Correct ctx->saw_frame_pointer logic.

2018-11-26 Thread David Miller
We need to initialize the frame pointer register not just if it is seen as a source operand, but also if it is seen as the destination operand of a store or an atomic instruction (which effectively is a source operand). This is exercised by test_verifier's "non-invalid fp arithmetic" Signed-off

[PATCH v2 net-next] tcp: remove hdrlen argument from tcp_queue_rcv()

2018-11-26 Thread Eric Dumazet
Only one caller needs to pull TCP headers, so lets move __skb_pull() to the caller side. Signed-off-by: Eric Dumazet Acked-by: Yuchung Cheng --- v2: sent as a standalone patch. net/ipv4/tcp_input.c | 13 ++--- 1 file changed, 6 insertions(+), 7 deletions(-) diff --git a/net/ipv4/tcp_i

[PATCH mlx5-next 06/13] net/mlx5: Remove unused events callback and logic

2018-11-26 Thread Saeed Mahameed
The mlx5_interface->event callback is not used by mlx5e/mlx5_ib anymore. We totally remove the delayed events logic work around, since with the dynamic notifier registration API it is not needed anymore, mlx5_ib can register its notifier and start receiving events exactly at the moment it is ready

[PATCH mlx5-next 13/13] net/mlx5: Debug print for forwarded async events

2018-11-26 Thread Saeed Mahameed
Print a debug message for every async FW event forwarded to mlx5 interfaces (mlx5e netdev and mlx5_ib rdma module). Signed-off-by: Saeed Mahameed --- drivers/net/ethernet/mellanox/mlx5/core/events.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/net/ethernet/mellanox/mlx5/core/ev

[PATCH mlx5-next 09/13] IB/mlx5: Handle raw delay drop general event

2018-11-26 Thread Saeed Mahameed
Handle FW general event rq delay drop as it was received from FW via mlx5 notifiers API, instead of handling the processed software version of that event. After this patch we can safely remove all software processed FW events types and definitions. Signed-off-by: Saeed Mahameed --- drivers/infin

[PATCH mlx5-next 08/13] net/mlx5: Allow forwarding event type general event as is

2018-11-26 Thread Saeed Mahameed
FW general event is used by mlx5_ib for RQ delay drop timeout event handling, in this patch we allow to forward FW general event type to mlx5 notifiers chain so mlx5_ib can handle it and to deprecate the software version of it. Signed-off-by: Saeed Mahameed --- drivers/net/ethernet/mellanox/mlx5

[PATCH mlx5-next 04/13] net/mlx5: Forward all mlx5 events to mlx5 notifiers chain

2018-11-26 Thread Saeed Mahameed
This to allow seamless migration to the new notifier chain API, and to eventually deprecate interfaces dev->event callback. Signed-off-by: Saeed Mahameed --- drivers/net/ethernet/mellanox/mlx5/core/dev.c | 3 +++ include/linux/mlx5/driver.h | 2 +- 2 files changed, 4 insertions

[PATCH mlx5-next 12/13] net/mlx5: Forward SRQ resource events

2018-11-26 Thread Saeed Mahameed
Allow forwarding of SRQ events to mlx5_core interfaces, e.g. mlx5_ib. Use mlx5_notifier_register/unregister in srq.c in order to allow seamless transition of srq.c to infiniband subsystem. Signed-off-by: Saeed Mahameed --- .../net/ethernet/mellanox/mlx5/core/events.c | 3 ++ drivers/net/ethern

[PATCH mlx5-next 05/13] IB/mlx5: Use the new mlx5 core notifier API

2018-11-26 Thread Saeed Mahameed
Remove the deprecated mlx5_interface->event mlx5_ib callback and use new mlx5 notifier API to subscribe for mlx5 events. For native mlx5_ib devices profiles pf_profile/nic_rep_profile register the notifier callback mlx5_ib_handle_event which treats the notifier context as mlx5_ib_dev. For vport r

[PATCH mlx5-next 11/13] net/mlx5: Forward QP/WorkQueues resource events

2018-11-26 Thread Saeed Mahameed
Allow forwarding QP and WQ events to mlx5_core interfaces, e.g. mlx5_ib Use mlx5_notifier_register/unregister in qp.c in order to allow seamless transition of qp.c to infiniband subsystem. Signed-off-by: Saeed Mahameed --- drivers/net/ethernet/mellanox/mlx5/core/events.c | 10 ++ driver

[PATCH mlx5-next 10/13] net/mlx5: Remove all deprecated software versions of FW events

2018-11-26 Thread Saeed Mahameed
Before the new mlx5 event notification infrastructure and API, mlx5_core used to process all events before forwarding them to mlx5 interfaces (mlx5e/mlx5_ib) and used to translate the event type enum to a software defined enum, this is not needed anymore since it is ok for mlx5e and mlx5_ib to rece

[PATCH mlx5-next 07/13] IB/mlx5: Handle raw port change event rather than the software version

2018-11-26 Thread Saeed Mahameed
Use the FW version of the port change event as forwarded via new mlx5 notifiers API. After this patch, processed software version of the port change event will become deprecated and will be totally removed in downstream patches. Signed-off-by: Saeed Mahameed --- drivers/infiniband/hw/mlx5/main.

[PATCH mlx5-next 02/13] net/mlx5: Allow port change event to be forwarded to driver notifiers chain

2018-11-26 Thread Saeed Mahameed
The idea is to allow mlx5 core interfaces (mlx5e/mlx5_ib) to be able to receive some allowed FW events as is via the new notifier API. In this patch we allow forwarding port change event to mlx5 core interfaces (mlx5e/mlx5_ib) as it was received from FW. Once mlx5e and mlx5_ib start using this eve

[PATCH mlx5-next 03/13] net/mlx5e: Use the new mlx5 core notifier API

2018-11-26 Thread Saeed Mahameed
Remove the deprecated mlx5_interface->event mlx5e callback and use new mlx5 notifier API to subscribe for mlx5 events, handle port change event as received from FW rather than handling the mlx5 core processed port change software version event. Signed-off-by: Saeed Mahameed --- drivers/net/ether

[PATCH mlx5-next 00/13] Mellanox, mlx5 core driver events API

2018-11-26 Thread Saeed Mahameed
Hi, This patchset is for mlx5-next shared branch, and will be applied there once the review is done. The main idea of this change is to define a flexible scalable and simpler high level mlx5 core APIs to forward device and driver events to upper level interface drivers e.g mlx5_ib and mlx5e netd

[PATCH mlx5-next 01/13] net/mlx5: Driver events notifier API

2018-11-26 Thread Saeed Mahameed
Use atomic notifier chain to fire events to mlx5 core driver consumers (mlx5e/mlx5_ib) and provide mlx5 register/unregister notifier API. This API will replace the current mlx5_interface->event callback and all the logic around it, especially the delayed events logic introduced by commit 97834eba7

Re: [PATCH iproute2] ss: add support for delivered and delivered_ce fields

2018-11-26 Thread Yuchung Cheng
On Mon, Nov 26, 2018 at 2:29 PM, Eric Dumazet wrote: > Kernel support was added in linux-4.18 in commit feb5f2ec6464 > ("tcp: export packets delivery info") > > Tested: > > ss -ti > ... > ESTAB 0 2270520 [2607:f8b0:8099:e16::]:47646 > [2607:f8b0:8099:e18::]:38953 > ts sack cubic

[PATCH iproute2] ss: add support for delivered and delivered_ce fields

2018-11-26 Thread Eric Dumazet
Kernel support was added in linux-4.18 in commit feb5f2ec6464 ("tcp: export packets delivery info") Tested: ss -ti ... ESTAB 0 2270520 [2607:f8b0:8099:e16::]:47646 [2607:f8b0:8099:e18::]:38953 ts sack cubic wscale:8,8 rto:7 rtt:2.824/0.278 mss:1428 pmtu:1500 rcvmss:536 adv

[PATCH bpf-next v2 2/3] bpf: add msg_pop_data helper to tools

2018-11-26 Thread John Fastabend
Add the necessary header definitions to tools for new msg_pop_data_helper. Signed-off-by: John Fastabend --- tools/include/uapi/linux/bpf.h| 16 +++- tools/testing/selftests/bpf/bpf_helpers.h | 2 ++ 2 files changed, 17 insertions(+), 1 deletion(-) diff --git a/tools/in

[PATCH bpf-next v2 3/3] bpf: test_sockmap, add options for msg_pop_data() helper

2018-11-26 Thread John Fastabend
Similar to msg_pull_data and msg_push_data add a set of options to have msg_pop_data() exercised. Signed-off-by: John Fastabend --- tools/testing/selftests/bpf/test_sockmap.c | 127 +++- tools/testing/selftests/bpf/test_sockmap_kern.h | 70 ++--- 2 files changed

Re: [PATCH mlx5-next 00/11] mlx5 core internal firmware events handling improvements

2018-11-26 Thread Saeed Mahameed
On Tue, 2018-11-20 at 14:12 -0800, Saeed Mahameed wrote: > Hi > > This patchset is for mlx5-next shared branch, and will be applied > there > once the review is done. > > The main idea of this change is to define a flexible scalable and > simpler low level mlx5 core APIs to upper level components

[PATCH bpf-next v2 1/3] bpf: helper to pop data from messages

2018-11-26 Thread John Fastabend
This adds a BPF SK_MSG program helper so that we can pop data from a msg. We use this to pop metadata from a previous push data call. Signed-off-by: John Fastabend --- include/uapi/linux/bpf.h | 16 - net/core/filter.c| 171 +++ net/ipv4/t

[PATCH bpf-next v2 0/3] bpf: add sk_msg helper sk_msg_pop_data

2018-11-26 Thread John Fastabend
After being able to add metadata to messages with sk_msg_push_data we have also found it useful to be able to "pop" this metadata off before sending it to applications in some cases. This series adds a new helper sk_msg_pop_data() and the associated patches to add tests and tools/lib support. Than

Re: consistency for statistics with XDP mode

2018-11-26 Thread Jakub Kicinski
On Wed, 21 Nov 2018 14:06:49 -0700, David Ahern wrote: > Keeping the basic xdp packets in the standard counters allows Paweł, for > example, to continue to monitor /proc/net/dev. > > Can we get agreement on this? And from there, get updates to the mlx5 > and virtio drivers? I have a long standing

Re: [PATCH bpf] bpf: Support sk lookup in netns with id 0

2018-11-26 Thread David Ahern
On 11/26/18 2:27 PM, Joe Stringer wrote: > @@ -2405,6 +2407,9 @@ enum bpf_func_id { > /* BPF_FUNC_perf_event_output for sk_buff input context. */ > #define BPF_F_CTXLEN_MASK(0xfULL << 32) > > +/* BPF_FUNC_sk_lookup_tcp and BPF_FUNC_sk_lookup_udp flags. */ > +#define BPF_F_SK_CUR

Re: [PATCH bpf-next] bpf: Avoid unnecessary instruction in conver_bpf_ld_abs()

2018-11-26 Thread Daniel Borkmann
On 11/26/2018 10:42 PM, David Miller wrote: > > 'offset' is constant and if it is zero, no need to subtract it > from BPF_REG_TMP. > > Signed-off-by: David S. Miller Applied to bpf-next, thanks!

[PATCH bpf] bpf: Support sk lookup in netns with id 0

2018-11-26 Thread Joe Stringer
David Ahern and Nicolas Dichtel report that the handling of the netns id 0 is incorrect for the BPF socket lookup helpers: rather than finding the netns with id 0, it is resolving to the current netns. This renders the netns_id 0 inaccessible. To fix this, adjust the API for the netns to treat all

[PATCH net-next v2] net/ncsi: Add NCSI Mellanox OEM command

2018-11-26 Thread Vijay Khemka
This patch adds OEM Mellanox commands and response handling. It also defines OEM Get MAC Address handler to get and configure the device. ncsi_oem_gma_handler_mlx: This handler send NCSI mellanox command for getting mac address. ncsi_rsp_handler_oem_mlx: This handles response received for all mell

Re: [v5, PATCH 2/2] dt-binding: mediatek-dwmac: add binding document for MediaTek MT2712 DWMAC

2018-11-26 Thread Rob Herring
On Fri, Nov 23, 2018 at 09:31:16AM +0800, biao huang wrote: > Dear Andrew, > > Thanks for you remind. > > Sincerely, I respect any comment from any reviewer. If I didn't reply > for any comment, really sorry for that. > > As to this "tx-delay" issue, the following reply in v3 m

[PATCH bpf-next] bpf: Avoid unnecessary instruction in conver_bpf_ld_abs()

2018-11-26 Thread David Miller
'offset' is constant and if it is zero, no need to subtract it from BPF_REG_TMP. Signed-off-by: David S. Miller diff --git a/net/core/filter.c b/net/core/filter.c index aa274679965d..f50ea971f7a9 100644 --- a/net/core/filter.c +++ b/net/core/filter.c @@ -463,7 +463,8 @@ static bool convert_bpf

Re: [RFC PATCH 0/3] sk_buff: add skb extension infrastructure

2018-11-26 Thread Florian Westphal
David Miller wrote: > From: Florian Westphal > Date: Mon, 26 Nov 2018 22:19:33 +0100 > > >> In the future please document what is so enormous and absolutely > >> required that they must put it all into the SKB control block. > > > > Ok, will do. > > Why don't we establish the details about wha

Re: [RFC PATCH 0/3] sk_buff: add skb extension infrastructure

2018-11-26 Thread David Miller
From: Florian Westphal Date: Mon, 26 Nov 2018 22:19:33 +0100 >> In the future please document what is so enormous and absolutely >> required that they must put it all into the SKB control block. > > Ok, will do. Why don't we establish the details about what MP-TCP needs in the CB before we disc

  1   2   3   >