Le 27 nov. 2018 à 01:46, David Ahern <d...@cumulusnetworks.com> a écrit : > On 11/26/18 5:41 PM, Alexis Bauvin wrote: >> Le 26 nov. 2018 à 18:54, David Ahern <d...@cumulusnetworks.com> a écrit : >>> On 11/26/18 9:32 AM, Alexis Bauvin wrote: >>>> Thanks for the review. I’ll send a v5 if you have no other comment on >>>> this version! >>> >>> A few comments on the test script; see attached which has the changes. >>> >>> Mainly the cleanup does not need to be called at the end since you setup >>> the exit trap. The cleanup calls ip to delete veth-hv-1 and veth-tap but >>> those are moved to other namespaces. >> >> This was on purpose to be sure to cleanup the interfaces in case the >> script crashes for some reason and left interfaces outside of the >> namespace. > > ok. > >>> It would be good to copy the topology ascii art into the test script as >>> well for future users. >> >> Will include this: > > <cool ascii diagram> > > Thanks for adding. > >> >>> Also, add the test as a separate patch at the end and include it in >>> tools/testing/selftests/net/Makefile >> >> Regarding the discussion on patch 5, it should be better to send it first >> after patch 3, and remove the down/up from it after current patch 5, >> right? > > Typically the test case is added at the end verifying the end goal of > the patch set as opposed to being part of a patch (3 in your case) and > then amended by a later patch.
Ok. Will make the test script the very last of the series. Thanks for the pointers.
