[no subject]

2015-10-27 Thread arwen lai
Dear Mr/Ms, we are a OEM parts supplier on many categories,we can supply all kinds of metal parts in compliance with customer's design. Idea and designs from customers can be realized into new products here confidentially. Any OEM metalwork is welcomed! B/R Yours James Cheung Skype:senkemfg

[GIT] Networking

2015-10-27 Thread David Miller
This may look a bit scary this late in the release cycle, but as is typically the case it's predominantly small driver fixes all over the place. 1) Fix two regressions in ipv6 route lookups, particularly wrt. output interface specifications in the lookup key. From David Ahern. 2) Fix checks

pull request: bluetooth-next 2015-10-28

2015-10-27 Thread Johan Hedberg
Hi Dave, Here are a some more Bluetooth patches for 4.4 which collected up during the past week. The most important ones are from Kuba Pawlak for fixing locking issues with SCO sockets. There's also a fix from Alexander Aring for 6lowpan, a memleak fix from Julia Lawall for the btmrvl driver and s

[PATCH v2 1/3] virtio_net: Stop doing DMA from the stack

2015-10-27 Thread Andy Lutomirski
From: Andy Lutomirski Once virtio starts using the DMA API, we won't be able to safely DMA from the stack. virtio-net does a couple of config DMA requests from small stack buffers -- switch to using dynamically-allocated memory. This should have no effect on any performance-critical code paths.

Re: [PATCH net-next v3] bridge: set is_local and is_static before fdb entry is added to the fdb hashtable

2015-10-27 Thread Stephen Hemminger
On Tue, 27 Oct 2015 07:52:56 -0700 Roopa Prabhu wrote: > From: Roopa Prabhu > > Problem Description: > We can add fdbs pointing to the bridge with NULL ->dst but that has a > few race conditions because br_fdb_insert() is used which first creates > the fdb and then, after the fdb has been publi

Re: [PATCH v2 net-next 0/4] Automatic adjustment of max frame size

2015-10-27 Thread Stephen Hemminger
On Mon, 26 Oct 2015 12:40:55 +0900 Toshiaki Makita wrote: > This patch set tries to resolve packet drop by oversize error on receiving > double tagged packets and possibly other encapsulated packets. > > Problem description: > Currently most NICs have 4 bytes room of receive buffer for vlan head

Re: [PATCH v1 1/3] virtio-net: Using single MSIX IRQ for TX/RX Q pair

2015-10-27 Thread Jason Wang
On 10/27/2015 04:38 PM, Michael S. Tsirkin wrote: > On Mon, Oct 26, 2015 at 10:52:47AM -0700, Ravi Kerur wrote: >> Ported earlier patch from Jason Wang (dated 12/26/2014). >> >> This patch tries to reduce the number of MSIX irqs required for >> virtio-net by sharing a MSIX irq for each TX/RX queu

Re: [PATCH net 0/2] Mellanox mlx4 driver fixes for 4.3-rc7

2015-10-27 Thread David Miller
From: Or Gerlitz Date: Tue, 27 Oct 2015 17:36:18 +0200 > Jack's fix is for a regression introduced in 4.3-rc1 > > Carol's fix addresses an issue which exists for while and > turns to beat us hard on PPC, please queue for -stable. Series applied, and patch #2 queued up for -stable. Thanks. --

Re: [PATCH 5/8] mm: memcontrol: account socket memory on unified hierarchy

2015-10-27 Thread Johannes Weiner
On Tue, Oct 27, 2015 at 05:45:32PM -0700, David Miller wrote: > From: Johannes Weiner > Date: Tue, 27 Oct 2015 09:42:27 -0700 > > > On Tue, Oct 27, 2015 at 05:15:54PM +0100, Michal Hocko wrote: > >> > For now, something like this as a boot commandline? > >> > > >> > cgroup.memory=nosocket > >>

Re: [PATCH RESEND v2 net-next] net: hisilicon: updates HNS config and documents

2015-10-27 Thread David Miller
From: huangdaode Date: Tue, 27 Oct 2015 19:16:34 +0800 > From: yankejian > > updates the bindings documents and dtsi file according to the review > comments[https://lkml.org/lkml/2015/9/21/670] from Rob Herring > > > Acked-by: Rob Herring > Signed-off-by: yankejian > Signed-off-by: huangda

Re: [PATCH] vhost: fix performance on LE hosts

2015-10-27 Thread David Miller
From: "Michael S. Tsirkin" Date: Tue, 27 Oct 2015 11:37:39 +0200 > commit 2751c9882b947292fcfb084c4f604e01724af804 ("vhost: cross-endian > support for legacy devices") introduced a minor regression: even with > cross-endian disabled, and even on LE host, vhost_is_little_endian is > checking is_le

Re: pull-request: wireless-drivers-next 2015-10-27

2015-10-27 Thread David Miller
From: Kalle Valo Date: Tue, 27 Oct 2015 10:46:38 +0200 > here's a bigger pull request for 4.4. The diffstat looks scary as we > created a new directory realtek for all realtek drivers. In the future > I'm planning to create similar directories for all vendors, currently we > just have ath, mediat

Re: [PATCH] net: hns: fixes the bug tested XGE by ethtool -p

2015-10-27 Thread David Miller
From: yankejian Date: Tue, 27 Oct 2015 17:17:40 +0800 > From: Li Peng > > delete action of ETHTOOL_ID_ON/ETHTOOL_ID_OFF in XGE ethtool -p, > so Hardware control the LED state instead of software. > > Signed-off-by: Li Peng > Signed-off-by: Yisen Zhuang > Signed-off-by: yankejian Applied. -

Re: [PATCH net-next] gianfar: Increase TX_TIMEOUT to 5HZ

2015-10-27 Thread David Miller
From: Abhimanyu Date: Tue, 27 Oct 2015 14:17:43 +0530 > Increased TX_TIMEOUT to 5HZ to accommodate worst case situation > for traffic and CPU intensive use cases > > Signed-off-by: Priyanka Jain > Signed-off-by: Abhimanyu Applied, thanks. -- To unsubscribe from this list: send the line "unsub

Re: [PATCH net] macvtap: unbreak receiving of gro skb with frag list

2015-10-27 Thread Jason Wang
On 10/27/2015 05:05 PM, Michael S. Tsirkin wrote: > On Tue, Oct 27, 2015 at 10:58:25AM +0800, Jason Wang wrote: >> >> On 10/26/2015 04:30 PM, Michael S. Tsirkin wrote: >>> On Mon, Oct 26, 2015 at 02:53:38PM +0800, Jason Wang wrote: On 10/26/2015 02:09 PM, Michael S. Tsirkin wrote: > On M

[PATCH 02/25] IB/mthca, net/mlx4: remove counting semaphores

2015-10-27 Thread Arnd Bergmann
The mthca and mlx4 device drivers use the same method to switch between polling and event-driven command mode, abusing two semaphores to create a mutual exclusion between one polled command or multiple concurrent event driven commands. Since we want to make counting semaphores go away, this patch

Re: [PATCH v7 10/10] ss: activate json_writer excluded logic

2015-10-27 Thread Stephen Hemminger
On Tue, 27 Oct 2015 14:21:03 +0100 Phil Sutter wrote: > On Thu, Sep 10, 2015 at 09:35:08PM +0200, Matthias Tafelmeier wrote: > > This small patch extends the lib json_writer module for formerly > > deactivated functionality. > > Why was it deactivated in the first place? The code came from an

Re: [PATCH net-next] seccomp, ptrace: add support for dumping seccomp filters

2015-10-27 Thread David Miller
From: Tycho Andersen Date: Tue, 27 Oct 2015 09:23:59 +0900 > This patch adds support for dumping a process' (classic BPF) seccomp > filters via ptrace. Applied, thanks. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majord...@vger.kernel.org More

Re: [PATCH net-next 0/2] mpls: mulipath improvements

2015-10-27 Thread David Miller
From: Robert Shearman Date: Tue, 27 Oct 2015 00:37:34 + > Two improvements to the recently added mpls multipath support. The > first is a fix for missing initialisation the nexthop address length > for the v4 and v6 explicit null label routes, and the second is to > reduce the amount of memor

Re: [PATCH] bpf: sample: define aarch64 specific registers

2015-10-27 Thread David Miller
From: Yang Shi Date: Mon, 26 Oct 2015 17:02:19 -0700 > Define aarch64 specific registers for building bpf samples correctly. > > Signed-off-by: Yang Shi Applied. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majord...@vger.kernel.org More majo

Re: [PATCH net] amd-xgbe: Fix race between access of desc and desc index

2015-10-27 Thread David Miller
From: Tom Lendacky Date: Mon, 26 Oct 2015 17:13:54 -0500 > During Tx cleanup it's still possible for the descriptor data to be > read ahead of the descriptor index. A memory barrier is required between > the read of the descriptor index and the start of the Tx cleanup loop. > This allows a change

Re: [PATCH net] RDS-TCP: Recover correctly from pskb_pull()/pksb_trim() failure in rds_tcp_data_recv

2015-10-27 Thread David Miller
From: Sowmini Varadhan Date: Mon, 26 Oct 2015 12:46:37 -0400 > Either of pskb_pull() or pskb_trim() may fail under low memory conditions. > If rds_tcp_data_recv() ignores such failures, the application will > receive corrupted data because the skb has not been correctly > carved to the RDS datagr

Re: [PATCH] forcedeth: fix unilateral interrupt disabling in netpoll path

2015-10-27 Thread David Miller
From: Neil Horman Date: Mon, 26 Oct 2015 12:24:22 -0400 > Forcedeth currently uses disable_irq_lockdep and enable_irq_lockdep, which in > some configurations simply calls local_irq_disable. This causes errant > warnings > in the netpoll path as in netpoll_send_skb_on_dev, where we disable irqs

Re: [PATCH net-next v2 1/1] sfc: replace spinlocks with bit ops for busy poll locking

2015-10-27 Thread David Miller
From: Shradha Shah Date: Mon, 26 Oct 2015 14:23:42 + > From: Bert Kenward > > This patch reduces the overhead of locking for busy poll. > Previously the state was protected by a lock, whereas now > it's manipulated solely with atomic operations. > > Signed-off-by: Shradha Shah Applied, t

Re: [PATCH net-next] sock: don't enable netstamp for af_unix sockets

2015-10-27 Thread David Miller
From: Hannes Frederic Sowa Date: Mon, 26 Oct 2015 13:51:37 +0100 > netstamp_needed is toggled for all socket families if they request > timestamping. But some protocols don't need the lower-layer timestamping > code at all. This patch starts disabling it for af-unix. > > E.g. systemd enables tim

Re: [PATCH net-next v8 00/10] Add new drivers: qed & qede

2015-10-27 Thread David Miller
From: Yuval Mintz Date: Mon, 26 Oct 2015 11:02:24 +0200 > This series implements the driver set for Qlogic's new QL4xxx series. > These are 10/20/25/40/50/100 Gig capable converged nics, supporting > ethernet (obviously), iscsi, fcoe, roce and iwarp protocols. Series applied. -- To unsubscribe f

Re: [PATCHv3 net 1/3] openvswitch: Fix double-free on ip_defrag() errors

2015-10-27 Thread David Miller
From: Joe Stringer Date: Sun, 25 Oct 2015 20:21:48 -0700 > If ip_defrag() returns an error other than -EINPROGRESS, then the skb is > freed. When handle_fragments() passes this back up to > do_execute_actions(), it will be freed again. Prevent this double free > by never freeing the skb in do_exe

Re: [PATCHv3 net 2/3] ipv6: Export nf_ct_frag6_consume_orig()

2015-10-27 Thread David Miller
From: Joe Stringer Date: Sun, 25 Oct 2015 20:21:49 -0700 > This is needed in openvswitch to fix an skb leak in the next patch. > > Signed-off-by: Joe Stringer Applied. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majord...@vger.kernel.org Mor

Re: [PATCHv3 net 3/3] openvswitch: Fix skb leak using IPv6 defrag

2015-10-27 Thread David Miller
From: Joe Stringer Date: Sun, 25 Oct 2015 20:21:50 -0700 > nf_ct_frag6_gather() makes a clone of each skb passed to it, and if the > reassembly is successful, expects the caller to free all of the original > skbs using nf_ct_frag6_consume_orig(). This call was previously missing, > meaning that t

Re: [PATCH v2 net-next 0/4] Automatic adjustment of max frame size

2015-10-27 Thread David Miller
From: Toshiaki Makita Date: Mon, 26 Oct 2015 12:40:55 +0900 > This patch set tries to resolve packet drop by oversize error on > receiving double tagged packets and possibly other encapsulated > packets. Nobody is reviewing this patch series, therefore I am not applying it. -- To unsubscribe fro

Re: new coverity defect in ipv6 route

2015-10-27 Thread Hannes Frederic Sowa
Hi Stephen, On Wed, Oct 28, 2015, at 01:43, Stephen Hemminger wrote: > *** CID 1328821: Memory - corruptions (ARRAY_VS_SINGLETON) > /net/ipv6/route.c: 320 in rt6_info_init() > 314 #endif

Re: [PATCH net-next 2/2] mpls: reduce memory usage of routes

2015-10-27 Thread roopa
On 10/26/15, 5:37 PM, Robert Shearman wrote: > Nexthops for MPLS routes have a via address field sized for the > largest via address that is expected, which is 32 bytes. This means > that in the most common case of having ipv4 via addresses, 28 bytes of > memory more than required are used per next

Re: [PATCH net-next 1/2] mpls: fix forwarding using v4/v6 explicit null

2015-10-27 Thread roopa
On 10/26/15, 5:37 PM, Robert Shearman wrote: > Fill in the via address length for the predefined IPv4 and IPv6 > explicit-null label routes. > > Fixes: f8efb73c97e2 ("mpls: multipath route support") > Signed-off-by: Robert Shearman > --- > net/mpls/af_mpls.c | 2 ++ > 1 file changed, 2 insertions

Re: [net PATCH] fib_trie: leaf_walk_rcu should not compute key if key is less than pn->key

2015-10-27 Thread David Miller
From: Alexander Duyck Date: Tue, 27 Oct 2015 15:06:45 -0700 > We were computing the child index in cases where the key value we were > looking for was actually less than the base key of the tnode. As a result > we were getting incorrect index values that would cause us to skip over > some childr

new coverity defect in ipv6 route

2015-10-27 Thread Stephen Hemminger
Begin forwarded message: Date: Tue, 27 Oct 2015 08:43:53 -0700 From: scan-ad...@coverity.com To: step...@networkplumber.org Subject: New Defects reported by Coverity Scan for Linux Hi, Please find the latest report on new defect(s) introduced to Linux found with Coverity Scan. 2 new defect

Re: [PATCH net v2 3/4] ipv6: no CHECKSUM_PARTIAL on MSG_MORE corked sockets

2015-10-27 Thread Tom Herbert
On Tue, Oct 27, 2015 at 5:12 PM, Hannes Frederic Sowa wrote: > On Tue, Oct 27, 2015, at 23:03, Tom Herbert wrote: >> On Tue, Oct 27, 2015 at 2:42 PM, Hannes Frederic Sowa >> wrote: >> > I posted v3 just now. I would like to let David consider it for net >> > inclusion. We can work on how to lift

Re: [PATCH 5/8] mm: memcontrol: account socket memory on unified hierarchy

2015-10-27 Thread David Miller
From: Johannes Weiner Date: Tue, 27 Oct 2015 09:42:27 -0700 > On Tue, Oct 27, 2015 at 05:15:54PM +0100, Michal Hocko wrote: >> > For now, something like this as a boot commandline? >> > >> > cgroup.memory=nosocket >> >> That would work for me. > > Okay, then I'll go that route for the socket s

Re: [net PATCH] fib_trie: leaf_walk_rcu should not compute key if key is less than pn->key

2015-10-27 Thread Brian Rak
On 10/27/2015 6:06 PM, Alexander Duyck wrote: We were computing the child index in cases where the key value we were looking for was actually less than the base key of the tnode. As a result we were getting incorrect index values that would cause us to skip over some children. To fix this I h

Re: [Bug 106241] New: shutdown(3)/close(3) behaviour is incorrect for sockets in accept(3)

2015-10-27 Thread Eric Dumazet
On Tue, 2015-10-27 at 23:17 +, Al Viro wrote: > * [Linux-specific aside] our __alloc_fd() can degrade quite badly > with some use patterns. The cacheline pingpong in the bitmap is probably > inevitable, unless we accept considerably heavier memory footprint, > but we also have a case wh

Re: [PATCH net v2 3/4] ipv6: no CHECKSUM_PARTIAL on MSG_MORE corked sockets

2015-10-27 Thread Hannes Frederic Sowa
On Tue, Oct 27, 2015, at 23:03, Tom Herbert wrote: > On Tue, Oct 27, 2015 at 2:42 PM, Hannes Frederic Sowa > wrote: > > I posted v3 just now. I would like to let David consider it for net > > inclusion. We can work on how to lift this limitation then in net-next, > > okay? I am currently in favor

Re: [PATCH net-next v3 1/4] ipv4: no CHECKSUM_PARTIAL on MSG_MORE corked sockets

2015-10-27 Thread Hannes Frederic Sowa
On Tue, Oct 27, 2015, at 23:22, Tom Herbert wrote: > On Tue, Oct 27, 2015 at 2:40 PM, Hannes Frederic Sowa > wrote: > > We cannot reliable calculate packet size on MSG_MORE corked sockets > > and thus cannot decide if they are going to be fragmented later on, > > so better not use CHECKSUM_PARTIAL

Re: [Bug 106241] New: shutdown(3)/close(3) behaviour is incorrect for sockets in accept(3)

2015-10-27 Thread Al Viro
On Tue, Oct 27, 2015 at 10:52:46AM +, Alan Burlison wrote: > Unfortunately Hadoop isn't the only thing that pulls the shutdown() > trick, so I don't think there's a simple fix for this, as discussed > earlier in the thread. Having said that, if close() on Linux also > did an implicit shutdown()

Re: [Intel-wired-lan] [PATCHv2] ixgbe: Wait for 1ms, not 1us, after RST

2015-10-27 Thread Keller, Jacob E
On Tue, 2015-10-27 at 18:45 -0400, Peter Hurley wrote: > On 10/27/2015 02:35 PM, ND Linux CI Server wrote: > > Greetings, > > > > This email is automatically generated by ND's Linux Patch Testing > > framework > > based on aiaiai. I have performed some automatic testing of a patch > > (series) > >

Re: [Intel-wired-lan] [PATCHv2] ixgbe: Wait for 1ms, not 1us, after RST

2015-10-27 Thread Peter Hurley
On 10/27/2015 02:35 PM, ND Linux CI Server wrote: > Greetings, > > This email is automatically generated by ND's Linux Patch Testing framework > based on aiaiai. I have performed some automatic testing of a patch (series) > you submitted to intel-wired-...@lists.osuosl.org > > The following conta

Re: [PATCH net-next] hyperv: Add handler for RNDIS_STATUS_NETWORK_CHANGE event

2015-10-27 Thread Richard Weinberger
On Mon, Jun 23, 2014 at 10:10 PM, David Miller wrote: > From: Haiyang Zhang > Date: Mon, 23 Jun 2014 16:09:59 + > >> So, what's the equivalent or similar command to "network restart" on SLES12? >> Could >> you update the command line for the usermodehelper when porting this patch >> to SLES

Re: [PATCH net-next v3 1/4] ipv4: no CHECKSUM_PARTIAL on MSG_MORE corked sockets

2015-10-27 Thread Tom Herbert
On Tue, Oct 27, 2015 at 2:40 PM, Hannes Frederic Sowa wrote: > We cannot reliable calculate packet size on MSG_MORE corked sockets > and thus cannot decide if they are going to be fragmented later on, > so better not use CHECKSUM_PARTIAL in the first place. > > Cc: Eric Dumazet > Cc: Vlad Yasevic

Re: [PATCH v1 1/3] virtio-net: Using single MSIX IRQ for TX/RX Q pair

2015-10-27 Thread Ravi Kerur
On 10/27/2015 1:38 AM, Michael S. Tsirkin wrote: > On Mon, Oct 26, 2015 at 10:52:47AM -0700, Ravi Kerur wrote: >> Ported earlier patch from Jason Wang (dated 12/26/2014). >> >> This patch tries to reduce the number of MSIX irqs required for >> virtio-net by sharing a MSIX irq for each TX/RX queue

Re: [PATCH v1 1/3] virtio-net: Using single MSIX IRQ for TX/RX Q pair

2015-10-27 Thread Ravi Kerur
On 10/26/2015 10:11 PM, Jason Wang wrote: > > > On 10/27/2015 01:52 AM, Ravi Kerur wrote: >> Ported earlier patch from Jason Wang (dated 12/26/2014). >> >> This patch tries to reduce the number of MSIX irqs required for >> virtio-net by sharing a MSIX irq for each TX/RX queue pair through >> ch

[net PATCH] fib_trie: leaf_walk_rcu should not compute key if key is less than pn->key

2015-10-27 Thread Alexander Duyck
We were computing the child index in cases where the key value we were looking for was actually less than the base key of the tnode. As a result we were getting incorrect index values that would cause us to skip over some children. To fix this I have added a test that will force us to use child i

Re: [PATCH net v2 3/4] ipv6: no CHECKSUM_PARTIAL on MSG_MORE corked sockets

2015-10-27 Thread Tom Herbert
On Tue, Oct 27, 2015 at 2:42 PM, Hannes Frederic Sowa wrote: > Hi Tom, > > On Tue, Oct 27, 2015, at 20:19, Hannes Frederic Sowa wrote: >> On Tue, Oct 27, 2015, at 19:37, Tom Herbert wrote: >> > On Tue, Oct 27, 2015 at 11:29 AM, Hannes Frederic Sowa >> > wrote: >> > > On Tue, Oct 27, 2015, at 18:3

Fw: [Bug 106711] New: VXLAN: RTNL assertion failed at net/core/net_namespace.c:187

2015-10-27 Thread Stephen Hemminger
Begin forwarded message: Date: Tue, 27 Oct 2015 14:05:08 + From: "bugzilla-dae...@bugzilla.kernel.org" To: "shemmin...@linux-foundation.org" Subject: [Bug 106711] New: VXLAN: RTNL assertion failed at net/core/net_namespace.c:187 https://bugzilla.kernel.org/show_bug.cgi?id=106711

Re: [PATCH net v2 3/4] ipv6: no CHECKSUM_PARTIAL on MSG_MORE corked sockets

2015-10-27 Thread Hannes Frederic Sowa
Hi Tom, On Tue, Oct 27, 2015, at 20:19, Hannes Frederic Sowa wrote: > On Tue, Oct 27, 2015, at 19:37, Tom Herbert wrote: > > On Tue, Oct 27, 2015 at 11:29 AM, Hannes Frederic Sowa > > wrote: > > > On Tue, Oct 27, 2015, at 18:32, Tom Herbert wrote: > > >> On Tue, Oct 27, 2015 at 9:44 AM, Hannes Fr

[PATCH net-next v3 4/4] ipv6: add defensive check for CHECKSUM_PARTIAL skbs in ip_fragment

2015-10-27 Thread Hannes Frederic Sowa
CHECKSUM_PARTIAL skbs should never arrive in ip_fragment. If we get one of those warn about them once and handle them gracefully by recalculating the checksum. Fixes: commit 32dce968dd987 ("ipv6: Allow for partial checksums on non-ufo packets") See-also: commit 72e843bb09d45 ("ipv6: ip6_fragment(

[PATCH net-next v3 0/4] net: clean up interactions of CHECKSUM_PARTIAL and fragmentation

2015-10-27 Thread Hannes Frederic Sowa
This series fixes wrong checksums on the wire for IPv4 and IPv6. Large send buffers and especially NFS lead to wrong checksums in both IPv4 and IPv6. CHECKSUM_PARTIAL skbs should not receive the respective fragmentations functions, so we add WARN_ON_ONCE to those functions to fix up those as soon

[PATCH net-next v3 3/4] ipv6: no CHECKSUM_PARTIAL on MSG_MORE corked sockets

2015-10-27 Thread Hannes Frederic Sowa
We cannot reliable calculate packet size on MSG_MORE corked sockets and thus cannot decide if they are going to be fragmented later on, so better not use CHECKSUM_PARTIAL in the first place. The IPv6 code also intended to protect and not use CHECKSUM_PARTIAL in the existence of IPv6 extension head

[PATCH net-next v3 1/4] ipv4: no CHECKSUM_PARTIAL on MSG_MORE corked sockets

2015-10-27 Thread Hannes Frederic Sowa
We cannot reliable calculate packet size on MSG_MORE corked sockets and thus cannot decide if they are going to be fragmented later on, so better not use CHECKSUM_PARTIAL in the first place. Cc: Eric Dumazet Cc: Vlad Yasevich Cc: Benjamin Coddington Cc: Tom Herbert Signed-off-by: Hannes Freder

[PATCH net-next v3 2/4] ipv4: add defensive check for CHECKSUM_PARTIAL skbs in ip_fragment

2015-10-27 Thread Hannes Frederic Sowa
CHECKSUM_PARTIAL skbs should never arrive in ip_fragment. If we get one of those warn about them once and handle them gracefully by recalculating the checksum. Cc: Eric Dumazet Cc: Vlad Yasevich Cc: Benjamin Coddington Cc: Tom Herbert Signed-off-by: Hannes Frederic Sowa --- net/ipv4/ip_outpu

Re: [PATCHv3 net 2/3] ipv6: Export nf_ct_frag6_consume_orig()

2015-10-27 Thread Pravin Shelar
On Sun, Oct 25, 2015 at 8:21 PM, Joe Stringer wrote: > This is needed in openvswitch to fix an skb leak in the next patch. > > Signed-off-by: Joe Stringer Acked-by: Pravin B Shelar -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majord...@vger.ker

Re: [PATCHv3 net 3/3] openvswitch: Fix skb leak using IPv6 defrag

2015-10-27 Thread Pravin Shelar
On Sun, Oct 25, 2015 at 8:21 PM, Joe Stringer wrote: > nf_ct_frag6_gather() makes a clone of each skb passed to it, and if the > reassembly is successful, expects the caller to free all of the original > skbs using nf_ct_frag6_consume_orig(). This call was previously missing, > meaning that the or

Re: [PATCHv3 net 1/3] openvswitch: Fix double-free on ip_defrag() errors

2015-10-27 Thread Pravin Shelar
On Sun, Oct 25, 2015 at 8:21 PM, Joe Stringer wrote: > If ip_defrag() returns an error other than -EINPROGRESS, then the skb is > freed. When handle_fragments() passes this back up to > do_execute_actions(), it will be freed again. Prevent this double free > by never freeing the skb in do_execute_

Re: [PATCH 6/6] net: phy: Stop 'phy-state-machine' and 'phy_change' work on remove

2015-10-27 Thread Andrew Lunn
On Tue, Oct 27, 2015 at 08:57:58AM -0700, Florian Fainelli wrote: > (don't top post please) > > On 27/10/15 08:53, Frode Isaksen wrote: > > What will you need in the oops ? I presume you don' want everything or ? > > > > The PHY state machine is not stopped with a PHY disconnect. > > It is stopp

Re: Missing IPv4 routes

2015-10-27 Thread Alexander Duyck
On 10/27/2015 01:01 PM, Brian Rak wrote: (Existing email got kinda messy, starting over again): So, I'm having an issue with the kernel where if I add a bunch of routes, I see some of them go "missing". They don't show up in the 'ip -4 route' list, but they do show up if I do 'ip -4 route get

Re: Missing IPv4 routes

2015-10-27 Thread Brian Rak
(Existing email got kinda messy, starting over again): So, I'm having an issue with the kernel where if I add a bunch of routes, I see some of them go "missing". They don't show up in the 'ip -4 route' list, but they do show up if I do 'ip -4 route get X'. I managed to come up with a simple

Re: [PATCH net v2 3/4] ipv6: no CHECKSUM_PARTIAL on MSG_MORE corked sockets

2015-10-27 Thread Hannes Frederic Sowa
On Tue, Oct 27, 2015, at 19:37, Tom Herbert wrote: > On Tue, Oct 27, 2015 at 11:29 AM, Hannes Frederic Sowa > wrote: > > On Tue, Oct 27, 2015, at 18:32, Tom Herbert wrote: > >> On Tue, Oct 27, 2015 at 9:44 AM, Hannes Frederic Sowa > >> wrote: > >> > > >> > > >> > On Tue, Oct 27, 2015, at 17:36, T

Re: [PATCH RFC net-next 2/2] tcp: Add Redundant Data Bundling (RDB)

2015-10-27 Thread Jonas Markussen
On 26 Oct 2015, at 22:58, Yuchung Cheng wrote: > but would RDB be voided if this developer turns on RDB then turns on > Nagle later? The short answer is answer is "kind of" My understanding is that Nagle will delay segments until they're either MSS-sized or until segments "down the pipe" are ack

Re: [PATCH net v2 2/4] ipv4: add defensive check for CHECKSUM_PARTIAL skbs in ip_fragment

2015-10-27 Thread Hannes Frederic Sowa
Hi Sergei, On Tue, Oct 27, 2015, at 20:01, Sergei Shtylyov wrote: > On 10/27/2015 06:02 PM, Hannes Frederic Sowa wrote: > > > CHECKSUM_PARTIAL skbs should never arrive in ip_fragment. If we get one > > of those warn about them once and handle them gracefully by recalculating > > the checksum. > >

Re: [PATCH v4 14/15] net: wireless: ath: Remove unneeded variable ret returning 0

2015-10-27 Thread punit vara
On Tue, Oct 27, 2015 at 1:42 PM, Kalle Valo wrote: > punit vara writes: > >> Will my other patches which are already correct be added to wireless >> tree ? or I have to resend everything ? > > Yes, please resend the whole patchset. I don't apply patches > individually from a patchset, it's just t

[RESEND PATCH 03/10] net: wireless: rtwifi: Remove duplicated arguments to |

2015-10-27 Thread Punit Vara
Remove uncessary repeated arguments COMP_EFUSE, COMP_REGD, COMP_CHAN with OR(|) This is patch to the debug.c file that removes following warning reported by coccicheck: -duplicated argument to & or | Signed-off-by: Punit Vara --- drivers/net/wireless/rtlwifi/debug.c | 6 +++--- 1 file changed

[RESEND PATCH 01/10] net: wireless: ath: Remove unnecessary semicolon

2015-10-27 Thread Punit Vara
This patch is to the htt_rx.c that removes unneeded semicolon which is reported by coccicheck. Here semicolon just create empty statement so please remote it. Signed-off-by: Punit Vara --- drivers/net/wireless/ath/ath10k/htt_rx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[RESEND PATCH 04/10] net: wireless: brcm80211: Remove duplicated arguments to |

2015-10-27 Thread Punit Vara
Remove uncessary repeated arguments with OR(|) This is patch to the brcmsmac/channel.c file that removes following warning reported by coccicheck: -duplicated argument to & or | Signed-off-by: Punit Vara --- drivers/net/wireless/brcm80211/brcmsmac/channel.c | 1 - 1 file changed, 1 deletion(-

[RESEND PATCH 06/10] net: wireless: ath: simplify return flow for carl9170_regwrite_result()

2015-10-27 Thread Punit Vara
This patch is to the carl9170/phy.c file that fixes warning reported by coccicheck : WARNING: end returns can be simplified I have removed unneccessary variable declaration and simply return flow for carl9170_regwrite_result() Signed-off-by: Punit Vara --- drivers/net/wireless/ath/carl9170/ph

[RESEND PATCH 05/10] net: wireless: simplify return flow for zd1201_setconfig16

2015-10-27 Thread Punit Vara
This patch is to the zd1201.c file that fixes up warning reported by coccicheck: WARNING: end returns can be simplified and declaration on line 1658 can be dropped Prefer direct return value instead of writing 2-3 more sentence. Signed-off-by: Punit Vara --- drivers/net/wireless/zd1201.c | 6 +

[RESEND PATCH 08/10] net: wireless: brcm80211: Remove unneeded variable which return 0

2015-10-27 Thread Punit Vara
This is patch to the brcmsmac/main.c that removes unnecessary variable which was declared to return zero. This patch fixes up warning reported by coccicheck: -Unneeded variable: "err". Return "0" on line 3788 Signed-off-by: Punit Vara --- drivers/net/wireless/brcm80211/brcmsmac/main.c | 3 +--

[RESEND PATCH 10/10] net: wireless: ath: Remove unneeded variable ret returning 0

2015-10-27 Thread Punit Vara
This patch is to the ath5k/eeprom.c that fixes up warning caught by coccicheck: -Unneeded variable: "ret". Return "0" on line 1733 Remove unneccesary variable ret created to return zero. Signed-off-by: Punit Vara --- drivers/net/wireless/ath/ath5k/eeprom.c | 4 ++-- 1 file changed, 2 insertion

[RESEND PATCH 09/10] net: wireless: brcm80211: Remove unneeded variable ret_code returning 0

2015-10-27 Thread Punit Vara
This patch is to the brcmsmac/stf.c that fixes up warning caught by coccicheck: -Unneeded variable: "ret_code". Return "0" on line 328 Remove unneccesary variable ret_code created to return zero. Signed-off-by: Punit Vara --- drivers/net/wireless/brcm80211/brcmsmac/stf.c | 5 ++--- 1 file chan

[RESEND PATCH 07/10] net: wireless: iwlegacy: Remove unneeded variable ret

2015-10-27 Thread Punit Vara
This patch is to the 3945-mac.c file that fixes up following warning by coccicheck: drivers/net/wireless/iwlegacy/3945-mac.c:247:5-8: Unneeded variable: "ret". Return "- EOPNOTSUPP" on line 249 Return -EOPNOTSUPP directly instead of return using ret Signed-off-by: Punit Vara --- drivers/net/wi

[RESEND PATCH 02/10] net: wireless: ath: Remove unnecessary semicolon

2015-10-27 Thread Punit Vara
This patch is to the ath10k/wmi.h that removes unneeded semicolon which is reported by coccicheck. Here semicolon just create empty statement so please remote it. Signed-off-by: Punit Vara --- drivers/net/wireless/ath/ath10k/wmi.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --g

Re: [PATCH net v2 2/4] ipv4: add defensive check for CHECKSUM_PARTIAL skbs in ip_fragment

2015-10-27 Thread Sergei Shtylyov
Hello. On 10/27/2015 06:02 PM, Hannes Frederic Sowa wrote: CHECKSUM_PARTIAL skbs should never arrive in ip_fragment. If we get one of those warn about them once and handle them gracefully by recalculating the checksum. Cc: Eric Dumazet Cc: Vlad Yasevich Cc: Benjamin Coddington Cc: Tom Herbe

Re: [PATCH net v2 2/4] ipv4: add defensive check for CHECKSUM_PARTIAL skbs in ip_fragment

2015-10-27 Thread Tom Herbert
On Tue, Oct 27, 2015 at 8:02 AM, Hannes Frederic Sowa wrote: > CHECKSUM_PARTIAL skbs should never arrive in ip_fragment. If we get one > of those warn about them once and handle them gracefully by recalculating > the checksum. > I believe a UDP sender within the kernel (like an encapsulation) that

SALLAM ALEIKUM

2015-10-27 Thread MAYA
صديقي العزيز أشعر أنك من العمر ما يكفي للحفاظ على أسرار والتعامل مع مسألة حساسة بشكل سري، وبعد دردشة لدينا القليل شعرت بداخلي بأنني يجب مناقشة اقتراحي معك بسبب المستوى الخاص من التفاهم. هذا هو السبب في أنني أريد أن تقصر هذه الصفقة السرية فيكم. يجب عليك أن تبقي هذه المحادثة على أنها س

Re: [PATCH net v2 3/4] ipv6: no CHECKSUM_PARTIAL on MSG_MORE corked sockets

2015-10-27 Thread Tom Herbert
On Tue, Oct 27, 2015 at 11:29 AM, Hannes Frederic Sowa wrote: > On Tue, Oct 27, 2015, at 18:32, Tom Herbert wrote: >> On Tue, Oct 27, 2015 at 9:44 AM, Hannes Frederic Sowa >> wrote: >> > >> > >> > On Tue, Oct 27, 2015, at 17:36, Tom Herbert wrote:> > - if >> > (cork->length + length

Re: [PATCHv2 net 2/2] ipv4: update RTNH_F_LINKDOWN flag on UP event

2015-10-27 Thread Andy Gospodarek
On Tue, Oct 27, 2015 at 09:42:25AM +0200, Julian Anastasov wrote: > > Hello, > > On Tue, 27 Oct 2015, Andy Gospodarek wrote: > > > I tested this patch and I now see that your reported problem is a result > > of dummy never taking carrier down. There was a presumption that > > carrier noti

Re: [PATCH net v2 2/4] ipv4: add defensive check for CHECKSUM_PARTIAL skbs in ip_fragment

2015-10-27 Thread Hannes Frederic Sowa
On Tue, Oct 27, 2015, at 17:06, Tom Herbert wrote: > On Tue, Oct 27, 2015 at 8:02 AM, Hannes Frederic Sowa > wrote: > > CHECKSUM_PARTIAL skbs should never arrive in ip_fragment. If we get one > > of those warn about them once and handle them gracefully by recalculating > > the checksum. > > > > Cc

Re: [PATCH net v2 3/4] ipv6: no CHECKSUM_PARTIAL on MSG_MORE corked sockets

2015-10-27 Thread Hannes Frederic Sowa
On Tue, Oct 27, 2015, at 18:32, Tom Herbert wrote: > On Tue, Oct 27, 2015 at 9:44 AM, Hannes Frederic Sowa > wrote: > > > > > > On Tue, Oct 27, 2015, at 17:36, Tom Herbert wrote:> > - if > > (cork->length + length > maxnonfragsize - headersize) { > >> > + if (cork->length + len

[PATCHv2] ixgbe: Wait for 1ms, not 1us, after RST

2015-10-27 Thread Dan Streetman
The driver currently waits 1us after issuing a RST, but the spec requires it to wait 1ms. This adds a msleep(1) before polling the reset bit. Signed-off-by: Dan Streetman Signed-off-by: Dan Streetman --- changes since v1: use msleep(1) instead of mdelay(1), per Peter Hurley move msleep(1) out

[PATCHv2 1/2] pci_ids: add Netronome Systems vendor

2015-10-27 Thread Jakub Kicinski
Add PCI vendor id for Netronome Systems. Signed-off-by: Jakub Kicinski Signed-off-by: Rolf Neugebauer --- include/linux/pci_ids.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/include/linux/pci_ids.h b/include/linux/pci_ids.h index d9ba49cedc5d..1acbefc4bbda 100644 --- a/include/linux/p

[PATCHv2 0/2] Netronome NFP4000/NFP6000 NIC VF driver

2015-10-27 Thread Jakub Kicinski
This patchset adds support for VFs of Netronome's NFP-4000 and NFP-6000 based NICs. We are currently also preparing the submission for the PF driver, but it is not quite ready yet. The PF driver can be found on GitHub: https://github.com/Netronome/nfp-drv-kmods changes since v1: - reorganize str

RE: [V5, 2/6] fsl/fman: Add FMan support

2015-10-27 Thread Liberman Igal
Regards, Igal Liberman > -Original Message- > From: Wood Scott-B07421 > Sent: Saturday, September 26, 2015 2:02 AM > To: Liberman Igal-B31950 > Cc: netdev@vger.kernel.org; linuxppc-...@lists.ozlabs.org; linux- > ker...@vger.kernel.org; Bucur Madalin-Cristian-B32716 > > Subject: Re: [V5

[PATCH net-next] enic: assign affinity hint to interrupts

2015-10-27 Thread Govindarajulu Varadarajan
The affinity hint is used by the user space daemon, irqbalancer, to indicate a preferred CPU mask for irqs. This patch sets the irq affinity hint to local numa core first, when exhausted we try non-local numa cores. Introduce enic module global variable enic_numa_count[] to store the number of aff

[linux-review:Neil-Armstrong/net-dsa-cleanup-dsa-driver/20151028-003842] 943beed83806cdd6149e6cf69db108f4c0b6fe31 BUILD DONE

2015-10-27 Thread kbuild test robot
https://github.com/0day-ci/linux Neil-Armstrong/net-dsa-cleanup-dsa-driver/20151028-003842 943beed83806cdd6149e6cf69db108f4c0b6fe31 net: dsa: make usage of mv88e6xxx common remove function drivers/net/dsa/bcm_sf2.c:1077:14: warning: initialization from incompatible pointer type [-Wincompatibl

Re: [PATCH] ixgbe: Wait for 1ms, not 1us, after RST

2015-10-27 Thread Peter Hurley
Hi Dan, On 10/26/2015 08:16 PM, dan.street...@canonical.com wrote: > From: Dan Streetman > > The driver currently waits 1us after issuing a RST, but the spec > requires it to wait 1ms. > > Signed-off-by: Dan Streetman > Signed-off-by: Dan Streetman > --- > drivers/net/ethernet/intel/ixgbe/ix

Re: [PATCH] ixgbe: Wait for 1ms, not 1us, after RST

2015-10-27 Thread Dan Streetman
On Tue, Oct 27, 2015 at 1:03 PM, Skidmore, Donald C wrote: > > >> -Original Message- >> From: dan.street...@canonical.com >> [mailto:dan.street...@canonical.com] >> Sent: Monday, October 26, 2015 5:16 PM >> To: Kirsher, Jeffrey T >> Cc: Brandeburg, Jesse; Nelson, Shannon; Wyborny, Carolyn;

Re: [PATCH net v2 3/4] ipv6: no CHECKSUM_PARTIAL on MSG_MORE corked sockets

2015-10-27 Thread Tom Herbert
On Tue, Oct 27, 2015 at 9:44 AM, Hannes Frederic Sowa wrote: > > > On Tue, Oct 27, 2015, at 17:36, Tom Herbert wrote:> > - if > (cork->length + length > maxnonfragsize - headersize) { >> > + if (cork->length + length > maxnonfragsize - headersize) { >> > emsgsize: >> > -

Re: [PATCH] ixgbe: check Master Disable bit after setting

2015-10-27 Thread Dan Streetman
On Tue, Oct 27, 2015 at 1:14 PM, Skidmore, Donald C wrote: > > >> -Original Message- >> From: dan.street...@canonical.com >> [mailto:dan.street...@canonical.com] >> Sent: Monday, October 26, 2015 5:20 PM >> To: Kirsher, Jeffrey T >> Cc: Brandeburg, Jesse; Nelson, Shannon; Wyborny, Carolyn;

Re: [RFC PATCH 1/3] net: dsa: bcm_sf2: cleanup resources in remove callback

2015-10-27 Thread kbuild test robot
Hi Neil, [auto build test ERROR on net/master -- if it's inappropriate base, please suggest rules for selecting the more suitable base] url: https://github.com/0day-ci/linux/commits/Neil-Armstrong/net-dsa-cleanup-dsa-driver/20151028-003842 config: x86_64-allmodconfig (attached as .config) re

RE: [Intel-wired-lan] [PATCH] fm10k:Fix error handling in the function fm10k_setup_tc

2015-10-27 Thread Singh, Krishneil K
-Original Message- From: Intel-wired-lan [mailto:intel-wired-lan-boun...@lists.osuosl.org] On Behalf Of Nicholas Krause Sent: Tuesday, October 20, 2015 2:05 PM To: Kirsher, Jeffrey T Cc: linux-ker...@vger.kernel.org; intel-wired-...@lists.osuosl.org; netdev@vger.kernel.org Subject: [In

Re: [PATCH net-next V18 3/3] 802.1AD: Flow handling, actions, vlan parsing and netlink attributes

2015-10-27 Thread Pravin Shelar
On Tue, Oct 27, 2015 at 9:45 AM, Thomas F Herbert wrote: > On 10/26/15 10:10 PM, Pravin Shelar wrote: > Thanks for the review. >> >> On Sun, Oct 25, 2015 at 5:11 PM, Thomas F Herbert >> wrote: >>> >>> Add support for 802.1ad including the ability to push and pop double >>> tagged vlans. Add suppo

RE: [PATCH] ixgbe: check Master Disable bit after setting

2015-10-27 Thread Skidmore, Donald C
> -Original Message- > From: dan.street...@canonical.com > [mailto:dan.street...@canonical.com] > Sent: Monday, October 26, 2015 5:20 PM > To: Kirsher, Jeffrey T > Cc: Brandeburg, Jesse; Nelson, Shannon; Wyborny, Carolyn; Skidmore, > Donald C; Vick, Matthew; Ronciak, John; Williams, Mitch

RE: [Intel-wired-lan] [PATCH] fm10k:Fix error handling in the function fm10k_setup_tc for certain function calls

2015-10-27 Thread Singh, Krishneil K
-Original Message- From: Intel-wired-lan [mailto:intel-wired-lan-boun...@lists.osuosl.org] On Behalf Of Nicholas Krause Sent: Friday, October 9, 2015 8:53 AM To: Kirsher, Jeffrey T Cc: linux-ker...@vger.kernel.org; intel-wired-...@lists.osuosl.org; netdev@vger.kernel.org Subject: [Intel

RE: [Intel-wired-lan] [PATCH 3/3] fm10k: use napi_schedule_irqoff()

2015-10-27 Thread Singh, Krishneil K
-Original Message- From: Intel-wired-lan [mailto:intel-wired-lan-boun...@lists.osuosl.org] On Behalf Of Alexander Duyck Sent: Tuesday, September 29, 2015 3:20 PM To: netdev@vger.kernel.org; intel-wired-...@lists.osuosl.org Subject: [Intel-wired-lan] [PATCH 3/3] fm10k: use napi_schedule_i

  1   2   3   >