On Tue, Oct 27, 2015 at 9:44 AM, Hannes Frederic Sowa
<han...@stressinduktion.org> wrote:
>
>
> On Tue, Oct 27, 2015, at 17:36, Tom Herbert wrote:> > - if
> (cork->length + length > maxnonfragsize - headersize) {
>> > + if (cork->length + length > maxnonfragsize - headersize) {
>> > emsgsize:
>> > - ipv6_local_error(sk, EMSGSIZE, fl6,
>> > - mtu - headersize +
>> > - sizeof(struct ipv6hdr));
>> > - return -EMSGSIZE;
>> > - }
>> > + ipv6_local_error(sk, EMSGSIZE, fl6,
>> > + mtu - headersize +
>> > + sizeof(struct ipv6hdr));
>> > + return -EMSGSIZE;
>> > }
>> >
>> > + /* CHECKSUM_PARTIAL only with no extension headers and when
>>
>> No, please don't do this. CHECKSUM_PARTIAL should work with extension
>> headers as defined, so this is just disabling otherwise valid and
>> useful functionality. If (some) drivers have problems with this they
>> need to be identified and fixed.
>
> I don't understand. The old code already didn't allow the use of
> opt_flen with CHECKSUM_PARTIAL.
>
Then that's a problem with the old code :-). Is there any other reason
that we can't use CHECKSUM_PARTIAL with extension headers other than
lack of correct driver support?
> The MSG_MORE check has nothing to do with that but only with corking.
>
> Bye,
> Hannes
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
