Re: [patch 3/4] net: Percpufy frequently used variables -- proto.sockets_allocated

2006-01-27 Thread Eric Dumazet
Ravikiran G Thirumalai a écrit : On Sat, Jan 28, 2006 at 01:35:03AM +0100, Eric Dumazet wrote: Eric Dumazet a écrit : Andrew Morton a écrit : Eric Dumazet <[EMAIL PROTECTED]> wrote: long percpu_counter_read_accurate(struct percpu_counter *fbc) { long res = 0; int cpu;

Re: [patch 3/4] net: Percpufy frequently used variables -- proto.sockets_allocated

2006-01-27 Thread Ravikiran G Thirumalai
On Sat, Jan 28, 2006 at 01:35:03AM +0100, Eric Dumazet wrote: > Eric Dumazet a écrit : > >Andrew Morton a écrit : > >>Eric Dumazet <[EMAIL PROTECTED]> wrote: > > > >#ifdef CONFIG_SMP > >void percpu_counter_mod(struct percpu_counter *fbc, long amount) > >{ > > long old, new; > > atomic_long_

Re: [ANNOUNCE] RT2x00 ieee80211 stack switch

2006-01-27 Thread Jouni Malinen
On Wed, Jan 04, 2006 at 01:35:08PM +0100, Jiri Benc wrote: > On Tue, 03 Jan 2006 18:06:30 +0100, Johannes Berg wrote: > > How about > > - get rid of all the embedded algorithms (AES, Michael, RC4, > >CRC) and use the crypto layer from the kernel > > Definitely. Yes, that is also on my to-do

Re: Devicescape stack and 'intelligent' devices

2006-01-27 Thread Jouni Malinen
On Wed, Jan 11, 2006 at 09:11:23PM +0100, Stefan Rompf wrote: > to evaluate the Devicescape stack, I started porting the ipw2100 driver to > it. > However I do have one major problem. At least the snapshort from January 2nd > does not seem to support devices that do scanning and associating con

Re: [patch 3/4] net: Percpufy frequently used variables -- proto.sockets_allocated

2006-01-27 Thread Andrew Morton
Eric Dumazet <[EMAIL PROTECTED]> wrote: > > [PATCH] Add atomic_long_xchg() and atomic_long_cmpxchg() wrappers > > ... > > +static inline long atomic_long_xchg(atomic_long_t *l, long val) > +{ > + atomic64_t *v = (atomic64_t *)l; > + return atomic64_xchg(v, val); All we need now is some

Re: [patch 3/4] net: Percpufy frequently used variables -- proto.sockets_allocated

2006-01-27 Thread Eric Dumazet
Andrew Morton a écrit : Eric Dumazet <[EMAIL PROTECTED]> wrote: An advantage of retaining a spinlock in percpu_counter is that if accuracy is needed at a low rate (say, /proc reading) we can take the lock and then go spill each CPU's local count into the main one. It would need to be a very low

Re: [patch] drivers/net/wireless: correct reported ssid lengths

2006-01-27 Thread Jouni Malinen
On Thu, Jan 12, 2006 at 03:00:58PM -0500, Dan Williams wrote: > ESSIDs can technically include NULL characters. Drivers should not be > adjusting the length of the ESSID before reporting it in their > SIOCGIWESSID handlers. Breaks stuff like wpa_supplicant. Note that ipw > drivers, which seem t

Re: [patch 3/4] net: Percpufy frequently used variables -- proto.sockets_allocated

2006-01-27 Thread Andrew Morton
Eric Dumazet <[EMAIL PROTECTED]> wrote: > > > > > An advantage of retaining a spinlock in percpu_counter is that if accuracy > > is needed at a low rate (say, /proc reading) we can take the lock and then > > go spill each CPU's local count into the main one. It would need to be a > > very low rat

Re: [patch 3/4] net: Percpufy frequently used variables -- proto.sockets_allocated

2006-01-27 Thread Ravikiran G Thirumalai
On Sat, Jan 28, 2006 at 12:21:07AM +0100, Eric Dumazet wrote: > Ravikiran G Thirumalai a écrit : > >On Fri, Jan 27, 2006 at 11:30:23PM +0100, Eric Dumazet wrote: > > Why not use a boot time allocated percpu area (as done today in > setup_per_cpu_areas()), but instead of reserving extra space for

Re: [patch 3/4] net: Percpufy frequently used variables -- proto.sockets_allocated

2006-01-27 Thread Eric Dumazet
Eric Dumazet a écrit : Andrew Morton a écrit : Eric Dumazet <[EMAIL PROTECTED]> wrote: Ravikiran G Thirumalai a écrit : On Fri, Jan 27, 2006 at 12:16:02PM -0800, Andrew Morton wrote: Ravikiran G Thirumalai <[EMAIL PROTECTED]> wrote: which can be assumed as not frequent. At sk_stream_mem_sch

Re: [patch 3/4] net: Percpufy frequently used variables -- proto.sockets_allocated

2006-01-27 Thread Andrew Morton
Ravikiran G Thirumalai <[EMAIL PROTECTED]> wrote: > > On Fri, Jan 27, 2006 at 03:08:47PM -0800, Andrew Morton wrote: > > Andrew Morton <[EMAIL PROTECTED]> wrote: > > > > > > Oh, and because vm_acct_memory() is counting a singleton object, it can > > > use > > > DEFINE_PER_CPU rather than alloc_per

Re: [patch 3/4] net: Percpufy frequently used variables -- proto.sockets_allocated

2006-01-27 Thread Eric Dumazet
Andrew Morton a écrit : Eric Dumazet <[EMAIL PROTECTED]> wrote: Ravikiran G Thirumalai a écrit : On Fri, Jan 27, 2006 at 12:16:02PM -0800, Andrew Morton wrote: Ravikiran G Thirumalai <[EMAIL PROTECTED]> wrote: which can be assumed as not frequent. At sk_stream_mem_schedule(), read_sockets_al

Re: [patch 3/4] net: Percpufy frequently used variables -- proto.sockets_allocated

2006-01-27 Thread Ravikiran G Thirumalai
On Fri, Jan 27, 2006 at 03:08:47PM -0800, Andrew Morton wrote: > Andrew Morton <[EMAIL PROTECTED]> wrote: > > > > Oh, and because vm_acct_memory() is counting a singleton object, it can use > > DEFINE_PER_CPU rather than alloc_percpu(), so it saves on a bit of kmalloc > > overhead. > > Actually, I

Please pull 'upstream' branch of wireless-2.6

2006-01-27 Thread John W. Linville
This branch includes the 'upstream-fixes' branch as well. I presume that you will have already pulled 'upstream-fixes' both to the netdev-2.6 'upstream-fixes' branch as well as the netdev-2.6 'upstream' branch. This pull request is intended for the 'upstream' branch of netdev-2.6. --- The follow

Re: pull request for wireless-2.6.git

2006-01-27 Thread John W. Linville
On Fri, Jan 27, 2006 at 10:05:01AM -0500, Jeff Garzik wrote: > So, before I pull this, two questions: > > 1) You sent a subsequent pull request, with only three csets listed. > Does that indicate a pull will now _only_ pull 3 csets, or it will pull > 3 _additional_ csets? > > 2) The above incl

Please pull 'upstream-fixes' branch of wireless-2.6

2006-01-27 Thread John W. Linville
The following changes since commit 3ee68c4af3fd7228c1be63254b9f884614f9ebb2: David S. Miller: [SPARC64]: Use compat_sys_futimesat in 32-bit syscall table. are found in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/linville/wireless-2.6.git upstream-fixes [EMAI

Re: [patch 3/4] net: Percpufy frequently used variables -- proto.sockets_allocated

2006-01-27 Thread Eric Dumazet
Ravikiran G Thirumalai a écrit : On Fri, Jan 27, 2006 at 11:30:23PM +0100, Eric Dumazet wrote: There are several issues here : alloc_percpu() current implementation is a a waste of ram. (because it uses slab allocations that have a minimum size of 32 bytes) Oh there was a solution for that :

Re: [patch 3/4] net: Percpufy frequently used variables -- proto.sockets_allocated

2006-01-27 Thread Andrew Morton
Eric Dumazet <[EMAIL PROTECTED]> wrote: > > Ravikiran G Thirumalai a écrit : > > On Fri, Jan 27, 2006 at 12:16:02PM -0800, Andrew Morton wrote: > >> Ravikiran G Thirumalai <[EMAIL PROTECTED]> wrote: > >>> which can be assumed as not frequent. > >>> At sk_stream_mem_schedule(), read_sockets_alloca

Re: [patch 3/4] net: Percpufy frequently used variables -- proto.sockets_allocated

2006-01-27 Thread Andrew Morton
Ravikiran G Thirumalai <[EMAIL PROTECTED]> wrote: > > On Fri, Jan 27, 2006 at 12:16:02PM -0800, Andrew Morton wrote: > > Ravikiran G Thirumalai <[EMAIL PROTECTED]> wrote: > > > > > > which can be assumed as not frequent. > > > At sk_stream_mem_schedule(), read_sockets_allocated() is invoked only

Re: [patch 3/4] net: Percpufy frequently used variables -- proto.sockets_allocated

2006-01-27 Thread Andrew Morton
Andrew Morton <[EMAIL PROTECTED]> wrote: > > Oh, and because vm_acct_memory() is counting a singleton object, it can use > DEFINE_PER_CPU rather than alloc_percpu(), so it saves on a bit of kmalloc > overhead. Actually, I don't think that's true. we're allocating a sizeof(long) with kmalloc_node(

Re: [patch 3/4] net: Percpufy frequently used variables -- proto.sockets_allocated

2006-01-27 Thread Eric Dumazet
Ravikiran G Thirumalai a écrit : On Fri, Jan 27, 2006 at 12:16:02PM -0800, Andrew Morton wrote: Ravikiran G Thirumalai <[EMAIL PROTECTED]> wrote: which can be assumed as not frequent. At sk_stream_mem_schedule(), read_sockets_allocated() is invoked only certain conditions, under memory pressu

Re: [patch 3/4] net: Percpufy frequently used variables -- proto.sockets_allocated

2006-01-27 Thread Ravikiran G Thirumalai
On Fri, Jan 27, 2006 at 11:30:23PM +0100, Eric Dumazet wrote: > > There are several issues here : > > alloc_percpu() current implementation is a a waste of ram. (because it uses > slab allocations that have a minimum size of 32 bytes) Oh there was a solution for that :). http://lwn.net/Artic

Re: [patch 3/4] net: Percpufy frequently used variables -- proto.sockets_allocated

2006-01-27 Thread Ravikiran G Thirumalai
On Fri, Jan 27, 2006 at 12:16:02PM -0800, Andrew Morton wrote: > Ravikiran G Thirumalai <[EMAIL PROTECTED]> wrote: > > > > which can be assumed as not frequent. > > At sk_stream_mem_schedule(), read_sockets_allocated() is invoked only > > certain conditions, under memory pressure -- on a large C

Re: [patch 3/4] net: Percpufy frequently used variables -- proto.sockets_allocated

2006-01-27 Thread Eric Dumazet
Andrew Morton a écrit : Ravikiran G Thirumalai <[EMAIL PROTECTED]> wrote: On Fri, Jan 27, 2006 at 09:53:53AM +0100, Eric Dumazet wrote: Ravikiran G Thirumalai a écrit : Change the atomic_t sockets_allocated member of struct proto to a per-cpu counter. Signed-off-by: Pravin B. Shelar <[EMAIL

[PATCH (final?)] Additional options for resetting packet statistics

2006-01-27 Thread Kris Katterjohn
Okay, it's probably now or never for this patch :) Signed-off-by: Kris Katterjohn <[EMAIL PROTECTED]> Signed-off-by: YOSHIFUJI Hideaki <[EMAIL PROTECTED]> --- x/net/packet/af_packet.c2006-01-25 22:18:41.0 -0600 +++ y/net/packet/af_packet.c2006-01-25 22:18:57.0 -0600 @@ -19

Re: What does the following code fragments do in e1000_clean_rx_irq?

2006-01-27 Thread Jesse Brandeburg
On 1/27/06, John Smith <[EMAIL PROTECTED]> wrote: > Hi Jesse, > > I have some difficulties understanding the meaning of the following code > fragments in e1000 driver. It seems this is for packet-split and non > packet-split respectively. But could you shed more lights on the logic > behind this co

Re: [PATCH RESEND 3/6] e1000: Added functions to save and restore config

2006-01-27 Thread Greg KH
On Thu, Jan 26, 2006 at 03:44:33PM +0100, Ingo Oeser wrote: > Jesse Brandeburg wrote: > > On Mon, 23 Jan 2006, Ingo Oeser wrote: > > > Jeff Kirsher wrote: > > > > These functions help restore the driver to active configuration when > > > > coming out of resume for > > > power management. > > > >

[PATCH d80211]: Add support for WE-18

2006-01-27 Thread Jouni Malinen
This patch addd Linux Wireless Extensions version 18 support into the Devicescape 802.11 stack by converting the WE ioctl registration to use the new dev->wireless_handlers mechanism and by adding support for the ioctls that are needed for WPA/WPA2 in client mode. The private ioctl versions of key

Re: [patch 3/4] net: Percpufy frequently used variables -- proto.sockets_allocated

2006-01-27 Thread Andrew Morton
Ravikiran G Thirumalai <[EMAIL PROTECTED]> wrote: > > On Fri, Jan 27, 2006 at 09:53:53AM +0100, Eric Dumazet wrote: > > Ravikiran G Thirumalai a écrit : > > >Change the atomic_t sockets_allocated member of struct proto to a > > >per-cpu counter. > > > > > >Signed-off-by: Pravin B. Shelar <[EMAIL P

Re: [patch 3/4] net: Percpufy frequently used variables -- proto.sockets_allocated

2006-01-27 Thread Ravikiran G Thirumalai
On Fri, Jan 27, 2006 at 09:53:53AM +0100, Eric Dumazet wrote: > Ravikiran G Thirumalai a écrit : > >Change the atomic_t sockets_allocated member of struct proto to a > >per-cpu counter. > > > >Signed-off-by: Pravin B. Shelar <[EMAIL PROTECTED]> > >Signed-off-by: Ravikiran Thirumalai <[EMAIL PROTEC

Re: tg3 bug noticed

2006-01-27 Thread Michael Chan
On Thu, 2006-01-26 at 22:40 -0500, Jeff Garzik wrote: > Since tg3 uses schedule_work(), to eliminate race(s) tg3 needs to call > flush_scheduled_work(), somewhere in the close path. Probably suspend > path, too. > [TG3]: Flush tg3_reset_task() Make sure tg3_reset_task() is flushed in the close

Re: [Patch 0/6] IPSEC: Sync series

2006-01-27 Thread jamal
On Fri, 2006-27-01 at 11:46 -0500, James Morris wrote: > On Fri, 27 Jan 2006, jamal wrote: > > > > > The following series of patches aim at allowing one IPSEC node to > > synchronize state to another. The mechanisms provide ability to easily > > write apps such as OpenBSD's sasyncd[1]. > > Pleas

What does the following code fragments do in e1000_clean_rx_irq?

2006-01-27 Thread John Smith
Hi Jesse, I have some difficulties understanding the meaning of the following code fragments in e1000 driver. It seems this is for packet-split and non packet-split respectively. But could you shed more lights on the logic behind this code fragment? Thanks, John static boolean_t e1000_clea

Re: [PATCH 1/9] sky2: pci express config register access

2006-01-27 Thread Jeff Garzik
Stephen Hemminger wrote: On Thu, 26 Jan 2006 22:16:31 -0500 Jeff Garzik <[EMAIL PROTECTED]> wrote: Stephen Hemminger wrote: The sky2 driver attempts to clear PCI express errors on boot, but the PCI subsystem sometimes won't let the sky2 driver write to PCI express registers. It depends on th

[GIT PULL] bcm43xx update

2006-01-27 Thread Michael Buesch
Hi John, I synced my git repository with the bcm43xx SVN repository. I will continue to develop the driver in git, so these ugly syncing will not be needed any longer. I will poke you from time to time to pull from my repos. (I don't know how the other bcm43xx developers will handle it. I suggest

Re: [PATCH 1/9] sky2: pci express config register access

2006-01-27 Thread Stephen Hemminger
On Thu, 26 Jan 2006 22:16:31 -0500 Jeff Garzik <[EMAIL PROTECTED]> wrote: > Stephen Hemminger wrote: > > The sky2 driver attempts to clear PCI express errors on boot, but > > the PCI subsystem sometimes won't let the sky2 driver write to PCI > > express registers. It depends on the phase of the mo

Re: [Patch 0/6] IPSEC: Sync series

2006-01-27 Thread James Morris
On Fri, 27 Jan 2006, jamal wrote: > > The following series of patches aim at allowing one IPSEC node to > synchronize state to another. The mechanisms provide ability to easily > write apps such as OpenBSD's sasyncd[1]. Please consider updating security/selinux/nlmsgtab.c for new and/or updated

Re: [PATCH][IPsec] IPsec gule of AES-XCBC-MAC

2006-01-27 Thread Kazunori Miyazawa
James Morris wrote: On Fri, 27 Jan 2006, James Morris wrote: Once again, these #ifdefs need to disappear from the core code. Sorry, I was looking at the wrong email. Please send patches inline. This would have helped :-) OK. I never mind. But I have already replied for your previous

Re: [PATCH][IPsec] IPsec gule of AES-XCBC-MAC

2006-01-27 Thread Kazunori Miyazawa
Sure, I'm considering your comment. And I did not resend any glue patch to the IPsec stack. Did I mistake to send it? I did not intend to reuse my old glue codes. I'm going to prepare it reflect your comment. I sent only XCBC core. James Morris wrote: On Fri, 13 Jan 2006, Kazunori Miyazawa wr

Re: [PATCH][IPsec] IPsec gule of AES-XCBC-MAC

2006-01-27 Thread James Morris
On Fri, 27 Jan 2006, James Morris wrote: > Once again, these #ifdefs need to disappear from the core code. Sorry, I was looking at the wrong email. > Please send patches inline. This would have helped :-) - James -- James Morris <[EMAIL PROTECTED]> - To unsubscribe from this list: send the

Re: [PATCH][IPsec] IPsec gule of AES-XCBC-MAC

2006-01-27 Thread James Morris
On Fri, 13 Jan 2006, Kazunori Miyazawa wrote: +#ifdef CONFIG_CRYPTO_XCBC + mode = aalg_desc->desc.sadb_alg_id == SADB_X_AALG_AES_XCBC_MAC ? + CRYPTO_TFM_MODE_CBC : 0; +#endif + ahp->key = x->aalg->alg_key; ahp->key_len = (x->aalg->alg_key_len+7)/8; - ahp->

Re: [PATCH 2.6.15-git9a] aoe [1/1]: do not stop retransmit timer when device goes down

2006-01-27 Thread Al Boldi
Ed L. Cashin wrote: > On Thu, Jan 26, 2006 at 01:04:37AM +0300, Al Boldi wrote: > > Ed L. Cashin wrote: > > > This patch is a bugfix that follows and depends on the > > > eight aoe driver patches sent January 19th. > > > > Will they also fix this? > > Or is this an md bug? > > No, this patch fixes

Re: [Patch 05/11] mv643xx_eth: Remove needless mp->port_mac_addr

2006-01-27 Thread Jeff Garzik
Dale Farnsworth wrote: From: Dale Farnsworth <[EMAIL PROTECTED]> mp->port_mac_addr is just a redundant copy of dev->dev_addr, so remove it. Signed-off-by: Dale Farnsworth <[EMAIL PROTECTED]> applied 5-11 to 'upstream-2.6.17' - To unsubscribe from this list: send the line "unsubscribe netdev

Re: [Patch 01/11] mv643xx_eth: Fix spinlock recursion bug

2006-01-27 Thread Jeff Garzik
Dale Farnsworth wrote: From: Dale Farnsworth <[EMAIL PROTECTED]> This patch eliminates a spinlock recursion bug introduced recently. Since eth_port_send() is always called with the lock held, we simply remove the locking inside the function itself. Signed-off-by: Dale Farnsworth <[EMAIL PROTECT

Re: [BUG] sky2 broken for Yukon PCI-E Gigabit Ethernet Controller 11ab:4362 (rev 19)

2006-01-27 Thread Knut Petersen
Herbert Xu wrote: When we pull the PPP protocol off the skb, we forgot to update the hardware RX checksum. This may lead to messages such as dsl0: hw csum failure. Similarly, we need to clear the hardware checksum flag when we use the existing packet to store the decompressed result.

Re: [Patch 00/11] mv643xx_eth: patch series of 2005-01-27

2006-01-27 Thread Dale Farnsworth
On Fri, Jan 27, 2006 at 10:32:31AM -0500, Jeff Garzik wrote: > Dale Farnsworth wrote: > >I'll followup to this posting with the latest mv643xx_eth patches: > > > > 01 Fix spinlock recursion bug bug fix > > 02 Update dev->last_rx on packet receivebug

Re: [PATCH] tulip: Make ALi (ULi) integrated 100BaseTX Ethernet work

2006-01-27 Thread Jeff Garzik
Olaf Hering wrote: We carry this patch since 2005-03-13. Jiri, can you check if 2.6.16 still doesnt work for you on this sort of hardware? I did not find a bugzilla nor a better description. The ULi-specific driver should be used rather than tulip... All support for this should be removed fro

Re: [Patch 00/11] mv643xx_eth: patch series of 2005-01-27

2006-01-27 Thread Jeff Garzik
Dale Farnsworth wrote: I'll followup to this posting with the latest mv643xx_eth patches: 01 Fix spinlock recursion bug bug fix 02 Update dev->last_rx on packet receive bug fix 03 whitespace cleanup c

Re: [BUG] sky2 broken for Yukon PCI-E Gigabit Ethernet Controller 11ab:4362 (rev 19)

2006-01-27 Thread Patrick McHardy
Herbert Xu wrote: > On Fri, Jan 27, 2006 at 07:07:34AM +0100, Knut Petersen wrote: > >>Well, there are no problems if SuSEfirewall2 is disabled. But have a look >>at the loaded modules: >> >>ipt_MASQUERADE 3968 1 >>pppoe 15360 2 >>pppox 4616 1 pppoe >

Re: pull request for wireless-2.6.git

2006-01-27 Thread Jeff Garzik
John W. Linville wrote: The following changes since commit 0f36b018b2e314d45af86449f1a97facb1fbe300: Linus Torvalds: Merge master.kernel.org:/.../sfrench/cifs-2.6 are found in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/linville/wireless-2.6.git upstream-jg

Re: [PATCH RESEND 6/6] e1000: Added driver comments

2006-01-27 Thread Jeff Garzik
Ingo Oeser wrote: Jeff Kirsher wrote: Signed-off-by: Jeff Kirsher <[EMAIL PROTECTED]> Signed-off-by: Jesse Brandeburg <[EMAIL PROTECTED]> Signed-off-by: John Ronciak <[EMAIL PROTECTED]> --- drivers/net/e1000/e1000_main.c | 72 +--- 1 files changed, 67 inser

Re: [Acx100-devel] Re: [-mm patch] drivers/net/wireless/tiacx/: remove code for WIRELESS_EXT < 18

2006-01-27 Thread Andreas Mohr
Hi, On Fri, Jan 27, 2006 at 02:49:49PM +0200, Denis Vlasenko wrote: > On Friday 27 January 2006 13:49, Johannes Berg wrote: > > On Fri, 2006-01-27 at 12:19 +0200, Denis Vlasenko wrote: > > > > > I very much want to get rid of all remaining compat cruft, and > > > I plan to do it as soon as acx wi

re: patching arm-linux 2.4.18 on sharp zaurus sl-5500

2006-01-27 Thread Lorne J. Leitman
Hello, Apologies in advance if this is appearing on an inappropriate list! We are a group of researchers at University of Pittbsurgh trying to implement an ad-hoc routing protocol on the Sharp Zaurus 5500 pda. Our network is running the following environment: -arm-linux kernel 2.4.18-pxa3

Re: fib_rules w. RCU lock [PATCH]

2006-01-27 Thread Robert Olsson
David S. Miller writes: > > + r = (struct fib_rule *) fib_rules.first; > I don't think this is right. > fib_rules.first is a pointer to the hlist_node (within the fib_rule) > not the fib_rule itself. It works because the hlist_node is the first member of the struct fib_rule but I agree i

[Patch 6/6] IPSEC: policy expire updates

2006-01-27 Thread jamal
This allows insertion of policy expires (useful to synchronize byte lifetimes) cheers, jamal This is similar to the SA expire insertion patch - only it inserts expires for SP. Signed-off-by: Jamal Hadi Salim <[EMAIL PROTECTED]> --- include/net/xfrm.h |2 +- net/xfrm/xfrm_policy.c |

[Patch 5/6] IPSEC: SA expire updates

2006-01-27 Thread jamal
This allows insertion of SA expires (useful to synchronize byte lifetimes) cheers, jamal This patch allows a user to insert SA expires. This is useful to do on an HA backup for the case of byte counts but may not be very useful for the case of time based expiry. Signed-off-by: Jamal Hadi Salim

[Patch 4/6] IPSEC: acquire updates

2006-01-27 Thread jamal
This allows an app to insert an Acquire cheers, jamal This introduces a feature similar to the one described in RFC 2367: " ... the application needing an SA sends a PF_KEY SADB_ACQUIRE message down to the Key Engine, which then either returns an error or sends a similar SADB_ACQUIRE me

[Patch 3/6] IPSEC: user updates

2006-01-27 Thread jamal
xfrm user updates cheers, jamal This patch adds xfrm as the user of the core changes Signed-off-by: Jamal Hadi Salim <[EMAIL PROTECTED]> --- net/key/af_key.c |2 net/xfrm/xfrm_user.c | 247 -- 2 files changed, 239 insertions(+), 10 de

[Patch 1/6] IPSEC: core updates

2006-01-27 Thread jamal
the core changes cheers, jamal This patch provides the core functionality needed for sync events for ipsec. Signed-off-by: Jamal Hadi Salim <[EMAIL PROTECTED]> --- include/linux/sysctl.h |3 ++ include/linux/xfrm.h | 30 include/net/xfrm.h | 33 +

[Patch 2/6] IPSEC: fast path updates

2006-01-27 Thread jamal
The fast path updates cheers, jamal This patch adds the sequence updates that will generate ipsec async events Signed-off-by: Jamal Hadi Salim <[EMAIL PROTECTED]> --- net/ipv4/ah4.c |2 ++ net/ipv4/esp4.c |2 ++ net/ipv6/ah6.c |2 ++ net/ipv6/esp6.c |2 ++ 4 files changed, 8

[Patch 0/6] IPSEC: Sync series

2006-01-27 Thread jamal
The following series of patches aim at allowing one IPSEC node to synchronize state to another. The mechanisms provide ability to easily write apps such as OpenBSD's sasyncd[1]. I actually have been sitting on the patches for a while but this week I was able to upgrade to the latest git tree and

Re: [-mm patch] drivers/net/wireless/tiacx/: remove code for WIRELESS_EXT < 18

2006-01-27 Thread Denis Vlasenko
On Friday 27 January 2006 13:49, Johannes Berg wrote: > On Fri, 2006-01-27 at 12:19 +0200, Denis Vlasenko wrote: > > > I very much want to get rid of all remaining compat cruft, and > > I plan to do it as soon as acx will be present in mainline kernel. > > I doubt you'll get it merged with the co

Re: wireless-2.6 status (25 January 2006)

2006-01-27 Thread John W. Linville
On Fri, Jan 27, 2006 at 09:17:50AM +, Christoph Hellwig wrote: > Folks, please stop these stupid ideas. There's a free driver, let's improve > and merge it. That's a thousand times better than any half-free driver > with buggy binary blobs. I presume you mean the ath-driver.org stuff? I'm

Re: [BUG] sky2 broken for Yukon PCI-E Gigabit Ethernet Controller 11ab:4362 (rev 19)

2006-01-27 Thread Herbert Xu
On Fri, Jan 27, 2006 at 07:07:34AM +0100, Knut Petersen wrote: > > Well, there are no problems if SuSEfirewall2 is disabled. But have a look > at the loaded modules: > > ipt_MASQUERADE 3968 1 > pppoe 15360 2 > pppox 4616 1 pppoe OK, although we can't

[PATCH 4/4] AES-XCBC-MAC

2006-01-27 Thread Kazunori Miyazawa
Changing Kconfig and Makefile --- crypto/Kconfig |9 + crypto/Makefile |1 + 2 files changed, 10 insertions(+), 0 deletions(-) 0eba6b1f8367cb6330f28ca22fa6c163f5ef892a diff --git a/crypto/Kconfig b/crypto/Kconfig index c442f2e..8dc28e9 100644 --- a/crypto/Kconfig +++ b/crypto/K

[PATCH 0/0] AES-XCBC-MAC

2006-01-27 Thread Kazunori Miyazawa
Hello, I resend following patches to the kernel support AES-XCBC-MAC. These patches can probably support another XCBC algorithms but I only tested with AES on the test vectors of RFC3566. They do not include glue codes for IPsec stack. I misunderstood XCBC. I regarded the constants in the previo

[PATCH 2/4] AES-XCBC-MAC

2006-01-27 Thread Kazunori Miyazawa
These patches glue for crypto api. --- crypto/cipher.c |8 crypto/internal.h | 16 2 files changed, 24 insertions(+), 0 deletions(-) 45bc98c447c18976c1ea0982054f2d677358fc31 diff --git a/crypto/cipher.c b/crypto/cipher.c index 65bcea0..aa30aa9 100644 --- a/cryp

[PATCH 3/4] AES-XCBC-MAC

2006-01-27 Thread Kazunori Miyazawa
These patches add tests for AES-XCBC-MAC. --- crypto/tcrypt.c | 103 ++- crypto/tcrypt.h | 80 +++ 2 files changed, 181 insertions(+), 2 deletions(-) 03dfa73836c8802a91bfd84b1a019b02667a74ea diff --gi

[PATCH 1/4] AES-XCBC-MAC

2006-01-27 Thread Kazunori Miyazawa
This patch add core codes. --- crypto/xcbc.c | 230 include/linux/crypto.h | 21 2 files changed, 251 insertions(+), 0 deletions(-) create mode 100644 crypto/xcbc.c 2473ccbfd89e4c20507caba721f44aa748a9bc6e diff --git a/crypto/x

Re: [-mm patch] drivers/net/wireless/tiacx/: remove code for WIRELESS_EXT < 18

2006-01-27 Thread Johannes Berg
On Fri, 2006-01-27 at 12:19 +0200, Denis Vlasenko wrote: > I very much want to get rid of all remaining compat cruft, and > I plan to do it as soon as acx will be present in mainline kernel. I doubt you'll get it merged with the compat cruft. johannes signature.asc Description: This is a digit

Re: 2.6.16-rc1-mm3

2006-01-27 Thread Reuben Farrelly
On 25/01/2006 8:24 p.m., Andrew Morton wrote: http://www.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.16-rc1/2.6.16-rc1-mm3/ - Dropped the timekeeping patch series due to a complex timesource selection bug. - Various fixes and updates. Changes since 2.6.16-rc1-mm2: Just trig

Re: [IPV4]: Always set fl.proto in ip_route_newports

2006-01-27 Thread Herbert Xu
Patrick McHardy <[EMAIL PROTECTED]> wrote: > > Thats what I meant, expressed slightly more misunderstandable :) Now that I read it again indeed you were right all along :) -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~} <[EMAIL PROTECTED]> Home Page: http://gondor.apan

Re: [-mm patch] drivers/net/wireless/tiacx/: remove code for WIRELESS_EXT < 18

2006-01-27 Thread Denis Vlasenko
Hi Adrian, On Sunday 22 January 2006 19:11, Adrian Bunk wrote: > WIRELESS_EXT < 18 will never be true in the kernel. > > > Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]> Please don't do this. We are not in the kernel yet. acx currently is in -mm, not in mainline. We have quite a few users of

Re: wireless-2.6 status (25 January 2006)

2006-01-27 Thread Christoph Hellwig
On Thu, Jan 26, 2006 at 03:04:22PM -0500, John W. Linville wrote: > On Thu, Jan 26, 2006 at 11:58:17AM -0800, Ben Greear wrote: > > David Hollis wrote: > > > >I don't know the details of the Atheros chip to > > >know if it might be possible to generate a firmware that users would > > >have to inst

RE: wireless-2.6 status (25 January 2006)

2006-01-27 Thread Samuel Ortiz
On Thu, 26 Jan 2006, ext Simon Barber wrote: > In order to get FCC certification the manufacturer must ensure there is > no easy way for the user to tune to illegal frequencies. FCC verifies that a product running a certain software follows FCC rules in terms of frequencies, power level, signal ba

Re: [patch 2/4] net: Percpufy frequently used variables -- struct proto.memory_allocated

2006-01-27 Thread Eric Dumazet
Ravikiran G Thirumalai a écrit : Change struct proto->memory_allocated to a batching per-CPU counter (percpu_counter) from an atomic_t. A batching counter is better than a plain per-CPU counter as this field is read often. Signed-off-by: Pravin B. Shelar <[EMAIL PROTECTED]> Signed-off-by: Rav

Re: [patch 3/4] net: Percpufy frequently used variables -- proto.sockets_allocated

2006-01-27 Thread Eric Dumazet
Ravikiran G Thirumalai a écrit : Change the atomic_t sockets_allocated member of struct proto to a per-cpu counter. Signed-off-by: Pravin B. Shelar <[EMAIL PROTECTED]> Signed-off-by: Ravikiran Thirumalai <[EMAIL PROTECTED]> Signed-off-by: Shai Fultheim <[EMAIL PROTECTED]> Hi Ravikiran If I c

Re: wireless-2.6 status (25 January 2006)

2006-01-27 Thread Jean-Baptiste Note
Hello John, Samuel, > Well, at least part of the answer is "I'm not done yet". I am still > collecting code and figuring-out how to get it all into one tree. > > But, the main answer has to do with the intellectual property > (i.e. copyright) issues concerning the HAL. My understanding is > tha

[Patch 10/11] mv643xx_eth: use MII library for ethtool functions

2006-01-27 Thread Dale Farnsworth
From: James Chapman <[EMAIL PROTECTED]> Use the common ethtool support functions of the MII library. Add generic MII ioctl handler. Add PHY parameter speed/duplex/negotiation initialization and modification. Signed-off-by: James Chapman <[EMAIL PROTECTED]> Signed-off-by: Dale Farnsworth <[EMAIL P

[Patch 11/11] mv643xx_eth: Clean up platform_data configuration

2006-01-27 Thread Dale Farnsworth
From: Dale Farnsworth <[EMAIL PROTECTED]> We shouldn't expose the hardware register contents in platform_data. The only things we allow the user to configure are autoneg, speed, and duplex. Add specific platform_data fields for these values and remove the registers configs. Signed-off-by: Dale F

[Patch 09/11] mv643xx_eth: use MII library for PHY management

2006-01-27 Thread Dale Farnsworth
From: James Chapman <[EMAIL PROTECTED]> Modify link up/down handling to use the functions from the MII library. Note that I track link state using the MII PHY registers rather than the mv643xx chip's link state registers because I think it's cleaner to use the MII library code rather than writing

Re: [IPV4]: Always set fl.proto in ip_route_newports

2006-01-27 Thread Patrick McHardy
Herbert Xu wrote: > On Thu, Jan 26, 2006 at 03:25:17PM +0100, Patrick McHardy wrote: > >>[IPV4]: Always set fl.proto in ip_route_newports >> >>ip_route_newports uses the struct flowi from the struct rtable returned >>by ip_route_connect for the new route lookup and just replaces the port >>numbers

[Patch 08/11] mv643xx_eth: Make port queue enable/disable code consistent

2006-01-27 Thread Dale Farnsworth
From: Dale Farnsworth <[EMAIL PROTECTED]> Add and use the following functions: mv643xx_eth_port_enable_tx() mv643xx_eth_port_enable_rx() mv643xx_eth_port_disable_tx() mv643xx_eth_port_disable_rx() so that ports are enabled/disabled consistently. Signed-off-by: Dal

[Patch 07/11] mv643xx_eth: Rename mp->tx_ring_skbs to mp->tx_desc_count

2006-01-27 Thread Dale Farnsworth
From: Dale Farnsworth <[EMAIL PROTECTED]> tx_ring_skbs is actually a count of tx descriptors currently in use. Since there may be multiple descriptors per skb, it is not the same as the number of skbs in the ring. Also change rx_ring_skbs to rx_desc_count to be consistent. Signed-off-by: Dale Fa

[Patch 06/11] mv643xx_eth: Merge unicast and multicast address filtering code

2006-01-27 Thread Dale Farnsworth
From: Dale Farnsworth <[EMAIL PROTECTED]> Remove duplicated code by having unicast and multicast code use a common filter table function: eth_port_set_filter_table_entry(). Signed-off-by: Dale Farnsworth <[EMAIL PROTECTED]> --- drivers/net/mv643xx_eth.c | 84 +++---

[Patch 02/11] mv643xx_eth: Update dev->last_rx on packet receive

2006-01-27 Thread Dale Farnsworth
From: Paolo Galtieri <[EMAIL PROTECTED]> Update dev->last_rx on packet receive This fix corrects errors seen during configuration of the bonding driver. Signed-off-by: Paolo Galtieri <[EMAIL PROTECTED]> Signed-off-by: Dale Farnsworth <[EMAIL PROTECTED]> --- drivers/net/mv643xx_eth.c |1 +

[Patch 03/11] mv643xx_eth: Whitespace cleanup

2006-01-27 Thread Dale Farnsworth
From: Dale Farnsworth <[EMAIL PROTECTED]> Signed-off-by: Dale Farnsworth <[EMAIL PROTECTED]> --- drivers/net/mv643xx_eth.c | 94 +--- 1 file changed, 46 insertions(+), 48 deletions(-) Index: linux-2.6-mv643xx_enet/drivers/net/mv643xx_eth.c =

[Patch 04/11] mv643xx_eth: Fix for building as a module

2006-01-27 Thread Dale Farnsworth
From: Dale Farnsworth <[EMAIL PROTECTED]> Enable mv643xx_eth driver to work when built as a module on mv64x60-based embedded systems. Signed-off-by: Dale Farnsworth <[EMAIL PROTECTED]> --- arch/ppc/syslib/mv64x60.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) Index: linux-2.6-m

[Patch 05/11] mv643xx_eth: Remove needless mp->port_mac_addr

2006-01-27 Thread Dale Farnsworth
From: Dale Farnsworth <[EMAIL PROTECTED]> mp->port_mac_addr is just a redundant copy of dev->dev_addr, so remove it. Signed-off-by: Dale Farnsworth <[EMAIL PROTECTED]> --- drivers/net/mv643xx_eth.c | 18 +++--- drivers/net/mv643xx_eth.h |3 +-- 2 files changed, 8 insertions(+)

[Patch 00/11] mv643xx_eth: patch series of 2005-01-27

2006-01-27 Thread Dale Farnsworth
I'll followup to this posting with the latest mv643xx_eth patches: 01 Fix spinlock recursion bug bug fix 02 Update dev->last_rx on packet receivebug fix 03 whitespace cleanup cleanup 04 fix

Re: [PATCH] ipv6: addrconf_ifdown fix dst refcounting.

2006-01-27 Thread Eric W. Biederman
Herbert Xu <[EMAIL PROTECTED]> writes: > On Wed, Jan 25, 2006 at 08:12:02PM +, Eric W. Biederman wrote: >> >> Unfortunately because we have already call rt6_ifdown() the route is >> not found in the routing table, the dst_free does not decrement the >> count and is therefore unable to free the

[Patch 01/11] mv643xx_eth: Fix spinlock recursion bug

2006-01-27 Thread Dale Farnsworth
From: Dale Farnsworth <[EMAIL PROTECTED]> This patch eliminates a spinlock recursion bug introduced recently. Since eth_port_send() is always called with the lock held, we simply remove the locking inside the function itself. Signed-off-by: Dale Farnsworth <[EMAIL PROTECTED]> --- drivers/net/mv