RE: [2.6 patch] net/sunrpc/xdr.c: remove xdr_decode_string()

2005-11-23 Thread Lever, Charles
> On Wednesday November 23, [EMAIL PROTECTED] wrote: > > On Wed, Nov 23, 2005 at 04:31:14AM -0800, Lever, Charles wrote: > > > so i don't remember why you are removing > xdr_decode_string. are we sure > > > that no-one will need this functionality in the future? > it is harmless > > > to remove

Setting ipv6 route flags

2005-11-23 Thread feketgai
Hi, I realized that in route.c the inet6_rtm_new_route() function the inet6_rtm_to_rtmsg() does not take into account the user supplied flags. This way it seems to be not possible to set the RTF_DEFAULT flag of a default route (dest address being "any"). It is true that the new route will end up i

Re: [RFC] [PATCH 0/3] ioat: DMA engine support

2005-11-23 Thread Andi Kleen
On Wed, Nov 23, 2005 at 07:17:01PM -0500, Benjamin LaHaise wrote: > On Wed, Nov 23, 2005 at 11:30:08PM +0100, Andi Kleen wrote: > > The main problem I see is that it'll likely only pay off when you can keep > > the queue of copies long (to amortize the cost of > > talking to an external chip). At

Re: Mouse issues in -mm

2005-11-23 Thread Frank Sorenson
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Dmitry Torokhov wrote: > What kind of touchpad do you have? Could you post your > /pros/bus/input/devices please? AlpsPS/2 ALPS GlidePoint /proc/bus/input/devices: I: Bus=0010 Vendor=001f Product=0001 Version=0100 N: Name="PC Speaker" P: Phys=isa0061

[PATCH 2/6] sk98lin: add permanent address support

2005-11-23 Thread shemminger
Add permanent address and link status support via ethtool. Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> --- skge-2.6.orig/drivers/net/sk98lin/skethtool.c +++ skge-2.6/drivers/net/sk98lin/skethtool.c @@ -549,4 +549,6 @@ struct ethtool_ops SkGeEthtoolOps = { .phys_id

[PATCH 4/6] sk98lin: allow ethtool checksum on/off per port

2005-11-23 Thread shemminger
Allow control of checksumming parameters via ethtool. Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> --- skge-2.6.orig/drivers/net/sk98lin/h/skdrv2nd.h +++ skge-2.6/drivers/net/sk98lin/h/skdrv2nd.h @@ -298,6 +298,7 @@ struct s_RxPort { RXD *pRxdRingTail; /* Tail of Rx r

[PATCH 6/6] sk98lin: remove /proc interface

2005-11-23 Thread shemminger
Remove device specific proc interface. It doesn't handle renames correctly; it ain't worth fixing. Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> --- skge-2.6.orig/drivers/net/sk98lin/Makefile +++ skge-2.6/drivers/net/sk98lin/Makefile @@ -26,8 +26,7 @@ sk98lin-objs:=\

[PATCH 0/6] sk98lin:

2005-11-23 Thread shemminger
These patches fix some lingering issues with the sk98lin driver. I expect the sk98lin driver to fade from use, but many users still unknowingly use it. They are ordered from most important to least important. Feel free to divide across releases as you see fit. -- - To unsubscribe from this list:

[PATCH 5/6] sk98lin: remove redundant fields in device info

2005-11-23 Thread shemminger
Shrink size of per device data by removing redundant fields or things that are only used at boot up. Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> --- skge-2.6.orig/drivers/net/sk98lin/h/skdrv2nd.h +++ skge-2.6/drivers/net/sk98lin/h/skdrv2nd.h @@ -268,8 +268,6 @@ typedef struct s_DevNet DE

[PATCH 1/6] sk98lin: fix checksumming code

2005-11-23 Thread shemminger
Remove code from sk98lin that does it's own checksum validation. This code is incorrect when dealing with nested protocols like VLAN's, and it is better to use regular receive code path to handle hardware checksum. Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> Index: skge-2.6/drivers/net/

[PATCH 3/6] sk98lin: avoid message confusion with skge

2005-11-23 Thread shemminger
Avoid possible confusion between skge and sk98lin driver by tagging messages properly. Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> --- skge-2.6.orig/drivers/net/sk98lin/skge.c +++ skge-2.6/drivers/net/sk98lin/skge.c @@ -4853,7 +4853,7 @@ static int __devinit skge_probe_one(stru d

Re: [2.6 patch] do not select NET_CLS

2005-11-23 Thread Sam Ravnborg
On Wed, Nov 23, 2005 at 06:13:32PM -0800, Randy.Dunlap wrote: > > So -q means "quick" ? >From make help: -q, --question Run no commands; exit status says if up to date > I wouldn't mind seeing a -quiet (even less quiet than V=0), > not even printing the CC, AS, LD, etc. commands -- just let the >

Re: Mouse issues in -mm

2005-11-23 Thread Dmitry Torokhov
On Wednesday 23 November 2005 21:06, Frank Sorenson wrote: > Andrew Morton wrote: > > Marc Koschewski <[EMAIL PROTECTED]> wrote: > >>Just booted into 2.6.15-rc2-mm1. The 'mouse problem' (as reported earlier) > >>still > >>persists, > > > > You'l probably need to re-report the mouse problem if the

Re: Network lockup under load

2005-11-23 Thread Jesse Brandeburg
> > > Some e1000 experts need to look into this. > > > > Hmmm, I'll find out who that is and bring them onboard, after > > the T.day break. I'll work with Joe to see where we can get on Monday. Jesse - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [

Re: [2.6 patch] do not select NET_CLS

2005-11-23 Thread Randy.Dunlap
On Wed, 23 Nov 2005 06:57:35 +0100 Sam Ravnborg wrote: > On Tue, Nov 22, 2005 at 03:00:41PM -0800, David S. Miller wrote: > > From: Sam Ravnborg <[EMAIL PROTECTED]> > > Date: Tue, 22 Nov 2005 23:49:14 +0100 > > > > > On Tue, Nov 22, 2005 at 02:37:13PM -0800, David S. Miller wrote: > > > > > > >

Mouse issues in -mm

2005-11-23 Thread Frank Sorenson
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Andrew Morton wrote: > Marc Koschewski <[EMAIL PROTECTED]> wrote: >>Just booted into 2.6.15-rc2-mm1. The 'mouse problem' (as reported earlier) >>still >>persists, > > You'l probably need to re-report the mouse problem if the previous report > didn't

Re: [RFC] [PATCH 0/3] ioat: DMA engine support

2005-11-23 Thread David S. Miller
From: Benjamin LaHaise <[EMAIL PROTECTED]> Date: Wed, 23 Nov 2005 19:17:01 -0500 > Similarly, we should make sure that network drivers prefetch the > header at the earliest possible time, too. Several do already, thankfully :) At last check skge, tg3, chelsio, and ixgb do the necessary prefetchi

Re: [RFC] [PATCH 0/3] ioat: DMA engine support

2005-11-23 Thread Benjamin LaHaise
On Wed, Nov 23, 2005 at 11:30:08PM +0100, Andi Kleen wrote: > The main problem I see is that it'll likely only pay off when you can keep > the queue of copies long (to amortize the cost of > talking to an external chip). At least for the standard recvmsg > skb->user space, user space-> skb cases

Re: [RFC] [PATCH 1/3] ioat: DMA subsystem

2005-11-23 Thread Greg KH
On Wed, Nov 23, 2005 at 12:26:42PM -0800, Andrew Grover wrote: > +static void > +dma_class_release(struct class_device *cd) > +{ > + /* do something */ > +} Well, then actually do something here. Don't try to trick the kernel to not complain about the lack of a release function by giving it a

Re: [RFC] [PATCH 0/3] ioat: DMA engine support

2005-11-23 Thread Jeff Garzik
Alan Cox wrote: Might also be interesting to use one half of a hypedthread CPU as a copier using the streaming instructions, might be better than turning it off to improve performance ? That's pretty interesting too... Jeff - To unsubscribe from this list: send the line "unsubscribe

Re: [RFC] [PATCH 0/3] ioat: DMA engine support

2005-11-23 Thread Alan Cox
On Mer, 2005-11-23 at 23:30 +0100, Andi Kleen wrote: > Another proposal was swiotlb. I was hoping Intel might have rediscovered the IOMMU by then and be back on feature parity with the VAX 11/750 > > But it's not clear it's a good idea: a lot of these applications prefer to > have the target in

Re: [RFC] [PATCH 0/3] ioat: DMA engine support

2005-11-23 Thread Jeff Garzik
Andi Kleen wrote: Longer term the right way to handle this would be likely to use POSIX AIO on sockets. With that interface it would be easier to keep long queues of data in flight, which would be best for the DMA engine. Agreed. For my own userland projects, I'm starting to feel the need for

Re: [2.6 patch] net/sunrpc/xdr.c: remove xdr_decode_string()

2005-11-23 Thread Neil Brown
On Wednesday November 23, [EMAIL PROTECTED] wrote: > On Wed, Nov 23, 2005 at 04:31:14AM -0800, Lever, Charles wrote: > > so i don't remember why you are removing xdr_decode_string. are we sure > > that no-one will need this functionality in the future? it is harmless > > to remove today, but i wo

Re: [RFC] [PATCH 0/3] ioat: DMA engine support

2005-11-23 Thread Jeff Garzik
Andrew Grover wrote: overall diffstat information: drivers/Kconfig |2 drivers/Makefile |1 drivers/dma/Kconfig | 40 ++ drivers/dma/Makefile |5 drivers/dma/cb_list.h | 12 drivers/dma/dmaengine.c | 394 drivers/

Re: [RFC: 2.6 patch] remove drivers/net/eepro100.c

2005-11-23 Thread Russell King
On Wed, Nov 23, 2005 at 02:39:46PM -0800, David S. Miller wrote: > From: Russell King <[EMAIL PROTECTED]> > Date: Wed, 23 Nov 2005 22:15:48 + > > > I leave it up to you how to proceed. Effectively I'm now completely > > out of the loop on this with no hardware to worry about. Sorry. > > > >

Re: [RFC: 2.6 patch] remove drivers/net/eepro100.c

2005-11-23 Thread David S. Miller
From: Russell King <[EMAIL PROTECTED]> Date: Wed, 23 Nov 2005 22:53:19 + > That means there's about 15 minutes left before I go to sleep before > having to be up early tomorrow to go on a 2 hour journey to attend a > meeting. What do you want me to do with those 15 minutes? Perform a > mirac

Re: [RFC] [PATCH 0/3] ioat: DMA engine support

2005-11-23 Thread Jeff Garzik
Alan Cox wrote: Additionally, current IOAT is memory->memory. I would love to be able to convince Intel to add transforms and checksums, Not just transforms but also masks and maybe even merges and textures would be rather handy 8) Ah yes: I totally forgot to mention XOR. Software RAID

Re: Network lockup under load

2005-11-23 Thread David S. Miller
From: Joe Korty <[EMAIL PROTECTED]> Date: Wed, 23 Nov 2005 17:37:07 -0500 > On Wed, Nov 23, 2005 at 02:07:04PM -0800, David S. Miller wrote: > > > There is some bug in the e1000 card that causes it to wedge with > > TSO+SG packets, the driver should have a sufficient workaround but > > aparently

Re: [RFC] [PATCH 3/3] ioat: testclient

2005-11-23 Thread Jeff Garzik
Andrew Grover wrote: diff --git a/drivers/dma/testclient.c b/drivers/dma/testclient.c new file mode 100644 index 000..9bfb979 --- /dev/null +++ b/drivers/dma/testclient.c @@ -0,0 +1,132 @@ +/*** + + + Copyright(c)

Re: [RFC] [PATCH 1/3] ioat: DMA subsystem

2005-11-23 Thread Jeff Garzik
Mostly ok, but some minor nits. Andrew Grover wrote: index 000..f2cc2d7 --- /dev/null +++ b/drivers/dma/cb_list.h @@ -0,0 +1,12 @@ +/* Extra macros that build on */ +#ifndef CB_LIST_H +#define CB_LIST_H + +#include + +/* Provide some safty to list_add, which I find easy to swap the arg

Re: [RFC] [PATCH 2/3] ioat: user buffer pin; net DMA client register

2005-11-23 Thread Jeff Garzik
A per-patch description would be nice, as DaveM mentioned... and also please put a diffstat in each email. Jeff - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-in

Re: [PATCH 2.6.14] Bridge: recompute features when adding a new device

2005-11-23 Thread David S. Miller
From: Olaf Rempel <[EMAIL PROTECTED]> Date: Wed, 23 Nov 2005 22:36:10 +0100 > We must recompute bridge features everytime the list of underlying > devices changes, or we might end up with features that are not > supported by all devices (eg. NETIF_F_TSO) > This patch adds the missing recompute wh

Re: Network lockup under load

2005-11-23 Thread Joe Korty
On Wed, Nov 23, 2005 at 02:07:04PM -0800, David S. Miller wrote: > There is some bug in the e1000 card that causes it to wedge with > TSO+SG packets, the driver should have a sufficient workaround but > aparently not. > > Some e1000 experts need to look into this. Hmmm, I'll find out who that is

Re: [RFC] [PATCH 0/3] ioat: DMA engine support

2005-11-23 Thread Jeff Garzik
Andrew Grover wrote: As presented in our talk at this year's OLS, the Bensley platform, which will be out in early 2006, will have an asyncronous DMA engine. It can be used to offload copies from the CPU, such as the kernel copies of received packets into the user buffer. More than a one-para

Re: [RFC: 2.6 patch] remove drivers/net/eepro100.c

2005-11-23 Thread David S. Miller
From: Russell King <[EMAIL PROTECTED]> Date: Wed, 23 Nov 2005 22:15:48 + > I leave it up to you how to proceed. Effectively I'm now completely > out of the loop on this with no hardware to worry about. Sorry. > > Finally, please don't assign any blame for this in my direction; I > reported

Re: [RFC] [PATCH 0/3] ioat: DMA engine support

2005-11-23 Thread Alan Cox
On Mer, 2005-11-23 at 12:26 -0800, Andrew Grover wrote: > early next year. Until then, the code doesn't really *do* anything, but we > wanted to release what we could right away, and start getting some > feedback. First comment partly based on Jeff Garziks comments - if you added an "operation" t

Re: [RFC] [PATCH 0/3] ioat: DMA engine support

2005-11-23 Thread Andi Kleen
On Wed, Nov 23, 2005 at 05:06:42PM -0500, Jeff Garzik wrote: > IOAT is super-neat stuff. The main problem I see is that it'll likely only pay off when you can keep the queue of copies long (to amortize the cost of talking to an external chip). At least for the standard recvmsg skb->user space,

Re: [RFC: 2.6 patch] remove drivers/net/eepro100.c

2005-11-23 Thread Russell King
On Wed, Nov 23, 2005 at 10:15:48PM +, Russell King wrote: > On Fri, Nov 18, 2005 at 11:12:28AM -0500, Jeff Garzik wrote: > > Russell King wrote: > > >On Fri, Nov 18, 2005 at 04:33:02AM +0100, Adrian Bunk wrote: > > > > > >>This patch removes the obsolete drivers/net/eepro100.c driver. > > >> >

Re: [RFC] [PATCH 0/3] ioat: DMA engine support

2005-11-23 Thread Alan Cox
On Mer, 2005-11-23 at 17:06 -0500, Jeff Garzik wrote: > Sample ideas: VM page pre-zeroing. ATA PIO data xfers (async copy to > static buffer, to dramatically shorten length of kmap+irqsave time). > Extremely large memcpy() calls. ATA PIO copies are 512 bytes of memory per sector and that is us

Re: [RFC: 2.6 patch] remove drivers/net/eepro100.c

2005-11-23 Thread Russell King
On Fri, Nov 18, 2005 at 11:12:28AM -0500, Jeff Garzik wrote: > Russell King wrote: > >On Fri, Nov 18, 2005 at 04:33:02AM +0100, Adrian Bunk wrote: > > > >>This patch removes the obsolete drivers/net/eepro100.c driver. > >> > >>Is there any reason why it should be kept? > > > > > >Tt's the only driv

Re: Network lockup under load

2005-11-23 Thread David S. Miller
From: Joe Korty <[EMAIL PROTECTED]> Date: Wed, 23 Nov 2005 16:32:55 -0500 > On Thu, Nov 24, 2005 at 08:11:05AM +1100, Herbert Xu wrote: > > > Please try turning sg and tso off to see if it helps. > > tso sg result > -- -- -- > on on stallout >

Re: [RFC] [PATCH 0/3] ioat: DMA engine support

2005-11-23 Thread Jeff Garzik
Andrew Grover wrote: As presented in our talk at this year's OLS, the Bensley platform, which will be out in early 2006, will have an asyncronous DMA engine. It can be used to offload copies from the CPU, such as the kernel copies of received packets into the user buffer. IOAT is super-neat s

Re: Network lockup under load

2005-11-23 Thread David S. Miller
From: Joe Korty <[EMAIL PROTECTED]> Date: Wed, 23 Nov 2005 16:01:24 -0500 >Then, a following ifdown/ifup with an intervening sleep let another 6 files >through before locking up. This means the e1000 card's transmitter is wedging when using TSO scatter-gather packet buffers. There are so

Re: Network lockup under load

2005-11-23 Thread David S. Miller
From: Herbert Xu <[EMAIL PROTECTED]> Date: Thu, 24 Nov 2005 08:11:05 +1100 > On Wed, Nov 23, 2005 at 04:01:24PM -0500, Joe Korty wrote: > > Will do in a bit, but as everything works fine with 2.6.13-rc1-git7 and > > earlier > > kernels, I don't expect this will be the problem. > > It's probably

Re: [RFC] [PATCH 1/3] ioat: DMA subsystem

2005-11-23 Thread David S. Miller
Please provide a complete and detailed changelog message for each patch and an introductory email explaining the top-level purpose of these changes. Yes, I personally know what these changes are all about, but not everyone does. Sending a bunch of non-descript patches to the list is always a ver

[PATCH 2.6.14] Bridge: recompute features when adding a new device

2005-11-23 Thread Olaf Rempel
We must recompute bridge features everytime the list of underlying devices changes, or we might end up with features that are not supported by all devices (eg. NETIF_F_TSO) This patch adds the missing recompute when adding a device to the bridge. Sign-off-by: Olaf Rempel <[EMAIL PROTECTED]> di

Re: Network lockup under load

2005-11-23 Thread Joe Korty
On Thu, Nov 24, 2005 at 08:11:05AM +1100, Herbert Xu wrote: > Please try turning sg and tso off to see if it helps. tso sg result -- -- -- on on stallout on off works off on works off off wo

Re: Network lockup under load

2005-11-23 Thread Herbert Xu
On Wed, Nov 23, 2005 at 04:01:24PM -0500, Joe Korty wrote: > On Thu, Nov 24, 2005 at 07:45:16AM +1100, Herbert Xu wrote: > > > What does ethtool -k say on the e1000 card? > > buttercup# ethtool -k eth0 > Offload parameters for eth0: > rx-checksumming: on > tx-checksumming: on >

Re: Network lockup under load

2005-11-23 Thread Joe Korty
On Thu, Nov 24, 2005 at 07:45:16AM +1100, Herbert Xu wrote: > What does ethtool -k say on the e1000 card? buttercup# ethtool -k eth0 Offload parameters for eth0: rx-checksumming: on tx-checksumming: on scatter-gather: on tcp segmentation offload: on > Looks like buttercu

Re: Network lockup under load

2005-11-23 Thread Herbert Xu
On Wed, Nov 23, 2005 at 02:42:39PM -0500, Joe Korty wrote: > > Intel(R) PRO/1000 Network Driver - version 6.0.60-k2 > Copyright (c) 1999-2005 Intel Corporation. > ACPI: PCI Interrupt :03:01.0[A] -> GSI 28 (level, low) -> IRQ 169 > e1000: eth0: e1000_probe: Intel(R) PRO/1000 Net

[RFC] [PATCH 3/3] ioat: testclient

2005-11-23 Thread Andrew Grover
diff --git a/drivers/dma/testclient.c b/drivers/dma/testclient.c new file mode 100644 index 000..9bfb979 --- /dev/null +++ b/drivers/dma/testclient.c @@ -0,0 +1,132 @@ +/*** + + + Copyright(c) 2004 - 2005 Intel Corp

[RFC] [PATCH 2/3] ioat: user buffer pin; net DMA client register

2005-11-23 Thread Andrew Grover
diff --git a/net/core/Makefile b/net/core/Makefile index 630da0f..d02132b 100644 --- a/net/core/Makefile +++ b/net/core/Makefile @@ -8,7 +8,8 @@ obj-y := sock.o request_sock.o skbuff.o obj-$(CONFIG_SYSCTL) += sysctl_net_core.o obj-y += dev.o ethtool.o dev_mcast.o dst.o \ -

[RFC] [PATCH 1/3] ioat: DMA subsystem

2005-11-23 Thread Andrew Grover
diff --git a/drivers/Kconfig b/drivers/Kconfig index 48f446d..fbe5116 100644 --- a/drivers/Kconfig +++ b/drivers/Kconfig @@ -66,4 +66,6 @@ source "drivers/infiniband/Kconfig" source "drivers/sn/Kconfig" +source "drivers/dma/Kconfig" + endmenu diff --git a/drivers/Makefile b/drivers/Makefile

[RFC] [PATCH 0/3] ioat: DMA engine support

2005-11-23 Thread Andrew Grover
As presented in our talk at this year's OLS, the Bensley platform, which will be out in early 2006, will have an asyncronous DMA engine. It can be used to offload copies from the CPU, such as the kernel copies of received packets into the user buffer. The code consists of the following section

Re: 2.6.15-rc2-mm1

2005-11-23 Thread Andrew Morton
Marc Koschewski <[EMAIL PROTECTED]> wrote: > > * Andrew Morton <[EMAIL PROTECTED]> [2005-11-23 03:35:50 -0800]: > > > > > ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.15-rc2/2.6.15-rc2-mm1/ > > > > (temp copy at > > http://www.zip.com.au/~akpm/linux/patches/stuff/2.6.15-rc2

Re: 2.6.15-rc2-mm1

2005-11-23 Thread Andrew Morton
Michal Piotrowski <[EMAIL PROTECTED]> wrote: > > Debug: sleeping function called from invalid context at > include/asm/semaphore.h:123 > in_atomic():1, irqs_disabled():0 > [] dump_stack+0x17/0x19 > [] __might_sleep+0x9c/0xae > [] translate_table+0x147/0xc14 [ip_tables] > [] ipt_register_

Re: [Fwd: [Bug 5644] New: NFS v3 TCP 3-way handshake incorrect, iptables blocks access]

2005-11-23 Thread Olaf Kirch
On Wed, Nov 23, 2005 at 07:01:59PM +0100, Olaf Kirch wrote: > We've seen this previously, and submitted a fix to netfilter which > supposedly went into mainline at some point. It seems to be gone > from 2.6.14 though. And here are the two patches that came out of the netfilter discussion at that t

Re: [Fwd: [Bug 5644] New: NFS v3 TCP 3-way handshake incorrect, iptables blocks access]

2005-11-23 Thread Olaf Kirch
On Wed, Nov 23, 2005 at 12:53:43PM -0500, Trond Myklebust wrote: > Sorry to be cross-posting, but does this bug ring any bells? I'm having > trouble seeing how the sunrpc server code could be at fault. We've seen this previously, and submitted a fix to netfilter which supposedly went into mainline

[Fwd: [Bug 5644] New: NFS v3 TCP 3-way handshake incorrect, iptables blocks access]

2005-11-23 Thread Trond Myklebust
Sorry to be cross-posting, but does this bug ring any bells? I'm having trouble seeing how the sunrpc server code could be at fault. Cheers, Trond --- Begin Message --- http://bugzilla.kernel.org/show_bug.cgi?id=5644 Summary: NFS v3 TCP 3-way handshake incorrect, iptables blocks

[PATCH] Re: leak in bridge netfilter if skb traverses > 1 bridge

2005-11-23 Thread David Kimdon
Indeed, as Herbert pointed out, no need to NULL the pointer, updated patch follows. Signed-off-by: David Kimdon <[EMAIL PROTECTED]> * net/bridge/br_netfilter.c (br_nf_pre_routing) : Call nf_bridge_put() before potentially allocating a new nf_bridge structure and overwr

Re: [2.6 patch] net/sunrpc/xdr.c: remove xdr_decode_string()

2005-11-23 Thread Adrian Bunk
On Wed, Nov 23, 2005 at 04:31:14AM -0800, Lever, Charles wrote: > > On Thu, Oct 06, 2005 at 07:13:14AM -0700, Lever, Charles wrote: > > > > > actually, can we hold off on this change? the RPC > > transport switch will > > > eventually need most of those EXPORT_SYMBOLs. > > > > Am I right to ass

Re: multi-supplicant WAS(Re: Issue 0 WAS (Re: Oustanding issues WAS(IRe: Consensus? WAS(RFC 2863)

2005-11-23 Thread jamal
On Wed, 2005-23-11 at 09:54 -0500, jamal wrote: > yes, this would work. However, i am still interested in the case where > you have a single radio but multiple AP connections - unless this is > impossible. I have to go back and look at that paper - I know they were > using very basic 802.11 >

multi-supplicant WAS(Re: Issue 0 WAS (Re: Oustanding issues WAS(IRe: Consensus? WAS(RFC 2863)

2005-11-23 Thread jamal
I just changed the topic so as not to distract the original discussion On Wed, 2005-23-11 at 06:41 -0800, Jouni Malinen wrote: > The case where one radio in client mode is associating with multiple APs > is usually done by having multiple virtual netdevs, i.e., one for each > association. Soun

Re: Issue 0 WAS (Re: Oustanding issues WAS(IRe: Consensus? WAS(RFC 2863)

2005-11-23 Thread Jouni Malinen
On Wed, Nov 23, 2005 at 09:24:05AM -0500, jamal wrote: > Well, thats certainly one way. Then the oper state machines you are > working on + stacking will work well. But this depends on if you can > justify the reason for those virtual devices. With wireless you can > probably justify to map the ra

Re: Issue 0 WAS (Re: Oustanding issues WAS(IRe: Consensus? WAS(RFC 2863)

2005-11-23 Thread jamal
Stefan, On Tue, 2005-22-11 at 21:38 +0100, Stefan Rompf wrote: > we could protect operstate with a spinlock_irqsave() and then change it > either > from netif_[carrier|dormant]_on/off() or userspace-supplicant. However, I'm > not feeling good about it. Ok, what you have is fine by me. > Loo

RE: [2.6 patch] net/sunrpc/xdr.c: remove xdr_decode_string()

2005-11-23 Thread Lever, Charles
> On Thu, Oct 06, 2005 at 07:13:14AM -0700, Lever, Charles wrote: > > > actually, can we hold off on this change? the RPC > transport switch will > > eventually need most of those EXPORT_SYMBOLs. > > Am I right to assume this will happen in the foreseeable future? the first portion of the tran

Re: Network lockup under load

2005-11-23 Thread Herbert Xu
On Tue, Nov 22, 2005 at 07:39:49PM -0500, Joe Korty wrote: > > 19:32:01.795103 buttercup.ccur.com.34798 > tsunami.ccur.com.ssh: . > 1495105:1496553(1448) ack 28242 win 2372 12059137> (DF) [tos 0x8] > 19:32:08.323773 buttercup.ccur.com.34798 > tsunami.ccur.com.ssh: . > 1495105:1496553(1448) ack

[PATCH 15/15] ixp2000: add driver version, bump version to 0.2

2005-11-23 Thread Lennert Buytenhek
Signed-off-by: Lennert Buytenhek <[EMAIL PROTECTED]> diff -urN linux-2.6.15-rc1.upstream.orig/drivers/net/ixp2000/ixpdev.c linux-2.6.15-rc1.upstream/drivers/net/ixp2000/ixpdev.c --- linux-2.6.15-rc1.upstream.orig/drivers/net/ixp2000/ixpdev.c 2005-11-22 11:43:31.0 +0100 +++ linux-2.6.15-r

[PATCH 13/15] enp2611: disable/enable SERDES carrier on interface down/up

2005-11-23 Thread Lennert Buytenhek
Disable/enable the SERDES carrier when an interface is administratively downed/upped. Signed-off-by: Lennert Buytenhek <[EMAIL PROTECTED]> diff -urN linux-2.6.15-rc1.upstream.orig/drivers/net/ixp2000/enp2611.c linux-2.6.15-rc1.upstream/drivers/net/ixp2000/enp2611.c --- linux-2.6.15-rc1.upstream.

[PATCH 14/15] ixp2000: add netpoll support

2005-11-23 Thread Lennert Buytenhek
Add netpoll support to the ixp2000 driver. Signed-off-by: Lennert Buytenhek <[EMAIL PROTECTED]> diff -urN linux-2.6.15-rc1.upstream.orig/drivers/net/ixp2000/ixpdev.c linux-2.6.15-rc1.upstream/drivers/net/ixp2000/ixpdev.c --- linux-2.6.15-rc1.upstream.orig/drivers/net/ixp2000/ixpdev.c 2005-11-22

[PATCH 12/15] pm3386: implement reset

2005-11-23 Thread Lennert Buytenhek
Implement pm3386 reset. A reset zeroes out the internally stored MAC addresses, so we need to save and reload them by hand. Signed-off-by: Lennert Buytenhek <[EMAIL PROTECTED]> diff -urN linux-2.6.15-rc1.upstream.orig/drivers/net/ixp2000/pm3386.c linux-2.6.15-rc1.upstream/drivers/net/ixp2000/pm

[PATCH 11/15] pm3386: add hook for setting carrier

2005-11-23 Thread Lennert Buytenhek
Add a pm3386 hook for disabling/enabling the SERDES carrier, so that we can disable it when the interface is administratively downed, and enable it when it is upped. Signed-off-by: Lennert Buytenhek <[EMAIL PROTECTED]> diff -urN linux-2.6.15-rc1.upstream.orig/drivers/net/ixp2000/pm3386.c linux-2

[PATCH 5/15] ixp2000: use netif_rx_schedule_test

2005-11-23 Thread Lennert Buytenhek
The sky2 driver introduced netif_rx_schedule_test(). This is exactly what we need, so remove our local version of this function (which was called netif_rx_schedule_prep_notup) and use the generic one instead. Signed-off-by: Lennert Buytenhek <[EMAIL PROTECTED]> diff -urN linux-2.6.15-rc1.upstrea

[PATCH 3/15] pm3386: remove unnecessary udelays

2005-11-23 Thread Lennert Buytenhek
Remove a number of unnecessary udelay() calls. Signed-off-by: Lennert Buytenhek <[EMAIL PROTECTED]> diff -urN linux-2.6.15-rc1.upstream.orig/drivers/net/ixp2000/pm3386.c linux-2.6.15-rc1.upstream/drivers/net/ixp2000/pm3386.c --- linux-2.6.15-rc1.upstream.orig/drivers/net/ixp2000/pm3386.c 2005-11

[PATCH 4/15] caleb/pm3386: include proper header files

2005-11-23 Thread Lennert Buytenhek
Make caleb.c and pm3386.c include their own header files, to catch incorrect prototype definitions. Signed-off-by: Lennert Buytenhek <[EMAIL PROTECTED]> diff -urN linux-2.6.15-rc1.upstream.orig/drivers/net/ixp2000/caleb.c linux-2.6.15-rc1.upstream/drivers/net/ixp2000/caleb.c --- linux-2.6.15-rc1

[PATCH 8/15] enp2611: report link up/down events

2005-11-23 Thread Lennert Buytenhek
Report carrier going up/down. Signed-off-by: Lennert Buytenhek <[EMAIL PROTECTED]> diff -urN linux-2.6.15-rc1.upstream.orig/drivers/net/ixp2000/enp2611.c linux-2.6.15-rc1.upstream/drivers/net/ixp2000/enp2611.c --- linux-2.6.15-rc1.upstream.orig/drivers/net/ixp2000/enp2611.c 2005-11-22 12

[PATCH 6/15] enp2611: don't check netif_running() in link status timer

2005-11-23 Thread Lennert Buytenhek
Even after an interface has gone !netif_running(), we still want to catch the 'carrier went down' event for our internal bookkeeping. Signed-off-by: Lennert Buytenhek <[EMAIL PROTECTED]> diff -urN linux-2.6.15-rc1.upstream.orig/drivers/net/ixp2000/enp2611.c linux-2.6.15-rc1.upstream/drivers/net/

[PATCH 2/15] pm3386: zero stats properly

2005-11-23 Thread Lennert Buytenhek
Zero our stats structure properly. Signed-off-by: Lennert Buytenhek <[EMAIL PROTECTED]> diff -urN linux-2.6.15-rc1.upstream.orig/drivers/net/ixp2000/pm3386.c linux-2.6.15-rc1.upstream/drivers/net/ixp2000/pm3386.c --- linux-2.6.15-rc1.upstream.orig/drivers/net/ixp2000/pm3386.c 2005-11-22 11:00:3

[PATCH 9/15] ixp2000: report MAC addresses for each port on init

2005-11-23 Thread Lennert Buytenhek
After initialising, report the MAC address that we're using for each port. Signed-off-by: Lennert Buytenhek <[EMAIL PROTECTED]> diff -urN linux-2.6.15-rc1.upstream.orig/drivers/net/ixp2000/ixpdev.c linux-2.6.15-rc1.upstream/drivers/net/ixp2000/ixpdev.c --- linux-2.6.15-rc1.upstream.orig/drivers/

[PATCH 7/15] enp2611: use 'dev' in link status timer

2005-11-23 Thread Lennert Buytenhek
We assign nds[i] to a local variable 'dev', which we never use afterwards. Use the local variable instead. Signed-off-by: Lennert Buytenhek <[EMAIL PROTECTED]> diff -urN linux-2.6.15-rc1.upstream.orig/drivers/net/ixp2000/enp2611.c linux-2.6.15-rc1.upstream/drivers/net/ixp2000/enp2611.c --- linu

[PATCH 0/15] ixp2000 updates

2005-11-23 Thread Lennert Buytenhek
This patch series brings the ixp2000 kernel driver up to version 0.2. diffstat information: drivers/net/ixp2000/caleb.c |1 drivers/net/ixp2000/enp2611.c | 21 - drivers/net/ixp2000/ixpdev.c | 67 ++ drivers/net/ixp2000/pm3386.c |

[PATCH 1/15] ixp2000: register netdevices last

2005-11-23 Thread Lennert Buytenhek
Do not register our netdevices with the kernel until we've actually finished setting up the hardware and microcode. Signed-off-by: Lennert Buytenhek <[EMAIL PROTECTED]> diff -urN linux-2.6.15-rc1.upstream.orig/drivers/net/ixp2000/ixpdev.c linux-2.6.15-rc1.upstream/drivers/net/ixp2000/ixpdev.c --

Re: [PATCH 06/13]: [IPV4/6]: Netfilter IPsec input hooks

2005-11-23 Thread YOSHIFUJI Hideaki / 吉藤英明
Hello. In article <[EMAIL PROTECTED]> (at Tue, 22 Nov 2005 02:14:26 +0100), Patrick McHardy <[EMAIL PROTECTED]> says: > The easiest way would be to store nhoff somewhere in the skb and > use it to continue at the next header. But I still hope there is > a way without keeping data in the skb. We

Re: [2.6 patch] do not select NET_CLS

2005-11-23 Thread Thomas Graf
* David S. Miller <[EMAIL PROTECTED]> 2005-11-22 14:37 > From: Patrick McHardy <[EMAIL PROTECTED]> > Date: Mon, 21 Nov 2005 17:16:18 +0100 > > > Adrian Bunk wrote: > > > This patch therefore changes NET_CLS back to the 2.6.14 status quo of > > > being an user-visible option. > > > > I disagree w

Fw: Questions about iproute

2005-11-23 Thread Tiago Mira Amado
-- Forwarded Message --- From: "Tiago Mira Amado" <[EMAIL PROTECTED]> To: [EMAIL PROTECTED] Sent: Tue, 22 Nov 2005 01:58:20 + Subject: Questions about iproute Good evening, I'm a student trying to implemente a Mobile IPv6 scenario with static routes. I'm using Fedora Core 3,

Re: Netlink send from the interrupt context

2005-11-23 Thread Robert Iakobashvili
On 11/23/05, Robert Iakobashvili <[EMAIL PROTECTED]> wrote: > On 11/23/05, Yu Zhiguo <[EMAIL PROTECTED]> wrote: > > Please refer to the function netlink_broadcast(), > >int netlink_broadcast(struct sock *ssk, struct sk_buff *skb, u32 pid, > > u32 group, int allocation) > > I think if allocatio