From: Geoff Levand <[EMAIL PROTECTED]>
Date: Thu, 25 Aug 2005 22:13:57 -0700
> @@ -970,7 +970,8 @@
> /* gem_interrupt is safe to reentrance so no need
>* to disable_irq here.
>*/
> - gem_interrupt(dev->irq, dev, NULL);
> + if(gem_interrupt(dev->irq, dev, NULL) == IRQ_
This fixes a major bug in the Sun GEM Ether
driver's netpoll implementation. When both polled
and interrupt driven i/o are used simultaneously,
for example when using kgdb over Ether with active
NFS mounts, a condition easily arises where the bug
is hit.
The problem is that gem_poll() expect
applied
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Venkatesan, Ganesh wrote:
Jeff:
E1000_osdep.h has a macro msec_delay that does exactly what you've
mentioned below (check for the correct context and call msleep). Did you
mean that you did not want drivers to have their own msec_delay()
macros?
I meant: have a human check the context. In thi
Venkatesan, Ganesh wrote:
The patch includes the following fixes:
a) On platforms where PAGE_SIZE > 4K, driver will use only required
number of pages compared to always using 3 pages.
b) Packet split won't be used if the PAGE_SIZE is > 16K
c) Adds a statistics counter to splits.
d) Setting the n
Venkatesan, Ganesh wrote:
Jeff:
Here is the original discussion with John Linville on this topic:
http://marc.theaimsgroup.com/?l=linux-netdev&m=111722587223104&w=2
It seems to me you should delete the watchdog timer, and simply call
queue_work_delayed().
Jeff
-
To unsubscribe fr
From: Eric Dumazet <[EMAIL PROTECTED]>
Date: Fri, 26 Aug 2005 03:07:06 +0200
> On one of my production machine, tcp_statistics was sitting in a heavily
> modified cache line, so *every* SNMP update had to force a reload.
But I disagree that statistics belong in the __read_mostly.
They are write
--- Ben Greear <[EMAIL PROTECTED]> wrote:
> Danial Thom wrote:
> >
> > --- Ben Greear <[EMAIL PROTECTED]>
> wrote:
> >
> >
> >>Danial Thom wrote:
> >>
> >>
> >>>I think the concensus is that 2.6 has made
> >>
> >>trade
> >>
> >>>offs that lower raw throughput, which is
> what
> >>
> >>a
> >>
Jeff Garzik wrote:
> Jiri Benc wrote:
>
>> Our patches against latest ieee80211 branch can be found at
>> http://kernel.org/pub/linux/kernel/people/jbenc/
>
> Thanks for your patience.
>
> To answer Pavel's question from the other email:
>
> I was hoping that Intel would resend their patches, redi
Hi David
This patch puts mostly read only data in the right section (read_mostly), to
help sharing of these data between CPUS without memory ping pongs.
On one of my production machine, tcp_statistics was sitting in a heavily
modified cache line, so *every* SNMP update had to force a reload.
On Thursday 25 August 2005 13:31, Jiri Benc wrote:
> Our patches against latest ieee80211 branch can be found at
> http://kernel.org/pub/linux/kernel/people/jbenc/
>
I hope to submit the adm8211 driver for review soon, but there's a bunch of
code in the driver which probably belong in the ieee8021
Hi,
I don't want to disturb the good work you guys are doing, but
I had a few comments on your patch regarding the WE APIs.
In particular :
--
+struct translate_scan {
+ char *start;
+ char *stop;
+ int count;
+}
Jiri Benc wrote:
Our patches against latest ieee80211 branch can be found at
http://kernel.org/pub/linux/kernel/people/jbenc/
Thanks for your patience.
To answer Pavel's question from the other email:
I was hoping that Intel would resend their patches, rediffed to the
latest ieee80211 branch
Hi!
> Our patches against latest ieee80211 branch can be found at
> http://kernel.org/pub/linux/kernel/people/jbenc/
>
> Patches have to be applied in this order (also specified in 'series'
> file):
>
> debug-macros-cleanup.patch
> ipw2100-cleanup-prefixes.patch
> ipw2100-cleanup-debug-prints.pa
From: Patrick McHardy <[EMAIL PROTECTED]>
Date: Sat, 20 Aug 2005 19:53:30 +0200
> The comment in Kconfig says "Textsearch support is select'ed if needed"
> and the other options don't include helptexts. This one probably
> shouldn't either.
I took care of this issue myself, it's in the net-2.6.14
From: Pablo Neira <[EMAIL PROTECTED]>
Date: Sat, 20 Aug 2005 19:48:21 +0200
> Attached the implementation of the Boyer-Moore string search
> algorithm for the new textsearch infrastructure.
>
> I've added as well a note about the limitations that this approach
> presents, as Thomas has remarked.
From: Alexey Dobriyan <[EMAIL PROTECTED]>
Subject: [PATCH] net/802: more endian annotations
Date: Sat, 20 Aug 2005 11:37:50 +0400
> The rest of endian warnings now belongs to tr.c exclusively.
>
> Signed-off-by: Alexey Dobriyan <[EMAIL PROTECTED]>
Queued for 2.6.14, thanks Alexey.
-
To unsubscri
I've scheduled all 5 patches for 2.6.14, thanks Michael.
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
The userspace must not be able to issue ethtool command and manage the
mii before it is completely initialized. Avoid some pesky "eth%d" messages.
Signed-off-by: Arnaud Patard <[EMAIL PROTECTED]>
Signed-off-by: Francois Romieu <[EMAIL PROTECTED]>
diff -puN drivers/net/sis190.c~sis190-155 drivers/
From: "Michael Chan" <[EMAIL PROTECTED]>
Date: Thu, 25 Aug 2005 13:39:35 -0700
> The tg3_abort_hw() call in tg3_test_loopback() is causing lockups on
> some devices. tg3_abort_hw() disables the memory arbiter, causing
> tg3_reset_hw() to hang when it tries to write the pre-reset signature.
> tg3_a
Arnaud Patard <[EMAIL PROTECTED]> :
[...]
> Signed-off-by: Arnaud Patard <[EMAIL PROTECTED]>
diff -rpuN a/drivers/net/sis190.c b/drivers/net/sis190.c
--- a/drivers/net/sis190.c 2005-08-25 15:36:24.0 +0200
+++ b/drivers/net/sis190.c 2005-08-25 15:36:34.0 +0200
@@ -1779,14
Jeff:
E1000_osdep.h has a macro msec_delay that does exactly what you've
mentioned below (check for the correct context and call msleep). Did you
mean that you did not want drivers to have their own msec_delay()
macros?
Ganesh.
>-Original Message-
>From: Chilakala, Mallikarjuna
>Sent:
Vladimir Dergachev <[EMAIL PROTECTED]> :
> :00:0c.0 Ethernet controller: U.S. Robotics: Unknown device 0116 (rev
> 10)
> Subsystem: U.S. Robotics: Unknown device 0116
> Flags: bus master, 66MHz, medium devsel, latency 32, IRQ 17
> I/O ports at b000 [size=256]
>
Hi,
I recently bought a US Robotics network card which turned out to be a
rebranded Realtek. I wish the did not mess with PCI ids !
Here is the lspci output - could you add the appropriate line to the kernel
driver ?
:00:0c.0 Ethernet controller: U.S. Robotics: Unknown device 011
The patch includes the following fixes:
a) On platforms where PAGE_SIZE > 4K, driver will use only required
number of pages compared to always using 3 pages.
b) Packet split won't be used if the PAGE_SIZE is > 16K
c) Adds a statistics counter to splits.
d) Setting the non Null ptr to zero sized bu
Agreed. Please ignore this patch.
Ganesh.
>-Original Message-
>From: Chilakala, Mallikarjuna
>Sent: Thursday, August 25, 2005 1:42 PM
>To: Venkatesan, Ganesh; Ronciak, John
>Subject: FW: PATCH net-drivers-2.6 7/8] e1000: Add a function to report
>PCI-E link power saving mode status
>
>
>
Jeff:
Here is the original discussion with John Linville on this topic:
http://marc.theaimsgroup.com/?l=linux-netdev&m=111722587223104&w=2
ganesh.
>-Original Message-
>From: Chilakala, Mallikarjuna
>Sent: Thursday, August 25, 2005 1:40 PM
>To: Venkatesan, Ganesh; Ronciak, John
>Subject:
On Aug 25, 2005, at 15:04, David Hollis wrote:
Question for you, I'm trying to setup my mdio_bus driver and I don't
know how I can get it registered at the appropriate time. I can't
read
the PHY IDs until after I've diddled some bits on the device which
happens in my USB probe function.
--- Ben Greear <[EMAIL PROTECTED]> wrote:
> Danial Thom wrote:
>
> > The tests I reported where on UP systems.
> Perhaps
> > the default settings are better for this in
> 2.4,
> > since that is what I used, and you used your
> > hacks for both.
>
> My modifications to the kernel are unlikely t
Jeff:
The original patch was attempting to load the u-code on the 10/100
controllers that are embedded in the ICH (I/O Control Hub). The u-code
patch is not designed to be loaded for these embedded controllers. Hence
the failure. The patch that Malli sent out earlier explicitly checks for
the cont
Malli Chilakala wrote:
driver update
Signed-off-by: Mallikarjuna R Chilakala <[EMAIL PROTECTED]>
Signed-off-by: Ganesh Venkatesan <[EMAIL PROTECTED]>
Signed-off-by: John Ronciak <[EMAIL PROTECTED]>
since I had comments on most of this patch series, -none- of the patches
were applied.
Please
Malli Chilakala wrote:
Driver version, white space, comments, device id & other
Signed-off-by: Mallikarjuna R Chilakala <[EMAIL PROTECTED]>
Signed-off-by: Ganesh Venkatesan <[EMAIL PROTECTED]>
Signed-off-by: John Ronciak <[EMAIL PROTECTED]>
seems OK
-
To unsubscribe from this list: send the
Malli Chilakala wrote:
Add a function to report PCI-E link power saving mode status
Signed-off-by: Mallikarjuna R Chilakala <[EMAIL PROTECTED]>
Signed-off-by: Ganesh Venkatesan <[EMAIL PROTECTED]>
Signed-off-by: John Ronciak <[EMAIL PROTECTED]>
NAK, we don't add dead code.
Code must have user
Malli Chilakala wrote:
Flush shadow RAM to save updates to ASF related bits for 82573 controllers.
These bits are past the first 63 words of NVM.
Signed-off-by: Mallikarjuna R Chilakala <[EMAIL PROTECTED]>
Signed-off-by: Ganesh Venkatesan <[EMAIL PROTECTED]>
Signed-off-by: John Ronciak <[EMAIL
Malli Chilakala wrote:
Added msleep_interruptible delay right before returning from diag_test to allow
the phy to recover from reset
Signed-off-by: Mallikarjuna R Chilakala <[EMAIL PROTECTED]>
Signed-off-by: Ganesh Venkatesan <[EMAIL PROTECTED]>
Signed-off-by: John Ronciak <[EMAIL PROTECTED]>
Malli Chilakala wrote:
Backout watchdog task patch from John Linville
Signed-off-by: Mallikarjuna R Chilakala <[EMAIL PROTECTED]>
Signed-off-by: Ganesh Venkatesan <[EMAIL PROTECTED]>
Signed-off-by: John Ronciak <[EMAIL PROTECTED]>
Rejected for two reasons:
1) No explanation why this back-out
Malli Chilakala wrote:
Fixes for packet split related issues
Signed-off-by: Mallikarjuna R Chilakala <[EMAIL PROTECTED]>
Signed-off-by: Ganesh Venkatesan <[EMAIL PROTECTED]>
Signed-off-by: John Ronciak <[EMAIL PROTECTED]>
Seems OK except for lack of description. Explain _what_ the packet
spl
Malli Chilakala wrote:
Support for multiple transmit/receive queues
Signed-off-by: Mallikarjuna R Chilakala <[EMAIL PROTECTED]>
Signed-off-by: Ganesh Venkatesan <[EMAIL PROTECTED]>
Signed-off-by: John Ronciak <[EMAIL PROTECTED]>
NAK'd for the following reasons:
1) should be split into multipl
Malli Chilakala wrote:
-/* Simply wait for 10ms */
-msec_delay(10);
+switch (hw->mac_type) {
+default:
+msec_delay(10);
+break;
+case e1000_82571:
+case e1000_82572:
+while (timeout) {
+if (E1000_READ_REG(hw, EEMNGCTL) & cfg_mask)
+
Problem was reported on ICH devices & we modified code in
e100_load_ucode so that it will never be loaded on ICH devices.
static void e100_load_ucode(str
+ /* do not load u-code for ICH devices */
+ if (nic->flags & ich)
+ return;
+
-Malli
-Original Message-
Fro
Flush shadow RAM to save updates to ASF related bits for 82573 controllers.
These bits are past the first 63 words of NVM.
Signed-off-by: Mallikarjuna R Chilakala <[EMAIL PROTECTED]>
Signed-off-by: Ganesh Venkatesan <[EMAIL PROTECTED]>
Signed-off-by: John Ronciak <[EMAIL PROTECTED]>
diff -up net
Driver version, white space, comments, device id & other
Signed-off-by: Mallikarjuna R Chilakala <[EMAIL PROTECTED]>
Signed-off-by: Ganesh Venkatesan <[EMAIL PROTECTED]>
Signed-off-by: John Ronciak <[EMAIL PROTECTED]>
diff -up netdev-2.6/drivers/net/e1000/e1000_main.c
netdev-2.6.new/drivers/net/
Add a function to report PCI-E link power saving mode status
Signed-off-by: Mallikarjuna R Chilakala <[EMAIL PROTECTED]>
Signed-off-by: Ganesh Venkatesan <[EMAIL PROTECTED]>
Signed-off-by: John Ronciak <[EMAIL PROTECTED]>
diff -up netdev-2.6/drivers/net/e1000/e1000_hw.c
netdev-2.6.new/drivers/ne
Backout watchdog task patch from John Linville
Signed-off-by: Mallikarjuna R Chilakala <[EMAIL PROTECTED]>
Signed-off-by: Ganesh Venkatesan <[EMAIL PROTECTED]>
Signed-off-by: John Ronciak <[EMAIL PROTECTED]>
diff -up netdev-2.6/drivers/net/e1000/e1000.h
netdev-2.6.new/drivers/net/e1000/e1000.h
-
Added msleep_interruptible delay right before returning from diag_test to allow
the phy to recover from reset
Signed-off-by: Mallikarjuna R Chilakala <[EMAIL PROTECTED]>
Signed-off-by: Ganesh Venkatesan <[EMAIL PROTECTED]>
Signed-off-by: John Ronciak <[EMAIL PROTECTED]>
diff -up netdev-2.6/drive
Fixes for packet split related issues
Signed-off-by: Mallikarjuna R Chilakala <[EMAIL PROTECTED]>
Signed-off-by: Ganesh Venkatesan <[EMAIL PROTECTED]>
Signed-off-by: John Ronciak <[EMAIL PROTECTED]>
diff -up netdev-2.6/drivers/net/e1000/e1000.h
netdev-2.6.new/drivers/net/e1000/e1000.h
--- netdev
driver update
Signed-off-by: Mallikarjuna R Chilakala <[EMAIL PROTECTED]>
Signed-off-by: Ganesh Venkatesan <[EMAIL PROTECTED]>
Signed-off-by: John Ronciak <[EMAIL PROTECTED]>
1. Support for 82571 and 82572 controllers
2. Support for multiple transmit/receive queues
3. Fixes for packet split relat
applied 1-6 to new 'e100' branch of netdev-2.6.git
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Support for 82571 and 82572 controllers
Signed-off-by: Mallikarjuna R Chilakala <[EMAIL PROTECTED]>
Signed-off-by: Ganesh Venkatesan <[EMAIL PROTECTED]>
Signed-off-by: John Ronciak <[EMAIL PROTECTED]>
diff -up netdev-2.6/drivers/net/e1000/e1000_ethtool.c
netdev-2.6.new/drivers/net/e1000/e1000_et
Malli Chilakala wrote:
Add cpu cycle saver microcode to 8086:{1209/1229} other than ICH devices.
Signed-off-by: Mallikarjuna R Chilakala <[EMAIL PROTECTED]>
Signed-off-by: Ganesh Venkatesan <[EMAIL PROTECTED]>
Signed-off-by: John Ronciak <[EMAIL PROTECTED]>
Can you please review for me the rep
Add cpu cycle saver microcode to 8086:{1209/1229} other than ICH devices.
Signed-off-by: Mallikarjuna R Chilakala <[EMAIL PROTECTED]>
Signed-off-by: Ganesh Venkatesan <[EMAIL PROTECTED]>
Signed-off-by: John Ronciak <[EMAIL PROTECTED]>
diff -up netdev-2.6/drivers/net/e100.c netdev-2.6.new/drivers/
On Wed, 2005-08-24 at 18:46 -0500, Andy Fleming wrote:
> This patch adds back the code that was taken out, thus re-enabling:
>
> * The PHY Layer to initialize without crashing
> * Drivers to actually connect to PHYs
> * The entire PHY Control Layer
>
Andy,
Thanks for the updated patch. Now I am
Increased delay loop for command blocks
Signed-off-by: Mallikarjuna R Chilakala <[EMAIL PROTECTED]>
Signed-off-by: Ganesh Venkatesan <[EMAIL PROTECTED]>
Signed-off-by: John Ronciak <[EMAIL PROTECTED]>
diff -up netdev-2.6/drivers/net/e100.c netdev-2.6.new/drivers/net/e100.c
--- netdev-2.6/drivers/
Driver version, white space, comments & other
Signed-off-by: Mallikarjuna R Chilakala <[EMAIL PROTECTED]>
Signed-off-by: Ganesh Venkatesan <[EMAIL PROTECTED]>
Signed-off-by: John Ronciak <[EMAIL PROTECTED]>
diff -up netdev-2.6/drivers/net/e100.c netdev-2.6.new/drivers/net/e100.c
--- netdev-2.6/dr
added msleep_interruptible delay right before returning from diag_test
Signed-off-by: Mallikarjuna R Chilakala <[EMAIL PROTECTED]>
Signed-off-by: Ganesh Venkatesan <[EMAIL PROTECTED]>
Signed-off-by: John Ronciak <[EMAIL PROTECTED]>
diff -up netdev-2.6/drivers/net/e100.c netdev-2.6.new/drivers/ne
Do not check Rx packet length against mtu - patch from Darren Tucker
Signed-off-by: Mallikarjuna R Chilakala <[EMAIL PROTECTED]>
Signed-off-by: Ganesh Venkatesan <[EMAIL PROTECTED]>
Signed-off-by: John Ronciak <[EMAIL PROTECTED]>
diff -up netdev-2.6/drivers/net/e100.c netdev-2.6.new/drivers/net/e
Fixed endian bug associated with cb_i bit in xmit_prepare
Signed-off-by: Mallikarjuna R Chilakala <[EMAIL PROTECTED]>
Signed-off-by: Ganesh Venkatesan <[EMAIL PROTECTED]>
Signed-off-by: John Ronciak <[EMAIL PROTECTED]>
diff -up netdev-2.6/drivers/net/e100.c netdev-2.6.new/drivers/net/e100.c
--- n
e100: driver update
Signed-off-by: Mallikarjuna R Chilakala <[EMAIL PROTECTED]>
Signed-off-by: Ganesh Venkatesan <[EMAIL PROTECTED]>
Signed-off-by: John Ronciak <[EMAIL PROTECTED]>
1. Do not check Rx packet length against mtu - patch from Darren Tucker
2. Added msleep_interruptible delay right be
Our patches against latest ieee80211 branch can be found at
http://kernel.org/pub/linux/kernel/people/jbenc/
Patches have to be applied in this order (also specified in 'series'
file):
debug-macros-cleanup.patch
ipw2100-cleanup-prefixes.patch
ipw2100-cleanup-debug-prints.patch
ipw2100-cleanup-sta
Danial Thom wrote:
The tests I reported where on UP systems. Perhaps
the default settings are better for this in 2.4,
since that is what I used, and you used your
hacks for both.
My modifications to the kernel are unlikely to speed anything
up, and probably will slow things down ever so slight
Sorry for again posting something OT, but I think the result of this
discussion will in the end provide valuable input to a lot of driver
authors.
On Sun, Aug 07, 2005 at 05:01:34PM +0200, Harald Welte wrote:
> On Sun, Aug 07, 2005 at 10:32:07AM +0300, Kalle Valo wrote:
> > Harald Welte <[EMAIL PR
Hi,
I was testing the sis190 driver and got an oops. Tests show that the error
path is the following :
sis190_init_one()
-> register_netdev
* Userspace sees the new interface and run ethtool ethX.
* ethtool calls ethtools_get_settings
* ethtools_get_settings try to access to the mii d
--- Ben Greear <[EMAIL PROTECTED]> wrote:
> Danial Thom wrote:
> >
> > --- Ben Greear <[EMAIL PROTECTED]>
> wrote:
> >
> >
> >>Danial Thom wrote:
> >>
> >>
> >>>I think the concensus is that 2.6 has made
> >>
> >>trade
> >>
> >>>offs that lower raw throughput, which is
> what
> >>
> >>a
> >>
Michael Chan wrote:
diff -rup a/drivers/net/bnx2.c b/drivers/net/bnx2.c
--- a/drivers/net/bnx2.c2005-08-19 10:46:53.0 -0700
+++ b/drivers/net/bnx2.c2005-08-24 11:59:51.0 -0700
@@ -3975,12 +3975,17 @@ bnx2_reset_task(void *data)
{
struct bnx2 *bp = data;
Gah, this time the revised patch is included, not just the diffstat.
datagram.c | 82 +++--
1 files changed, 26 insertions(+), 56 deletions(-)
diff -up --recursive 2.6.12.3.clean/net/core/datagram.c
2.6.12.3/net/core/datagram.c
--- 2.6.1
On Thursday 25 August 2005 03:30, David S. Miller wrote:
> From: Daniel Phillips <[EMAIL PROTECTED]>
> > As far as I can see, it is illegal for any but the first skb to have
> > a non-null skb_shinfo(skb)->frag_list, is this correct?
>
> As currently used, yes.
That's a relief. I updated the patc
The fragment list handling was wrong in the previous version, now correct I
think.
datagram.c | 82 +++--
1 files changed, 26 insertions(+), 56 deletions(-)
diff -up --recursive 2.6.12.3.clean/net/core/datagram.c
2.6.12.3/net/core/datagra
> I have been reported 400 Mbps in a direction and 800 Mbps in the opposite
Speed of my dreams...
> If you are working from disk, the traffic will cross the pci bus twice.
> Expect something in the 40~60 Mbyte/s range. You could play with the mtu
> but I do not suggest it with an "old" kernel.
From: Daniel Phillips <[EMAIL PROTECTED]>
Date: Thu, 25 Aug 2005 03:17:51 -0400
> As far as I can see, it is illegal for any but the first skb to have
> a non-null skb_shinfo(skb)->frag_list, is this correct?
As currently used, yes.
-
To unsubscribe from this list: send the line "unsubscribe netd
On Thursday 25 August 2005 02:44, David S. Miller wrote:
> Frag lists cannot be deeper than one level of nesting,
> and I think the recursive version is easier to understand,
> so I really don't see the value of your change.
Losing 34 lines of a 74 line function is the value.
The real problem wit
70 matches
Mail list logo
