On Thursday 25 August 2005 02:44, David S. Miller wrote: > Frag lists cannot be deeper than one level of nesting, > and I think the recursive version is easier to understand, > so I really don't see the value of your change.
Losing 34 lines of a 74 line function is the value. The real problem with my version is, it isn't right, it walks the ->next link from the original skb, whereas the original version gets the list from skb_shinfo(skb)->frag_list and walks the ->next links of that. This structure actually does allow for lists of lists, but it does not look like this was intended. As far as I can see, it is illegal for any but the first skb to have a non-null skb_shinfo(skb)->frag_list, is this correct? Regards, Daniel - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
