Arnaud Patard <[EMAIL PROTECTED]> :
[...]
> Signed-off-by: Arnaud Patard <[EMAIL PROTECTED]>
diff -rpuN a/drivers/net/sis190.c b/drivers/net/sis190.c
--- a/drivers/net/sis190.c 2005-08-25 15:36:24.000000000 +0200
+++ b/drivers/net/sis190.c 2005-08-25 15:36:34.000000000 +0200
@@ -1779,14 +1779,18 @@ static int __devinit sis190_init_one(str
dev->irq = pdev->irq;
dev->base_addr = (unsigned long) 0xdead;
+ pci_set_drvdata(pdev, dev);
+
spin_lock_init(&tp->lock);
+ rc = sis190_mii_probe(dev);
+ if (rc < 0)
+ goto err_release_board;
+
rc = register_netdev(dev);
if (rc < 0)
goto err_release_board;
-> the mii structs are not freed on this error path
- pci_set_drvdata(pdev, dev);
- rc = sis190_mii_probe(dev);
if (rc < 0)
^^^^^^
-> this test is not needed any more
goto err_unregister_dev;
I'll fix both and forward to Jeff. Thanks for the report.
--
Ueimor
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
