Re: [Mesa-dev] [PATCH 0/8] Android makefiles clean up

2019-07-02 Thread Emil Velikov
On Tue, 25 Jun 2019 at 11:08, Chih-Wei Huang wrote: > > There are several issues in the current Android makefiles. Though they > may not affect the functionalities, it's ugly and unprofessional. > > * Add unnecessary LOCAL_EXPORT_C_INCLUDE_DIRS > * Not export necessary include paths > * Add dummy

[Mesa-dev] [PATCH 0/8] Android makefiles clean up

2019-06-25 Thread Chih-Wei Huang
There are several issues in the current Android makefiles. Though they may not affect the functionalities, it's ugly and unprofessional. * Add unnecessary LOCAL_EXPORT_C_INCLUDE_DIRS * Not export necessary include paths * Add dummy libraries to LOCAL_WHOLE_STATIC_LIBRARIES * Use unnecessary dummy

[Mesa-dev] [PATCH 0/8] radv: preliminary work for DCC and mipmaps

2019-06-17 Thread Samuel Pitoiset
Hi, This series is a prerequisite before enabling DCC for mipmapped color textures. It basically allocates more metadata space and it adds mipmap support for color decompressions on graphics and compute. DCC for mipmaps is still disabled by default but I should be able to enable it soon for GFX8.

[Mesa-dev] [PATCH 0/8] panfrost: 2D array and 3D textures

2019-06-14 Thread Alyssa Rosenzweig
Exactly what it says on the tin. Decode them and implement them. Alyssa Rosenzweig (8): panfrost/midgard: Add swizzle_of/mask_of helpers panfrost/midgard: Fix 3D texture masks/swizzles panfrost: Specify 3D in texture descriptor panfrost: Implement 3D texture resource management panfrost:

[Mesa-dev] [PATCH 0/8] radv: add support for sample locations during layout transitions

2019-05-30 Thread Samuel Pitoiset
Hi, This series implements user sample locations during explicit and automatic (subpass) layout transitions as defined by VK_EXT_sample_locations. Previously, HTILE was disabled for depth/stencil images that might need sample locations because it was a bit tricky to implement. The last patch of

[Mesa-dev] [PATCH 0/8] ddebug, radeonsi: misc changes to help debugging

2019-04-24 Thread Nicolai Hähnle
Hi folks, this is a collection of assorted patches that should help with driver debugging: - add driconf-style debug options in a convenient way - some minor ddebug cleanups - allow dumping aux context command streams - allow force-syncing of compile threads Please review! Thanks, Nicolai -- .

Re: [Mesa-dev] [PATCH 0/8] radv: VK_KHR_8bit_storage

2019-03-20 Thread Bas Nieuwenhuizen
Reviewed-by: Bas Nieuwenhuizen for the series. On Tue, Mar 19, 2019 at 9:28 AM Samuel Pitoiset wrote: > > Hi, > > This series implements VK_KHR_8bit_storage for RADV. Original work > is from Rhys Perry, I did rebase, update some patches and test. > > Please review, > thanks! > > Rhys Perry (5):

[Mesa-dev] [PATCH 0/8] radv: VK_KHR_8bit_storage

2019-03-19 Thread Samuel Pitoiset
Hi, This series implements VK_KHR_8bit_storage for RADV. Original work is from Rhys Perry, I did rebase, update some patches and test. Please review, thanks! Rhys Perry (5): ac/nir: implement 8-bit push constant, ssbo and ubo loads ac/nir: implement 8-bit ssbo stores ac/nir: add 8-bit type

[Mesa-dev] [PATCH 0/8] Half way to remove _NEW_ARRAY.

2019-03-05 Thread Mathias . Froehlich
From: Mathias Fröhlich Hi all, The following series introduces functions to map and unmap all vbos stored in a vao. Make use of those functions where possible. On that way cleanup and fix what comes up along the way. The series also already removes half of the state that is tracked using the _NE

[Mesa-dev] [PATCH 0/8] RadeonSI: PKT3_WRITE_DATA for small uploads

2019-01-18 Thread Marek Olšák
Hi, These uploads should have lower CPU overhead. There are also some cleanups around the WRITE_DATA packet. Please review. Thanks, Marek ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH 0/8] i965: improved the support for ETC2 formats on Gen 7

2019-01-14 Thread Eleni Maria Stea
On Mon, 19 Nov 2018 10:54:04 +0200 Eleni Maria Stea wrote: > Intel Gen7 GPUs don't have native support for ETC2 formats. We store > the ETC2 images as RGBA in order to render them. This is a problem for > GetCompressed* functions that should return compressed pixel values > but return instead RGB

[Mesa-dev] [PATCH 0/8] i965: improved the support for ETC2 formats on Gen 7

2018-11-19 Thread Eleni Maria Stea
Intel Gen7 GPUs don't have native support for ETC2 formats. We store the ETC2 images as RGBA in order to render them. This is a problem for GetCompressed* functions that should return compressed pixel values but return instead RGBA. With these patches, we store the compressed image data in the mai

Re: [Mesa-dev] [PATCH 0/8] intel: Move shared/SSBO access lowering to NIR

2018-11-15 Thread Samuel Iglesias Gonsálvez
On 14/11/2018 22:38, Jason Ekstrand wrote: > I just sent one more, "nir/lower_io: Add shared to get_io_offset_src" > that's required for the pass to apply properly to shared vairables. > I have reviewed it too. > Do we have any testing of shared variables with anything other than 32 > bits?  D

Re: [Mesa-dev] [PATCH 0/8] intel: Move shared/SSBO access lowering to NIR

2018-11-14 Thread Jason Ekstrand
I just sent one more, "nir/lower_io: Add shared to get_io_offset_src" that's required for the pass to apply properly to shared vairables. Do we have any testing of shared variables with anything other than 32 bits? Do we even test 64 bits? I'm begining to think that there are basically zero test

Re: [Mesa-dev] [PATCH 0/8] intel: Move shared/SSBO access lowering to NIR

2018-11-14 Thread Samuel Iglesias Gonsálvez
Thanks a lot for this work. Patches 1-7 are, Reviewed-by: Samuel Iglesias Gonsálvez I will review patch 8 later, probably tomorrow. Sam On 14/11/2018 00:23, Jason Ekstrand wrote: > In order to properly do all the different kinds of SSBO and SLM writes that > we have in GL and Vulkan, we have

[Mesa-dev] [PATCH 0/8] intel: Move shared/SSBO access lowering to NIR

2018-11-13 Thread Jason Ekstrand
In order to properly do all the different kinds of SSBO and SLM writes that we have in GL and Vulkan, we have to do some lowering. The hardware doesn't have instructions for writing a N-bit vecM with an arbitrary write-mask. Instead, we have byte scattered messages which work on a scalar byte, wo

Re: [Mesa-dev] [PATCH 0/8] Gallium & RadeonSI optimization for Ryzen CPUs

2018-09-11 Thread Michel Dänzer
On 2018-09-10 9:02 p.m., Marek Olšák wrote: > On Mon, Sep 10, 2018 at 10:45 AM, Michel Dänzer wrote: >> On 2018-09-07 9:01 p.m., Marek Olšák wrote: >>> On Fri, Sep 7, 2018 at 11:04 AM, Michel Dänzer wrote: On 2018-09-07 4:31 p.m., Marek Olšák wrote: > On Fri, Sep 7, 2018, 4:34 AM Michel

Re: [Mesa-dev] [PATCH 0/8] Gallium & RadeonSI optimization for Ryzen CPUs

2018-09-10 Thread Marek Olšák
On Mon, Sep 10, 2018 at 10:45 AM, Michel Dänzer wrote: > On 2018-09-07 9:01 p.m., Marek Olšák wrote: >> On Fri, Sep 7, 2018 at 11:04 AM, Michel Dänzer wrote: >>> On 2018-09-07 4:31 p.m., Marek Olšák wrote: On Fri, Sep 7, 2018, 4:34 AM Michel Dänzer wrote: > On 2018-09-06 10:56 p.m., Axe

Re: [Mesa-dev] [PATCH 0/8] Gallium & RadeonSI optimization for Ryzen CPUs

2018-09-10 Thread Michel Dänzer
On 2018-09-07 9:01 p.m., Marek Olšák wrote: > On Fri, Sep 7, 2018 at 11:04 AM, Michel Dänzer wrote: >> On 2018-09-07 4:31 p.m., Marek Olšák wrote: >>> On Fri, Sep 7, 2018, 4:34 AM Michel Dänzer wrote: On 2018-09-06 10:56 p.m., Axel Davy wrote: > I fear if we begin to do the work man

Re: [Mesa-dev] [PATCH 0/8] Gallium & RadeonSI optimization for Ryzen CPUs

2018-09-07 Thread Marek Olšák
On Fri, Sep 7, 2018 at 3:34 PM, Alan Swanson wrote: > On Fri, 2018-09-07 at 15:01 -0400, Marek Olšák wrote: >> On Fri, Sep 7, 2018 at 11:04 AM, Michel Dänzer >> wrote: >> > On 2018-09-07 4:31 p.m., Marek Olšák wrote: >> > > >> > > I don't think the performance can be worse than it is right now. >

Re: [Mesa-dev] [PATCH 0/8] Gallium & RadeonSI optimization for Ryzen CPUs

2018-09-07 Thread Alan Swanson
On Fri, 2018-09-07 at 15:01 -0400, Marek Olšák wrote: > On Fri, Sep 7, 2018 at 11:04 AM, Michel Dänzer > wrote: > > On 2018-09-07 4:31 p.m., Marek Olšák wrote: > > > > > > I don't think the performance can be worse than it is right now. > > > > In the worst case, all processes using OpenGL (or a

Re: [Mesa-dev] [PATCH 0/8] Gallium & RadeonSI optimization for Ryzen CPUs

2018-09-07 Thread Marek Olšák
I'm changing the initial L3 cache number to this: +static unsigned L3_cache_number; +static once_flag init_cache_number_flag = ONCE_FLAG_INIT; + +static void +util_init_cache_number(void) +{ + /* Get a semi-random number. */ + int64_t t = os_time_get_nano(); + L3_cache_number = (t ^ (t >> 8)

Re: [Mesa-dev] [PATCH 0/8] Gallium & RadeonSI optimization for Ryzen CPUs

2018-09-07 Thread Marek Olšák
On Fri, Sep 7, 2018 at 11:04 AM, Michel Dänzer wrote: > On 2018-09-07 4:31 p.m., Marek Olšák wrote: >> On Fri, Sep 7, 2018, 4:34 AM Michel Dänzer wrote: >>> On 2018-09-06 10:56 p.m., Axel Davy wrote: >>> I fear if we begin to do the work manually, there won't be interest to do that in t

Re: [Mesa-dev] [PATCH 0/8] Gallium & RadeonSI optimization for Ryzen CPUs

2018-09-07 Thread Michel Dänzer
On 2018-09-07 4:31 p.m., Marek Olšák wrote: > On Fri, Sep 7, 2018, 4:34 AM Michel Dänzer wrote: >> On 2018-09-06 10:56 p.m., Axel Davy wrote: >> >>> I fear if we begin to do the work manually, there won't be interest to >>> do that in the kernel, >>> and thus all applications will need to include

Re: [Mesa-dev] [PATCH 0/8] Gallium & RadeonSI optimization for Ryzen CPUs

2018-09-07 Thread Marek Olšák
On Fri, Sep 7, 2018, 4:34 AM Michel Dänzer wrote: > On 2018-09-06 10:56 p.m., Axel Davy wrote: > > Yeah by pinning to cores, I meant to group of cores. > > > > I think a reasonable policy would be for the kernel to put all threads > > of a given process on the same L3 > > as long as the number of

Re: [Mesa-dev] [PATCH 0/8] Gallium & RadeonSI optimization for Ryzen CPUs

2018-09-07 Thread Michel Dänzer
On 2018-09-06 10:56 p.m., Axel Davy wrote: > Yeah by pinning to cores, I meant to group of cores. > > I think a reasonable policy would be for the kernel to put all threads > of a given process on the same L3 > as long as the number of threads is lower than the L3 group size. > When there is more

Re: [Mesa-dev] [PATCH 0/8] Gallium & RadeonSI optimization for Ryzen CPUs

2018-09-06 Thread Marek Olšák
On Thu, Sep 6, 2018 at 5:54 PM, Roland Scheidegger wrote: > Am 06.09.2018 um 22:56 schrieb Axel Davy: >> Yeah by pinning to cores, I meant to group of cores. >> >> I think a reasonable policy would be for the kernel to put all threads >> of a given process on the same L3 >> as long as the number o

Re: [Mesa-dev] [PATCH 0/8] Gallium & RadeonSI optimization for Ryzen CPUs

2018-09-06 Thread Roland Scheidegger
Am 06.09.2018 um 22:56 schrieb Axel Davy: > Yeah by pinning to cores, I meant to group of cores. > > I think a reasonable policy would be for the kernel to put all threads > of a given process on the same L3 > as long as the number of threads is lower than the L3 group size. > When there is more t

Re: [Mesa-dev] [PATCH 0/8] Gallium & RadeonSI optimization for Ryzen CPUs

2018-09-06 Thread Marek Olšák
Mesa/RadeonSI already has a lot of threads. My CPU has 8C/16T, but if you debug glxgears, you'll see 21 threads in that process with radeonsi. They are mostly shader compiler threads. Games have a bunch of threads too. Only a small number of threads really need be pinned to one L3 cache. Those ar

Re: [Mesa-dev] [PATCH 0/8] Gallium & RadeonSI optimization for Ryzen CPUs

2018-09-06 Thread Axel Davy
Yeah by pinning to cores, I meant to group of cores. I think a reasonable policy would be for the kernel to put all threads of a given process on the same L3 as long as the number of threads is lower than the L3 group size. When there is more threads I guess it'd need heuristics to pick which

Re: [Mesa-dev] [PATCH 0/8] Gallium & RadeonSI optimization for Ryzen CPUs

2018-09-06 Thread Marek Olšák
Actually, you make a good point about the kernel, but the kernel has no visibility into which threads need to be coupled together. So the kernel can't do anything. Marek On Thu, Sep 6, 2018 at 2:24 PM, Marek Olšák wrote: > I think you are missing the point. This series doesn't pin threads to > c

Re: [Mesa-dev] [PATCH 0/8] Gallium & RadeonSI optimization for Ryzen CPUs

2018-09-06 Thread Marek Olšák
I think you are missing the point. This series doesn't pin threads to cores. It pins threads to one L3, which can have 4 or 8 cores. Marek On Thu, Sep 6, 2018 at 5:22 AM, Axel Davy wrote: > Hi Marek, > > Shouldn't this core pinning be handled by the kernel ? > > Else all multithreaded games (or

[Mesa-dev] [PATCH 0/8] intel/tools: decoding fixes

2018-09-06 Thread Lionel Landwerlin
Hi all, Here are a number of fixes and slight rework dealing with the ring buffer decoding. Found while trying to generate aub files that remap all the buffers from the i915 error state. A more complete state of this ongoing work is available there (unfortunately not quite there for Gen9) : h

Re: [Mesa-dev] [PATCH 0/8] Gallium & RadeonSI optimization for Ryzen CPUs

2018-09-06 Thread Axel Davy
Hi Marek, Shouldn't this core pinning be handled by the kernel ? Else all multithreaded games (or applications) need an update. I also see a risk in applications handling the core pinning: several intensive applications may pin the same cores. The kernel would be able to switch automatically

[Mesa-dev] [PATCH 0/8] Gallium & RadeonSI optimization for Ryzen CPUs

2018-09-05 Thread Marek Olšák
Hi, When the Ryzen CPUs were launched, they didn't perform very well in games, and it took a while before games were patched. Guess what, Mesa drivers have suffered from the same inefficincies until now. The AMD Zen architecture has multiple core complexes (CCX) where each CCX has e.g. 4C/8T and

[Mesa-dev] [PATCH 0/8] VK_ANDROID_external_memory_android_hardware_buffer

2018-08-21 Thread Tapani Pälli
Hi; I finally got dEQP happy with this so not RFC anymore but I consider this ready for proper review. It was mainly lacking proper handling of usage flags in vkGetPhysicalDeviceImageFormatProperties2 and when creating exportable memory in vkAllocateMemory. Any comments appreciated! // Tapani T

Re: [Mesa-dev] [PATCH 0/8] Easy OpenGL extensions

2018-08-15 Thread Dieter Nützel
Ah, with 'latest' stuff only #8 choke. Dieter Am 15.08.2018 11:21, schrieb Dieter Nützel: Hello Marek, sadly this series didn't apply on top of current git master. Dieter Am 09.08.2018 04:12, schrieb Marek Olšák: Hi, This series adds these extensions: - AMD_gpu_shader_int64 - AMD_multi_dr

Re: [Mesa-dev] [PATCH 0/8] Easy OpenGL extensions

2018-08-15 Thread Dieter Nützel
Hello Marek, sadly this series didn't apply on top of current git master. Dieter Am 09.08.2018 04:12, schrieb Marek Olšák: Hi, This series adds these extensions: - AMD_gpu_shader_int64 - AMD_multi_draw_indirect - AMD_query_buffer_object - AMD_texture_texture4 - EXT_vertex_attrib_64bit It als

[Mesa-dev] [PATCH 0/8] Easy OpenGL extensions

2018-08-08 Thread Marek Olšák
Hi, This series adds these extensions: - AMD_gpu_shader_int64 - AMD_multi_draw_indirect - AMD_query_buffer_object - AMD_texture_texture4 - EXT_vertex_attrib_64bit It also exposes these extensions for gallium (radeonsi): - EXT_disjoint_timer_query - KHR_texture_compression_astc_sliced_3d It also

Re: [Mesa-dev] [PATCH 0/8] GL_AMD_framebuffer_multisample_advanced for RadeonSI

2018-08-02 Thread Brian Paul
On 08/01/2018 05:25 PM, Marek Olšák wrote: Hi, This implements GL_AMD_framebuffer_multisample_advanced, which is AMD EQAA. I have also sent out a piglit test that tests the new API. Please review. I did a quick read-through and it looks OK to me. Reviewed-by: Brian Paul ___

[Mesa-dev] [PATCH 0/8] GL_AMD_framebuffer_multisample_advanced for RadeonSI

2018-08-01 Thread Marek Olšák
Hi, This implements GL_AMD_framebuffer_multisample_advanced, which is AMD EQAA. I have also sent out a piglit test that tests the new API. Please review. Thanks, Marek ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.

[Mesa-dev] [PATCH 0/8] More OpenCL patches

2018-07-16 Thread Karol Herbst
This time there are actually some OpenCL patches like adding support for the OpenCL SPIR-V extensions or a few opcodes we don't hit with vulkan or glsl. Also some of the glsl builtins are moved into a new file so that we can start sharing builtin implementations across multiple SPIR-V extensions.

Re: [Mesa-dev] [PATCH 0/8] i965: Don't recycle BOs until they are idle

2018-06-18 Thread Eric Anholt
Jason Ekstrand writes: > On Mon, Jun 18, 2018 at 2:14 AM, Michel Dänzer wrote: > >> On 2018-06-16 08:23 AM, Jason Ekstrand wrote: >> > On Fri, Jun 15, 2018 at 4:44 PM, Eric Anholt wrote: >> > >> >> Michel Dänzer writes: >> >> >> >>> On 2018-06-15 05:25 PM, Jason Ekstrand wrote: >> On June

Re: [Mesa-dev] [PATCH 0/8] i965: Don't recycle BOs until they are idle

2018-06-18 Thread Jason Ekstrand
On Mon, Jun 18, 2018 at 2:14 AM, Michel Dänzer wrote: > On 2018-06-16 08:23 AM, Jason Ekstrand wrote: > > On Fri, Jun 15, 2018 at 4:44 PM, Eric Anholt wrote: > > > >> Michel Dänzer writes: > >> > >>> On 2018-06-15 05:25 PM, Jason Ekstrand wrote: > On June 15, 2018 01:14:24 Michel Dänzer w

Re: [Mesa-dev] [PATCH 0/8] i965: Don't recycle BOs until they are idle

2018-06-18 Thread Michel Dänzer
On 2018-06-16 08:23 AM, Jason Ekstrand wrote: > On Fri, Jun 15, 2018 at 4:44 PM, Eric Anholt wrote: > >> Michel Dänzer writes: >> >>> On 2018-06-15 05:25 PM, Jason Ekstrand wrote: On June 15, 2018 01:14:24 Michel Dänzer wrote: > On 2018-06-15 07:31 AM, Jason Ekstrand wrote: >>

Re: [Mesa-dev] [PATCH 0/8] i965: Don't recycle BOs until they are idle

2018-06-15 Thread Jason Ekstrand
On Fri, Jun 15, 2018 at 4:44 PM, Eric Anholt wrote: > Michel Dänzer writes: > > > On 2018-06-15 05:25 PM, Jason Ekstrand wrote: > >> On June 15, 2018 01:14:24 Michel Dänzer wrote: > >>> On 2018-06-15 07:31 AM, Jason Ekstrand wrote: > > I did some testing and x11perf -copywinwin500 is.

Re: [Mesa-dev] [PATCH 0/8] i965: Don't recycle BOs until they are idle

2018-06-15 Thread Eric Anholt
Michel Dänzer writes: > On 2018-06-15 05:25 PM, Jason Ekstrand wrote: >> On June 15, 2018 01:14:24 Michel Dänzer wrote: >>> On 2018-06-15 07:31 AM, Jason Ekstrand wrote: I did some testing and x11perf -copywinwin500 is... exactly the same with or without my patches.  If anyth

Re: [Mesa-dev] [PATCH 0/8] i965: Don't recycle BOs until they are idle

2018-06-15 Thread Jason Ekstrand
On Fri, Jun 15, 2018 at 8:31 AM, Michel Dänzer wrote: > On 2018-06-15 05:25 PM, Jason Ekstrand wrote: > > On June 15, 2018 01:14:24 Michel Dänzer wrote: > >> On 2018-06-15 07:31 AM, Jason Ekstrand wrote: > >>> > >>> I did some testing and x11perf -copywinwin500 is... exactly the same > >>> with

Re: [Mesa-dev] [PATCH 0/8] i965: Don't recycle BOs until they are idle

2018-06-15 Thread Michel Dänzer
On 2018-06-15 05:25 PM, Jason Ekstrand wrote: > On June 15, 2018 01:14:24 Michel Dänzer wrote: >> On 2018-06-15 07:31 AM, Jason Ekstrand wrote: >>> >>> I did some testing and x11perf -copywinwin500 is... exactly the same >>> with >>> or without my patches.  If anything they might improve it by jus

Re: [Mesa-dev] [PATCH 0/8] i965: Don't recycle BOs until they are idle

2018-06-15 Thread Jason Ekstrand
On June 15, 2018 01:14:24 Michel Dänzer wrote: On 2018-06-15 07:31 AM, Jason Ekstrand wrote: On Thu, Jun 14, 2018 at 10:55 AM, Jason Ekstrand wrote: On June 14, 2018 01:43:12 Michel Dänzer wrote: On 2018-06-13 10:26 PM, Jason Ekstrand wrote: The current BO cache puts BOs back into the re

Re: [Mesa-dev] [PATCH 0/8] i965: Don't recycle BOs until they are idle

2018-06-15 Thread Michel Dänzer
On 2018-06-15 07:31 AM, Jason Ekstrand wrote: > On Thu, Jun 14, 2018 at 10:55 AM, Jason Ekstrand > wrote: >> On June 14, 2018 01:43:12 Michel Dänzer wrote: >> On 2018-06-13 10:26 PM, Jason Ekstrand wrote: >>> The current BO cache puts BOs back into the recycle bucket the moment the refc

Re: [Mesa-dev] [PATCH 0/8] i965: Don't recycle BOs until they are idle

2018-06-14 Thread Jason Ekstrand
On Thu, Jun 14, 2018 at 10:55 AM, Jason Ekstrand wrote: > On June 14, 2018 01:43:12 Michel Dänzer wrote: > > On 2018-06-13 10:26 PM, Jason Ekstrand wrote: >> >>> The current BO cache puts BOs back into the recycle bucket the moment the >>> refcount hits zero. If the BO is busy, we just don't re

Re: [Mesa-dev] [PATCH 0/8] i965: Don't recycle BOs until they are idle

2018-06-14 Thread Jason Ekstrand
On June 14, 2018 01:43:12 Michel Dänzer wrote: On 2018-06-13 10:26 PM, Jason Ekstrand wrote: The current BO cache puts BOs back into the recycle bucket the moment the refcount hits zero. If the BO is busy, we just don't re-use it until it isn't or we re-use it for a render target which we ass

Re: [Mesa-dev] [PATCH 0/8] i965: Don't recycle BOs until they are idle

2018-06-14 Thread Michel Dänzer
On 2018-06-13 10:26 PM, Jason Ekstrand wrote: > The current BO cache puts BOs back into the recycle bucket the moment the > refcount hits zero. If the BO is busy, we just don't re-use it until it > isn't or we re-use it for a render target which we assume will be used > first for drawing. This pa

[Mesa-dev] [PATCH 0/8] i965: Don't recycle BOs until they are idle

2018-06-13 Thread Jason Ekstrand
The current BO cache puts BOs back into the recycle bucket the moment the refcount hits zero. If the BO is busy, we just don't re-use it until it isn't or we re-use it for a render target which we assume will be used first for drawing. This patch series reworks the way the BO cache works a bit so

Re: [Mesa-dev] [PATCH 0/8] GL compatibility: Basic GS and tessellation enablement

2018-05-24 Thread Marek Olšák
On Thu, May 24, 2018 at 4:32 PM, Ian Romanick wrote: > On 05/23/2018 01:58 PM, Marek Olšák wrote: > > Hi, > > > > This advances GL compatibility support a little bit. Geometry and > > tessellation shaders should work if you don't combine them with > > non-GLSL stages. All GLSL legacy variables sh

Re: [Mesa-dev] [PATCH 0/8] GL compatibility: Basic GS and tessellation enablement

2018-05-24 Thread Ian Romanick
On 05/23/2018 01:58 PM, Marek Olšák wrote: > Hi, > > This advances GL compatibility support a little bit. Geometry and > tessellation shaders should work if you don't combine them with > non-GLSL stages. All GLSL legacy variables should work. What is the plan for mixing geometry shaders with fixe

Re: [Mesa-dev] [PATCH 0/8] GL compatibility: Basic GS and tessellation enablement

2018-05-24 Thread Timothy Arceri
All looks good to me :) Series: Reviewed-by: Timothy Arceri On 24/05/18 06:58, Marek Olšák wrote: Hi, This advances GL compatibility support a little bit. Geometry and tessellation shaders should work if you don't combine them with non-GLSL stages. All GLSL legacy variables should work. All

[Mesa-dev] [PATCH 0/8] GL compatibility: Basic GS and tessellation enablement

2018-05-23 Thread Marek Olšák
Hi, This advances GL compatibility support a little bit. Geometry and tessellation shaders should work if you don't combine them with non-GLSL stages. All GLSL legacy variables should work. All GL compatibility piglit tests for geometry shaders pass on radeonsi. (we have a lot of compiler tests a

Re: [Mesa-dev] [PATCH 0/8] radv: some cleanups & preliminary work for DCC MSAA

2018-04-07 Thread Bas Nieuwenhuizen
Thanks. The series is Reviewed-by: Bas Nieuwenhuizen On Fri, Apr 6, 2018 at 7:34 PM, Samuel Pitoiset wrote: > Hi, > > This small series is a preliminary work before doing some > improvements in the DCC/CMASK/FMASK codepaths. What I plan to do is: > > - implement DCC for MSAA textures (I have a

[Mesa-dev] [PATCH 0/8] radv: some cleanups & preliminary work for DCC MSAA

2018-04-06 Thread Samuel Pitoiset
Hi, This small series is a preliminary work before doing some improvements in the DCC/CMASK/FMASK codepaths. What I plan to do is: - implement DCC for MSAA textures (I have a WIP branch) - implement TC-compatible CMASK - implement DCC for mipmaps and arrays And probably some other improvements/c

[Mesa-dev] [PATCH 0/8] Push down gl_vertex_array into drivers.

2018-03-25 Thread Mathias . Froehlich
From: Mathias Fröhlich Hi, This series pushes the inputs array down into the driver backends. Also the draw code paths get cleaned up to use the higher level function entry points from the driver functions struct. And finally vbo_split* can now be moved into the tnl module. This step is meant o

Re: [Mesa-dev] [PATCH 0/8] Fix several issues/missings in make dist/distcheck

2018-03-22 Thread Juan A. Suarez Romero
On Thu, 2018-03-22 at 14:16 +, Emil Velikov wrote: > Can we merge the series as-is, until we untangle the dist bits? Just sent a V2 following Daniel proposal. J.A. ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.free

Re: [Mesa-dev] [PATCH 0/8] Fix several issues/missings in make dist/distcheck

2018-03-22 Thread Emil Velikov
On 22 March 2018 at 12:32, Juan A. Suarez Romero wrote: > On Thu, 2018-03-22 at 12:08 +, Daniel Stone wrote: >> On 22 March 2018 at 11:16, Juan A. Suarez Romero wrote: >> > On Thu, 2018-03-22 at 11:03 +, Emil Velikov wrote: >> > > On 21 March 2018 at 13:36, Daniel Stone wrote: >> > > > I

Re: [Mesa-dev] [PATCH 0/8] Fix several issues/missings in make dist/distcheck

2018-03-22 Thread Juan A. Suarez Romero
On Thu, 2018-03-22 at 13:32 +0100, Juan A. Suarez Romero wrote: > On Thu, 2018-03-22 at 12:08 +, Daniel Stone wrote: > > On 22 March 2018 at 11:16, Juan A. Suarez Romero > > wrote: > > > On Thu, 2018-03-22 at 11:03 +, Emil Velikov wrote: > > > > On 21 March 2018 at 13:36, Daniel Stone wr

Re: [Mesa-dev] [PATCH 0/8] Fix several issues/missings in make dist/distcheck

2018-03-22 Thread Juan A. Suarez Romero
On Thu, 2018-03-22 at 12:08 +, Daniel Stone wrote: > On 22 March 2018 at 11:16, Juan A. Suarez Romero wrote: > > On Thu, 2018-03-22 at 11:03 +, Emil Velikov wrote: > > > On 21 March 2018 at 13:36, Daniel Stone wrote: > > > > I thought we had resolved earlier to _not_ ship files generated

Re: [Mesa-dev] [PATCH 0/8] Fix several issues/missings in make dist/distcheck

2018-03-22 Thread Daniel Stone
On 22 March 2018 at 11:16, Juan A. Suarez Romero wrote: > On Thu, 2018-03-22 at 11:03 +, Emil Velikov wrote: >> On 21 March 2018 at 13:36, Daniel Stone wrote: >> > I thought we had resolved earlier to _not_ ship files generated by >> > wayland-scanner in dist after the last round of fixes. >>

Re: [Mesa-dev] [PATCH 0/8] Fix several issues/missings in make dist/distcheck

2018-03-22 Thread Juan A. Suarez Romero
On Thu, 2018-03-22 at 11:03 +, Emil Velikov wrote: > On 21 March 2018 at 13:36, Daniel Stone wrote: > > Hi Juan, > > > > On 19 March 2018 at 17:49, Juan A. Suarez Romero > > wrote: > > > The first two patches in the series is a new fix for issue > > > https://bugs.freedesktop.org/show_bug.c

Re: [Mesa-dev] [PATCH 0/8] Fix several issues/missings in make dist/distcheck

2018-03-22 Thread Emil Velikov
On 21 March 2018 at 13:36, Daniel Stone wrote: > Hi Juan, > > On 19 March 2018 at 17:49, Juan A. Suarez Romero wrote: >> The first two patches in the series is a new fix for issue >> https://bugs.freedesktop.org/show_bug.cgi?id=105211, as the current version >> breaks when running the above comma

Re: [Mesa-dev] [PATCH 0/8] Fix several issues/missings in make dist/distcheck

2018-03-22 Thread Juan A. Suarez Romero
On Wed, 2018-03-21 at 13:36 +, Daniel Stone wrote: > Hi Juan, > > On 19 March 2018 at 17:49, Juan A. Suarez Romero wrote: > > The first two patches in the series is a new fix for issue > > https://bugs.freedesktop.org/show_bug.cgi?id=105211, as the current version > > breaks when running the

Re: [Mesa-dev] [PATCH 0/8] Fix several issues/missings in make dist/distcheck

2018-03-21 Thread Daniel Stone
Hi Juan, On 19 March 2018 at 17:49, Juan A. Suarez Romero wrote: > The first two patches in the series is a new fix for issue > https://bugs.freedesktop.org/show_bug.cgi?id=105211, as the current version > breaks when running the above command, due "make dist/distcheck" tries to > generate the th

Re: [Mesa-dev] [PATCH 0/8] Fix several issues/missings in make dist/distcheck

2018-03-19 Thread Emil Velikov
On 19 March 2018 at 17:49, Juan A. Suarez Romero wrote: > This series fix several issues that happen when running "./autogen.sh && make > {dist, distcheck}". > Sigh, I should really send local patches as soon as I write them - 1-6 have been sitting locally for about a week :-\ 1-7 are Reviewed-by

[Mesa-dev] [PATCH 0/8] Fix several issues/missings in make dist/distcheck

2018-03-19 Thread Juan A. Suarez Romero
This series fix several issues that happen when running "./autogen.sh && make {dist, distcheck}". The first two patches in the series is a new fix for issue https://bugs.freedesktop.org/show_bug.cgi?id=105211, as the current version breaks when running the above command, due "make dist/distcheck"

Re: [Mesa-dev] [PATCH 0/8 v2] A few clover fixes for both CTS and eventual 1.2 support

2018-02-09 Thread Pierre Moreau
On 2018-02-09 — 11:50, Aaron Watry wrote: > No worries. I've been rebasing this series every time I've pulled > mesa for the last few months, and this week is the first time I've had > any real conflicts that need addressing. I'll see if I can find some > time to address your comments and re-orga

Re: [Mesa-dev] [PATCH 0/8 v2] A few clover fixes for both CTS and eventual 1.2 support

2018-02-09 Thread Aaron Watry
No worries. I've been rebasing this series every time I've pulled mesa for the last few months, and this week is the first time I've had any real conflicts that need addressing. I'll see if I can find some time to address your comments and re-organize the commits as you suggested. Jan also had s

Re: [Mesa-dev] [PATCH 0/8 v2] A few clover fixes for both CTS and eventual 1.2 support

2018-02-09 Thread Pierre Moreau
Hello Aaron, Sorry for not having reviewed the updated series… I will have a look at it over the weekend. If I understand correctly, patches 1 and 2 have been squashed together and upstreamed already, while patches 3 through 8 have not been merged yet. Is this series the latest version, or do you

Re: [Mesa-dev] [PATCH 0/8] Partly untangle pos/generic0 aliasing dependencies v2.

2018-02-01 Thread Mathias Fröhlich
Hi Brian, On Thursday, 1 February 2018 17:17:57 CET Brian Paul wrote: > Looks good. > > Reviewed-by: Brian Paul Thanks!! > I don't remember, do you need me to push these for you? I used to have an account for mesa. I have not used that for some time, but I assume that it is still functional.

Re: [Mesa-dev] [PATCH 0/8] Partly untangle pos/generic0 aliasing dependencies v2.

2018-02-01 Thread Brian Paul
On 02/01/2018 12:32 AM, mathias.froehl...@gmx.net wrote: From: Mathias Fröhlich Hi, Thanks for the review! This is the starting point to a patch series that I intent to feed. The aim is to get rid of some VERT_ATTRIB_MAX long loops that currently happen at about any draw call. The series tri

[Mesa-dev] [PATCH 0/8] Partly untangle pos/generic0 aliasing dependencies v2.

2018-01-31 Thread Mathias . Froehlich
From: Mathias Fröhlich Hi, Thanks for the review! This is the starting point to a patch series that I intent to feed. The aim is to get rid of some VERT_ATTRIB_MAX long loops that currently happen at about any draw call. The series tries to separate out one of the depencies of the attribute al

[Mesa-dev] [PATCH 0/8] Partly untangle pos/generic0 aliasing dependencies.

2018-01-30 Thread Mathias . Froehlich
From: Mathias Fröhlich This is the starting point to a patch series that I intent to feed. The aim is to get rid of some VERT_ATTRIB_MAX long loops that currently happen at about any draw call. The series tries to separate out one of the depencies of the attribute aliasing code as a preparation

[Mesa-dev] [PATCH 0/8] Clean up fixed function vertex shader key

2018-01-27 Thread Mathias . Froehlich
From: Mathias Fröhlich Hi all, The following series applies some optimizations to fixed function vertex shader hash key generation. Most is targeted to get a smaller hash key to get a smaller cache footprint and a shorter final key to compare. Two of the changes avoid possible different shader h

Re: [Mesa-dev] [PATCH 0/8] Algebraic optimizations

2018-01-18 Thread Elie Tournier
On Tue, Jan 16, 2018 at 04:44:39PM -0800, Ian Romanick wrote: > This is the first series to resurrect some work that I started as long > as 2.5 years ago. A lot of that work produced mixed bag results, but > that was before nir_opt_algebraic.py had the "is_used_once" modifier. > Without this, the

Re: [Mesa-dev] [PATCH 0/8] Algebraic optimizations

2018-01-17 Thread Samuel Iglesias Gonsálvez
Series is, Reviewed-by: Samuel Iglesias Gonsálvez On 17/01/18 01:44, Ian Romanick wrote: > This is the first series to resurrect some work that I started as long > as 2.5 years ago. A lot of that work produced mixed bag results, but > that was before nir_opt_algebraic.py had the "is_used_once"

[Mesa-dev] [PATCH 0/8] Algebraic optimizations

2018-01-16 Thread Ian Romanick
This is the first series to resurrect some work that I started as long as 2.5 years ago. A lot of that work produced mixed bag results, but that was before nir_opt_algebraic.py had the "is_used_once" modifier. Without this, the last patch was more like 50 helped / 500 hurt on most platforms. All

[Mesa-dev] [PATCH 0/8] Meson cleanups, style fixes, and race hardening

2018-01-05 Thread Dylan Baker
This series is a collection of style cleanups, maintainability fixes, and suggestions from reviewers of previous patches. Other than the style changes (which are mostly about using consistent whitespace and removing temporary variables that are useless), this adds a new internal dependency for nir

[Mesa-dev] [PATCH 0/8] spirv: Types, types, and OpSwitch

2017-12-07 Thread Jason Ekstrand
When I started working on switching spirv_to_nir from having piles of assert() to vtn_assert/fail, Ian and I both agreed that we should start moving in a direction where we had vtn_fail with reasonable error messages rather than vtn_assert() with some compiler-internal garbage message. However some

[Mesa-dev] [PATCH 0/8] amd/common,radeonsi: misc cleanups

2017-11-21 Thread Nicolai Hähnle
Hi all, this is just a bunch of random cleanups of things that I happened to notice while passing by and that accumulated over time. The one thing that perhaps ties into a kind of theme is cleaning up sid.h, which I did while exploring some possibilities for moving to fully auto-generating most p

[Mesa-dev] [PATCH 0/8] Fix non-shared glapi path

2017-11-20 Thread Dylan Baker
There are two distinct set of problems this series addresses. 1) the meson build has never worked 2) the checks for this path have been broken in several different ways for a long time. Dylan Baker (8): glapi: don't walk backwards for includes meson: fix test source name for static glapi

Re: [Mesa-dev] [PATCH 0/8] i965: add performance query support for Coffeelake

2017-11-13 Thread Kenneth Graunke
On Monday, November 13, 2017 6:58:28 AM PST Lionel Landwerlin wrote: > Hi, > > Although the main point of this series is to add performance queries > for Coffeelake. This series also brings the following : > > 1. Fix a number of Media/VME counters > 2. Rename some counter descriptions > 3. Add

Re: [Mesa-dev] [PATCH 0/8] i965: add performance query support for Coffeelake

2017-11-13 Thread Lionel Landwerlin
Some of the big patches got caught. You can find this series here : https://github.com/djdeath/mesa/tree/wip/djdeath/oa-userspace-configs - Lionel On 13/11/17 14:58, Lionel Landwerlin wrote: Hi, Although the main point of this series is to add performance queries for Coffeelake. This series

[Mesa-dev] [PATCH 0/8] i965: add performance query support for Coffeelake

2017-11-13 Thread Lionel Landwerlin
Hi, Although the main point of this series is to add performance queries for Coffeelake. This series also brings the following : 1. Fix a number of Media/VME counters 2. Rename some counter descriptions 3. Add userspace loading of config not already present 4. Add newer busyness configs (allo

[Mesa-dev] [PATCH 0/8] Fence and ddebug fixes, and a minor threading improvement

2017-11-13 Thread Nicolai Hähnle
Hi all, a bunch of fixes for things that I observed while trying to run the CTS with hang debugging enabled: - after the rebase, futex-based fences weren't actually getting enabled - fixes to timeout handling and calculations - an unrelated ddebug use-after-free bug - finally, avoid even more dri

[Mesa-dev] [PATCH 0/8] etnaviv: add OES_texture_half_float support

2017-10-20 Thread Christian Gmeiner
This patch series adds support for half-float texture support. I have the feeling that RS and PE formats differ but that needs more investigation. The last patch in this series is a result of that assumption. Nevertheless it passes piglit/bin/oes_texture_float half. Christian Gmeiner (8): mesa:

Re: [Mesa-dev] [PATCH 0/8] Resend of preprocessor series

2017-09-06 Thread Thomas Helland
I'm busy until Sunday, but I'll see if I can find the time to address Nicolai's comments on Sunday evening. I've addressed the build issues with the tests, and the comment about using util_vsnprintf, so it's getting there. I've also done some general polishing on comments, etc. 6. sep. 2017 23.0

Re: [Mesa-dev] [PATCH 0/8] Resend of preprocessor series

2017-09-06 Thread Dieter Nützel
For the series: Tested-by: Dieter Nützel But do NOT apply on current git any longer. With Nicolai's comments addressed new version underway? ;-) Dieter Am 29.08.2017 21:56, schrieb Thomas Helland: This is a resend of the string buffer implementation and related patches sent out back in May.

Re: [Mesa-dev] [PATCH 0/8] swr: update rasterizer

2017-09-05 Thread Cherniak, Bruce
Reviewed-by: Bruce Cherniak > On Sep 5, 2017, at 1:57 PM, Tim Rowley wrote: > > Highlight is starting to unify the simd/simd16 code, removing lots of > temporary code duplication. > > No piglit or vtk test regressions. > > Tim Rowley (8): > swr/rast: Allow gather of floats from fetch shader

[Mesa-dev] [PATCH 0/8] swr: update rasterizer

2017-09-05 Thread Tim Rowley
Highlight is starting to unify the simd/simd16 code, removing lots of temporary code duplication. No piglit or vtk test regressions. Tim Rowley (8): swr/rast: Allow gather of floats from fetch shader with 2-4GB offsets swr: set caps for VB 4-byte alignment swr/rast: Removed some trailing wh

Re: [Mesa-dev] [PATCH 0/8] Resend of preprocessor series

2017-08-30 Thread Emil Velikov
Hi Thomas, On 29 August 2017 at 20:56, Thomas Helland wrote: > This is a resend of the string buffer implementation and > related patches sent out back in May. I've done one more > change to the string buffer; using u_string.h for a compatible > vsnprintf version to reduce the code even more. I'v

[Mesa-dev] [PATCH 0/8] Resend of preprocessor series

2017-08-29 Thread Thomas Helland
This is a resend of the string buffer implementation and related patches sent out back in May. I've done one more change to the string buffer; using u_string.h for a compatible vsnprintf version to reduce the code even more. I've not been able to test this due to two build breakages (xmlpool and dr

Re: [Mesa-dev] [PATCH 0/8 v2] A few clover fixes for both CTS and eventual 1.2 support

2017-08-04 Thread Jan Vesely
Hi, I went through most of the series. I think the approach is OK. The biggest issue I had is with the sequence: 1.) add an interface 2.) implement a feature 3.) change the interface I gave my rb to 1 and 2, but you might want to consider changing them as well, if returning int from the functions

  1   2   3   4   >