It would be nice if You could replace the logic that iterates these arrays.
We no longer need to terminate on a sentinel nullptr entry and can now use
range based for loop
On Wed, Sep 26, 2018 at 2:06 PM Greg Clayton via Phabricator <
revi...@reviews.llvm.org> wrote:
> clayborg accepted this revis
You might be right, I’m on mobile so hard for me to review. I saw a bunch
of nullptr so assumed it was still using sentinel values for iterating. If
not, ignore my suggestion
On Wed, Sep 26, 2018 at 4:26 PM Tatyana Krasnukha via Phabricator <
revi...@reviews.llvm.org> wrote:
> tatyana-krasnukha ad
No, separate revision is fine. Thanks!
On Wed, Sep 26, 2018 at 4:40 PM Tatyana Krasnukha via Phabricator <
revi...@reviews.llvm.org> wrote:
> tatyana-krasnukha added a comment.
>
> It seems you are speaking about OptionDefinition, not PropertyDefinition.
> I was going to create a separate revision
I think it’s fine. Eventually when you are ready to support remote
debugging hopefully we can convert it over to using lldb-server
On Fri, Sep 28, 2018 at 4:44 AM Aleksandr Urakov via Phabricator <
revi...@reviews.llvm.org> wrote:
> aleksandr.urakov added a comment.
>
> Thanks for explanations!
>
One idea would be to define some lit substitutions like %debuginfo. It’s
true you can produce a gcc style command line that will be equivalent to a
clang-cl invocation but it won’t be easy. eg you’ll needing to pass
-fms-compatibility as well as various -I for includes.
It may be easier to have su
Author: zturner
Date: Wed Oct 10 09:39:07 2018
New Revision: 344154
URL: http://llvm.org/viewvc/llvm-project?rev=344154&view=rev
Log:
Create a SymbolFile plugin for cross-platform PDB access.
The existing SymbolFilePDB only works on Windows, as it is written
against a closed-source Microsoft SDK
Author: zturner
Date: Wed Oct 10 11:52:37 2018
New Revision: 344173
URL: http://llvm.org/viewvc/llvm-project?rev=344173&view=rev
Log:
[SymbolFileNativePDB] Fix compilation errors with gcc.
Modified:
lldb/trunk/source/Plugins/SymbolFile/NativePDB/PdbIndex.cpp
lldb/trunk/source/Plugins/Symb
On Wed, Oct 10, 2018 at 6:38 PM Hui Huang via Phabricator <
revi...@reviews.llvm.org> wrote:
> Hui added inline comments.
>
>
>
> Comment at: source/Plugins/ObjectFile/PECOFF/ObjectFilePECOFF.cpp:810
> +
> + std::lock_guard guard(module_sp->GetMutex());
> +
>
> z
I'm working on a fix for this and several other issues right now. For this
one I think we just need to add -- on the command line.
On Thu, Oct 11, 2018 at 9:36 AM Davide Italiano
wrote:
> On Wed, Oct 10, 2018 at 9:40 AM Zachary Turner via lldb-commits
> wrote:
> >
> > A
Author: zturner
Date: Thu Oct 11 11:01:55 2018
New Revision: 344269
URL: http://llvm.org/viewvc/llvm-project?rev=344269&view=rev
Log:
Better support for POSIX paths in PDBs.
While it doesn't make a *ton* of sense for POSIX paths to be
in PDBs, it's possible to occur in real scenarios involving
cr
Author: zturner
Date: Thu Oct 11 11:45:44 2018
New Revision: 344279
URL: http://llvm.org/viewvc/llvm-project?rev=344279&view=rev
Log:
Revert SymbolFileNativePDB plugin.
This was originally causing some test failures on non-Windows
platforms, which required fixes in the compiler and linker. After
See the other email thread. The bots have been broken since September, all
of them complain about missing FileCheck executable
On Thu, Oct 11, 2018 at 2:58 PM Vedant Kumar via Phabricator <
revi...@reviews.llvm.org> wrote:
> vsk added a comment.
>
> In https://reviews.llvm.org/D50478#1262710, @s
https://reviews.llvm.org/D53002
Is the thread I'm referring to.
On Thu, Oct 11, 2018 at 2:59 PM Zachary Turner via Phabricator <
revi...@reviews.llvm.org> wrote:
> zturner added a subscriber: vsk.
> zturner added a comment.
>
> See the other email thread. The bots have been broken since Septemb
Why is FileCheck missing in the first place?
On Thu, Oct 11, 2018 at 3:13 PM Vedant Kumar via Phabricator <
revi...@reviews.llvm.org> wrote:
> vsk created this revision.
> vsk added reviewers: stella.stamenova, zturner.
>
> This allows bots which haven't updated to pass in --filecheck to dotest.py
They have to restart the master, Galina just did it yesterday so it might
happen again in a couple days
On Fri, Oct 12, 2018 at 12:36 PM Stella Stamenova
wrote:
> + Galina,
>
>
>
> Galina, is there anything we need to do for the buildbots to pick up the
> change that Vedant made?
>
>
>
> Thanks,
Author: zturner
Date: Fri Oct 12 12:47:13 2018
New Revision: 344409
URL: http://llvm.org/viewvc/llvm-project?rev=344409&view=rev
Log:
Resubmit "Add SymbolFileNativePDB plugin."
This was originally reverted due to some test failures on
Linux. Those problems turned out to require several additiona
Sorry for the trouble, hopefully it sticks this time.
On Fri, Oct 12, 2018 at 1:55 PM Jason Molenda via lldb-commits <
lldb-commits@lists.llvm.org> wrote:
> Author: jmolenda
> Date: Fri Oct 12 13:53:21 2018
> New Revision: 344414
>
> URL: http://llvm.org/viewvc/llvm-project?rev=344414&view=rev
>
ason Molenda wrote:
> >
> >
> >
> >> On Oct 12, 2018, at 12:47 PM, Zachary Turner via lldb-commits <
> lldb-commits@lists.llvm.org> wrote:
> >>
> >> Resubmit "Add SymbolFileNativePDB plugin."
> >>
> >> This was orig
t;> > On Oct 12, 2018, at 3:22 PM, Jason Molenda wrote:
>> >
>> >
>> >
>> >> On Oct 12, 2018, at 12:47 PM, Zachary Turner via lldb-commits <
>> lldb-commits@lists.llvm.org> wrote:
>> >>
>> >> Resubmit "Add SymbolFi
e cleared?
>
>
> > On Oct 12, 2018, at 3:27 PM, Jason Molenda wrote:
> >
> > Ah, mystery solved. The lit test specifies REQUIRES Darwin.
> >
> >> On Oct 12, 2018, at 3:22 PM, Jason Molenda wrote:
> >>
> >>
> >>
> >>> On
Author: zturner
Date: Fri Oct 12 15:57:40 2018
New Revision: 344429
URL: http://llvm.org/viewvc/llvm-project?rev=344429&view=rev
Log:
Try to fix some failures on MacOSX with the NativePDB patch.
This adds -- before any filenames, so that /U doesn't get interpreted
as a command line.
It also adds
t; Ah, mystery solved. The lit test specifies REQUIRES Darwin.
>> >
>> >> On Oct 12, 2018, at 3:22 PM, Jason Molenda wrote:
>> >>
>> >>
>> >>
>> >>> On Oct 12, 2018, at 12:47 PM, Zachary Turner via lldb-commits <
>> lldb-commit
Author: zturner
Date: Fri Oct 12 16:07:32 2018
New Revision: 344431
URL: http://llvm.org/viewvc/llvm-project?rev=344431&view=rev
Log:
Add REQUIRES: lld to SymbolFileNativePDB tests.
Modified:
lldb/trunk/lit/SymbolFile/NativePDB/disassembly.cpp
lldb/trunk/lit/SymbolFile/NativePDB/simple-br
Once we’re no longer using DIA this should be a lot easier to control on
our side
On Tue, Oct 16, 2018 at 11:17 AM Vedant Kumar wrote:
>
>
> On Oct 16, 2018, at 10:59 AM, Stella Stamenova
> wrote:
>
> The windows error is because the names are different, as you expected:
>
> AssertionError: 'voi
Lgtm
On Thu, Oct 18, 2018 at 8:03 AM Michał Górny via Phabricator <
revi...@reviews.llvm.org> wrote:
> mgorny created this revision.
> mgorny added a reviewer: zturner.
> Herald added a subscriber: JDevlieghere.
>
> Repository:
> rLLDB LLDB
>
> https://reviews.llvm.org/D53402
>
> Files:
> sour
Author: zturner
Date: Mon Oct 22 09:19:07 2018
New Revision: 344913
URL: http://llvm.org/viewvc/llvm-project?rev=344913&view=rev
Log:
Some cleanups to the native pdb plugin [NFC].
This is mostly some cleanup done in the process of implementing
some basic support for types. I tried to split up th
To answer your question, PE/COFF executable symbol tables are basically
empty
On Mon, Oct 22, 2018 at 10:44 AM Greg Clayton via Phabricator <
revi...@reviews.llvm.org> wrote:
> clayborg requested changes to this revision.
> clayborg added a comment.
> This revision now requires changes to proceed.
Author: zturner
Date: Tue Oct 23 09:37:53 2018
New Revision: 345047
URL: http://llvm.org/viewvc/llvm-project?rev=345047&view=rev
Log:
[NativePDB] Add basic support for tag types to the native pdb plugin.
This adds support to LLDB for named types (class, struct, union, and
enum). This is true cro
Author: zturner
Date: Tue Oct 23 10:22:02 2018
New Revision: 345055
URL: http://llvm.org/viewvc/llvm-project?rev=345055&view=rev
Log:
Change two methods from const char* to StringRef [NFC].
Modified:
lldb/trunk/include/lldb/Symbol/ClangASTContext.h
lldb/trunk/source/Plugins/SymbolFile/DWA
Author: zturner
Date: Tue Oct 23 15:15:27 2018
New Revision: 345092
URL: http://llvm.org/viewvc/llvm-project?rev=345092&view=rev
Log:
Remove unused private methods.
Modified:
lldb/trunk/source/Plugins/SymbolFile/NativePDB/SymbolFileNativePDB.h
Modified: lldb/trunk/source/Plugins/SymbolFile/N
Author: zturner
Date: Tue Oct 23 15:15:05 2018
New Revision: 345091
URL: http://llvm.org/viewvc/llvm-project?rev=345091&view=rev
Log:
Fix some comments pointed out by Leonard Mosescu.
These were originally pointed out in D53511 but I forgot
to incorporate them in my patch.
Modified:
lldb/tru
It seems like FileSpec was moved out of Utility and into Host. I’m not a
fan of this change, because it took a lot of effort to get it into Utility,
which helped break a lot of bad dependencies. Can we invert this dependency
and move FileSpec back into Utility?
On Wed, Oct 24, 2018 at 5:53 PM Jonas
I guess the question is, How is that hash and the bucket computed? If it's
based on the full name, then you should be able to get fast exact lookup.
If it's based on the based name, then it will indeed be slow.
On Thu, Oct 25, 2018 at 11:33 AM Jim Ingham via Phabricator via
lldb-commits wrote:
Yes, it's an interesting dichotomy how the two formats have evolved. PDB
was designed with IDEs in mind so it's optimized around exact matches. For
example, you press a key on a specific line of code. Nobody ever is
entering commands to do fuzzy lookups based on base names, so this was
never rea
Author: zturner
Date: Thu Oct 25 13:44:56 2018
New Revision: 345312
URL: http://llvm.org/viewvc/llvm-project?rev=345312&view=rev
Log:
[NFC] Refactor SetBaseClasses and DeleteBaseClasses.
We currently had a 2-step process where we had to call
SetBaseClassesForType and DeleteBaseClasses. Every sin
Author: zturner
Date: Thu Oct 25 13:45:19 2018
New Revision: 345313
URL: http://llvm.org/viewvc/llvm-project?rev=345313&view=rev
Log:
Don't type-erase the SymbolContextItem enumeration.
When we get the `resolve_scope` parameter from the SB API, it's a
`uint32_t`. We then pass it through all of L
Author: zturner
Date: Thu Oct 25 13:45:40 2018
New Revision: 345314
URL: http://llvm.org/viewvc/llvm-project?rev=345314&view=rev
Log:
Don't type-erase the FunctionNameType or TypeClass enums.
This is similar to D53597, but following up with 2 more enums.
After this, all flag enums should be stron
Author: zturner
Date: Fri Oct 26 02:06:38 2018
New Revision: 345373
URL: http://llvm.org/viewvc/llvm-project?rev=345373&view=rev
Log:
[NativePDB] Add the ability to dump dump global variables.
LLDB has the ability to display global variables, even without a running
process, via the target variabl
Ahh, I meant to remind you, because I noticed this when I was looking
through the SymbolFilePDB code recently. I think the LLVM guideline is not
to use so much auto. The generally accepted rule is that we can use for
the result of make_shared, make_unique, and result of iterator types, but
otherw
For trivial changes it's ok to submit without review. This is true for
cleanup and trivial refactor, but especially for build break like this
one., and even more so if you consider yourself code owner in the
corresponding code area.
On Fri, Oct 26, 2018 at 2:29 AM Aleksandr Urakov via Phabricator
Ok, that reasoning makes sense, I’ll see what i can do
On Fri, Oct 26, 2018 at 9:25 AM Greg Clayton via Phabricator <
revi...@reviews.llvm.org> wrote:
> clayborg added a comment.
>
> My issue with adding "exact_match" is it renders a few of the arguments
> useless:
>
> size_t FindTypes(
> co
Even in this exact case we have the multiple variants situation. If we use
the substitutions method we would reduce the test coverage by half, which
doesn’t seem like a good idea.
Similarly, in the target variables tests i added to the native pdb plugin
Jim was asking if I could also enable that e
Author: zturner
Date: Tue Oct 30 11:57:08 2018
New Revision: 345629
URL: http://llvm.org/viewvc/llvm-project?rev=345629&view=rev
Log:
[NativePDB] Add support for dumping global variables of class type.
Previous patches added support for dumping global variables of
primitive types, so we now do th
Author: zturner
Date: Thu Nov 1 09:37:29 2018
New Revision: 345848
URL: http://llvm.org/viewvc/llvm-project?rev=345848&view=rev
Log:
[NativePDB] Get LLDB types from PDB function types.
This adds basic support for getting function signature types
into LLDB's type system, including into clang's AS
Lgtm
On Fri, Nov 2, 2018 at 3:03 AM Aleksandr Urakov via Phabricator <
revi...@reviews.llvm.org> wrote:
> aleksandr.urakov created this revision.
> aleksandr.urakov added reviewers: zturner, stella.stamenova.
> aleksandr.urakov added a project: LLDB.
> Herald added subscribers: lldb-commits, teemp
Author: zturner
Date: Fri Nov 2 10:49:01 2018
New Revision: 346008
URL: http://llvm.org/viewvc/llvm-project?rev=346008&view=rev
Log:
Refactor the lit configuration files
A year or so ago, I re-wrote most of the lit infrastructure in LLVM so
that it wasn't so boilerplate-y. I added lots of common
Author: zturner
Date: Fri Nov 2 12:55:15 2018
New Revision: 346035
URL: http://llvm.org/viewvc/llvm-project?rev=346035&view=rev
Log:
Fix a bug in the lit test suite generation.
I'm not sure why this has to be CMAKE_CURRENT_SOURCE_DIR, but
it causes all kinds of strange cmake generation errors wh
Fix incoming, sorry about that.
On Fri, Nov 2, 2018 at 2:57 PM Jonas Devlieghere via Phabricator <
revi...@reviews.llvm.org> wrote:
> JDevlieghere added a comment.
>
> Hi Zachary, looks like this broke GreenDragon:
> http://green.lab.llvm.org/green/view/LLDB/job/lldb-cmake/12087/console
>
> Can y
Author: zturner
Date: Fri Nov 2 15:02:09 2018
New Revision: 346046
URL: http://llvm.org/viewvc/llvm-project?rev=346046&view=rev
Log:
Fix the lit test suite.
This change was accidentally missed from the original changeset.
Modified:
lldb/trunk/lit/lit.site.cfg.py.in
Modified: lldb/trunk/lit
Author: zturner
Date: Fri Nov 2 17:06:37 2018
New Revision: 346057
URL: http://llvm.org/viewvc/llvm-project?rev=346057&view=rev
Log:
Make sure to have lit load the configured site config first.
For the lldb unit test suite, we forgot to add the mapping from
site config to main config, so when it
Author: zturner
Date: Fri Nov 2 17:07:03 2018
New Revision: 346058
URL: http://llvm.org/viewvc/llvm-project?rev=346058&view=rev
Log:
Fix some windows-specific fallout from the FileSpec change.
Modified:
lldb/trunk/source/Host/windows/Host.cpp
lldb/trunk/unittests/SymbolFile/PDB/SymbolFil
Unfortunately then color output is impossible. Where else would the output
be expected to go?
On Sun, Nov 4, 2018 at 2:23 AM Pavel Labath via Phabricator <
revi...@reviews.llvm.org> wrote:
> labath added inline comments.
>
>
>
> Comment at: lldb/source/Commands/CommandObjectTarget
Ok so probably this commands output will not go to a log file when logging
is enabled? I can’t think of any other side effects.
Given that the immediate use case for this is interactive investigation and
testing, the first of which is helped by color output and the second of
which doesn’t need log
The issue is that clang writes directly to stderr
On Sun, Nov 4, 2018 at 5:38 AM Pavel Labath via Phabricator <
revi...@reviews.llvm.org> wrote:
> labath added a comment.
>
> In https://reviews.llvm.org/D54072#1286748, @zturner wrote:
>
> > Unfortunately then color output is impossible. Where else
I tried that one and it didn’t show color, bit maybe I need to add an
overload of dumpColor that allows to pass a raw_ostream
On Sun, Nov 4, 2018 at 6:25 AM Raphael Isemann via Phabricator <
revi...@reviews.llvm.org> wrote:
> teemperor added a comment.
>
> I think Pavel's point is to call the `dum
Author: zturner
Date: Mon Nov 5 09:40:28 2018
New Revision: 346149
URL: http://llvm.org/viewvc/llvm-project?rev=346149&view=rev
Log:
Add a target modules dump ast command.
This is useful for investigating the clang ast as you reconstruct
it via by parsing debug info. It can also be used to writ
Author: zturner
Date: Mon Nov 5 11:25:39 2018
New Revision: 346156
URL: http://llvm.org/viewvc/llvm-project?rev=346156&view=rev
Log:
Properly cast from DeclContext to Decl.
Apparently there's a special procedure for doing this. Not
following this silently breaks builds.
Modified:
lldb/trun
r346156.
On Mon, Nov 5, 2018 at 11:09 AM Davide Italiano
wrote:
> On Mon, Nov 5, 2018 at 9:42 AM Zachary Turner via lldb-commits
> wrote:
> >
> > Author: zturner
> > Date: Mon Nov 5 09:40:28 2018
> > New Revision: 346149
> >
> > URL: http://llvm.o
I have not run the dotest suite recently, is that where you’re seeing the
failures? I successfully ran the lit suite and unit tests though
On Wed, Nov 7, 2018 at 1:32 PM Stella Stamenova via Phabricator <
revi...@reviews.llvm.org> wrote:
> stella.stamenova added a comment.
>
> Several of the windo
It’s possible we lost some environment variable propagation, that would do
it. But I’m curious how it was finding the visual studio installation
before my patch.
It also looks like it’s failing finding link.exe (we really should make
lld-link the default). Another fix is to pass -fuse-ld=lld or sp
Actually maybe it’s the other way around. Are you specifying
LLDB_TEST_COMPILER? If it’s picking up VS’s version, it would definitely be
able to find link.exe
On Wed, Nov 7, 2018 at 2:07 PM Stella Stamenova via Phabricator <
revi...@reviews.llvm.org> wrote:
> stella.stamenova added a comment.
>
>
I meant the folder. It’s the first result in your search results. Just
curious, why does your build successfully complete without fixing that
instance?
On Wed, Nov 7, 2018 at 2:20 PM Shafik Yaghmour via Phabricator <
revi...@reviews.llvm.org> wrote:
> shafik added a comment.
>
> @zturner I don't s
Author: zturner
Date: Thu Nov 8 10:50:11 2018
New Revision: 346429
URL: http://llvm.org/viewvc/llvm-project?rev=346429&view=rev
Log:
[NativePDB] Higher fidelity reconstruction of AST from Debug Info.
In order to accurately put a type into the correct location in the AST
we construct from debug i
Author: zturner
Date: Thu Nov 8 10:50:31 2018
New Revision: 346430
URL: http://llvm.org/viewvc/llvm-project?rev=346430&view=rev
Log:
Fix bug in PE/COFF plugin and ValueObjectVariable.
There are two bugs here. The first is that MSVC and clang-cl
emit their bss section under the name '.data' inst
>
> http://green.lab.llvm.org/green/job/lldb-cmake/12343/
>
> --
> Davide
> On Thu, Nov 8, 2018 at 10:52 AM Zachary Turner via lldb-commits
> wrote:
> >
> > Author: zturner
> > Date: Thu Nov 8 10:50:31 2018
> > New Revision: 346430
> >
> > UR
+greg.
Greg, is the test wrong here or the patch? If it’s the test let’s just fix
the test, otherwise we can revert the patch until we figure it out.
It seems related to my change to use the layout type instead of the forward
type.
On Thu, Nov 8, 2018 at 1:03 PM Davide Italiano
wrote:
> On Th
Go ahead and revert to green until i get back
On Thu, Nov 8, 2018 at 1:17 PM Zachary Turner wrote:
> +greg.
>
> Greg, is the test wrong here or the patch? If it’s the test let’s just
> fix the test, otherwise we can revert the patch until we figure it out.
>
> It seems related to my change to us
Author: zturner
Date: Thu Nov 8 17:09:10 2018
New Revision: 346459
URL: http://llvm.org/viewvc/llvm-project?rev=346459&view=rev
Log:
Fix a test whose output changed.
A previous commit fixed an issue with our AST generation where
we were outputting enum decls incorrectly. But we forgot to
update
Author: zturner
Date: Fri Nov 9 08:06:44 2018
New Revision: 346505
URL: http://llvm.org/viewvc/llvm-project?rev=346505&view=rev
Log:
Resubmit "Fix bug in PE/COFF plugin."
The original commit was actually 2 unrelated bug fixes, but it turns
out the second bug fix wasn't quite correct, so the enti
Author: zturner
Date: Fri Nov 9 08:29:19 2018
New Revision: 346511
URL: http://llvm.org/viewvc/llvm-project?rev=346511&view=rev
Log:
[NativePDB] Add support for bitfield records.
Bitfields are represented as LF_MEMBER records whose TypeIndex
points to an LF_BITFIELD record that describes the bit
Author: zturner
Date: Fri Nov 9 09:08:26 2018
New Revision: 346517
URL: http://llvm.org/viewvc/llvm-project?rev=346517&view=rev
Log:
[NativePDB] Fix completion of enum types.
This was originally submitted in a patch which fixed two unrelated
bugs at the same time. This portion of the fix was re
f at any point when it is
> needed. I know classes already do this when they need to know more. Maybe
> the AST doesn't treat enums like classes where it will complete the type
> through the external AST class.
>
> The correct fix is to probably call
>
> bool CompilerType::G
On Mon, Nov 12, 2018 at 6:51 AM Aleksandr Urakov via Phabricator <
revi...@reviews.llvm.org> wrote:
> aleksandr.urakov added a comment.
>
> This change looks reasonable to me for solving the problem with the
> current `LF_NESTTYPE` approach. But I'm not sure... Now we all the same
> need to analyz
I know when I stepped through it with the Pi example, it was returning all
matches, but not filtering down the results based on the template parameter
first, so you’d get back every instantiation but the template parameter
would be treated as a subexpression.
I think the SymbolFile plugin should j
Author: zturner
Date: Tue Nov 13 12:07:57 2018
New Revision: 346787
URL: http://llvm.org/viewvc/llvm-project?rev=346787&view=rev
Log:
[NativePDB] Add support for S_CONSTANT records.
clang-cl does not emit these, but MSVC does, so we need to be able to
handle them.
Because clang-cl does not gener
Author: zturner
Date: Tue Nov 13 12:07:32 2018
New Revision: 346786
URL: http://llvm.org/viewvc/llvm-project?rev=346786&view=rev
Log:
[NativePDB] Improved support for nested type reconstruction.
In a previous patch, we pre-processed the TPI stream in order to build
the reverse mapping from nested
I think it must be related to setting up the environment in which to run
clang. In all other projects we call llvm_config.use_clang() which is in
llvm/utils/lit/lit/llvm/config.py, but because here we have an exact path
of a clang we are trying to use, we skip this function in LLDB's lit
configura
I believe that is correct, and perhaps part of the problem. In other
projects we call llvm_config.use_clang(), and that actually explicitly
creates a substitution so that if someone writes "clang" they'll get an
error that says "use %clang instead". Because we have the exact path, that
isn't happ
On Tue, Nov 13, 2018 at 3:47 PM Stella Stamenova
wrote:
> I am not sure if that’s the right solution for a couple of reasons:
>
>1. As far as I can tell only clang calls use_clang (and only lld calls
>use_lld), while the other projects such as lld and llvm rely on the
>environment to
Ok so for dotest, it seems to be ignoring the config.cc and config.cxx
entirely. So we can theoretically do whatever we want with it, or change
around the directory structure so that it's more like:
lldb
* lit
* * Dotest
* * Unit
* * Tests
and put the config.cc / config.cxx logic under Tests. T
use_clang() already will fall back on searching the environment variable
'CLANG' to find a path to it.
self.config.clang = self.use_llvm_tool(
'clang', search_env='CLANG', required=required)
But we could make this environment variable a parameter to use_clang() if
we wanted to
On Tue, Nov 13, 2018 at 11:46 AM Davide Italiano via lldb-commits <
lldb-commits@lists.llvm.org> wrote:
> Author: davide
> Date: Tue Nov 13 11:43:43 2018
> New Revision: 346783
>
> URL: http://llvm.org/viewvc/llvm-project?rev=346783&view=rev
> Log:
> [Cocoa] Implement formatter for the new NSDate
On Tue, Nov 13, 2018 at 11:46 AM Davide Italiano via lldb-commits <
lldb-commits@lists.llvm.org> wrote:
> Author: davide
> Date: Tue Nov 13 11:43:43 2018
> New Revision: 346783
>
> URL: http://llvm.org/viewvc/llvm-project?rev=346783&view=rev
> Log:
> [Cocoa] Implement formatter for the new NSDate
Author: zturner
Date: Wed Nov 14 09:22:09 2018
New Revision: 346873
URL: http://llvm.org/viewvc/llvm-project?rev=346873&view=rev
Log:
Fix some compilation failures introduced in recent patches.
This fixes two compilation failures:
1) Designated initializers are C++20. We can't use them in LLV
I think I have a pretty good handle on what the problems are. I'm honestly
surprised the lit test suite ever worked, even before my patch that "broke"
it. We were basically just picking up whatever the system PATH was and
just going with it, so a lot of the substitutions weren't actually
substitu
Author: zturner
Date: Wed Nov 14 21:06:59 2018
New Revision: 346932
URL: http://llvm.org/viewvc/llvm-project?rev=346932&view=rev
Log:
Fix a use-after-free of the ABI plugin.
This was introduced in r346775. Previously the ABI shared_ptr
was declared as a function local static meaning it would liv
Author: zturner
Date: Thu Nov 15 14:03:49 2018
New Revision: 346999
URL: http://llvm.org/viewvc/llvm-project?rev=346999&view=rev
Log:
Fix compilation failure in unit tests on Windows.
Modified:
lldb/trunk/unittests/Process/gdb-remote/GDBRemoteTestUtils.cpp
Modified: lldb/trunk/unittests/Proc
Author: zturner
Date: Thu Nov 15 18:42:32 2018
New Revision: 347018
URL: http://llvm.org/viewvc/llvm-project?rev=347018&view=rev
Log:
[NativePDB] Rewrite the PdbSymUid to use our own custom namespacing scheme.
Originally we created our 64-bit UID scheme by using the first byte as
sort of a "tag"
Author: zturner
Date: Thu Nov 15 19:16:27 2018
New Revision: 347020
URL: http://llvm.org/viewvc/llvm-project?rev=347020&view=rev
Log:
Don't use uniform initialization syntax.
Modified:
lldb/trunk/source/Plugins/SymbolFile/NativePDB/PdbIndex.cpp
lldb/trunk/source/Plugins/SymbolFile/NativeP
Did this fix the bitfield problem too? I didn’t fix that one.
On Fri, Nov 16, 2018 at 11:56 AM Davide Italiano wrote:
> I saw you partially fixed this.
>
> I addressed the remaining problem in:
> Davides-Mac-Pro:lldb davide$ git llvm push
> Pushing 1 commit:
> b6fd30d9119 [Cocoa] Prefer llvm::S
Author: zturner
Date: Fri Nov 16 16:05:06 2018
New Revision: 347114
URL: http://llvm.org/viewvc/llvm-project?rev=347114&view=rev
Log:
Add missing triple from llvm-mc command line.
Modified:
lldb/trunk/lit/SymbolFile/NativePDB/s_constant.cpp
Modified: lldb/trunk/lit/SymbolFile/NativePDB/s_con
Well msvc implies system-windows, but i can have both
On Fri, Nov 16, 2018 at 7:37 PM Stella Stamenova via Phabricator <
revi...@reviews.llvm.org> wrote:
> stella.stamenova accepted this revision.
> stella.stamenova added a comment.
> This revision is now accepted and ready to land.
>
> Feel free
Author: zturner
Date: Sun Nov 18 12:48:25 2018
New Revision: 347174
URL: http://llvm.org/viewvc/llvm-project?rev=347174&view=rev
Log:
Revert "Implement basic DidAttach and DidLaunch for DynamicLoaderWindowsDYLD"
This breaks many tests on Windows, which now all fail with an error such
as "Unable t
I had to revert this because it breaks many tests on Windows (found by
bisecting). It was reverted in r347174.
You can reproduce one of the failures by building with this patch applied,
then doing python bin/llvm-lit.py -sv ~/src/lldb/lit/SymbolFile/PDB.
2 of the tests should fail and you see an
Different shells have different quoting rules, so unfortunately something
like this:
# RUN: %lldb -b -s %s -O 'target create %t' -O 'target stop-hook add -n b
-o "expr ptr"'
is non-portable. For example, on Windows all single quotes are converted
to double quotes before running, so this is effec
I’ve often thought we should convert LLDB’s command line parsing code over
to use either cl::opt or lib/Option. This would also solve the problem you
describe here at the same time.
Do you think it’s worth trying to do this?
On Sun, Nov 18, 2018 at 7:17 PM Jonas Devlieghere via Phabricator <
revi.
Lib option definitely does, as its entire purpose is to be powerful and
flexible enough to mimic arbitrary command line tools.
cl::opt is a little less powerful but it still preserves order among
multiple options with the same flag, just not multiple options with
different flags.
I don’t have a s
Author: zturner
Date: Mon Nov 19 07:06:10 2018
New Revision: 347213
URL: http://llvm.org/viewvc/llvm-project?rev=347213&view=rev
Log:
Don't use -O in lit tests.
Because of different shell quoting rules, and the fact that LLDB
commands often contain spaces, -O is not portable for writing command
l
Author: zturner
Date: Mon Nov 19 07:12:34 2018
New Revision: 347216
URL: http://llvm.org/viewvc/llvm-project?rev=347216&view=rev
Log:
Fix some issues with LLDB's lit configuration files.
Recently I tried to port LLDB's lit configuration files over to use a
on the surface, but broke some cases tha
Author: zturner
Date: Mon Nov 19 08:41:31 2018
New Revision: 347223
URL: http://llvm.org/viewvc/llvm-project?rev=347223&view=rev
Log:
Remove non-ASCII characters at the beginning of file.
It's not clear how these ended up in the file, but this fixes it.
Modified:
lldb/trunk/lit/helper/toolch
1 - 100 of 2276 matches
Mail list logo
