You might be right, I’m on mobile so hard for me to review. I saw a bunch of nullptr so assumed it was still using sentinel values for iterating. If not, ignore my suggestion On Wed, Sep 26, 2018 at 4:26 PM Tatyana Krasnukha via Phabricator < revi...@reviews.llvm.org> wrote:
> tatyana-krasnukha added a comment. > > Hmm... There is no such logic left, isn't it? > If you mean iterating OptionValueProperties::m_properties vector, I can > replace cycles with range based for loop, but this doesn't seem to be > related to these changes. > > > Repository: > rLLDB LLDB > > https://reviews.llvm.org/D52572 > > > >
_______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
