On Wed, Oct 10, 2018 at 6:38 PM Hui Huang via Phabricator <
revi...@reviews.llvm.org> wrote:

> Hui added inline comments.
>
>
> ================
> Comment at: source/Plugins/ObjectFile/PECOFF/ObjectFilePECOFF.cpp:810
> +
> +  std::lock_guard<std::recursive_mutex> guard(module_sp->GetMutex());
> +
> ----------------
> zturner wrote:
> > Does this actually need to be a `recursive_mutex`?
> I think there is access to the member 'm_filespec_

ap'.


I mean instead of a non recursive mutex.

>
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to