[Lldb-commits] [PATCH] D54454: Be more permissive in what we consider a variable name.

zturner created this revision. zturner added reviewers: clayborg, jingham, labath. Herald added subscribers: JDevlieghere, aprantl. When we evaluate a variable name as part of an expression, we run a regex against it so break it apart. The intent seems to be that we want to get the main variabl

[Lldb-commits] [PATCH] D54454: Be more permissive in what we consider a variable name.

zturner added a comment. In https://reviews.llvm.org/D54454#1296358, @jingham wrote: > You were probably speaking loosely, but to be clear, the code you are > changing doesn't get used for expressions - i.e. the expression command - > unless I'm missing something. > > This little mini-parser is

[Lldb-commits] [PATCH] D54454: Be more permissive in what we consider a variable name.

zturner added a comment. In https://reviews.llvm.org/D54454#1296377, @jingham wrote: > Those seem legit things to try to capture, though a little esoteric. Since > "frame variable" and "target variable" didn't support these constructs before > you should certainly add some tests for that. > >

[Lldb-commits] [PATCH] D54454: Be more permissive in what we consider a variable name.

zturner added a comment. BTW, I will have to see if it's possible to write a test for this. Even when I compiled and built a program with DWARF on Linux, the `target variable Pi` example didn't "just work" for me, because `FindGlobalVariables` wasn't returning the variable. So I think this pa

[Lldb-commits] [PATCH] D54460: Don't keep a global ABI plugin per architecture

zturner added a comment. > If there were ever anything per-process that effected the ABI plugin's > behavior (for instance if it relied on a Process property) you could very > well use the wrong processes setting. Even worse, since the ABI's hold onto a > process through a weak pointer, if the

[Lldb-commits] [PATCH] D54454: Be more permissive in what we consider a variable name.

zturner added a subscriber: clayborg. zturner added a comment. I know when I stepped through it with the Pi example, it was returning all matches, but not filtering down the results based on the template parameter first, so you’d get back every instantiation but the template parameter would be tre

[Lldb-commits] [PATCH] D54357: [NativePDB] Improved support for nested type reconstruction

This revision was automatically updated to reflect the committed changes. Closed by commit rL346786: [NativePDB] Improved support for nested type reconstruction. (authored by zturner, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D543

[Lldb-commits] [PATCH] D54452: [NativePDB] Add support for handling S_CONSTANT records

This revision was automatically updated to reflect the committed changes. Closed by commit rL346787: [NativePDB] Add support for S_CONSTANT records. (authored by zturner, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D54452?vs=173775&

[Lldb-commits] [PATCH] D54009: Refactor LLDB lit configuration files

zturner added a comment. I think it must be related to setting up the environment in which to run clang. In all other projects we call llvm_config.use_clang() which is in llvm/utils/lit/lit/llvm/config.py, but because here we have an exact path of a clang we are trying to use, we skip this functi

[Lldb-commits] [PATCH] D54567: Fix LLDB's lit files

zturner created this revision. zturner added reviewers: stella.stamenova, labath, aleksandr.urakov, rnk. Herald added subscribers: jfb, arphaman, delcypher, JDevlieghere, aheejin, aprantl, mgorny. Herald added a reviewer: alexshap. Recently I tried to port LLDB's lit configuration files over to u

[Lldb-commits] [PATCH] D54567: Fix LLDB's lit files

zturner added a comment. In https://reviews.llvm.org/D54567#1299982, @aprantl wrote: > > Removal of functionality - The lit test suite no longer respects > > LLDB_TEST_C_COMPILER and LLDB_TEST_CXX_COMPILER. This means there is no > > more support for gcc, but nobody was using this anyway (note:

[Lldb-commits] [PATCH] D54567: Fix LLDB's lit files

zturner added a comment. In https://reviews.llvm.org/D54567#123, @stella.stamenova wrote: > In https://reviews.llvm.org/D54567#122, @aprantl wrote: > > > In https://reviews.llvm.org/D54567#1299989, @stella.stamenova wrote: > > > > > We should also remove LLDB_TEST_C_COMPILER and LLDB_TEST

[Lldb-commits] [PATCH] D54567: Fix LLDB's lit files

zturner added a comment. In https://reviews.llvm.org/D54567#128, @aprantl wrote: > In https://reviews.llvm.org/D54567#123, @stella.stamenova wrote: > > > In https://reviews.llvm.org/D54567#122, @aprantl wrote: > > > > > In https://reviews.llvm.org/D54567#1299989, @stella.stamenova wro

[Lldb-commits] [PATCH] D54567: Fix LLDB's lit files

zturner added a comment. In https://reviews.llvm.org/D54567#1300028, @aprantl wrote: > In https://reviews.llvm.org/D54567#127, @zturner wrote: > > > It's possible I didn't make this part clear enough. I didn't mean that > > nobody is using `LLDB_TEST_C_COMPILER`, I meant that nobody is usin

[Lldb-commits] [PATCH] D54567: Fix LLDB's lit files

zturner added a comment. In https://reviews.llvm.org/D54567#1300031, @stella.stamenova wrote: > In https://reviews.llvm.org/D54567#1300030, @aprantl wrote: > > > In https://reviews.llvm.org/D54567#130, @zturner wrote: > > > > > http://green.lab.llvm.org/green/view/LLDB/job/lldb-cmake-clang-5.

[Lldb-commits] [PATCH] D54567: Fix LLDB's lit files

zturner added a comment. In https://reviews.llvm.org/D54567#1300029, @stella.stamenova wrote: > In https://reviews.llvm.org/D54567#129, @zturner wrote: > > > In https://reviews.llvm.org/D54567#123, @stella.stamenova wrote: > > > > > In https://reviews.llvm.org/D54567#122, @aprantl wro

[Lldb-commits] [PATCH] D54567: Fix LLDB's lit files

zturner added a comment. In https://reviews.llvm.org/D54567#1300029, @stella.stamenova wrote: > In https://reviews.llvm.org/D54567#129, @zturner wrote: > > > In https://reviews.llvm.org/D54567#123, @stella.stamenova wrote: > > > > > In https://reviews.llvm.org/D54567#122, @aprantl wro

[Lldb-commits] [PATCH] D54567: Fix LLDB's lit files

zturner added a comment. In https://reviews.llvm.org/D54567#1300083, @stella.stamenova wrote: > In https://reviews.llvm.org/D54567#1300064, @zturner wrote: > > > In https://reviews.llvm.org/D54567#1300029, @stella.stamenova wrote: > > > > > In https://reviews.llvm.org/D54567#129, @zturner wro

[Lldb-commits] [PATCH] D54567: Fix LLDB's lit files

zturner added a comment. In https://reviews.llvm.org/D54567#1300183, @JDevlieghere wrote: > Personally I don't think we should differentiate between the lit and dotest > suite when it comes to using a custom compiler. The separation between the > two suits is mostly the result of what framework

[Lldb-commits] [PATCH] D54567: Fix LLDB's lit files

zturner added a comment. In https://reviews.llvm.org/D54567#1300641, @JDevlieghere wrote: > In https://reviews.llvm.org/D54567#1300459, @zturner wrote: > > > I'm not sure how hard it would be. > > > > One problem is that dotest supports not just choosing a compiler, but > > choosing multiple com

[Lldb-commits] [PATCH] D54567: Fix LLDB's lit files

zturner updated this revision to Diff 174473. zturner added a comment. Herald added a subscriber: ki.stfu. - Added an `__init__.py` to the helper directory. This is required on Python 2 to make the import work. - Changed a bunch of `%cc` substitutions to `%clang`. - Changed the `%clang_cl` comma

[Lldb-commits] [PATCH] D54567: Fix LLDB's lit files

zturner added a subscriber: stella.stamenova. zturner added a comment. Well msvc implies system-windows, but i can have both https://reviews.llvm.org/D54567 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mail

[Lldb-commits] [PATCH] D54544: Implement basic DidAttach and DidLaunch for DynamicLoaderWindowsDYLD

zturner added a subscriber: lanza. zturner added a comment. I had to revert this because it breaks many tests on Windows (found by bisecting). It was reverted in r347174. You can reproduce one of the failures by building with this patch applied, then doing python bin/llvm-lit.py -sv ~/src/lldb/l

[Lldb-commits] [PATCH] D54680: Don't use lldb -O in lit tests

zturner created this revision. zturner added a reviewer: friss. Because of different shell quoting rules, and the fact that LLDB commands often contain spaces, -O is not portable for writing command lines. Instead, we should use explicit lldbinit files. https://reviews.llvm.org/D54680 Files:

[Lldb-commits] [PATCH] D54680: Don't use lldb -O in lit tests

zturner added a comment. In https://reviews.llvm.org/D54680#1302408, @davide wrote: > Is there a way of fixing this that doesn't require scattering the test > between two files? Unless we create a utility that extracts lines based on prefixes and outputs them to a temporary file, I don't have

[Lldb-commits] [PATCH] D54682: [Driver] Extract option parsing and option processing.

zturner added a subscriber: JDevlieghere. zturner added a comment. I’ve often thought we should convert LLDB’s command line parsing code over to use either cl::opt or lib/Option. This would also solve the problem you describe here at the same time. Do you think it’s worth trying to do this? Rep

[Lldb-commits] [PATCH] D54682: [Driver] Extract option parsing and option processing.

zturner added a comment. Lib option definitely does, as its entire purpose is to be powerful and flexible enough to mimic arbitrary command line tools. cl::opt is a little less powerful but it still preserves order among multiple options with the same flag, just not multiple options with differen

[Lldb-commits] [PATCH] D54680: Don't use lldb -O in lit tests

This revision was automatically updated to reflect the committed changes. Closed by commit rL347213: Don't use -O in lit tests. (authored by zturner, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D54680?vs=174549&id=174609#toc Reposi

[Lldb-commits] [PATCH] D54567: Fix LLDB's lit files

This revision was automatically updated to reflect the committed changes. Closed by commit rC347216: Fix some issues with LLDB's lit configuration files. (authored by zturner, committed by ). Herald added a subscriber: cfe-commits. Changed prior to commit: https://reviews.llvm.org/D54567?vs=174

[Lldb-commits] [PATCH] D54731: [lit] Enable the use of custom user-defined lit commands

zturner created this revision. zturner added reviewers: labath, stella.stamenova, davide, rnk, aprantl, friss. Herald added a subscriber: delcypher. Currently lit supports running shell commands through the use of the `RUN: ` prefix. This patch allows individual test suites to install their own

[Lldb-commits] [PATCH] D54692: [Driver] Use libOption with tablegen.

zturner added a comment. Can you post a short snippet of old help and new help output? Repository: rLLDB LLDB https://reviews.llvm.org/D54692 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo

[Lldb-commits] [PATCH] D54731: [lit] Enable the use of custom user-defined lit commands

zturner added a reviewer: vsk. zturner added a comment. +vsk. One thing I need input from LLDB people on is whether this seems like a good "general direction" for writing lit tests. Does wrapping compilation and linker commands behind a python function seem like it would address these use cas

[Lldb-commits] [PATCH] D54731: [lit] Enable the use of custom user-defined lit commands

zturner added a comment. In https://reviews.llvm.org/D54731#1305183, @labath wrote: > I think that something like this would go a long way towards solving the > problems with lit tests we're having in lldb. > > However, the part that is not clear to me is whether it is actually necessary > to m

[Lldb-commits] [PATCH] D54808: [lit] Add pthread to the compilation of the tests on Linux

zturner added a subscriber: stella.stamenova. zturner added a comment. Lgtm Repository: rLLDB LLDB https://reviews.llvm.org/D54808 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commi

[Lldb-commits] [PATCH] D54692: [Driver] Use libOption with tablegen.

zturner added a comment. I actually don't find this too bad, and like Pavel mentioned earlier, it's something that we can fix in LLVM and improve everyone's output. Which is one of the nice things about sharing code like this. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://revi

[Lldb-commits] [PATCH] D54692: [Driver] Use libOption with tablegen.

zturner added a comment. In D54692#1308190 , @labath wrote: > > There’s actually been a slow push away from cl::opt. It’s less flexible > > and doesn’t support some things that the TableGen approach does. > > Recently there’s been a few efforts to port e

[Lldb-commits] [PATCH] D54914: Add a generic build script for building test inferiors

zturner created this revision. zturner added reviewers: rnk, davide, stella.stamenova, labath, vsk, aprantl. This is an alternative approach to D54731 . Instead of allow the user to invoke arbitrary python code directly from inside of a test, this patch adds a p

[Lldb-commits] [PATCH] D54914: Add a generic build script for building test inferiors

zturner updated this revision to Diff 175344. zturner added a comment. Herald added a subscriber: delcypher. It turned out to not be super complicated, so I went ahead and made it support toolchain auto-detection. This allows the substitution to bake in a command line parameter of `--compiler=a

[Lldb-commits] [PATCH] D54914: Add a generic build script for building test inferiors

zturner updated this revision to Diff 175366. zturner added a comment. I went ahead and fixed up the rest of the native pdb tests. This exposed a couple of minor issues with the build script which I also fixed in the process. @stella.stamenova would you mind giving this a try? I think it will

[Lldb-commits] [PATCH] D54914: Add a generic build script for building test inferiors

zturner added a comment. In D54914#1309901 , @aprantl wrote: > I would like to ask a general question that I (indirectly) also asked in > D54731 : Why do we want to implement support > for building inferiors in LIT-based

[Lldb-commits] [PATCH] D54942: [PDB] Make PDB lit tests use the new builder

zturner added a comment. > Clang called from the builder shows errors on types like char16_t and > char32_t. That's why enums-layout.test and typedefs.test are made to use MSVC > instead; For me enums-layout.test crashes, but I see the same behavior in typedefs.test. This is because lld-link

[Lldb-commits] [PATCH] D54914: Add a generic build script for building test inferiors

zturner updated this revision to Diff 175561. zturner added a comment. Updated with suggestions. Currently all NativePDB tests pass with this version of the script, and all other tests are unaffected since they don't use the new substitution. Subsequent followups will focus on getting other te

[Lldb-commits] [PATCH] D54914: Add a generic build script for building test inferiors

zturner added a comment. In D54914#1309700 , @labath wrote: > I didn't look at the code in detail, as most of it deals with windows stuff, > and I don't know much about those anyway. However, the interesting question > for me would be how to make this us

[Lldb-commits] [PATCH] D54914: Add a generic build script for building test inferiors

zturner added a comment. In D54914#1311137 , @labath wrote: > In D54914#1310337 , @zturner wrote: > > > In D54914#1309700 , @labath wrote: > > > > > I didn't look at the code

[Lldb-commits] [PATCH] D54914: Add a generic build script for building test inferiors

zturner added a comment. If there are no further comments I'd like to get this in later today. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54914/new/ https://reviews.llvm.org/D54914 ___ lldb-commits mailing list lldb-commits@lists.llvm.or

[Lldb-commits] [PATCH] D53368: [Symbol] Search symbols with name and type in a symbol file

zturner added a comment. In D53368#1313124 , @labath wrote: > I've recently started looking at adding a new symbol file format (breakpad > symbols). While researching the best way to achieve that, I started comparing > the operation of PDB and DWARF symb

[Lldb-commits] [PATCH] D53368: [Symbol] Search symbols with name and type in a symbol file

zturner added a comment. In D53368#1313238 , @labath wrote: > In D53368#1313145 , @zturner wrote: > > > In D53368#1313124 , @labath wrote: > > > > > I've recently started loo

[Lldb-commits] [PATCH] D54914: Add a generic build script for building test inferiors

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rLLDB348058: [lit] Add a generic build script with a lit substitution. (authored by zturner, committed by ). Herald added a

[Lldb-commits] [PATCH] D55142: Minidump debugging using the native PDB reader

zturner added inline comments. Comment at: source/Plugins/Process/minidump/ProcessMinidump.cpp:60 + void Dump(Stream *s) override { *s << "PlaceholderObjectFile\n"; } + uint32_t GetAddressByteSize() const override { return 0; } + uint32_t GetDependentModules(FileSpecList &file

[Lldb-commits] [PATCH] D55230: [lit] Multiple build outputs and default target bitness

zturner created this revision. zturner added reviewers: labath, stella.stamenova, aleksandr.urakov. Herald added a subscriber: mgorny. This patch introduces two improvements to the `build.py` script. First, it supports multiple build inputs and outputs. This is helpful if you want to run with `

[Lldb-commits] [PATCH] D55230: [lit] Multiple build outputs and default target bitness

zturner added a comment. In D55230#1317320 , @clayborg wrote: > What is the reason we aren't using cmake + ninja for this kind of stuff? Or > is it using it under the covers? CMake gives you a nice static configuration for how you want to build your hos

[Lldb-commits] [PATCH] D55230: [lit] Multiple build outputs and default target bitness

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rL348305: [build.py] A few general improvements. (authored by zturner, committed by ). Herald added a subscriber: llvm-commi

[Lldb-commits] [PATCH] D55214: Introduce ObjectFileBreakpad

zturner added inline comments. Comment at: lit/Modules/Breakpad/lit.local.cfg:1 +config.suffixes = ['.test'] This shouldn't be necessary, the top-level `lit.cfg.py` already recognizes `.test` extension. You only need a lit.local.cfg if you're changing something

[Lldb-commits] [PATCH] D55384: [NativePDB] Reconstruct FunctionDecl AST nodes from PDB debug info

zturner created this revision. zturner added reviewers: aleksandr.urakov, amccarth, labath, lemo. Herald added subscribers: hiraditya, aprantl. Previously we would create an `lldb::Function` object for each function parsed, but we would not add these to the clang AST. This is a first step toward

[Lldb-commits] [PATCH] D55384: [NativePDB] Reconstruct FunctionDecl AST nodes from PDB debug info

zturner updated this revision to Diff 177039. zturner added a comment. Clang-cl emits `S_LOCAL` symbols while MSVC emits `S_REGREL32` and `S_REGISTER` symbols. So, to get more test coverage, I added an MSVC test as well. Also a little NFC cleanup in the main source file (basically just making

[Lldb-commits] [PATCH] D55318: [Expressions] Add support of expressions evaluation in some object's context

zturner added inline comments. Comment at: include/lldb/API/SBValue.h:310-312 + lldb::SBValue EvaluateExpression(const char *expr) const; + lldb::SBValue EvaluateExpression(const char *expr, + const SBExpressionOptions &options) const;

[Lldb-commits] [PATCH] D55318: [Expressions] Add support of expressions evaluation in some object's context

zturner added inline comments. Comment at: include/lldb/API/SBValue.h:310-312 + lldb::SBValue EvaluateExpression(const char *expr) const; + lldb::SBValue EvaluateExpression(const char *expr, + const SBExpressionOptions &options) const;

[Lldb-commits] [PATCH] D55384: [NativePDB] Reconstruct FunctionDecl AST nodes from PDB debug info

zturner updated this revision to Diff 177243. zturner added a comment. Add some comments regarding fixing `DeclContext` reconstruction. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55384/new/ https://reviews.llvm.org/D55384 Files: lldb/lit/SymbolFile/NativePDB/Inputs/ast-functions.l

[Lldb-commits] [PATCH] D55384: [NativePDB] Reconstruct FunctionDecl AST nodes from PDB debug info

zturner marked 2 inline comments as done. zturner added a comment. In D55384#1322702 , @labath wrote: > In D55384#1321970 , @zturner wrote: > > > Clang-cl emits `S_LOCAL` symbols while MSVC emits `S_REGREL32` and >

[Lldb-commits] [PATCH] D55384: [NativePDB] Reconstruct FunctionDecl AST nodes from PDB debug info

zturner updated this revision to Diff 177244. zturner marked an inline comment as done. zturner added a comment. Removed accidentally added function. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55384/new/ https://reviews.llvm.org/D55384 Files: lldb/lit/SymbolFile/NativePDB/Inputs/a

[Lldb-commits] [PATCH] D55384: [NativePDB] Reconstruct FunctionDecl AST nodes from PDB debug info

This revision was automatically updated to reflect the committed changes. Closed by commit rL348631: [NativePDB] Reconstruct function declarations from debug info. (authored by zturner, committed by ). Herald added subscribers: llvm-commits, kristina. Changed prior to commit: https://reviews.ll

[Lldb-commits] [PATCH] D55472: Speadup memory regions handling and cleanup related code

zturner added inline comments. Comment at: include/lldb/API/SBMemoryRegionInfoList.h:31 - bool GetMemoryRegionAtIndex(uint32_t idx, SBMemoryRegionInfo ®ion_info); + void Reserve(size_t capacity); clayborg wrote: > This you can add, but std::vector implement

[Lldb-commits] [PATCH] D55522: Cache memory regions in ProcessMinidump and use the linux maps as the source of the information if available.

zturner added inline comments. Comment at: source/Plugins/Process/minidump/MinidumpParser.cpp:409 +return false; + llvm::StringRef text((const char *)data.data(), data.size()); + llvm::StringRef line; You can write this as `auto text = llvm::toStringRef(dat

[Lldb-commits] [PATCH] D55142: Minidump debugging using the native PDB reader

zturner added a comment. How large is the PDB file here? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55142/new/ https://reviews.llvm.org/D55142 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailma

[Lldb-commits] [PATCH] D55142: Minidump debugging using the native PDB reader

zturner added inline comments. Comment at: source/Plugins/SymbolFile/NativePDB/SymbolFileNativePDB.cpp:139-144 +llvm::consumeError(expected_binary.takeError()); +pdb_file = obj_file.GetFileSpec() + .GetFileNameStrippingExtension() + .Ge

[Lldb-commits] [PATCH] D55569: [lit] Add a basic implementation of build for GccBuilder

zturner added a comment. @labath: Sorry, I didn't miss it, I just forgot about it (that's not much better, I know). I'll look today. If Pavel's is more complete let's use that as a starting point, although TBH I'm fine going with either one. Repository: rLLDB LLDB CHANGES SINCE LAST ACTIO

[Lldb-commits] [PATCH] D55571: [ast] CreateParameterDeclaration should use an appropriate DeclContext.

zturner created this revision. zturner added reviewers: clayborg, jingham, labath, davide. Herald added subscribers: JDevlieghere, kristof.beyls, javed.absar. Previously CreateParameterDeclaration was always using the translation unit DeclContext. We would later go and add parameters to the Func

[Lldb-commits] [PATCH] D55575: [NativePDB] Support local variables

zturner created this revision. zturner added reviewers: labath, lemo, aleksandr.urakov, amccarth, clayborg, leonid.mashinskiy. Herald added subscribers: JDevlieghere, aprantl. This patch adds support for parsing and evaluating local variables. using the native pdb plugin. While implementing thi

[Lldb-commits] [PATCH] D55142: Minidump debugging using the native PDB reader

zturner added a comment. In D55142#1326247 , @lemo wrote: > > How large is the PDB file here? > > ~100kb We have a couple of tests in LLVM where PDB files are checked in, but they are very few. We cannot explode the repo with large numbers of binary fi

[Lldb-commits] [PATCH] D55575: [NativePDB] Support local variables

zturner marked an inline comment as done. zturner added inline comments. Comment at: lldb/lit/SymbolFile/NativePDB/local-variables.cpp:31-37 +// CHECK-NEXT:14 } +// CHECK-NEXT:15 +// CHECK-NEXT:16 int main(int argc, char **argv) { +// CHECK-NEXT: -> 17 int Som

[Lldb-commits] [PATCH] D55575: [NativePDB] Support local variables

zturner marked an inline comment as done. zturner added inline comments. Comment at: lldb/source/Plugins/SymbolFile/NativePDB/SymbolFileNativePDB.cpp:1929 +} +#include "lldb/Target/MemoryRegionInfo.h" +CompilerDeclContext labath wrote: > Huh? Oops :-/ CHANGES

[Lldb-commits] [PATCH] D55430: build.py: Implement "gcc" builder

zturner added inline comments. Comment at: lldb/trunk/lit/helper/build.py:630 +args.append('-nostdinc') +args.append('-static') +args.append('-c') Why do we need this? Repository: rL LLVM CHANGES SINCE LAST ACTION https://re

[Lldb-commits] [PATCH] D55571: [ast] CreateParameterDeclaration should use an appropriate DeclContext.

This revision was automatically updated to reflect the committed changes. Closed by commit rLLDB348941: [ast] CreateParameterDeclaration should use an appropriate DeclContext. (authored by zturner, committed by ). Herald added a subscriber: teemperor. Changed prior to commit: https://reviews.ll

[Lldb-commits] [PATCH] D55575: [NativePDB] Support local variables

zturner updated this revision to Diff 177877. zturner added a comment. Updated test to be less dependent on the exact format of the source. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55575/new/ https://reviews.llvm.org/D55575 Files: lldb/lit/SymbolFile/NativePDB/Inputs/local-varia

[Lldb-commits] [PATCH] D55575: [NativePDB] Support local variables

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rLLDB349067: [NativePDB] Add support for local variables. (authored by zturner, committed by ). Herald added subscribers: te

[Lldb-commits] [PATCH] D55571: [ast] CreateParameterDeclaration should use an appropriate DeclContext.

zturner added a comment. In D55571#1330354 , @friss wrote: > Zachary, how did you figure out this can be an issue? Does it fix something > we should be testing? Recently I added a `target modules dump ast` command and I've been using it to write tests

[Lldb-commits] [PATCH] D55727: Add "dump" command as a custom "process plugin" subcommand when ProcessMinidump is used.

zturner added a comment. This sounds like a good use-case for a lit / FileCheck test. Could you add some simple tests that run lldb with -c on a static minidump with known information inside that we don't change, then run these commands and check the output? CHANGES SINCE LAST ACTION https

[Lldb-commits] [PATCH] D55142: Minidump debugging using the native PDB reader

zturner added a comment. I thought about what my "ideal" design would look like. I'm not suggesting anyone should actually go off and do this, but since we're brainstorming design anyway, it doesn't hurt to consider what an optimal one should look like (and for the record, there may be things

[Lldb-commits] [PATCH] D56010: [NativePDB] Fix setting breakpoint by file and line

zturner created this revision. zturner added reviewers: aleksandr.urakov, lemo, labath, amccarth. Herald added a subscriber: arphaman. There were several problems preventing this from working. The first is that when the PDB had an absolute path to the main source file, we would construct an

[Lldb-commits] [PATCH] D56124: PECOFF: Fix section name computation

zturner added a comment. What about just making this function return a StringRef? Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56124/new/ https://reviews.llvm.org/D56124 ___ lldb-commits mailing list lldb-commits@

[Lldb-commits] [PATCH] D56126: [NativePDB] Add basic support of methods recostruction in AST

zturner added a comment. > This info is contained in the Symbols stream, not in the TPI stream. As far > as I understand, we can't find in a simple way the link between a > LF_ONEMETHOD record and a corresponding S_GPROC32 record. I think it's the > place, where we need to use the approach simi

[Lldb-commits] [PATCH] D56126: [NativePDB] Add basic support of methods recostruction in AST

zturner added inline comments. Comment at: lit/SymbolFile/NativePDB/ast-methods.cpp:28 +// CHECK: |-CXXRecordDecl {{.*}} struct Struct definition +// CHECK: | |-CXXMethodDecl {{.*}} simple_method 'void () __attribute__((thiscall))' +// CHECK: | |-CXXMethodDecl {{.*}} virtual_met

[Lldb-commits] [PATCH] D56237: Implement GetFileLoadAddress for the Windows process plugin

zturner added a comment. We should probably have a test for this. It sounds like all you need to do to test this is create a target, set a breakpoint, run the process, then verify that you see some text that says the breakpoint was resolved. With the new build.py script this should be able to

[Lldb-commits] [PATCH] D56229: [PECOFF] Implementation of ObjectFilePECOFF:: GetUUID()

zturner added a comment. Should we use the GUID from the COFF Debug Directory instead? It certainly seems more appropriate, if it's there. The UUID's purpose is to match symbol to the executable, so if you use a hash of the path it might solve this one problem, but won't solve the general cas

[Lldb-commits] [PATCH] D56293: Use the minidump exception record if present

zturner requested changes to this revision. zturner added a comment. This revision now requires changes to proceed. I don't think we can check in an executable file, we should try to compile it on the spot. We have 1-2 existing unit tests that check in an exe and we occasionally get reports tha

[Lldb-commits] [PATCH] D56229: [PECOFF] Implementation of ObjectFilePECOFF:: GetUUID()

zturner added a comment. In D56229#1346869 , @Hui wrote: > Not quite sure but correct me if i am wrong. > > (1) I think the Debug Directory is optional for COFF if it does have debug > information and pdb to match with. > > (2) The Debug Directory does no

[Lldb-commits] [PATCH] D56230: [gdb-remote] Use lldb's portable Host::GetEnvironment() instead of getenv

zturner added inline comments. Comment at: source/Plugins/Process/gdb-remote/GDBRemoteCommunication.cpp:1138 + // Double quote the string. + ::snprintf(arg_cstr, sizeof(arg_cstr), "--log-channels=\"%s\"", + env_debugserver_log_channels.c_str());

[Lldb-commits] [PATCH] D56234: [lldb-server] Add unnamed pipe support to PipeWindows

zturner added inline comments. Comment at: source/Host/windows/PipeWindows.cpp:34-38 m_read = INVALID_HANDLE_VALUE; m_write = INVALID_HANDLE_VALUE; - m_read_fd = -1; - m_write_fd = -1; + m_read_fd = PipeWindows::kInvalidDescriptor; + m_write_fd = PipeWindows::kInvalid

[Lldb-commits] [PATCH] D56233: [lldb-server] Add initial support for building lldb-server on Windows

zturner added inline comments. Comment at: include/lldb/Host/windows/PosixApi.h:78-79 +#define WNOHANG 1 +#define WUNTRACED 2 + krytarowski wrote: > I think that these symbols should not be leaked here in the first place. In general we should avoid mocking posi

[Lldb-commits] [PATCH] D56232: [lldb-server] Add remote platform capabilities for Windows

zturner added a comment. In D56232#1344652 , @labath wrote: > All of these functions seem identical to their PlatformPOSIX counterparts. Is > that right? And I seem to remember already seeing a lot of code duplication > between PlatformPOSIX and Platform

[Lldb-commits] [PATCH] D56232: [lldb-server] Add remote platform capabilities for Windows

zturner added inline comments. Comment at: source/Plugins/Platform/Windows/PlatformWindows.cpp:189-195 + else { +if (m_remote_platform_sp) + return m_remote_platform_sp->RunShellCommand( + command, working_dir, status_ptr, signo_ptr, command_output, timeout);

[Lldb-commits] [PATCH] D56231: [lldb-server] Improve support on Windows

zturner added inline comments. Comment at: source/Host/common/File.cpp:606-607 #else long cur = ::lseek(m_descriptor, 0, SEEK_CUR); +SeekFromStart(offset); error = Write(buf, num_bytes); Be careful here. `pwrite` on posix is atomic, which means th

[Lldb-commits] [PATCH] D56315: Add a verbose mode to "image dump line-table" and use it to write a .debug_line test

zturner accepted this revision. zturner added a comment. Ok, that makes sense. BTW, it would be nice if someone ever decided to make `llvm-mc` recognize more symbolic constants so we didn't have to use magic numbers everywhere. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56315/new/

[Lldb-commits] [PATCH] D56418: Change lldb-test to use ParseAllDebugSymbols instead of ParseDeclsForContext

zturner created this revision. zturner added reviewers: labath, clayborg, aleksandr.urakov, asmith, amccarth. Herald added subscribers: JDevlieghere, aprantl. `ParseDeclsForContext` was originally created to serve the very specific case where the context is a function block. It was never intende

[Lldb-commits] [PATCH] D56418: Change lldb-test to use ParseAllDebugSymbols instead of ParseDeclsForContext

zturner marked an inline comment as done. zturner added inline comments. Comment at: lldb/source/Plugins/SymbolFile/PDB/SymbolFilePDB.cpp:318 + + TypeSystem *type_system = GetTypeSystemForLanguage(lldb::eLanguageTypeC_plus_plus); + if (!type_system) amccarth w

[Lldb-commits] [PATCH] D56461: [NativePDB] Add support for parsing typedefs and make lldb-test work with the native reader.

zturner created this revision. zturner added reviewers: aleksandr.urakov, amccarth, lemo, labath. Herald added a subscriber: aprantl. Typedefs are represented as `S_UDT` records in the globals stream. This creates a strange situation where "types" are actually represented as "symbols", so they

[Lldb-commits] [PATCH] D56462: Change SymbolFile::ParseTypes to ParseTypesForCompileUnit

zturner created this revision. zturner added reviewers: clayborg, labath, davide, jingham. Herald added a subscriber: JDevlieghere. The function `SymbolFile::ParseTypes` previously accepted a `SymbolContext`. This makes it extremely difficult to implement faithfully, because you have to account

[Lldb-commits] [PATCH] D47021: Fix PathMappingList for relative and empty paths after recent FileSpec normalization changes

zturner added inline comments. Comment at: source/Target/PathMappingList.cpp:76 ++m_mod_id; - m_pairs.push_back(pair(path, replacement)); + m_pairs.push_back(pair(NormalizePath(path), NormalizePath(replacement))); if (notify && m_callback) Slightly more i

[Lldb-commits] [PATCH] D43984: Make the clang module cache setting available without a target

zturner added subscribers: aprantl, labath, zturner. zturner added a comment. This change has introduced a dependency from Core -> clang Driver (due to #include "clang/Driver/Driver.h" in ModuleList.cpp). Can you please try to find a way to remove this dependency? Repository: rL LLVM https:/

[Lldb-commits] [PATCH] D47228: Break dependency from Core to ObjectFileJIT

zturner created this revision. zturner added reviewers: labath, jingham. Herald added a subscriber: mgorny. This was responsible for the cycle Core > ObjectFile > Core. The only reason this dependency was here was so that `Module` could have a function called `CreateJITModule` which created thin

<    20   21   22   23   24   25   26   27   28   29   >