zturner added a comment. In https://reviews.llvm.org/D54567#1299998, @aprantl wrote:
> In https://reviews.llvm.org/D54567#1299993, @stella.stamenova wrote: > > > In https://reviews.llvm.org/D54567#1299992, @aprantl wrote: > > > > > In https://reviews.llvm.org/D54567#1299989, @stella.stamenova wrote: > > > > > > > We should also remove LLDB_TEST_C_COMPILER and LLDB_TEST_CXX_COMPILER > > > > from the cmake files along with this change, otherwise, people will > > > > still expect them to work. > > > > > > > > > That would not be a good idea. There are several bots that are using > > > these flags. > > > > > > The change that Zachary is making is removing their usage, so after his > > change they would not do anything. If he ends up committing this change, > > these two properties (along with LLDB_DEFAULT_TEST_C_COMPILER and > > LLDB_TEST_USE_CUSTOM_C_COMPILER, etc.) should also go. > > > Perhaps I'm misunderstanding something. My primary point is that we need a > way to run configure which C and C++ compiler is used to compile the tests in > LLDB testsuite. As long as this is still possible, I'm happy. > > We discussed previously that we might want to separate tests that exercise > different compilers from tests that exercise core functionality of LLDB and > perhaps the `lit/` vs. the `packages/` subdirectories is where we want to > draw this line, and only keep the configurability of the compiler for the > tests in the `packages/` directory. But it isn't clear to me that that is > where this is going either. I always have trouble making sense of the Greendragon bots. Starting from this page: http://green.lab.llvm.org/green/view/LLDB/job/lldb-cmake-clang-5.0.2/ What do I need to click on to get the equivalent of this: http://lab.llvm.org:8011/builders/lldb-x86_64-ubuntu-14.04-cmake/builds/31244/steps/test6/logs/stdio https://reviews.llvm.org/D54567 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
