zturner added inline comments.

================
Comment at: include/lldb/API/SBValue.h:310-312
+  lldb::SBValue EvaluateExpression(const char *expr) const;
+  lldb::SBValue EvaluateExpression(const char *expr,
+                                   const SBExpressionOptions &options) const;
----------------
jingham wrote:
> zturner wrote:
> > Can you use `StringRef` instead of `const char *` here?
> This is an SB API.  We don't use StringRef's or any other llvm data types in 
> the SB API's.
Ahh, you are right of course.  My bad.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55318/new/

https://reviews.llvm.org/D55318



_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to