Author: zturner
Date: Fri Nov 13 15:28:45 2015
New Revision: 253085
URL: http://llvm.org/viewvc/llvm-project?rev=253085&view=rev
Log:
Modernize FormatBacktrace() and make portable for Python 3.
Modified:
lldb/trunk/source/Plugins/ScriptInterpreter/Python/PythonDataObjects.cpp
lldb/trunk/s
Author: zturner
Date: Fri Nov 13 15:35:07 2015
New Revision: 253088
URL: http://llvm.org/viewvc/llvm-project?rev=253088&view=rev
Log:
Remove debugging code left in by accident.
Modified:
lldb/trunk/source/Plugins/ScriptInterpreter/Python/PythonExceptionState.cpp
Modified:
lldb/trunk/source/
; should never be true, or if you are doing this check you should assert so
> we can figure out how this is happening.
>
> Note, ThreadDestroy doesn't lock itself against uses of the thread. That
> hasn't been necessary but if you are seeing crashes here, it might be worth
>
Author: zturner
Date: Fri Nov 13 15:53:03 2015
New Revision: 253092
URL: http://llvm.org/viewvc/llvm-project?rev=253092&view=rev
Log:
Change the null check to an assert.
Modified:
lldb/trunk/source/Target/ThreadList.cpp
Modified: lldb/trunk/source/Target/ThreadList.cpp
URL:
http://llvm.org/
zturner added a subscriber: zturner.
zturner added a comment.
I think the `is None` check should go back inside the `check_list_or_lambda`
function. Bringing it outside the function looks identical to me. If `None`
is passed to the function, the `callable()` check will fail, and then the
`els
zturner added a comment.
Ahh ok I see the problem. Sorry I didn't read your description. Let me think
about it some more
http://reviews.llvm.org/D14673
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailma
zturner added a comment.
I guess this is ok. I don't like raising the `None` check outside the
function, but I don't see another way that isn't more convoluted.
However, I think you still need to fix the grouping of the parentheses. the
`compiler is None` should not override the version check
zturner added a comment.
Makes sense. If compiler is None, but compilerVersion is None, maybe you could
just assert. Because that's an error in the use of the decorator IMO
http://reviews.llvm.org/D14673
___
lldb-commits mailing list
lldb-commits
zturner created this revision.
zturner added a reviewer: tfiala.
zturner added a subscriber: lldb-commits.
The goal here is to allow us to add expectedFailure / etc decorators
based on SWIG version.
The end result of this is that patch is that after running SWIG generation
you will have a line su
zturner added a comment.
In http://reviews.llvm.org/D14673#290280, @jingham wrote:
> If the problem is that the self of the test object doesn't always have a
> debug_info setting, why not just always initialize it to None? Seems weird
> to have a general property like this that we don't initia
zturner created this revision.
zturner added reviewers: tfiala, clayborg.
zturner added a subscriber: lldb-commits.
http://reviews.llvm.org/D14726
Files:
packages/Python/lldbsuite/test/lldbtest.py
Index: packages/Python/lldbsuite/test/lldbtest.py
===
Author: zturner
Date: Mon Nov 16 16:40:12 2015
New Revision: 253261
URL: http://llvm.org/viewvc/llvm-project?rev=253261&view=rev
Log:
Python3 - Fix some issues related to `PythonFile` class.
Python 3 has lots of new debug asserts, and some of these were
firing on PythonFile. Specifically related
Author: zturner
Date: Mon Nov 16 16:40:30 2015
New Revision: 253263
URL: http://llvm.org/viewvc/llvm-project?rev=253263&view=rev
Log:
Add the ability to xfail or skip based on swig / python version.
Modified:
lldb/trunk/packages/Python/lldbsuite/test/lldbtest.py
Modified: lldb/trunk/packages
Author: zturner
Date: Mon Nov 16 16:40:20 2015
New Revision: 253262
URL: http://llvm.org/viewvc/llvm-project?rev=253262&view=rev
Log:
Insert the SWIG version into LLDB's __init__.py
The goal here is to allow us to add skip / xfail decorators
based on SWIG version.
Modified:
lldb/trunk/script
zturner added a comment.
Ahh, sorry. I litearlly just committed a change to the same function. You may
have to do a merge, sorry about that.
http://reviews.llvm.org/D14673
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llv
Author: zturner
Date: Mon Nov 16 17:58:20 2015
New Revision: 253273
URL: http://llvm.org/viewvc/llvm-project?rev=253273&view=rev
Log:
Python 3 - Skip a certain test for a particular (swig,python) combo.
Current versions of SWIG have a bug with Python 3 that causes
Python to assert when iterating
Is there any way to have the step that runs the swig executable not be part
of this script? Seems like running swig should be a build step, and
running these scripts on the output of swig should be a step that follows
On Mon, Nov 16, 2015 at 11:20 PM Todd Fiala via lldb-commits <
lldb-commits@lis
On Tue, Nov 17, 2015 at 8:18 AM Todd Fiala wrote:
> Breaking out the binding generation into a separate step will also be
> important for a couple reasons:
>
> * (from before) I want to eliminate the requirement for the vast majority
> of the builds to have a swig on their system, and
>
> * (not
Moving this back over to the list since I'm sure others have some input
here. Also +lldb-dev since it has more visibility than lldb-commits.
On Tue, Nov 17, 2015 at 11:25 AM Zachary Turner wrote:
> On Tue, Nov 17, 2015 at 8:18 AM Todd Fiala wrote:
>
>> Breaking out the b
On Tue, Nov 17, 2015 at 8:03 PM Todd Fiala wrote:
> Nothing concrete at the moment; however, it could be interesting to look
> at the clang community and see what could be done for llvm-based language
> implementations. The angle that I think would be interesting would be if
> we can generate bi
Just to be sure, did you catch the change I made to the old scripts in the
past few days to embed the swig version in the generated lldb.py? Maybe
you did, I just want to make sure that change is in your new version.
On Wed, Nov 18, 2015 at 9:38 AM Todd Fiala via lldb-commits <
lldb-commits@lists
On Wed, Nov 18, 2015 at 10:00 AM Todd Fiala wrote:
> Checking in the static bindings is no different than projects checking in
> autoconf config baked scripts so that the vast majority of people don't
> need to run autoconf just to get a setup that rarely changes. There is
> precedent for this g
at it now...)
>>
>> commit cc353bbc992ab324aef395c54a2a46fcaaa3855b
>> Author: Zachary Turner
>> Date: Mon Nov 16 22:40:20 2015 +
>>
>> Insert the SWIG version into LLDB's __init__.py
>>
>> The goal here is to allow us to add skip / xf
Author: zturner
Date: Wed Nov 18 12:40:16 2015
New Revision: 253487
URL: http://llvm.org/viewvc/llvm-project?rev=253487&view=rev
Log:
Fix some issues with swig & string conversion.
This patch fixes two issues:
1) Popen needs to be used with universal_newlines=True by default.
This elicits aut
quot; path on Windows
> (including tests) try-able at this time?
>
> -Todd
>
> On Wed, Nov 18, 2015 at 10:37 AM, Zachary Turner
> wrote:
>
>> Yea, this is the right one. Thanks! I haven't tested this yet, but I
>> will later. (Our buildbot currently build
On Wed, Nov 18, 2015 at 11:15 AM Todd Fiala wrote:
>
> My intent here is to only provide the --allow-static-binding option on
> cmake if it is explicitly turned on. And it will be off by default.
>
I know, but I don't really like adding options that nobody is going to use,
because it makes maint
;m not breaking stuff.
>>
>> On Wed, Nov 18, 2015 at 11:07 AM, Zachary Turner
>> wrote:
>>
>>> yea. Pass -DPYTHON_HOME=C:\Python35 to CMake and you're good to go.
>>>
>>> I've still got about 20-30 tests failing and/or timing out, but I
necessary
Then this would be much better, as it eliminates a post processing step and
allows easier maintenance of this code.
On Wed, Nov 18, 2015 at 10:37 AM Zachary Turner wrote:
> Yea, this is the right one. Thanks! I haven't tested this yet, but I
> will later. (Our buildbot
On Wed, Nov 18, 2015 at 11:15 AM Todd Fiala wrote:
> On Wed, Nov 18, 2015 at 10:34 AM, Zachary Turner
> wrote:
>
>> Because even if it isn't perfect for everyone, it works for everyone.
>>
>
> Unless you can't get swig on your system in a way that does
(This is originally from a thread on lldb-commits, but it seems more
appropriate here, so I'm responding here.
On Wed, Nov 18, 2015 at 12:47 PM Todd Fiala wrote:
> BTW if you cook up something on the swig-as-a-service end that ends up
> working to eliminate the need for swig, I'll be happy to re
zturner accepted this revision.
zturner added a comment.
This revision is now accepted and ready to land.
lgtm, probably don't need to ask for review on this kind of patch :)
http://reviews.llvm.org/D14784
___
lldb-commits mailing list
lldb-commits@
Author: zturner
Date: Wed Nov 18 15:09:55 2015
New Revision: 253501
URL: http://llvm.org/viewvc/llvm-project?rev=253501&view=rev
Log:
Fix CMake dependency on lldb.py
Modified:
lldb/trunk/CMakeLists.txt
Modified: lldb/trunk/CMakeLists.txt
URL:
http://llvm.org/viewvc/llvm-project/lldb/trunk/C
hat ends up
> working to eliminate the need for swig, I'll be happy to remove the static
> binding support at that point.
>
> -Todd
>
> On Wed, Nov 18, 2015 at 12:45 PM, Todd Fiala wrote:
>
>>
>> On Wed, Nov 18, 2015 at 11:55 AM, Zachary Turner
>> wrote:
&
zturner accepted this revision.
zturner added a comment.
This revision is now accepted and ready to land.
As long as with your new script these are no longer being called anywhere,
should be safe to remove.
http://reviews.llvm.org/D14783
___
lldb-c
zturner added a comment.
sounds good
http://reviews.llvm.org/D14783
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
zturner added a comment.
If nobody on the Apple side is using CMake, then I'm still not clear why we
need this. Everyone using CMake already will continue to work fine using
dynamically generated bindings, right?
I still don't agree with the need for the static bindings in any configuration,
zturner added a comment.
So you can't install swig on your Linux machines either?
I really can't wrap my head around why we need this. What is the problem with
installing swig, given that we need to install other software already?
The build instructions here
[http://lldb.llvm.org/build.html#B
zturner added a comment.
It's not that I don't like it. I mean, it used to be, but it's a minor change.
At this point it's about that I've repeatedly asked for some kind of
reasonable explanation about why swig is a contentious dependency, and the most
I've gotten is "things are about to chan
zturner accepted this revision.
zturner added a comment.
This revision is now accepted and ready to land.
Anyway, just check it in. The content of this patch is not worth arguing
about. What is worth arguing about, however, is that changes need to have some
kind of reasonable justification. "
zturner added a reviewer: clayborg.
zturner added a comment.
+greg since this touches some SB stuff and the ObjectFile plugins.
Comment at: include/lldb/API/SBProcess.h:345-346
@@ +344,4 @@
+// Save the state of the process in a core file (or mini dump on Windows).
+lldb
Hi Enrico, have there been any tests exercising any of the language plugin
stuff yet? Hard to follow every CL that goes in, so just trying to catch
up.
On Wed, Nov 18, 2015 at 5:14 PM Enrico Granata via lldb-commits <
lldb-commits@lists.llvm.org> wrote:
> Author: enrico
> Date: Wed Nov 18 19:11:
Fair enough. I figured it was worth asking about, but the rationale makes
sense.
On Wed, Nov 18, 2015 at 5:18 PM Jim Ingham wrote:
>
> > On Nov 18, 2015, at 4:31 PM, Zachary Turner via lldb-commits <
> lldb-commits@lists.llvm.org> wrote:
> >
> > zturner added a r
zturner added a subscriber: zturner.
zturner added a comment.
Fair enough. I figured it was worth asking about, but the rationale makes
sense.
http://reviews.llvm.org/D14793
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llv
zturner added inline comments.
Comment at: source/API/SBProcess.cpp:1433-1437
@@ +1432,7 @@
+{
+ProcessSP process_sp(GetSP());
+lldb::SBFileSpec core_file(file_name);
+lldb::SBError error;
+error.SetError(PluginManager::SaveCore(process_sp, core_file.get()));
+
zturner added a comment.
So, this is the last thing I'm going to say on this thread.
What I'm fighting for here is consistency. We seem to have the same goal
(making LLDB easier to build for the casual developer) but a different
understanding of how to go about accomplishing this. From your p
zturner added a comment.
In http://reviews.llvm.org/D14790#292493, @krytarowski wrote:
> Not long ago we rejected dynamic dependency on `curses`(3), as a fall-back
> for NetBSD (without `libpanel`(3) in the 7.0 release). Why doing the similar
> thing with swig is fine?
>
> Why are we abstractin
zturner added a comment.
Kamil, the situation is a little complicated, please read the following threads
for some context:
http://lists.llvm.org/pipermail/lldb-dev/2015-November/008802.html
http://lists.llvm.org/pipermail/lldb-dev/2015-November/008829.html
http://lists.llvm.org/pipermail/lldb-de
zturner added a comment.
In http://reviews.llvm.org/D14793#293007, @clayborg wrote:
> Yes, I agree Zach, the caller of SaveCore should verify the process is in a
> good state first. The only downside of that is if the windows mini-dumper can
> actually make a core file on a running process, we
Author: zturner
Date: Thu Nov 19 13:10:54 2015
New Revision: 253589
URL: http://llvm.org/viewvc/llvm-project?rev=253589&view=rev
Log:
Pass -fms-compatibility-version when building test inferiors.
-fms-compatibility-version defaults to VS 2013. When using
VS 2015, this will lead to compilation fa
Adrian:
I think the check_list_or_lambda function needs to be renamed to
`check_decorator_attribute`, and it needs to handle values that are neither
lists nor functions. i.e. it needs to handle single values. So I believe
right now check_list_or_lambda does something like this:
def check_list_o
Agreed, when a CL is reverted due to a buildbot breakage, please include a
link to the failing bot in the commit message of the revert.
On Thu, Nov 19, 2015 at 5:57 PM Kamil Rytarowski via lldb-commits <
lldb-commits@lists.llvm.org> wrote:
> krytarowski added a comment.
>
> Could you please refer
Author: zturner
Date: Fri Nov 20 11:40:57 2015
New Revision: 253679
URL: http://llvm.org/viewvc/llvm-project?rev=253679&view=rev
Log:
Remove `lldb.root` and just look for the file we care about.
Removed:
lldb/trunk/lldb.root
Modified:
lldb/trunk/packages/Python/lldbsuite/__init__.py
l
When you revert a commit, can you please include a log to the buildbot?
Otherwise we have no easy way of diagnosing the failure.
On Fri, Nov 20, 2015 at 12:33 PM Siva Chandra via lldb-commits <
lldb-commits@lists.llvm.org> wrote:
> Author: sivachandra
> Date: Fri Nov 20 14:30:36 2015
> New Revisi
zturner created this revision.
zturner added a reviewer: tfiala.
zturner added a subscriber: lldb-commits.
Prepare_bindings had a hand-rolled function to search the `PATH` for an
executable. I need to use this same function in a new script, so I'm raising
the function into lldbsuite.support so
zturner created this revision.
zturner added a reviewer: tfiala.
zturner added a subscriber: lldb-commits.
This version supports local generation only. It's intentionally
stupid, and does not support any kind of dependency checking.
If you run the script, it's going to call SWIG. Per
zturner updated this revision to Diff 40852.
zturner added a comment.
Fixed a few minor issues
http://reviews.llvm.org/D14896
Files:
scripts/swig_bot.py
scripts/swig_bot_lib/__init__.py
scripts/swig_bot_lib/client.py
scripts/swig_bot_lib/local.py
scripts/swig_bot_lib/server.py
Index:
zturner added a comment.
Note: I was wrong in my initial post, you can't actually generate multiple
language bindings in a single invocation. So the second patchset loops over
the language list and invokes swig multiple times.
Note that we have some occurrences of `%pythoncode` in the swig fil
Author: zturner
Date: Fri Nov 20 19:39:04 2015
New Revision: 253755
URL: http://llvm.org/viewvc/llvm-project?rev=253755&view=rev
Log:
Create `lldbsuite.support.fs` and move `find_executable` there.
I have plans to reuse this function in another script, so raising
this out of prepare_bindings allo
zturner created this revision.
zturner added a reviewer: tfiala.
zturner added a subscriber: lldb-commits.
With this patch, the client will package up all the required
inputs into a compressed zip file, establish a connection to the
server, send the input to the server, and wait for th
zturner updated this revision to Diff 40991.
zturner added a comment.
`socket.recv` doesn't guarantee a full read. The data can be truncated if it
could not be read all at once. This patch fixes this by introducing a helper
function in `lldbsuite.support` to read an exact number of bytes, retr
Author: zturner
Date: Tue Nov 24 15:35:17 2015
New Revision: 254022
URL: http://llvm.org/viewvc/llvm-project?rev=254022&view=rev
Log:
First implementation of swig_bot.py
This version supports local generation only. It's intentionally
stupid, and does not support any kind of dependency checking.
Author: zturner
Date: Tue Nov 24 15:35:40 2015
New Revision: 254024
URL: http://llvm.org/viewvc/llvm-project?rev=254024&view=rev
Log:
Make swig_bot server support Ctrl+C
Modified:
lldb/trunk/scripts/swig_bot.py
lldb/trunk/scripts/swig_bot_lib/server.py
Modified: lldb/trunk/scripts/swig_b
Author: zturner
Date: Tue Nov 24 15:35:58 2015
New Revision: 254026
URL: http://llvm.org/viewvc/llvm-project?rev=254026&view=rev
Log:
swig-bot - Close the socket when shutting down.
Modified:
lldb/trunk/scripts/swig_bot_lib/client.py
Modified: lldb/trunk/scripts/swig_bot_lib/client.py
URL:
Author: zturner
Date: Tue Nov 24 15:35:50 2015
New Revision: 254025
URL: http://llvm.org/viewvc/llvm-project?rev=254025&view=rev
Log:
Include config settings in the archive, and extract on the remote.
Added:
lldb/trunk/scripts/swig_bot_lib/config.py
Modified:
lldb/trunk/scripts/swig_bot_l
Author: zturner
Date: Tue Nov 24 15:35:32 2015
New Revision: 254023
URL: http://llvm.org/viewvc/llvm-project?rev=254023&view=rev
Log:
swig_bot remote path connection / preliminary implementation.
With this patch, the client will package up all the required
inputs into a compressed zip file, estab
Author: zturner
Date: Tue Nov 24 16:27:02 2015
New Revision: 254033
URL: http://llvm.org/viewvc/llvm-project?rev=254033&view=rev
Log:
Fix build after swig_bot_lib changes.
Modified:
lldb/trunk/scripts/prepare_bindings.py
Modified: lldb/trunk/scripts/prepare_bindings.py
URL:
http://llvm.org/
Author: zturner
Date: Tue Nov 24 17:11:54 2015
New Revision: 254037
URL: http://llvm.org/viewvc/llvm-project?rev=254037&view=rev
Log:
Another hack to fix the build bot.
This script really should not be assuming every subdirectory is
a language directory for swig generation. Using a hack to get
t
Author: zturner
Date: Wed Nov 25 11:49:47 2015
New Revision: 254078
URL: http://llvm.org/viewvc/llvm-project?rev=254078&view=rev
Log:
Be *stupider* about what constitutes a supported language binding.
We were trying to be super smart and find all the supported language
bindings. This led to us s
This doesn't look substantially different than builder_freebsd. Assuming
there is no practical difference, how about just using that for both
freebsd and netbsd?
On Sun, Nov 29, 2015 at 6:17 PM Kamil Rytarowski via lldb-commits <
lldb-commits@lists.llvm.org> wrote:
> krytarowski created this rev
zturner added a subscriber: zturner.
zturner added a comment.
This doesn't look substantially different than builder_freebsd. Assuming
there is no practical difference, how about just using that for both
freebsd and netbsd?
Repository:
rL LLVM
http://reviews.llvm.org/D15065
__
Ok, if there's already precedent for duplicating the files then go ahead
and follow the pattern. Although I'm not sure I'm crazy about duplicating
files on the off chance that something might be different someday.
In any case, lgtm.
On Sun, Nov 29, 2015 at 8:01 PM Kamil Rytarowski wrote:
> kry
zturner added a subscriber: zturner.
zturner requested changes to this revision.
zturner added a reviewer: zturner.
zturner added a comment.
This revision now requires changes to proceed.
@labath, can you point out where clang is doing the same thing? I searched for
files named `regcomp.c` for e
zturner added a comment.
lldb-mi is including from the source tree, it should be including from the
incldue tree.
In other words, the incldue should be changed to:
#include "llvm/Support/Regex.h"
and the code should be updated to use `llvm::Regex` instead of the raw c
functions.
Repositor
zturner added inline comments.
Comment at:
source/Plugins/LanguageRuntime/RenderScript/RenderScriptRuntime/RenderScriptRuntime.cpp:185
@@ -184,3 +184,3 @@
-static const ConstString FallbackStructName; // Print this as the
type name of a struct Element
zturner accepted this revision.
zturner added a comment.
This revision is now accepted and ready to land.
Ahh ok if there's already precedent for returning by reference then it's fine.
http://reviews.llvm.org/D15092
___
lldb-commits mailing list
lld
Author: zturner
Date: Mon Nov 30 16:31:13 2015
New Revision: 254340
URL: http://llvm.org/viewvc/llvm-project?rev=254340&view=rev
Log:
Have swig_bot actually run swig, and send back the output.
Added:
lldb/trunk/scripts/swig_bot_lib/remote.py
- copied, changed from r254338, lldb/trunk/sc
Author: zturner
Date: Mon Nov 30 16:31:24 2015
New Revision: 254341
URL: http://llvm.org/viewvc/llvm-project?rev=254341&view=rev
Log:
Unpack the output on the client, completing the cycle.
Modified:
lldb/trunk/scripts/swig_bot_lib/client.py
lldb/trunk/scripts/swig_bot_lib/local.py
lld
Author: zturner
Date: Wed Dec 2 13:00:52 2015
New Revision: 254533
URL: http://llvm.org/viewvc/llvm-project?rev=254533&view=rev
Log:
Use sub-commands instead of --mode={client,server}.
This is more pythonic and allows a more idiomatic way of getting
detailed usage information for each individual
zturner created this revision.
zturner added a reviewer: tfiala.
zturner added a subscriber: lldb-commits.
http://reviews.llvm.org/D15162
Files:
packages/Python/lldbsuite/test/dotest_channels.py
packages/Python/lldbsuite/test/test_results.py
Index: packages/Python/lldbsuite/test/test_results
Author: zturner
Date: Wed Dec 2 17:07:33 2015
New Revision: 254563
URL: http://llvm.org/viewvc/llvm-project?rev=254563&view=rev
Log:
Fix test result serialization to use bytes.
Modified:
lldb/trunk/packages/Python/lldbsuite/test/dotest_channels.py
lldb/trunk/packages/Python/lldbsuite/tes
Author: zturner
Date: Thu Dec 3 13:20:05 2015
New Revision: 254633
URL: http://llvm.org/viewvc/llvm-project?rev=254633&view=rev
Log:
Un XFAIL some tests that are now passing on Windows.
Modified:
lldb/trunk/packages/Python/lldbsuite/test/functionalities/conditional_break/TestConditionalBrea
Author: zturner
Date: Thu Dec 3 13:20:11 2015
New Revision: 254634
URL: http://llvm.org/viewvc/llvm-project?rev=254634&view=rev
Log:
Update .gitignore to include __pycache__ directories.
Modified:
lldb/trunk/.gitignore
Modified: lldb/trunk/.gitignore
URL:
http://llvm.org/viewvc/llvm-projec
zturner created this revision.
zturner added reviewers: granata.enrico, tfiala.
zturner added a subscriber: lldb-commits.
I think this patch may require some xcode changes. This is because of the
`from six.moves import reload_module`. In the CMake build as part of the swig
wrapper python scrip
zturner added inline comments.
Comment at: source/Plugins/Process/Windows/MiniDump/ProcessWinMiniDump.cpp:312
@@ +311,3 @@
+// necessary to test for any of the bits that provide that access
type.
+const bool readable =
+entry->Protect & (PA
Thanks, I'll commit this later today then.
On Fri, Dec 4, 2015 at 10:25 AM Todd Fiala wrote:
> tfiala accepted this revision.
> tfiala added a comment.
> This revision is now accepted and ready to land.
>
> Hey Zachary,
>
> As best as I can tell, we don't need to do anything here, at least not o
zturner created this revision.
zturner added reviewers: jingham, labath.
zturner added a subscriber: lldb-commits.
This test would fail before if conditional breakpoints weren't
working correctly, and the nature of the test (spinning up 10
threads, etc) opens the door to raciness.
zturner added a comment.
Ahh, derp. I commented that out when I was testing something locally, and
forgot to uncomment it. So yea, that should be uncommented.
I was having some trouble following the logic of the original test, so it's
possible this test misses an edge case that I haven't thou
zturner added a comment.
Wouldn't the functionality that's tested by that combination of two things at
the same be equivalently tested by this test, plus a test that only tests the
behavior of conditional breakpoints?
In other words, if you had two tests, one which only tests thread specific
b
zturner added a comment.
Also the origianl test as written was either flaky or disabled on almost every
platform, so it doesn't seem like it was providing much value to anyone.
http://reviews.llvm.org/D15241
___
lldb-commits mailing list
lldb-commi
zturner added a comment.
I don't have any examples, one of the linux guys might. But you can look at
the decorators at the top, which say this:
@skipIfFreeBSD # test frequently times out or hangs
@expectedFailureFreeBSD('llvm.org/pr18522') # hits break in another thread in
testrun
@expec
zturner added a comment.
For now I'll just make this a separate test in the same file I guess. But it's
a bummer to have a test that's broken almost everywhere. Makes me think
something is wrong with the test instead of with LLDB. I agree with you though
that it's not obvious what might be w
Author: zturner
Date: Fri Dec 4 16:59:14 2015
New Revision: 254791
URL: http://llvm.org/viewvc/llvm-project?rev=254791&view=rev
Log:
Python 3 - Fix script import --allow-reload.
Differential Revision: http://reviews.llvm.org/D15209
Reviewed By: Todd Fiala
Modified:
lldb/trunk/source/Plugin
Author: zturner
Date: Fri Dec 4 16:59:41 2015
New Revision: 254792
URL: http://llvm.org/viewvc/llvm-project?rev=254792&view=rev
Log:
Make TestThreadSpecificBreakpoint.py more focused.
This test would fail before if conditional breakpoints weren't
working correctly, and the nature of the test (sp
On Sun, Dec 6, 2015 at 7:13 PM Todd Fiala via lldb-commits <
lldb-commits@lists.llvm.org> wrote:
> Author: tfiala
> Date: Sun Dec 6 21:10:02 2015
> New Revision: 254890
>
> URL: http://llvm.org/viewvc/llvm-project?rev=254890&view=rev
> Log:
> Move test summary counts to end; simplify issue detail
to stick the var :-) I'm thinking I may have other places that
> construct that, I'll replace those as I find them.
>
> -Todd
>
> On Sun, Dec 6, 2015 at 10:02 PM, Todd Fiala wrote:
>
>> Oh I'll have a look, thanks.
>>
>> On Sun, Dec 6, 2015 at 7:5
Author: zturner
Date: Mon Dec 7 15:23:41 2015
New Revision: 254946
URL: http://llvm.org/viewvc/llvm-project?rev=254946&view=rev
Log:
Rename test_results.py to result_formatter.py.
There is already a class called LLDBTestResults which I would like
to move into a separate file, but the most approp
ec 7, 2015 at 1:23 PM, Zachary Turner via lldb-commits <
> lldb-commits@lists.llvm.org> wrote:
>
>> Author: zturner
>> Date: Mon Dec 7 15:23:41 2015
>> New Revision: 254946
>>
>> URL: http://llvm.org/viewvc/llvm-project?rev=254946&view=rev
>> Lo
zturner created this revision.
zturner added reviewers: tfiala, clayborg.
zturner added a subscriber: lldb-commits.
Herald added subscribers: srhines, danalbert, tberghammer.
Since this is a big patch, you may just want to apply it locally and verify
that nothing breaks. I've tested both the old
I'm going to have to merge this into my patch. Can you hold off on any
other patches until I get in?
On Mon, Dec 7, 2015 at 4:56 PM Todd Fiala via lldb-commits <
lldb-commits@lists.llvm.org> wrote:
> Author: tfiala
> Date: Mon Dec 7 18:53:56 2015
> New Revision: 254979
>
> URL: http://llvm.org/
zturner added a comment.
This is mostly mechanical, and since it looks like we have 2 people making big
changes at the same time I'll go ahead and put this in so we don't step on each
others' toes. But feel free to revert if this breaks anything. If you do
experience any errors, it is most li
1101 - 1200 of 3010 matches
Mail list logo
