[Lldb-commits] [PATCH] D52618: [Windows] A basic implementation of memory allocations in a debuggee process

stella.stamenova added a comment. In https://reviews.llvm.org/D52618#1250909, @zturner wrote: > One idea would be to define some lit substitutions like %debuginfo. It’s > true you can produce a gcc style command line that will be equivalent to a > clang-cl invocation but it won’t be easy. eg yo

[Lldb-commits] [PATCH] D53086: [PDB] Fix flaky `variables-locations.test` after PR38857

stella.stamenova accepted this revision. stella.stamenova added a comment. This revision is now accepted and ready to land. Could you document that in the test? Repository: rLLDB LLDB https://reviews.llvm.org/D53086 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D51934: [target] Change target create's behavior wrt loading dependent files.

stella.stamenova added a comment. This test has been failing on Windows since it was added as it doesn't build correctly. I noticed some of the tests are also disabled on Linux. Is this supposed to pass on all platforms? Error when building test subject. Build Command: make VPATH=E:\_wor

[Lldb-commits] [PATCH] D53166: [lldbsuite] Fix the filecheck functionality to work with Python 3

stella.stamenova created this revision. stella.stamenova added reviewers: zturner, asmith. Herald added a subscriber: lldb-commits. This is another string/byte conversion issue between Python 2 and 3. In Python 2, the subprocess communication expects a byte string, but in Python 3, it expects by

[Lldb-commits] [PATCH] D50478: Add support for artificial tail call frames

stella.stamenova added a comment. Unfortunately, the bots are broken because of the FileCheck issue, so I can't confirm with them, but I see a number of these tests fail in our local testing. Some fail on both Windows and Linux and some just fail on Linux. Here are the failing tests: Linux:

[Lldb-commits] [PATCH] D53175: [dotest] Make a missing FileCheck binary a warning, not an error

stella.stamenova added a comment. I spent a bit more time on this and I think I have a better idea of what's happening. Vedant added functionality so that we can use FileCheck-style checks inside non-lit LLDB tests. Part of that change was to require a parameter --filecheck to be passed when c

[Lldb-commits] [PATCH] D53175: [dotest] Make a missing FileCheck binary a warning, not an error

stella.stamenova added a comment. The failing bots are not windows bots but Linux bots. It looks like you only updated the configurations for xcode. I think the file that needs to be updated is: zorg\buildbot\builders\LLDBBuilder.py https://reviews.llvm.org/D53175 _

[Lldb-commits] [PATCH] D53175: [dotest] Make a missing FileCheck binary a warning, not an error

stella.stamenova added a comment. @jasonmolenda That's not a bad idea. If you have a change ready, you could send it for review ;) https://reviews.llvm.org/D53175 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-b

[Lldb-commits] [PATCH] D53175: [dotest] Make a missing FileCheck binary a warning, not an error

stella.stamenova requested changes to this revision. stella.stamenova added a comment. This revision now requires changes to proceed. @vsk Could you also make the filecheck function explicitly fail when it doesn't have a path to the binary? That way it will be fairly obvious what the problem is

[Lldb-commits] [PATCH] D49271: Adding libc++ formattors for std::optional

stella.stamenova added a comment. I see this test failing on Linux right now (bots are down, so I can't confirm that the official bots fail as well). The failure is because of the last decorator which was not part of the review: @skipIf(macos_version=["<", "10.14"]) It looks like this only w

[Lldb-commits] [PATCH] D53166: [lldbsuite] Fix the filecheck functionality to work with Python 3

stella.stamenova updated this revision to Diff 169459. stella.stamenova edited the summary of this revision. stella.stamenova added a comment. Force the comparison in filecheck to use text rather than bytes Repository: rLLDB LLDB https://reviews.llvm.org/D53166 Files: packages/Python/lldbs

[Lldb-commits] [PATCH] D53166: [lldbsuite] Fix the filecheck functionality to work with Python 3

stella.stamenova added inline comments. Comment at: packages/Python/lldbsuite/test/lldbtest.py:2247-2249 subproc = Popen(filecheck_args, stdin=PIPE, stdout=PIPE, stderr=PIPE) cmd_stdout, cmd_stderr = subproc.communicate(input=output) cmd_status = subpro

[Lldb-commits] [PATCH] D53208: [lldbsuite] Fix the mac version decorator to work on non-mac platforms

stella.stamenova created this revision. stella.stamenova added reviewers: labath, davide, asmith, shafik. Herald added a subscriber: lldb-commits. On non-mac platforms, mac_ver returns an empty string which when converted to LooseVersion has no "version" property. This causes a failure when the

[Lldb-commits] [PATCH] D53166: [lldbsuite] Fix the filecheck functionality to work with Python 3

This revision was automatically updated to reflect the committed changes. Closed by commit rLLDB344386: [lldbsuite] Fix the filecheck functionality to work with Python 3 (authored by stella.stamenova, committed by ). Repository: rLLDB LLDB https://reviews.llvm.org/D53166 Files: packages/Pyt

[Lldb-commits] [PATCH] D52851: Adding support to step into the callable wrapped by libc++ std::function

stella.stamenova added a comment. This change has the same problem as https://reviews.llvm.org/D49271 - the class name LibCxxFunctionTestCase is re-used from another test case. This will cause issues when the tests report results and create logs. Please use unique names for each class and test.

[Lldb-commits] [PATCH] D53175: [dotest] Make a missing FileCheck binary a warning, not an error

stella.stamenova accepted this revision. stella.stamenova added a comment. This revision is now accepted and ready to land. Thanks! https://reviews.llvm.org/D53175 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-b

[Lldb-commits] [PATCH] D53175: [dotest] Make a missing FileCheck binary a warning, not an error

stella.stamenova added a comment. The bots are now failing because lexists doesn't handle NoneType correctly: File "/lldb-buildbot/lldbSlave/buildWorkingDir/llvm/tools/lldb/packages/Python/lldbsuite/test/configuration.py", line 191, in get_filecheck_path if os.path.lexists(filecheck):

[Lldb-commits] [PATCH] D49271: Adding libc++ formattors for std::optional

stella.stamenova added a comment. In https://reviews.llvm.org/D49271#1263842, @shafik wrote: > @stella.stamenova Thank you for catching this. I fixed the test names, I am > looking into the best way to fix the skipif now. @shafik I send a change for review this morning that I think should do t

[Lldb-commits] [PATCH] D53208: [lldbsuite] Fix the mac version decorator to work on non-mac platforms

stella.stamenova added inline comments. Comment at: packages/Python/lldbsuite/test/decorators.py:194 py_version[0], py_version[1], sys.version_info) -skip_for_macos_version = (macos_version is None) or ( +skip_for_macos_version = (macos_version is Non

[Lldb-commits] [PATCH] D53208: [lldbsuite] Fix the mac version decorator to work on non-mac platforms

stella.stamenova updated this revision to Diff 169509. Repository: rLLDB LLDB https://reviews.llvm.org/D53208 Files: packages/Python/lldbsuite/test/decorators.py Index: packages/Python/lldbsuite/test/decorators.py === --- pack

[Lldb-commits] [PATCH] D53226: [lldbsuite] Disable Test128BitsInteger on Windows

stella.stamenova created this revision. stella.stamenova added reviewers: davide, asmith. Herald added a subscriber: lldb-commits. This test is failing on Windows because lldb does not support JIT on Windows. Repository: rLLDB LLDB https://reviews.llvm.org/D53226 Files: packages/Python/ll

[Lldb-commits] [PATCH] D53226: [lldbsuite] Disable Test128BitsInteger on Windows

stella.stamenova updated this revision to Diff 169515. https://reviews.llvm.org/D53226 Files: packages/Python/lldbsuite/test/expression_command/rdar44436068/Test128BitsInteger.py Index: packages/Python/lldbsuite/test/expression_command/rdar44436068/Test128BitsInteger.py

[Lldb-commits] [PATCH] D53226: [lldbsuite] Disable Test128BitsInteger on Windows

This revision was automatically updated to reflect the committed changes. Closed by commit rLLDB344543: [lldbsuite] Disable Test128BitsInteger on Windows (authored by stella.stamenova, committed by ). Repository: rLLDB LLDB https://reviews.llvm.org/D53226 Files: packages/Python/lldbsuite/t

[Lldb-commits] [PATCH] D53297: [lldbsuite] Make the names of test classes unique

stella.stamenova created this revision. stella.stamenova added reviewers: jasonmolenda, asmith. Herald added subscribers: lldb-commits, kbarton, nemanjai. If the names are not unique, the tests overwrite each other's results and logs. This also causes failures on platforms where the files are loc

[Lldb-commits] [PATCH] D53297: [lldbsuite] Make the names of test classes unique

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rLLDB344547: [lldbsuite] Make the names of test classes unique (authored by stella.stamenova, committed by ). Repository:

[Lldb-commits] [PATCH] D53208: [lldbsuite] Fix the mac version decorator to work on non-mac platforms

stella.stamenova added a comment. In https://reviews.llvm.org/D53208#1264056, @jingham wrote: > We do compose the decorators in a bunch of places (like Shafik's usage here). > That will work more naturally if the categories that the decorators assert > are as decoupled as possible. So the sta

[Lldb-commits] [PATCH] D51934: [target] Change target create's behavior wrt loading dependent files.

stella.stamenova added a comment. Thanks. I guess the more explicit question is: which platforms is this feature (and test) applicable to? The test should be disabled on other platforms. It is already disabled on Linux because it is not applicable and it is failing to even build on Windows in i

[Lldb-commits] [PATCH] D50478: Add support for artificial tail call frames

stella.stamenova added a comment. In https://reviews.llvm.org/D50478#1262717, @vsk wrote: > In https://reviews.llvm.org/D50478#1262710, @stella.stamenova wrote: > > > Unfortunately, the bots are broken because of the FileCheck issue, so I > > can't confirm with them, but I see a number of these

[Lldb-commits] [PATCH] D53331: [lldbsuite] Mark the TestScriptedResolver tests as XFAIL on Windows

stella.stamenova created this revision. stella.stamenova added reviewers: asmith, zturner. Herald added subscribers: lldb-commits, abidh. They fail similarly to some of the other breakpoint tests on Windows, so I suspect the cause is the same. I've linked to the same bug. Repository: rLLDB LL

[Lldb-commits] [PATCH] D53208: [lldbsuite] Fix the mac version decorator to work on non-mac platforms

This revision was automatically updated to reflect the committed changes. Closed by commit rLLDB344623: [lldbsuite] Fix the mac version decorator to work on non-mac platforms (authored by stella.stamenova, committed by ). Repository: rLLDB LLDB https://reviews.llvm.org/D53208 Files: package

[Lldb-commits] [PATCH] D53357: [Windows] Fix threads comparison on Windows

stella.stamenova accepted this revision. stella.stamenova added a comment. This revision is now accepted and ready to land. LGTM Repository: rLLDB LLDB https://reviews.llvm.org/D53357 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http

[Lldb-commits] [PATCH] D53331: [lldbsuite] Mark the TestScriptedResolver tests as XFAIL on Windows

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rLLDB344744: [lldbsuite] Mark the TestScriptedResolver tests as XFAIL on Windows (authored by stella.stamenova, committed by

[Lldb-commits] [PATCH] D53415: [lldbsuite, windows] Disable two tail call frames tests that fail on Windows

stella.stamenova created this revision. stella.stamenova added reviewers: asmith, vsk. Herald added subscribers: lldb-commits, abidh. These tests fail on Windows because of known limitations (a.k.a. bugs) with the current implementation of GetFrameAtIndex Repository: rLLDB LLDB https://revie

[Lldb-commits] [PATCH] D53415: [lldbsuite, windows] Disable two tail call frames tests that fail on Windows

This revision was automatically updated to reflect the committed changes. Closed by commit rL344788: [lldbsuite, windows] Disable two tail call frames tests that fail on Windows (authored by stella.stamenova, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: http

[Lldb-commits] [PATCH] D53759: [PDB] Support PDB-backed expressions evaluation

stella.stamenova accepted this revision. stella.stamenova added a comment. This revision is now accepted and ready to land. A couple of comments, but looks good otherwise. I'd wait for someone else to have a look as well. Comment at: source/Plugins/Process/Windows/Common/Proce

[Lldb-commits] [PATCH] D54009: Refactor LLDB lit configuration files

stella.stamenova accepted this revision. stella.stamenova added a comment. This revision is now accepted and ready to land. Looks good. The formatting in lit.cfg.py is a bit messy (indentations, especially), but as long as the tests pass, this is an improvement :). Thanks! https://reviews.llvm.

[Lldb-commits] [PATCH] D54009: Refactor LLDB lit configuration files

stella.stamenova added a comment. In https://reviews.llvm.org/D54009#1284839, @zturner wrote: > In https://reviews.llvm.org/D54009#1284827, @stella.stamenova wrote: > > > Looks good. The formatting in lit.cfg.py is a bit messy (indentations, > > especially), but as long as the tests pass, this i

[Lldb-commits] [PATCH] D53915: [FileSystem] Move resolve logic out of FileSpec

stella.stamenova added a comment. Some of the file spec changes caused a bunch of failures on Windows. We know have a silent Buildbot that you can see the failures on as well: http://lab.llvm.org:8014/builders/lldb-x64-windows-ninja/builds/1128/steps/test/logs/stdio Let me know if you need anyt

[Lldb-commits] [PATCH] D54009: Refactor LLDB lit configuration files

stella.stamenova added a comment. Several of the windows tests that invoke clang-cl have started failing recently (I am not sure exactly when) and I suspect this change is the culprit. Were you able to run the tests successfully with this change? Repository: rLLDB LLDB https://reviews.llvm.

[Lldb-commits] [PATCH] D54009: Refactor LLDB lit configuration files

stella.stamenova added a comment. In https://reviews.llvm.org/D54009#1290644, @zturner wrote: > I have not run the dotest suite recently, is that where you’re seeing the > failures? I successfully ran the lit suite and unit tests though Yes, they are primarily in the lldb-suite but not only:

[Lldb-commits] [PATCH] D53530: Fix (and improve) the support for C99 variable length array types

stella.stamenova added a comment. TestVla fails on Windows: http://lab.llvm.org:8014/builders/lldb-x64-windows-ninja/builds/1129/steps/test/logs/stdio AssertionError: False is not True : 'frame var vla' returns expected result, got '(int []) vla = {}' I will have time to look in more detail

[Lldb-commits] [PATCH] D53530: Fix (and improve) the support for C99 variable length array types

stella.stamenova added a comment. In https://reviews.llvm.org/D53530#1290680, @aprantl wrote: > In https://reviews.llvm.org/D53530#1290664, @stella.stamenova wrote: > > > TestVla fails on Windows: > > http://lab.llvm.org:8014/builders/lldb-x64-windows-ninja/builds/1129/steps/test/logs/stdio > >

[Lldb-commits] [PATCH] D54009: Refactor LLDB lit configuration files

stella.stamenova added a comment. I haven't verified this yet - but I suspect it is now picking up the clang-cl that comes with VS rather than the one that was just built. Repository: rLLDB LLDB https://reviews.llvm.org/D54009 ___ lldb-commits m

[Lldb-commits] [PATCH] D54009: Refactor LLDB lit configuration files

stella.stamenova added a comment. The builds don't specify the two options for LLDB_TEST_C/CXX_COMPILER, so they should be picking up the freshly build compilers. We don't have an option for clang-cl though - so it's never been explicitly specified. Repository: rLLDB LLDB https://reviews.ll

[Lldb-commits] [PATCH] D54567: Fix LLDB's lit files

stella.stamenova added a comment. We should also remove LLDB_TEST_C_COMPILER and LLDB_TEST_CXX_COMPILER from the cmake files along with this change, otherwise, people will still expect them to work. https://reviews.llvm.org/D54567 ___ lldb-commits

[Lldb-commits] [PATCH] D54567: Fix LLDB's lit files

stella.stamenova added a comment. In https://reviews.llvm.org/D54567#122, @aprantl wrote: > In https://reviews.llvm.org/D54567#1299989, @stella.stamenova wrote: > > > We should also remove LLDB_TEST_C_COMPILER and LLDB_TEST_CXX_COMPILER from > > the cmake files along with this change, otherw

[Lldb-commits] [PATCH] D54567: Fix LLDB's lit files

stella.stamenova added a comment. In https://reviews.llvm.org/D54567#129, @zturner wrote: > In https://reviews.llvm.org/D54567#123, @stella.stamenova wrote: > > > In https://reviews.llvm.org/D54567#122, @aprantl wrote: > > > > > In https://reviews.llvm.org/D54567#1299989, @stella.stam

[Lldb-commits] [PATCH] D54567: Fix LLDB's lit files

stella.stamenova added a comment. In https://reviews.llvm.org/D54567#1300030, @aprantl wrote: > In https://reviews.llvm.org/D54567#130, @zturner wrote: > > > http://green.lab.llvm.org/green/view/LLDB/job/lldb-cmake-clang-5.0.2/ > > > > What do I need to click on to get the equivalent of this:

[Lldb-commits] [PATCH] D54567: Fix LLDB's lit files

stella.stamenova added a comment. In https://reviews.llvm.org/D54567#1300064, @zturner wrote: > In https://reviews.llvm.org/D54567#1300029, @stella.stamenova wrote: > > > In https://reviews.llvm.org/D54567#129, @zturner wrote: > > > > > In https://reviews.llvm.org/D54567#123, @stella.stam

[Lldb-commits] [PATCH] D54567: Fix LLDB's lit files

stella.stamenova added a comment. > That said, in the interest of not changing too much all at once, it still > seems like something that's perhaps better done in a future patch. WDYT? I actually think it would be better now - the people who use the properties for compile the lit tests will

[Lldb-commits] [PATCH] D54567: Fix LLDB's lit files

stella.stamenova accepted this revision. stella.stamenova added a comment. This revision is now accepted and ready to land. Feel free to check this in. At this point this will only improve the results on Windows and it works correctly on Linux. Comment at: lldb/lit/SymbolFile/

[Lldb-commits] [PATCH] D54709: [lldbsuite] Invoke sed on Windows to determine the cache dir for clang

stella.stamenova created this revision. stella.stamenova added reviewers: aprantl, zturner. Herald added subscribers: lldb-commits, teemperor. In order to invoke sed on Windows, we need to quote the command correctly. Since we already have commands which do that, move the definitions at the begi

[Lldb-commits] [PATCH] D54709: [lldbsuite] Invoke sed on Windows to determine the cache dir for clang

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rL347243: [lldbsuite] Invoke sed on Windows to determine the cache dir for clang (authored by stella.stamenova, committed by

[Lldb-commits] [PATCH] D54731: [lit] Enable the use of custom user-defined lit commands

stella.stamenova accepted this revision. stella.stamenova added a comment. This revision is now accepted and ready to land. LGTM as long as the tests are all still passing :) https://reviews.llvm.org/D54731 ___ lldb-commits mailing list lldb-commits

[Lldb-commits] [PATCH] D54808: [lit] Add pthread to the compilation of the tests on Linux

stella.stamenova created this revision. stella.stamenova added reviewers: labath, zturner, asmith. Herald added subscribers: lldb-commits, jfb. Right now only some platforms add pthread to the compilation, however, at least one of the tests requires the pthread library on Linux as well. Since the

[Lldb-commits] [PATCH] D54808: [lit] Add pthread to the compilation of the tests on Linux

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rL347412: [lit] Add pthread to the compilation of the tests on Linux (authored by stella.stamenova, committed by ). Herald a

[Lldb-commits] [PATCH] D54942: [PDB] Make PDB lit tests use the new builder

stella.stamenova added a comment. This looks fine, but let's see if Zachary's change lands first and how it looks like after it lands :). Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54942/new/ https://reviews.llvm.org/D54942 __

[Lldb-commits] [PATCH] D54914: Add a generic build script for building test inferiors

stella.stamenova added a comment. I ran the tests with this change and there are about a dozen new failures: 2018-11-28T20:25:29.2437909Z 2018-11-28T20:25:29.2581909Z FAIL: LLDB :: SymbolFile/NativePDB/function-types-builtins.cpp (16962 of 45532) 2018

[Lldb-commits] [PATCH] D54914: Add a generic build script for building test inferiors

stella.stamenova added a comment. It works for me when you make the command: command='"%s"' % (sys.executable), I haven't tested it on Linux yet, but the tests work fine on Windows. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54914/new/ https://reviews.llvm.org/D54914 _

[Lldb-commits] [PATCH] D53759: [PDB] Support PDB-backed expressions evaluation

stella.stamenova added a comment. It looks like after this change went in, the tests on Windows starting timing out instead of completing. The last run before the change took about 2 minutes and starting with the first run with this change, they're running for 40 minutes before being killed: A

[Lldb-commits] [PATCH] D55038: [Reproducers] Change how reproducers are initialized.

stella.stamenova added a comment. One of these tests fail on Windows: Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55038/new/ https://reviews.llvm.org/D55038 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D55230: [lit] Multiple build outputs and default target bitness

stella.stamenova added inline comments. Comment at: lldb/lit/helper/build.py:664 +if args.output and args.mode == 'compile' and len(args.inputs) > 1: +raise ValueError('Cannot specify -o with mode=compile and multiple source files. Use --outdir instead.') +

[Lldb-commits] [PATCH] D55230: [lit] Multiple build outputs and default target bitness

stella.stamenova added a comment. LLDB :: BuildScript/toolchain-clang-cl.test is failing on Linux. 2018-12-05T17:59:42.1570845Z Command Output (stderr): 2018-12-05T17:59:42.1582271Z -- 2018-12-05T17:59:42.1593369Z Traceback (most recent call last): 2018-12-05T17:59:42.1604689Z File "/h

[Lldb-commits] [PATCH] D54942: [PDB] Make PDB lit tests use the new builder

stella.stamenova added a comment. enums-layout.test is now failing on Windows: http://lab.llvm.org:8014/builders/lldb-x64-windows-ninja/builds/1938/steps/test/logs/stdio Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54942/new/ https://reviews.llvm.org/D54942 _

[Lldb-commits] [PATCH] D55332: [CMake] Python bindings generation polishing

stella.stamenova added inline comments. Comment at: CMakeLists.txt:134 --srcRoot=${LLDB_SOURCE_DIR} - --targetDir=${LLDB_PYTHON_TARGET_DIR} - --cfgBldDir=${LLDB_PYTHON_TARGET_DIR} + --targetDir=$ + --cfgBldDi

[Lldb-commits] [PATCH] D55457: Do not use PATH_MAX with SmallString

stella.stamenova created this revision. stella.stamenova added reviewers: labath, asmith. Herald added a subscriber: lldb-commits. Instead use a more reasonable value to start and rely on the fact that SmallString will resize if necessary. Repository: rLLDB LLDB https://reviews.llvm.org/D554

[Lldb-commits] [PATCH] D55457: Do not use PATH_MAX with SmallString

This revision was automatically updated to reflect the committed changes. Closed by commit rLLDB348775: Do not use PATH_MAX with SmallString (authored by stella.stamenova, committed by ). Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55457/new/ https://reviews.l

[Lldb-commits] [PATCH] D55569: [lit] Add a basic implementation of build for GccBuilder

stella.stamenova created this revision. stella.stamenova added reviewers: zturner, asmith. Herald added subscribers: lldb-commits, abidh. This adds an implementation for compile as well as compile-and-link, but not link. For compile-and-link we rely on clang to orchestrate both similarly to how

[Lldb-commits] [PATCH] D55430: build.py: Implement "gcc" builder

stella.stamenova accepted this revision. stella.stamenova added a comment. This revision is now accepted and ready to land. A couple of small comments, but it looks good otherwise. Thanks! Comment at: lit/BuildScript/toolchain-clang.test:1 +RUN: %build -n --verbose --arch=32 --

[Lldb-commits] [PATCH] D55569: [lit] Add a basic implementation of build for GccBuilder

stella.stamenova abandoned this revision. stella.stamenova added a comment. Let's use @labath's change instead. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55569/new/ https://reviews.llvm.org/D55569 ___ lldb-comm

[Lldb-commits] [PATCH] D55575: [NativePDB] Support local variables

stella.stamenova added a comment. local-variables.cpp is failing on the Buildbot: http://lab.llvm.org:8014/builders/lldb-x64-windows-ninja/builds/2255/steps/test/logs/stdio Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55575/new/ https://reviews.llvm.org/D5557

[Lldb-commits] [PATCH] D55575: [NativePDB] Support local variables

stella.stamenova added a comment. $ ":" "RUN: at line 5" $ "E:\build_slave\lldb-x64-windows-ninja\build\bin\lldb.EXE" "-S" "E:/build_slave/lldb-x64-windows-ninja/llvm/tools/lldb/lit\lit-lldb-init" "-f" "E:\build_slave\lldb-x64-windows-ninja\build\tools\lldb\lit\SymbolFile\NativePDB\Output\lo

[Lldb-commits] [PATCH] D55430: build.py: Implement "gcc" builder

stella.stamenova added a comment. I am trying to use the new builder to build the lldb-mi tests, so that they can start consistently passing on Windows, so they're now using the gcc builder on Linux and failing: 2018-12-14T19:24:41.8890855Z 2018-12-14T19:24:41.8904193Z

[Lldb-commits] [PATCH] D55736: build.py: inherit environment in the gcc builder

stella.stamenova accepted this revision. stella.stamenova added a comment. This revision is now accepted and ready to land. This does fix the issues. Thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55736/new/ https://reviews.llvm.org/D55736 _

[Lldb-commits] [PATCH] D55607: Make crashlog.py work when a .dSYM is present, but a binary is missing

stella.stamenova added a comment. This change made the Windows test get stuck: http://lab.llvm.org:8014/builders/lldb-x64-windows-ninja/builds/2340 They are now being killed after running for 40 minutes instead of completing in under 2. Repository: rL LLVM CHANGES SINCE LAST ACTION https

[Lldb-commits] [PATCH] D55607: Make crashlog.py work when a .dSYM is present, but a binary is missing

stella.stamenova added a comment. In D55607#1334666 , @aprantl wrote: > Can you confirm that reverting this path actually fixes the issue? I'm asking > because the only test that is executing this script has a REQUIRES: > system-darwin line in it. Remo

[Lldb-commits] [PATCH] D55384: [NativePDB] Reconstruct FunctionDecl AST nodes from PDB debug info

stella.stamenova added a comment. A bunch of the NativePDB tests are failing on Windows now. http://lab.llvm.org:8014/builders/lldb-x64-windows-ninja/builds/2365/steps/test/logs/stdio Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55384/new/ https://reviews.llvm.o

[Lldb-commits] [PATCH] D55384: [NativePDB] Reconstruct FunctionDecl AST nodes from PDB debug info

stella.stamenova added a comment. It looks like this might not be specific to your change as a few other tests are failing with a similar error. I'm looking into it. Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55384/new/ https://reviews.llvm.org/D55384 _

[Lldb-commits] [PATCH] D55384: [NativePDB] Reconstruct FunctionDecl AST nodes from PDB debug info

stella.stamenova added a comment. I tracked this down - the failures are not due to this change (or any LLDB change). It's this change to the common CMake files in LLVM: https://reviews.llvm.org/D55056 Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55384/new/ htt

[Lldb-commits] [PATCH] D47646: [IRMemoryMap] Use labels in the "malloc" and "free" lldb-test commands

stella.stamenova added a comment. While you are at it, can you make sure this works on Windows? The current version of the test that is checked in fails. https://reviews.llvm.org/D47646 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http

[Lldb-commits] [PATCH] D47646: [IRMemoryMap] Use labels in the "malloc" and "free" lldb-test commands

stella.stamenova added a comment. In https://reviews.llvm.org/D47646#1119471, @vsk wrote: > In https://reviews.llvm.org/D47646#1119396, @stella.stamenova wrote: > > > While you are at it, can you make sure this works on Windows? The current > > version of the test that is checked in fails. > > >

[Lldb-commits] [PATCH] D47646: [IRMemoryMap] Use labels in the "malloc" and "free" lldb-test commands

stella.stamenova added a comment. I can look into the failure - but can you XFAIL the test rather than skipping it and log a bug, so that we can track the failure rather than potentially assuming down the line that the test is not meant for windows? https://reviews.llvm.org/D47646 _

[Lldb-commits] [PATCH] D47679: [lldb, lldb-mi] Enable lldb-mi -break-insert test on Windows.

stella.stamenova added a comment. You can actually follow the pattern in the other tests and do: %cc -o %t %p/inputs/break-insert.c -g %t``` then becomes the name of the output file and you can use that in our other commands. This is better than specifying a hardcoded name. Having sa

[Lldb-commits] [PATCH] D47679: [lldb, lldb-mi] Enable lldb-mi -break-insert test on Windows.

stella.stamenova added a comment. In https://reviews.llvm.org/D47679#1120081, @polyakov.alex wrote: > Due to https://reviews.llvm.org/D47678 we can enable this test with a XFAIL > directive for Windows. Not true. As I said, the original review when I disabled the test has the log of what happ

[Lldb-commits] [PATCH] D47679: [lldb, lldb-mi] Enable lldb-mi -break-insert test on Windows.

stella.stamenova added a comment. In https://reviews.llvm.org/D47679#1120177, @polyakov.alex wrote: > In https://reviews.llvm.org/D47679#1120172, @stella.stamenova wrote: > > > In https://reviews.llvm.org/D47679#1120081, @polyakov.alex wrote: > > > > > Due to https://reviews.llvm.org/D47678 we ca

[Lldb-commits] [PATCH] D47646: [IRMemoryMap] Use labels in the "malloc" and "free" lldb-test commands

stella.stamenova added a comment. In https://reviews.llvm.org/D47646#1120498, @labath wrote: > Looks great, thanks for doing this. > > As far as windows goes, I believe that there we simply don't have the memory > allocation part implemented, so it's not surprising that these tests fail. It > m

[Lldb-commits] [PATCH] D47679: [lldb, lldb-mi] Enable lldb-mi -break-insert test on Windows.

stella.stamenova accepted this revision. stella.stamenova added a comment. This revision is now accepted and ready to land. I stand corrected. The test didn't hang. https://reviews.llvm.org/D47679 ___ lldb-commits mailing list lldb-commits@lists.llv

[Lldb-commits] [PATCH] D47797: [lldb-mi] Re-implement MI -exec-next command.

stella.stamenova added inline comments. Comment at: lit/tools/lldb-mi/exec/exec-next.test:2 +# XFAIL: windows +# -> llvm.org/pr24452 +# aprantl wrote: > @stella.stemanova: Would be interesting to understand why (/if ?) this > doesn't work on windows I can test i

[Lldb-commits] [PATCH] D48665: Added test case for: r334978 - Fixed file completion for paths that start with '~'

stella.stamenova added a comment. This test fails on Windows with the Visual Studio generator. ##[error]llvm\tools\lldb\unittests\interpreter\testcompletion.cpp(291,0): Error : Value of: ContainsExactString(Twine("~/foo") + path::get_separator() + "nested" + path::get_separator(), Results)

[Lldb-commits] [PATCH] D48746: Fix path completion test case added in rL335905 on Windows

stella.stamenova accepted this revision. stella.stamenova added a comment. The test passes with the fix. Thanks! https://reviews.llvm.org/D48746 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo

[Lldb-commits] [PATCH] D48802: [lldb-mi] Re-implement symbol-list-lines command.

stella.stamenova added a comment. symbol-list-lines.test fails on windows. I'm trying to get through the rest of the failing tests on Windows, so I can add a bot to run the tests and alert on new failures. FAIL: lldb :: tools/lldb-mi/symbol/symbol-list

[Lldb-commits] [PATCH] D48802: [lldb-mi] Re-implement symbol-list-lines command.

stella.stamenova added a comment. (gdb) -file-exec-and-symbols "E:\\_work\\4\\b\\LLVMBuild\\tools\\lldb\\lit\\tools\\lldb-mi\\symbol\\Output\\symbol-list-lines.test.tmp" ^done (gdb) ^done (gdb) =library-loaded,id="E:\\_work\\4\\b\\LLVMBuild\\tools\\lldb\\lit\\tools\\lldb-mi\\symb

[Lldb-commits] [PATCH] D48960: Use an unwinder to get register contexts of frames other than zeroth under Windows

stella.stamenova added a comment. I'm actually in the middle of cleaning up the change attached to this bug: https://bugs.llvm.org/show_bug.cgi?id=37495 which is equivalent functionally but follows the pattern for the other targets. Let me run some tests and I'll submit it for review. It should

[Lldb-commits] [PATCH] D49018: Convert a location information from PDB to a DWARF expression

stella.stamenova added a comment. I am not 100% sure that this is the cause yet, but the test variables.test is now failing on Windows. @aleksandr.urakov and @JDevlieghere, which tests did you run on Windows? Did they all pass? Repository: rL LLVM https://reviews.llvm.org/D49018

[Lldb-commits] [PATCH] D49207: Get rid of the C-string parameter in DoExecute

stella.stamenova added a comment. I am debugging through it right now, but I believe this change caused several tests on Windows with Python 3 to fail. The failures are all related to UTF-8. For example: UnicodeDecodeError: 'utf-8' codec can't decode byte 0x80 in position 0: invalid start by

[Lldb-commits] [PATCH] D48802: [lldb-mi] Re-implement symbol-list-lines command.

stella.stamenova added a comment. @apolyakov Perhaps we can mark the test as XFAIL on Windows while you investigate. Any objections? Repository: rL LLVM https://reviews.llvm.org/D48802 ___ lldb-commits mailing list lldb-commits@lists.llvm.org ht

[Lldb-commits] [PATCH] D49309: No longer pass a StringRef to the Python API

stella.stamenova added a comment. All better now! Tests are passing. Repository: rL LLVM https://reviews.llvm.org/D49309 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D48802: [lldb-mi] Re-implement symbol-list-lines command.

stella.stamenova added a comment. Thank you! Repository: rL LLVM https://reviews.llvm.org/D48802 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D49018: Convert a location information from PDB to a DWARF expression

stella.stamenova added a comment. I'll spend some time looking into this today, but with commit 0fa537f42f1af238c74bf41998dc1af31195839a variables.test passes. Then with commit d9899ad86e0a9b05781015cacced1438fcf70343, the test fails. There are clearly a couple of other commits in that range, b

[Lldb-commits] [PATCH] D49018: Convert a location information from PDB to a DWARF expression

stella.stamenova added a comment. The CHECK-SAME expression on line 10 can no longer find the expected string in the output. This is due to an extra `location = DW_OP_addr(000140004114) ,` in the output between the two expected strings `CHECK-SAME: scope = global, external`, so it looks lik

  1   2   3   4   >